Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-07-13 Thread Srinivas, Vidya
, Charlton > Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] > tests/kms_prime: Aligned pitch to 64 byte for Intel platforms > > Hello Ville, > > Thank you very much. > Before reaching our i915's i915_gem_dumb_create, it goes to > vgem_gem_dumb_create for kms_

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-06-28 Thread Surendrakumar Upadhyay, TejaskumarX
> -Original Message- > From: Intel-gfx On Behalf Of > Srinivas, Vidya > Sent: 31 May 2021 20:18 > To: Ville Syrjälä > Cc: igt-...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Lin, > Charlton > Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-06-11 Thread Srinivas, Vidya
Hello Ville, Apologies for bothering you. Kms_prime goes through vgem_gem_dumb_create where the pitch gets calculated which is not 64 byte aligned. kms_prime->vgem_gem_dumb_create->intel_framebuffer_init which reports plane 0 pitch (5464) must be at least 64 byte aligned. We have submitted thi

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-06-04 Thread Srinivas, Vidya
Thank you very much Mark, for testing the patch and providing the "Tested-by" tag. I shall incorporate you review comments and submit the patch. Additionally, we have submitted the kernel alternative https://patchwork.freedesktop.org/patch/436199/ Regards Vidya -Original Message- From:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-06-04 Thread Mark Yacoub
On Mon, May 31, 2021 at 10:47 AM Srinivas, Vidya wrote: > > Hello Ville, > > Thank you very much. > Before reaching our i915's i915_gem_dumb_create, it goes to > vgem_gem_dumb_create for kms_prime. > > The pitch gets calculated there and it is not 64 byte aligned. Due to this, > intel_framebuffe

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-05-31 Thread Srinivas, Vidya
Hello Ville, Thank you very much. Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime. The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned" and framebuffer creation f

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms

2021-05-31 Thread Ville Syrjälä
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote: > For Intel platforms, pitch needs to be 64 byte aligned. > Kernel code vgem_gem_dumb_create which is platform generic code > doesnt do the alignment. This causes frame buffer creation to fail > on Intel platforms where the pitch is no