[Intel-gfx] [patch v2] drm/i915: fix a limit check in hsw_compute_wm_results()

2013-08-09 Thread Dan Carpenter
The '!' here was not intended. Since '!' has higher precedence than compare, it means the check is never true. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: My first patch was wrong. diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

Re: [Intel-gfx] [patch v2] drm/i915: fix a limit check in hsw_compute_wm_results()

2013-08-09 Thread Ville Syrjälä
On Fri, Aug 09, 2013 at 01:07:31PM +0300, Dan Carpenter wrote: The '!' here was not intended. Since '!' has higher precedence than compare, it means the check is never true. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com The

Re: [Intel-gfx] [patch v2] drm/i915: fix a limit check in hsw_compute_wm_results()

2013-08-09 Thread Daniel Vetter
On Fri, Aug 09, 2013 at 01:29:33PM +0300, Ville Syrjälä wrote: On Fri, Aug 09, 2013 at 01:07:31PM +0300, Dan Carpenter wrote: The '!' here was not intended. Since '!' has higher precedence than compare, it means the check is never true. Signed-off-by: Dan Carpenter