The documentation for "drm_plane_funcs.format_mod_supported" reads:
This *optional* hook is used for the DRM to determine if the given
format/modifier combination is valid for the plane. This allows the
DRM to generate the correct format bitmask (which formats apply to
which modifier),
Thanks for your reviews :) I'll wait a couple of days to see
if somebody else wants to comment and I'll send v3 adding the
reviewed by tags and fixing the compiler warning.
On Thu, Dec 23, 2021 at 05:03:19PM +0200, Ville Syrjälä wrote:
> Another related thing that might be worth checking is
On Thu, Dec 23, 2021 at 01:42:32PM +, Simon Ser wrote:
> On Thursday, December 23rd, 2021 at 12:56, Ville Syrjälä
> wrote:
>
> > > - /* If we can't determine support, just bail */
> > > - if (!plane->funcs->format_mod_supported)
> > > - goto done;
> > > -
> > > mod =
On Thursday, December 23rd, 2021 at 12:56, Ville Syrjälä
wrote:
> > - /* If we can't determine support, just bail */
> > - if (!plane->funcs->format_mod_supported)
> > - goto done;
> > -
> > mod = modifiers_ptr(blob_data);
> > for (i = 0; i < plane->modifier_count; i++) {
On Wed, Dec 22, 2021 at 10:05:47AM +0100, José Expósito wrote:
> The documentation for "drm_plane_funcs.format_mod_supported" reads:
>
> This *optional* hook is used for the DRM to determine if the given
> format/modifier combination is valid for the plane. This allows the
> DRM to generate
On Wednesday, December 22nd, 2021 at 10:05, José Expósito
wrote:
> Make "create_in_format_blob" behave as documented.
LGTM, nice!
Reviewed-by: Simon Ser
CC Ville just in case
