Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Wed, Jan 11, 2017 at 08:16:56AM -0800, Dave Hansen wrote: > On 01/11/2017 07:39 AM, Daniel Vetter wrote: > > Hm, just cherry-picked it on top of Linus' latest 4.10 git, applies > > cleanly there. The substituation was for 4.9. I can send you the patch > > here, but seems all fine from what I

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/11/2017 07:39 AM, Daniel Vetter wrote: > Hm, just cherry-picked it on top of Linus' latest 4.10 git, applies > cleanly there. The substituation was for 4.9. I can send you the patch > here, but seems all fine from what I can tell ... All of the printk's that I added were making it fail to

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Wed, Jan 11, 2017 at 07:24:45AM -0800, Dave Hansen wrote: > On 01/10/2017 11:43 PM, Daniel Vetter wrote: > > On Tue, Jan 10, 2017 at 08:52:47AM -0800, Dave Hansen wrote: > >> On 01/10/2017 02:31 AM, Daniel Vetter wrote: > >>> commit e73ab00e9a0f1731f34d0620a9c55f5c30c4ad4e > >>> Author: Daniel

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Wed, Jan 11, 2017 at 4:24 PM, Dave Hansen wrote: > On 01/10/2017 11:43 PM, Daniel Vetter wrote: >> On Tue, Jan 10, 2017 at 08:52:47AM -0800, Dave Hansen wrote: >>> On 01/10/2017 02:31 AM, Daniel Vetter wrote: commit e73ab00e9a0f1731f34d0620a9c55f5c30c4ad4e

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/10/2017 11:43 PM, Daniel Vetter wrote: > On Tue, Jan 10, 2017 at 08:52:47AM -0800, Dave Hansen wrote: >> On 01/10/2017 02:31 AM, Daniel Vetter wrote: >>> commit e73ab00e9a0f1731f34d0620a9c55f5c30c4ad4e >>> Author: Daniel Vetter >>> Date: Sun Dec 18 14:35:45 2016

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/10/2017 02:31 AM, Daniel Vetter wrote: > commit e73ab00e9a0f1731f34d0620a9c55f5c30c4ad4e > Author: Daniel Vetter > Date: Sun Dec 18 14:35:45 2016 +0100 > > drm: prevent double-(un)registration for connectors > > Lack of that would perfectly explain that oops

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Mon, Jan 09, 2017 at 09:42:22AM -0800, Dave Hansen wrote: > On 01/09/2017 08:59 AM, Daniel Vetter wrote: > > On Mon, Jan 9, 2017 at 5:50 PM, Dave Hansen wrote: > >> On 01/09/2017 08:41 AM, Daniel Vetter wrote: > >>> On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Mon, Jan 9, 2017 at 12:22 PM, Dave Hansen wrote: > On 01/09/2017 08:59 AM, Daniel Vetter wrote: >> On Mon, Jan 9, 2017 at 5:50 PM, Dave Hansen wrote: >>> On 01/09/2017 08:41 AM, Daniel Vetter wrote: On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/09/2017 08:59 AM, Daniel Vetter wrote: > On Mon, Jan 9, 2017 at 5:50 PM, Dave Hansen wrote: >> On 01/09/2017 08:41 AM, Daniel Vetter wrote: >>> On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen wrote: Well, now I found where the -2 comes from.

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/09/2017 08:59 AM, Daniel Vetter wrote: > On Mon, Jan 9, 2017 at 5:50 PM, Dave Hansen wrote: >> On 01/09/2017 08:41 AM, Daniel Vetter wrote: >>> On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen wrote: Well, now I found where the -2 comes from.

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Mon, Jan 9, 2017 at 5:50 PM, Dave Hansen wrote: > On 01/09/2017 08:41 AM, Daniel Vetter wrote: >> On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen wrote: >>> Well, now I found where the -2 comes from. >>> intel_dp_register_mst_connector() calls

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/09/2017 08:41 AM, Daniel Vetter wrote: > On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen wrote: >> Well, now I found where the -2 comes from. >> intel_dp_register_mst_connector() calls drm_connector_register(), which >> fails to add the kobject (warning below). But, it

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Mon, Jan 9, 2017 at 2:40 PM, Dave Hansen wrote: > Well, now I found where the -2 comes from. > intel_dp_register_mst_connector() calls drm_connector_register(), which > fails to add the kobject (warning below). But, it does zero error > checking on the

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/09/2017 05:40 AM, Dave Hansen wrote: > Is there some stable code to go back to here? Or, is there something > about my configuration that's unique? I really wonder why nobody else > is running into this. Here are a couple of similar-looking reports, if that helps:

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

Well, now I found where the -2 comes from. intel_dp_register_mst_connector() calls drm_connector_register(), which fails to add the kobject (warning below). But, it does zero error checking on the drm_connector_register() call and leaves the partially-constructed connector in place. The next

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On 01/09/2017 02:15 AM, Daniel Vetter wrote: ... > Can you pls do some printk tracing to make sure that without your patch > we're indeed releasing the same connector twice from this loop? I suspect > you're just ever-so-slightly shifting the timing and things blow up > somewhre else. But no idea

Re: [Intel-gfx] 4.10-rc2 oops in DRM connector code

On Thu, Jan 05, 2017 at 11:03:44AM -0800, Dave Hansen wrote: > My Thinkpad x260 doesn't like to be unplugged from its dock. I don't > think this is a new bug. It's happening on my distro's 4.4 kernel > as well. > > The actual oops is in device_del(). It appears to have been passed a > null

[Intel-gfx] 4.10-rc2 oops in DRM connector code

My Thinkpad x260 doesn't like to be unplugged from its dock. I don't think this is a new bug. It's happening on my distro's 4.4 kernel as well. The actual oops is in device_del(). It appears to have been passed a null 'struct device *'. There appears to have been a race _around_ here fixed in