Re: [Intel-gfx] BUG_ON vs WARN_ON (was: Re: [PATCH] drm/i915: Localise the fbdev console lock frobbing)

2014-08-14 Thread Daniel Vetter
On Thu, Aug 14, 2014 at 01:07:06PM +0300, Jani Nikula wrote: > On Thu, 14 Aug 2014, Daniel Vetter wrote: > > On Thu, Aug 14, 2014 at 8:54 AM, Chris Wilson > > wrote: > >> I disaggree with the conversion of the BUG_ON though, a WARN there is > >> going to screw up unpredictably (well, a hard hang

[Intel-gfx] BUG_ON vs WARN_ON (was: Re: [PATCH] drm/i915: Localise the fbdev console lock frobbing)

2014-08-14 Thread Jani Nikula
On Thu, 14 Aug 2014, Daniel Vetter wrote: > On Thu, Aug 14, 2014 at 8:54 AM, Chris Wilson > wrote: >> I disaggree with the conversion of the BUG_ON though, a WARN there is >> going to screw up unpredictably (well, a hard hang without any output >> is the predictable outcome). I'd like to have as