Re: [Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
; Korjani, Vikas Subject: Re: [Intel-gfx] Design review request: DRM color manager On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote: [...] > Please note that the color correction methods changes per platform and > what's valid for one Intel platform may not be valid for ot

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote: [...] > Please note that the color correction methods changes per platform and > what's valid for one Intel platform may not be valid for other. So the > atomic modeset should have a clear idea of what is supported on which > platfor

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-14 Thread Sharma, Shashank
What I understood from the reviews comments from the experts, is having a central color management at DRM kernel layer is not a good idea, and we should create individual DRM properties for the color correction methods, and let the control be there in the user space level, where an atomic modes

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-14 Thread Thierry Reding
On Tue, May 13, 2014 at 09:18:45AM +0530, Sharma, Shashank wrote: > Daniel, > Please find my comments inline. > > Regards > Shashank > On 5/12/2014 8:58 PM, Daniel Vetter wrote: > >On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: > >>Thanks for your time and the comments David. >

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
Daniel, Please find my comments inline. Regards Shashank On 5/12/2014 8:58 PM, Daniel Vetter wrote: On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: Thanks for your time and the comments David. please find mine inline. Regards Shashank On 5/12/2014 5:20 PM, David Herrmann wrot

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 5:28 PM, Daniel Vetter wrote: > Those are all just reasons for atomic modeset and maybe an atomic modeget > ioctl which transfers the entire blob of things. Maybe we should start > with the atomic modeget to get things rolling. Otoh you can always do that > in userspace

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Daniel Vetter
On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: > Thanks for your time and the comments David. > please find mine inline. > > Regards > Shashank > On 5/12/2014 5:20 PM, David Herrmann wrote: > >Hi > > > >On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank > > wrote: > >>Benefits o

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
Thanks for your time and the comments David. please find mine inline. Regards Shashank On 5/12/2014 5:20 PM, David Herrmann wrote: Hi On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank wrote: Benefits of using color manager: 1. Unique framework for all the col

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank wrote: > Benefits of using color manager: > > 1. Unique framework for all the color correction properties, across all >DRM drivers, across various platforms. > 2. Only one set/get call for all kind of prope

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
hank On 5/7/2014 7:41 PM, Sharma, Shashank wrote: FYI -Original Message- From: Sharma, Shashank Sent: Tuesday, April 22, 2014 8:32 PM To: Daniel Vetter Cc: David Herrmann; intel-gfx@lists.freedesktop.org; Cn, Ramakrishnan; Jindal, Sonika; Shankar, Uma Subject: RE: [Intel-gfx] Design revie

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Daniel Vetter
- Can be clubbed with modeset implementations. > > > > > Regards > Shashank > > On 5/7/2014 7:41 PM, Sharma, Shashank wrote: >> >> FYI >> >> >> -Original Message- >> From: Sharma, Shashank >> Sent: Tuesday, April 22, 2014 8:32 PM

Re: [Intel-gfx] Design review request: DRM color manager

2014-05-11 Thread Sharma, Shashank
...@intel.com Subject: [Intel-gfx] Design review request: DRM color manager Hello all, As per previous discussions, I am sending the drm-color-manager design for review, as inline text. Please have a look and let me know your feedback. (I tried hard to align the inline text diagram in mail, hope you

[Intel-gfx] Design review request: DRM color manager

2014-05-07 Thread Sharma, Shashank
ma Subject: RE: [Intel-gfx] Design review request: DRM color manager David, My apologies for starting a pre-mature design discussion. Daniel, Thanks for pointing out first two things, It was not known to me, I will take care of this in future. First time I presented color-manager design, in internal

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread Sharma, Shashank
Behalf Of Daniel Vetter Sent: Tuesday, April 22, 2014 7:18 PM To: Sharma, Shashank Cc: David Herrmann; intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Thierry Reding; Cn, Ramakrishnan; Alex Deucher; Jindal, Sonika; Shankar, Uma Subject: Re: [Intel-gfx] Design review request: DRM color

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread Daniel Vetter
On Tue, Apr 22, 2014 at 12:07:41PM +, Sharma, Shashank wrote: > Thanks again David, > Comments inline. Three things: - Please don't send out .pptx files to upstream/public mailing lists, that's just not how the upstream community works. - Please either fix up ms outlook to do proper in-li

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread Sharma, Shashank
Thanks again David, Comments inline. Regards Shashank -Original Message- From: David Herrmann [mailto:dh.herrm...@gmail.com] Sent: Tuesday, April 22, 2014 5:10 PM To: Sharma, Shashank Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Ville Syrjälä; Thierry Reding; A

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread David Herrmann
Hi On Tue, Apr 22, 2014 at 12:21 PM, Sharma, Shashank wrote: > 1) Why do you register only a single property? Why not register a separate > property for each color-correction that is available? This way you can drop > the property-id and use the high-level DRM-prop IDs/names. >>> That’s the who

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread Sharma, Shashank
Thanks for the review and comments David. Please find my comments inline. Regards Shashank -Original Message- From: David Herrmann [mailto:dh.herrm...@gmail.com] Sent: Tuesday, April 22, 2014 3:08 PM To: Sharma, Shashank Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread David Herrmann
Hi On Tue, Apr 22, 2014 at 6:11 AM, Sharma, Shashank wrote: > Gentle reminder Usual approach is to send any proposals as inline plain-text. It's really hard to comment on attachments, especially if it's an MS-office format. Anyhow, some comments on the proposal: 1) Why do you register only a si

Re: [Intel-gfx] Design review request: DRM color manager

2014-04-21 Thread Sharma, Shashank
Gentle reminder Regards Shashank -Original Message- From: Sharma, Shashank Sent: Friday, April 18, 2014 12:01 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Ville Syrjälä; Thierry Reding; Alex Deucher; Sean Paul; robdcl...@gmail.com Cc: Shankar, Uma; Korjani, V