[Intel-gfx] linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?

2017-11-27 Thread David Binderman
Hello there, linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640]: (style) Checking if unsigned variable 'bb_size' is less than zero. Source code is /* get the size of the batch buffer */ bb_size = find_bb_size(s); if (bb_size < 0) return -EINVAL; but static int

Re: [Intel-gfx] linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?

2017-11-27 Thread Wang, Zhi A
Thanks for the email. It has been refined recently, the code can be found here: https://cgit.freedesktop.org/drm-intel/tree/drivers/gpu/drm/i915/gvt/cmd_parser.c Thanks for the notification, again. :) -Original Message- From: David Binderman [mailto:dcb...@hotmail.com] Sent: Monday,