Re: [PATCH] drm/i915/xelpg: Add fake PCH for xelpg

2023-12-19 Thread Kalvala, Haridhar
On 12/18/2023 9:24 PM, Matt Roper wrote: Oh, and one more thing I forgot to mention before hitting send...the title for this patch doesn't make sense. Xe_LPG is the graphics IP used by MTL; that's completely unrelated to the display IP (which is Xe_LPD+). Since we're assigning the fake PCH

Re: [PATCH] drm/i915/xelpg: Add fake PCH for xelpg

2023-12-18 Thread Matt Roper
On Mon, Dec 18, 2023 at 04:33:13PM +0530, Haridhar Kalvala wrote: > Correct the implementation trying to detect MTL PCH with > the MTL fake PCH id. > > On MTL, both the North Display (NDE) and South Display (SDE) functionality > reside on the same die (the SoC die in this case), unlike many past

Re: [PATCH] drm/i915/xelpg: Add fake PCH for xelpg

2023-12-18 Thread Matt Roper
Oh, and one more thing I forgot to mention before hitting send...the title for this patch doesn't make sense. Xe_LPG is the graphics IP used by MTL; that's completely unrelated to the display IP (which is Xe_LPD+). Since we're assigning the fake PCH value based off the platform (IS_METEORLAKE)

[PATCH] drm/i915/xelpg: Add fake PCH for xelpg

2023-12-18 Thread Haridhar Kalvala
Correct the implementation trying to detect MTL PCH with the MTL fake PCH id. On MTL, both the North Display (NDE) and South Display (SDE) functionality reside on the same die (the SoC die in this case), unlike many past platforms where the SDE was on a separate PCH die. The code is (badly)