Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-29 Thread Ville Syrjälä
On Wed, May 29, 2024 at 12:37:30AM +0300, Imre Deak wrote: > On Tue, May 28, 2024 at 10:38:06PM +0300, Ville Syrjälä wrote: > > On Tue, May 28, 2024 at 02:27:52PM +0300, Imre Deak wrote: > > > On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > >

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Tue, May 28, 2024 at 10:38:06PM +0300, Ville Syrjälä wrote: > On Tue, May 28, 2024 at 02:27:52PM +0300, Imre Deak wrote: > > On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Different planes could have different alignment requirements > > > e

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Ville Syrjälä
On Tue, May 28, 2024 at 02:27:52PM +0300, Imre Deak wrote: > On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Different planes could have different alignment requirements > > even for the same format/modifier. Collect the alignment > > requirements ac

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Tue, May 28, 2024 at 02:27:58PM +0300, Imre Deak wrote: > [...] > > +} > > + > > static unsigned int > > intel_plane_fb_min_alignment(const struct intel_plane_state *plane_state) > > { > > struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane); > > - const struct drm_frameb

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Different planes could have different alignment requirements > even for the same format/modifier. Collect the alignment > requirements across all planes capable of scanning out the > fb such that the alignmen

[PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Different planes could have different alignment requirements even for the same format/modifier. Collect the alignment requirements across all planes capable of scanning out the fb such that the alignment used when pinning the normal ggtt view is satisfactory to all those plane