Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-04-03 Thread Lucas De Marchi
On Thu, Mar 28, 2024 at 12:33:09PM +0200, Jani Nikula wrote: On Thu, 28 Mar 2024, Andi Shyti wrote: Hi Arun, ... - drmm_mutex_init(&xe->drm, &xe->sb_lock); - drmm_mutex_init(&xe->drm, &xe->display.backlight.lock); - drmm_mutex_init(&xe->drm, &xe->display.audio.mutex); -

RE: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-30 Thread Murthy, Arun R
> -Original Message- > From: Andi Shyti > Sent: Thursday, March 28, 2024 4:38 PM > To: Murthy, Arun R > Cc: Andi Shyti ; Jani Nikula > ; intel-gfx@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Subject: Re: [PATCHv2] drm/xe/display: check for

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Andi Shyti
Hi Arun, > > On Thu, Mar 28, 2024 at 12:33:09PM +0200, Jani Nikula wrote: > > > On Thu, 28 Mar 2024, Andi Shyti wrote: > > > >> - drmm_mutex_init(&xe->drm, &xe->sb_lock); > > > >> - drmm_mutex_init(&xe->drm, &xe->display.backlight.lock); > > > >> - drmm_mutex_init(&xe->drm, &xe->di

RE: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Murthy, Arun R
> -Original Message- > From: Andi Shyti > Sent: Thursday, March 28, 2024 4:16 PM > To: Jani Nikula > Cc: Andi Shyti ; Murthy, Arun R > ; intel-gfx@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Subject: Re: [PATCHv2] drm/xe/display: check for

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Andi Shyti
Hi Jani, On Thu, Mar 28, 2024 at 12:33:09PM +0200, Jani Nikula wrote: > On Thu, 28 Mar 2024, Andi Shyti wrote: > >> - drmm_mutex_init(&xe->drm, &xe->sb_lock); > >> - drmm_mutex_init(&xe->drm, &xe->display.backlight.lock); > >> - drmm_mutex_init(&xe->drm, &xe->display.audio.mutex); > >> - drmm

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Jani Nikula
On Thu, 28 Mar 2024, Andi Shyti wrote: > Hi Arun, > > ... > >> -drmm_mutex_init(&xe->drm, &xe->sb_lock); >> -drmm_mutex_init(&xe->drm, &xe->display.backlight.lock); >> -drmm_mutex_init(&xe->drm, &xe->display.audio.mutex); >> -drmm_mutex_init(&xe->drm, &xe->display.wm.wm_mutex); >>

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Andi Shyti
Hi Arun, ... > - drmm_mutex_init(&xe->drm, &xe->sb_lock); > - drmm_mutex_init(&xe->drm, &xe->display.backlight.lock); > - drmm_mutex_init(&xe->drm, &xe->display.audio.mutex); > - drmm_mutex_init(&xe->drm, &xe->display.wm.wm_mutex); > - drmm_mutex_init(&xe->drm, &xe->display.pp

[PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-03-28 Thread Arun R Murthy
Check return value for drmm_mutex_init as it can fail and return on failure. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_display.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/d