Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix selftest_mocs for DGFX

2020-02-14 Thread Daniele Ceraolo Spurio
On 2/14/20 10:29 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2020-02-14 17:56:58) On 2/12/20 4:49 PM, Brian Welty wrote: On 2/12/2020 4:34 PM, Chris Wilson wrote: Quoting Brian Welty (2020-02-13 00:14:18) For DGFX devices, the MOCS control value is not initialized or used.

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix selftest_mocs for DGFX

2020-02-14 Thread Chris Wilson
Quoting Chris Wilson (2020-02-14 18:29:31) > +static bool has_l3cc(struct drm_i915_private *i915) > +{ > + return true; > +} > + > +static bool has_mocs(struct drm_i915_private *i915) > +{ > + return !IS_DGFX(i915); > +} > + > static int live_mocs_init(struct live_mocs *arg, struct

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix selftest_mocs for DGFX

2020-02-14 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2020-02-14 17:56:58) > > > On 2/12/20 4:49 PM, Brian Welty wrote: > > > > On 2/12/2020 4:34 PM, Chris Wilson wrote: > >> Quoting Brian Welty (2020-02-13 00:14:18) > >>> For DGFX devices, the MOCS control value is not initialized or used. > >> > >> Then why is the

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix selftest_mocs for DGFX

2020-02-14 Thread Daniele Ceraolo Spurio
On 2/12/20 4:49 PM, Brian Welty wrote: On 2/12/2020 4:34 PM, Chris Wilson wrote: Quoting Brian Welty (2020-02-13 00:14:18) For DGFX devices, the MOCS control value is not initialized or used. Then why is the table populated? -Chris The format has changed (been reduced?) for DGFX.

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix selftest_mocs for DGFX

2020-02-12 Thread Brian Welty
On 2/12/2020 4:34 PM, Chris Wilson wrote: > Quoting Brian Welty (2020-02-13 00:14:18) >> For DGFX devices, the MOCS control value is not initialized or used. > > Then why is the table populated? > -Chris > The format has changed (been reduced?) for DGFX. drm_i915_mocs_entry.l3cc_value is

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix selftest_mocs for DGFX

2020-02-12 Thread Chris Wilson
Quoting Brian Welty (2020-02-13 00:14:18) > For DGFX devices, the MOCS control value is not initialized or used. Then why is the table populated? -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org