Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Jesse Barnes
On Thu, 27 Mar 2014 16:22:44 -0700 Kenneth Graunke kenn...@whitecape.org wrote: On 03/27/2014 03:44 PM, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 10:34 PM, Kenneth Graunke kenn...@whitecape.org wrote: Why are we parsing batches with I915_EXEC_SECURE at all? Secure batches are only

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Chris Wilson
On Fri, May 16, 2014 at 12:05:45PM -0700, Jesse Barnes wrote: On Thu, 27 Mar 2014 16:22:44 -0700 Kenneth Graunke kenn...@whitecape.org wrote: On 03/27/2014 03:44 PM, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 10:34 PM, Kenneth Graunke kenn...@whitecape.org wrote: Why are we

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Jesse Barnes
On Fri, 16 May 2014 20:20:50 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, May 16, 2014 at 12:05:45PM -0700, Jesse Barnes wrote: On Thu, 27 Mar 2014 16:22:44 -0700 Kenneth Graunke kenn...@whitecape.org wrote: On 03/27/2014 03:44 PM, Daniel Vetter wrote: On Thu, Mar 27,

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Jesse Barnes
On Fri, 16 May 2014 12:34:08 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 16 May 2014 20:20:50 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Yes, X only sets the secure bit when it pokes the display registers, and those registers should be privileged even with a cmd

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Volkin, Bradley D
On Fri, May 16, 2014 at 12:53:30PM -0700, Jesse Barnes wrote: On Fri, 16 May 2014 12:34:08 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 16 May 2014 20:20:50 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Yes, X only sets the secure bit when it pokes the display

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Jesse Barnes
On Fri, 16 May 2014 20:49:30 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, May 16, 2014 at 12:34:08PM -0700, Jesse Barnes wrote: On Fri, 16 May 2014 20:20:50 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: We haven't even fixed the major regression from enabling FBC.

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-05-16 Thread Jesse Barnes
On Fri, 16 May 2014 13:12:27 -0700 Volkin, Bradley D bradley.d.vol...@intel.com wrote: On Fri, May 16, 2014 at 12:53:30PM -0700, Jesse Barnes wrote: On Fri, 16 May 2014 12:34:08 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 16 May 2014 20:20:50 +0100 Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-28 Thread Chris Wilson
On Thu, Mar 27, 2014 at 04:42:21PM -0700, Volkin, Bradley D wrote: On Thu, Mar 27, 2014 at 01:16:26PM -0700, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 4:57 PM, Volkin, Bradley D bradley.d.vol...@intel.com wrote: On Thu, Mar 27, 2014 at 12:57:21AM -0700, Daniel Vetter wrote: Another

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Daniel Vetter
On Wed, Mar 26, 2014 at 11:26:05AM -0700, Volkin, Bradley D wrote: On Wed, Mar 26, 2014 at 10:37:44AM -0700, Kenneth Graunke wrote: On 03/26/2014 09:38 AM, Daniel Vetter wrote: On Wed, Mar 26, 2014 at 09:03:58AM -0700, Volkin, Bradley D wrote: On Tue, Mar 25, 2014 at 11:21:23PM -0700,

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Volkin, Bradley D
[snip] On Thu, Mar 27, 2014 at 12:57:21AM -0700, Daniel Vetter wrote: Another one that blows is igt/gen7_forcewake_mt. Not sure yet whether it's an issue with the test or the checker: https://bugs.freedesktop.org/show_bug.cgi?id=76670 For this one, the parser rejects an

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Daniel Vetter
On Thu, Mar 27, 2014 at 4:57 PM, Volkin, Bradley D bradley.d.vol...@intel.com wrote: On Thu, Mar 27, 2014 at 12:57:21AM -0700, Daniel Vetter wrote: Another one that blows is igt/gen7_forcewake_mt. Not sure yet whether it's an issue with the test or the checker:

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Kenneth Graunke
On 03/27/2014 01:16 PM, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 4:57 PM, Volkin, Bradley D bradley.d.vol...@intel.com wrote: On Thu, Mar 27, 2014 at 12:57:21AM -0700, Daniel Vetter wrote: Another one that blows is igt/gen7_forcewake_mt. Not sure yet whether it's an issue with the test or

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Daniel Vetter
On Thu, Mar 27, 2014 at 10:34 PM, Kenneth Graunke kenn...@whitecape.org wrote: Why are we parsing batches with I915_EXEC_SECURE at all? Secure batches are only issued from trusted code which is guaranteed to be running as root. I don't see any benefit to scanning those batches, and there's

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Kenneth Graunke
On 03/27/2014 03:44 PM, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 10:34 PM, Kenneth Graunke kenn...@whitecape.org wrote: Why are we parsing batches with I915_EXEC_SECURE at all? Secure batches are only issued from trusted code which is guaranteed to be running as root. I don't see any

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-27 Thread Volkin, Bradley D
On Thu, Mar 27, 2014 at 01:16:26PM -0700, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 4:57 PM, Volkin, Bradley D bradley.d.vol...@intel.com wrote: On Thu, Mar 27, 2014 at 12:57:21AM -0700, Daniel Vetter wrote: Another one that blows is igt/gen7_forcewake_mt. Not sure yet whether it's an

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Daniel Vetter
On Tue, Mar 25, 2014 at 10:52:03PM -0700, Kenneth Graunke wrote: Mesa needs to be able to write OACONTROL in order to expose the Observability Architecture's performance counters via OpenGL. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Thanks a lot for quickly tracking this down. Now

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Jani Nikula
On Wed, 26 Mar 2014, Kenneth Graunke kenn...@whitecape.org wrote: Mesa needs to be able to write OACONTROL in order to expose the Observability Architecture's performance counters via OpenGL. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- drivers/gpu/drm/i915/i915_cmd_parser.c | 1

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Volkin, Bradley D
On Tue, Mar 25, 2014 at 11:21:23PM -0700, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 10:52:03PM -0700, Kenneth Graunke wrote: Mesa needs to be able to write OACONTROL in order to expose the Observability Architecture's performance counters via OpenGL. Signed-off-by: Kenneth Graunke

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Daniel Vetter
On Wed, Mar 26, 2014 at 09:03:58AM -0700, Volkin, Bradley D wrote: On Tue, Mar 25, 2014 at 11:21:23PM -0700, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 10:52:03PM -0700, Kenneth Graunke wrote: Mesa needs to be able to write OACONTROL in order to expose the Observability Architecture's

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Volkin, Bradley D
On Wed, Mar 26, 2014 at 10:37:44AM -0700, Kenneth Graunke wrote: On 03/26/2014 09:38 AM, Daniel Vetter wrote: On Wed, Mar 26, 2014 at 09:03:58AM -0700, Volkin, Bradley D wrote: On Tue, Mar 25, 2014 at 11:21:23PM -0700, Daniel Vetter wrote: On Tue, Mar 25, 2014 at 10:52:03PM -0700, Kenneth

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Daniel Vetter
On Wed, Mar 26, 2014 at 11:26:05AM -0700, Volkin, Bradley D wrote: On Wed, Mar 26, 2014 at 10:37:44AM -0700, Kenneth Graunke wrote: On 03/26/2014 09:38 AM, Daniel Vetter wrote: On Wed, Mar 26, 2014 at 09:03:58AM -0700, Volkin, Bradley D wrote: On Tue, Mar 25, 2014 at 11:21:23PM -0700,

Re: [Intel-gfx] [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist.

2014-03-26 Thread Kenneth Graunke
On 03/26/2014 11:26 AM, Volkin, Bradley D wrote: On Wed, Mar 26, 2014 at 10:37:44AM -0700, Kenneth Graunke wrote: On 03/26/2014 09:38 AM, Daniel Vetter wrote: On Wed, Mar 26, 2014 at 09:03:58AM -0700, Volkin, Bradley D wrote: On Tue, Mar 25, 2014 at 11:21:23PM -0700, Daniel Vetter wrote: On