Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 Thread Daniel Vetter
On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Since we merged runtime PM support for DPMS, it is possible that these functions will be called when the power wells are disabled but a mode is set, resulting in failed assertion and

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 Thread Paulo Zanoni
2014-07-17 5:38 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Since we merged runtime PM support for DPMS, it is possible that these functions will be called when the power wells are disabled

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 Thread Daniel Vetter
On Thu, Jul 17, 2014 at 2:53 PM, Paulo Zanoni przan...@gmail.com wrote: 2014-07-17 5:38 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Since we merged runtime PM support for DPMS, it is

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 Thread Paulo Zanoni
2014-07-17 10:23 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Thu, Jul 17, 2014 at 2:53 PM, Paulo Zanoni przan...@gmail.com wrote: 2014-07-17 5:38 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 Thread Daniel Vetter
On Thu, Jul 17, 2014 at 3:29 PM, Paulo Zanoni przan...@gmail.com wrote: I can do this, but please notice that we already have power-well-checking code in many of the other assertions on our driver... And it will probably be just a matter of time since someone starts using the assertions again

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 Thread Paulo Zanoni
2014-07-17 13:58 GMT-03:00 Daniel Vetter dan...@ffwll.ch: On Thu, Jul 17, 2014 at 3:29 PM, Paulo Zanoni przan...@gmail.com wrote: I can do this, but please notice that we already have power-well-checking code in many of the other assertions on our driver... And it will probably be just a