Re: [Intel-gfx] [PATCH] drm/i915: s/seqno/request/ tracking inside objects

2014-07-29 Thread Chris Wilson
On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote: +static void +i915_gem_object_retire(struct drm_i915_gem_object *obj) +{ + struct i915_gem_request *rq; + int i; + + if (!obj-active) + return; + + rq = obj-last_write.request; + if (rq

Re: [Intel-gfx] [PATCH] drm/i915: s/seqno/request/ tracking inside objects

2014-07-29 Thread Chris Wilson
On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote: +static void i915_request_retire(struct i915_gem_request *rq) { - list_del(request-list); - i915_gem_request_remove_from_client(request); + rq-completed = true; + + list_del(rq-list); +

Re: [Intel-gfx] [PATCH] drm/i915: s/seqno/request/ tracking inside objects

2014-07-29 Thread Daniel Vetter
On Tue, Jul 29, 2014 at 08:29:53AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote: @@ -3038,44 +3203,35 @@ out: */ int i915_gem_object_sync(struct drm_i915_gem_object *obj, - struct intel_engine_cs *to) +

Re: [Intel-gfx] [PATCH] drm/i915: s/seqno/request/ tracking inside objects

2014-07-29 Thread Jesse Barnes
On Tue, 29 Jul 2014 12:41:26 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jul 29, 2014 at 08:29:53AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote: @@ -3038,44 +3203,35 @@ out: */ int i915_gem_object_sync(struct

Re: [Intel-gfx] [PATCH] drm/i915: s/seqno/request/ tracking inside objects

2014-07-28 Thread Daniel Vetter
On Fri, Jul 25, 2014 at 01:27:00PM +0100, Chris Wilson wrote: At the heart of this change is that the seqno is a too low level of an abstraction to handle the growing complexities of command tracking, both with the introduction of multiple command queues with execbuffer and the potential for

Re: [Intel-gfx] [PATCH] drm/i915: s/seqno/request/ tracking inside objects

2014-07-28 Thread Jesse Barnes
On Fri, 25 Jul 2014 13:27:00 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: @@ -614,12 +615,12 @@ static int i915_gem_pageflip_info(struct seq_file *m, void *data) seq_printf(m, Flip pending (waiting for vsync) on pipe %c (plane %c)\n, pipe, plane); } -