Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing

2014-10-24 Thread Daniel Vetter
On Thu, Oct 23, 2014 at 09:58:47AM -0700, Todd Previte wrote: On 10/20/2014 10:48 AM, Paulo Zanoni wrote: 2014-10-09 12:38 GMT-03:00 Todd Previte tprev...@gmail.com: +/* Displayport compliance testing - PHY pattern testing */ +static uint8_t +intel_dp_autotest_phy_pattern(struct intel_dp

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing

2014-10-24 Thread Daniel Vetter
On Thu, Oct 09, 2014 at 08:38:01AM -0700, Todd Previte wrote: Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds the necessary framework for the source device to appropriately respond to test automation requests from a sink device.

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing

2014-10-23 Thread Todd Previte
Version 2 in process now. Responses in line below. On 10/20/2014 10:48 AM, Paulo Zanoni wrote: Hi Since I already commented about the coding style on the previous reviews, I'll ignore that aspect for the comments below. I think all the style issues have been resolved. Checkpatch.pl has 0

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add automated testing support for Displayport compliance testing

2014-10-20 Thread Paulo Zanoni
Hi Since I already commented about the coding style on the previous reviews, I'll ignore that aspect for the comments below. 2014-10-09 12:38 GMT-03:00 Todd Previte tprev...@gmail.com: Add the skeleton framework for supporting automation for Displayport compliance testing. This patch adds