Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-07-06 Thread Dave Gordon
On 06/07/15 15:28, Daniel Vetter wrote: On Fri, Jul 03, 2015 at 01:30:27PM +0100, Dave Gordon wrote: From: Alex Dai yu@intel.com This uses the common firmware loader to fetch the firmware image, then loads it into the GuC's memory via a dedicated DMA engine. This patch is derived from GuC

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 05:37:57PM +0100, Dave Gordon wrote: On 06/07/15 15:28, Daniel Vetter wrote: On Fri, Jul 03, 2015 at 01:30:27PM +0100, Dave Gordon wrote: From: Alex Dai yu@intel.com This uses the common firmware loader to fetch the firmware image, then loads it into the GuC's

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-07-06 Thread Daniel Vetter
On Fri, Jul 03, 2015 at 01:30:27PM +0100, Dave Gordon wrote: From: Alex Dai yu@intel.com This uses the common firmware loader to fetch the firmware image, then loads it into the GuC's memory via a dedicated DMA engine. This patch is derived from GuC loading work originally done by

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-06-19 Thread Dave Gordon
On 18/06/15 21:12, Chris Wilson wrote: On Thu, Jun 18, 2015 at 10:53:10AM -0700, Yu Dai wrote: On 06/15/2015 01:30 PM, Chris Wilson wrote: On Mon, Jun 15, 2015 at 07:36:23PM +0100, Dave Gordon wrote: + /* Set the source address for the new blob */ + offset =

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-06-18 Thread Yu Dai
On 06/15/2015 01:30 PM, Chris Wilson wrote: On Mon, Jun 15, 2015 at 07:36:23PM +0100, Dave Gordon wrote: snip + * Return true if get a success code from normal boot or RC6 boot + */ +static inline bool i915_guc_get_status(struct drm_i915_private *dev_priv, +

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-06-18 Thread Dave Gordon
On 15/06/15 21:30, Chris Wilson wrote: On Mon, Jun 15, 2015 at 07:36:23PM +0100, Dave Gordon wrote: +/* We can't enable contexts until all firmware is loaded */ +ret = intel_guc_ucode_load(dev, false); Pardon. I know context initialisation is broken, but adding to that breakage is

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-06-18 Thread Chris Wilson
On Thu, Jun 18, 2015 at 10:53:10AM -0700, Yu Dai wrote: On 06/15/2015 01:30 PM, Chris Wilson wrote: On Mon, Jun 15, 2015 at 07:36:23PM +0100, Dave Gordon wrote: + /* Set the source address for the new blob */ + offset = i915_gem_obj_ggtt_offset(fw_obj); Why would it even have a GGTT

Re: [Intel-gfx] [PATCH 05/15] drm/i915: GuC-specific firmware loader

2015-06-15 Thread Chris Wilson
On Mon, Jun 15, 2015 at 07:36:23PM +0100, Dave Gordon wrote: + /* We can't enable contexts until all firmware is loaded */ + ret = intel_guc_ucode_load(dev, false); Pardon. I know context initialisation is broken, but adding to that breakage is not pleasant. ret =