Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Provide a mock GPU reset routine

2019-09-27 Thread Chris Wilson
Quoting Chris Wilson (2019-09-27 20:14:42) > -static reset_func intel_get_gpu_reset(struct drm_i915_private *i915) > +static reset_func intel_get_gpu_reset(const struct intel_gt *gt) > { > - if (INTEL_GEN(i915) >= 8) > + struct drm_i915_private *i915 = gt->i915; > + > + if

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Provide a mock GPU reset routine

2019-09-27 Thread Chris Wilson
Quoting Andi Shyti (2019-09-27 21:41:19) > Hi Chris, > > On Fri, Sep 27, 2019 at 08:14:42PM +0100, Chris Wilson wrote: > > For those mock tests that may wish to pretend triggering a GPU reset and > > processing the cleanup. > > The patch is OK, per se, but I think it should be split in two >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Provide a mock GPU reset routine

2019-09-27 Thread Andi Shyti
Hi Chris, On Fri, Sep 27, 2019 at 08:14:42PM +0100, Chris Wilson wrote: > For those mock tests that may wish to pretend triggering a GPU reset and > processing the cleanup. The patch is OK, per se, but I think it should be split in two parts: - the i915 to gt conversion (that is the biggest