Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-05 Thread Daniel Vetter
On Mon, Dec 05, 2016 at 12:33:28PM -0800, Manasi Navare wrote: > On Fri, Dec 02, 2016 at 05:26:35PM +0100, Daniel Vetter wrote: > > Hm, tiny new bikeshed: I'd drop the _property postfix here. The function > > name is already really long as-is, and the fact that the link status is > > exposed as a

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-05 Thread Manasi Navare
On Fri, Dec 02, 2016 at 05:26:35PM +0100, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > > At the time userspace does setcrtc, we've already promised the mode > > would work. The promise is based on the theoretical capabilities of > > the link, but it's

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-04 Thread Daniel Vetter
On Fri, Dec 02, 2016 at 09:48:59AM -0800, Manasi Navare wrote: > On Fri, Dec 02, 2016 at 05:26:35PM +0100, Daniel Vetter wrote: > > On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > > > At the time userspace does setcrtc, we've already promised the mode > > > would work. The promise

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-02 Thread Manasi Navare
On Fri, Dec 02, 2016 at 05:26:35PM +0100, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > > At the time userspace does setcrtc, we've already promised the mode > > would work. The promise is based on the theoretical capabilities of > > the link, but it's

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-02 Thread Daniel Vetter
On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > At the time userspace does setcrtc, we've already promised the mode > would work. The promise is based on the theoretical capabilities of > the link, but it's possible we can't reach this in practice. The DP > spec describes how the

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-01 Thread Sean Paul
On Thu, Dec 1, 2016 at 1:58 PM, Manasi Navare wrote: > Sean, could you please review this patch, I have tried to address > all the comments from you. > Comments look good to me. Reviewed-by: Sean Paul Sean > Regards > Manasi > > On Tue, Nov

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-01 Thread Manasi Navare
Sean, could you please review this patch, I have tried to address all the comments from you. Regards Manasi On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > At the time userspace does setcrtc, we've already promised the mode > would work. The promise is based on the theoretical