Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-19 Thread Chris Wilson
On Fri, Nov 18, 2016 at 06:58:59PM -0800, Manasi Navare wrote: > In the usual working scenarios, this property is "Good". > If something fails during modeset, the DRM driver can > set the link status to "Bad", prune the mode list based on the > link rate/lane count fallback values and send

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Daniel Vetter
On Tue, Nov 15, 2016 at 03:56:09PM -0800, Manasi Navare wrote: > On Tue, Nov 15, 2016 at 08:49:21AM +0100, Daniel Vetter wrote: > > On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > > > + * If userspace is not aware of this property, the user experience is > > > the same > > > + *

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Daniel Vetter
On Tue, Nov 15, 2016 at 05:13:43PM -0800, Manasi Navare wrote: > On Tue, Nov 15, 2016 at 08:53:27AM +0100, Daniel Vetter wrote: > > On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > > > In the usual working scenarios, this property is "Good". > > > If something fails during modeset,

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Manasi Navare
On Tue, Nov 15, 2016 at 08:53:27AM +0100, Daniel Vetter wrote: > On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > > In the usual working scenarios, this property is "Good". > > If something fails during modeset, the DRM driver can > > set the link status to "Bad", prune the mode

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Manasi Navare
On Tue, Nov 15, 2016 at 08:49:21AM +0100, Daniel Vetter wrote: > On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > > In the usual working scenarios, this property is "Good". > > If something fails during modeset, the DRM driver can > > set the link status to "Bad", prune the mode

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-14 Thread Daniel Vetter
On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > In the usual working scenarios, this property is "Good". > If something fails during modeset, the DRM driver can > set the link status to "Bad", prune the mode list based on the > link rate/lane count fallback values and send

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-14 Thread Daniel Vetter
On Mon, Nov 14, 2016 at 07:23:33PM -0800, Manasi Navare wrote: > None of the other functions that set the connector property hold the > mode config locks while setting the connector property, I am following > the same convention. > Also we dont need to grab and release the locks in

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-14 Thread Daniel Vetter
On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > In the usual working scenarios, this property is "Good". > If something fails during modeset, the DRM driver can > set the link status to "Bad", prune the mode list based on the > link rate/lane count fallback values and send

Re: [Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-14 Thread Manasi Navare
None of the other functions that set the connector property hold the mode config locks while setting the connector property, I am following the same convention. Also we dont need to grab and release the locks in i915_modeset_work_func that first validates the modes and then sets this link status