Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-10 Thread Hans de Goede
Hi, On 07/09/2018 08:14 PM, Ville Syrjälä wrote: On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: Any kind of hack that involves reading out the hardware state should go into something like intel_sanitize_encoder(). Actually by that time we have already read out the hw state,

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-09 Thread Ville Syrjälä
On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: > Hi, > > On 07/06/2018 04:16 PM, Ville Syrjälä wrote: > > On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: > >> On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > >> different frequency then the

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-09 Thread Hans de Goede
Hi, On 07/09/2018 07:37 PM, Rodrigo Vivi wrote: On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: Hi, On 07/06/2018 04:16 PM, Ville Syrjälä wrote: On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: On BYT and CHT the GOP sometimes initializes the pclk at a

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-09 Thread Rodrigo Vivi
On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: > Hi, > > On 07/06/2018 04:16 PM, Ville Syrjälä wrote: > > On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: > > > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > > > different frequency then the

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-07 Thread Hans de Goede
Hi, On 07/06/2018 04:16 PM, Ville Syrjälä wrote: On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) different frequency then the pclk which we've calculated. This commit makes the DSI code read-back the pclk set

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-06 Thread Ville Syrjälä
On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > different frequency then the pclk which we've calculated. > > This commit makes the DSI code read-back the pclk set by the GOP and > if that is within a