Re: [Intel-gfx] [PATCH 4/5] drm/i915/gem: Pin gen6_ppgtt prior to constructing the request

2019-12-06 Thread Andi Shyti
Hi Chris, > All pinning must be done prior to i915_request_create, to avoid > timeline->mutex inversions. > > Here we slightly abuse the context_barrier_task stages to utilise the > 'skip' decision as an opportunity to acquire the pin on the new ppgtt. > Consider it s/skip/prepare/. At the

Re: [Intel-gfx] [PATCH 4/5] drm/i915/gem: Pin gen6_ppgtt prior to constructing the request

2019-12-06 Thread Chris Wilson
Quoting Andi Shyti (2019-12-06 23:31:26) > Hi Chris, > > > All pinning must be done prior to i915_request_create, to avoid > > timeline->mutex inversions. > > > > Here we slightly abuse the context_barrier_task stages to utilise the > > 'skip' decision as an opportunity to acquire the pin on the