Re: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

2018-05-15 Thread Souptick Joarder
>> >> default: >> >> - WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", >> >> ret); >> >> + WARN_ONCE(ret, "unhandled error in %s: %x\n", __func__, >> >> ret); >> > >> > I don't see point in %x (which should be 0x%x, really), why change it? >> >> ret

Re: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

2018-05-15 Thread Chris Wilson
Quoting Souptick Joarder (2018-05-15 16:29:25) > On Tue, May 15, 2018 at 7:19 PM, Joonas Lahtinen > wrote: > > Quoting Souptick Joarder (2018-04-17 22:02:02) > >> Use new return type vm_fault_t for fault handler. For > >> now, this is just documenting that the

Re: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

2018-05-15 Thread Souptick Joarder
On Tue, May 15, 2018 at 7:19 PM, Joonas Lahtinen wrote: > Quoting Souptick Joarder (2018-04-17 22:02:02) >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an errno.

Re: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

2018-05-15 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-05-15 14:49:17) > Quoting Souptick Joarder (2018-04-17 22:02:02) > > default: > > - WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", > > ret); > > + WARN_ONCE(ret, "unhandled error in %s: %x\n", __func__, > > ret); > > I

Re: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

2018-05-15 Thread Joonas Lahtinen
Quoting Souptick Joarder (2018-04-17 22:02:02) > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. > > Reference id ->

Re: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t

2018-05-10 Thread Souptick Joarder
On Wed, Apr 18, 2018 at 12:32 AM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a