Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-11-03 Thread Vivi, Rodrigo
On Fri, 2023-11-03 at 09:47 +, Tvrtko Ursulin wrote: > > On 03/11/2023 08:58, Coelho, Luciano wrote: > > On Fri, 2023-11-03 at 03:31 +, Vivi, Rodrigo wrote: > > > > > > > > > > Any other suggestions? > > > > > > > > I think it will boil down to the reason uncore lock is held > > > >

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-11-03 Thread Tvrtko Ursulin
On 03/11/2023 08:58, Coelho, Luciano wrote: On Fri, 2023-11-03 at 03:31 +, Vivi, Rodrigo wrote: Any other suggestions? I think it will boil down to the reason uncore lock is held over the respective sections ie. the comment in i915_get_crtc_scanoutpos. If it is timing sensitive to the

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-11-03 Thread Coelho, Luciano
On Fri, 2023-11-03 at 03:31 +, Vivi, Rodrigo wrote: > > > > > > Any other suggestions? > > > > I think it will boil down to the reason uncore lock is held over > > the > > respective sections ie. the comment in i915_get_crtc_scanoutpos. > > > > If it is timing sensitive to the extent irq

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-11-02 Thread Vivi, Rodrigo
> > > > Any other suggestions? > > I think it will boil down to the reason uncore lock is held over the > respective sections ie. the comment in i915_get_crtc_scanoutpos. > > If it is timing sensitive to the extent irq off was needed it may > apply > to Xe as well. Likewise the need to use

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-10-25 Thread Tvrtko Ursulin
On 25/10/2023 11:32, Coelho, Luciano wrote: On Wed, 2023-10-25 at 11:25 +0100, Tvrtko Ursulin wrote: On 25/10/2023 11:18, Tvrtko Ursulin wrote: On 23/10/2023 11:33, Luca Coelho wrote: The uncore code may not always be available (e.g. when we build the display code with Xe), so we can't

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-10-25 Thread Coelho, Luciano
On Wed, 2023-10-25 at 11:25 +0100, Tvrtko Ursulin wrote: > On 25/10/2023 11:18, Tvrtko Ursulin wrote: > > > > On 23/10/2023 11:33, Luca Coelho wrote: > > > The uncore code may not always be available (e.g. when we build the > > > display code with Xe), so we can't always rely on having the

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-10-25 Thread Tvrtko Ursulin
On 25/10/2023 11:18, Tvrtko Ursulin wrote: On 23/10/2023 11:33, Luca Coelho wrote: The uncore code may not always be available (e.g. when we build the display code with Xe), so we can't always rely on having the uncore's spinlock. To handle this, split the spin_lock/unlock_irqsave/restore()

Re: [Intel-gfx] [PATCH v3] drm/i915: handle uncore spinlock when not available

2023-10-25 Thread Tvrtko Ursulin
On 23/10/2023 11:33, Luca Coelho wrote: The uncore code may not always be available (e.g. when we build the display code with Xe), so we can't always rely on having the uncore's spinlock. To handle this, split the spin_lock/unlock_irqsave/restore() into spin_lock/unlock() followed by a call