Re: [Intel-gfx] [PATCH v3] igt/gem_trtt: Exercise the TRTT hardware

2016-03-03 Thread Goel, Akash
On 3/3/2016 9:16 PM, Chris Wilson wrote: On Thu, Mar 03, 2016 at 09:08:25PM +0530, Goel, Akash wrote: Before we destroy the context (or exit), how about a query_trtt(). We should also query after create to ensure that the defaults are set. Just thinking that is better doing the query after

Re: [Intel-gfx] [PATCH v3] igt/gem_trtt: Exercise the TRTT hardware

2016-03-03 Thread Chris Wilson
On Thu, Mar 03, 2016 at 09:08:25PM +0530, Goel, Akash wrote: > >Before we destroy the context (or exit), how about a query_trtt(). > >We should also query after create to ensure that the defaults are set. > >Just thinking that is better doing the query after several steps (i.e. > >the execbuf)

Re: [Intel-gfx] [PATCH v3] igt/gem_trtt: Exercise the TRTT hardware

2016-03-03 Thread Goel, Akash
Thanks for the review. On 3/3/2016 3:34 PM, Chris Wilson wrote: On Thu, Mar 03, 2016 at 10:25:59AM +0530, akash.g...@intel.com wrote: +static bool uses_full_ppgtt(int fd, int min) gem_gtt_type() fine will change like this, gem_gtt_type(fd) > 2 +static bool

Re: [Intel-gfx] [PATCH v3] igt/gem_trtt: Exercise the TRTT hardware

2016-03-03 Thread Chris Wilson
On Thu, Mar 03, 2016 at 10:25:59AM +0530, akash.g...@intel.com wrote: > +static bool uses_full_ppgtt(int fd, int min) gem_gtt_type() > +static bool has_softpin_support(int fd) gem_has_softpin() > +static int emit_store_dword(int fd, uint32_t *cmd_buf, uint32_t dw_offset, > +