Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-28 Thread Sagar Arun Kamble
On 2/28/2018 11:29 PM, Oscar Mateo wrote: On 2/26/2018 9:49 PM, Sagar Arun Kamble wrote: On 2/27/2018 4:34 AM, Oscar Mateo wrote: On 2/25/2018 9:22 PM, Sagar Arun Kamble wrote: On 2/23/2018 4:35 AM, Oscar Mateo wrote: + * We might have detected that some engines are fused off

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-28 Thread Oscar Mateo
On 2/26/2018 9:49 PM, Sagar Arun Kamble wrote: On 2/27/2018 4:34 AM, Oscar Mateo wrote: On 2/25/2018 9:22 PM, Sagar Arun Kamble wrote: On 2/23/2018 4:35 AM, Oscar Mateo wrote: + * We might have detected that some engines are fused off after we initialized + * the forcewake

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-26 Thread Sagar Arun Kamble
On 2/27/2018 4:34 AM, Oscar Mateo wrote: On 2/25/2018 9:22 PM, Sagar Arun Kamble wrote: On 2/23/2018 4:35 AM, Oscar Mateo wrote: + * We might have detected that some engines are fused off after we initialized + * the forcewake domains. Prune them, to make sure they only reference

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-26 Thread Oscar Mateo
On 2/25/2018 9:22 PM, Sagar Arun Kamble wrote: On 2/23/2018 4:35 AM, Oscar Mateo wrote: + * We might have detected that some engines are fused off after we initialized + * the forcewake domains. Prune them, to make sure they only reference existing + * engines. + */ +void

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-25 Thread Sagar Arun Kamble
On 2/23/2018 4:35 AM, Oscar Mateo wrote: + * We might have detected that some engines are fused off after we initialized + * the forcewake domains. Prune them, to make sure they only reference existing + * engines. + */ +void intel_uncore_prune(struct drm_i915_private *dev_priv) +{ +   

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-22 Thread kbuild test robot
Hi Oscar, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20180222] [cannot apply to v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-22 Thread kbuild test robot
Hi Oscar, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20180222] [cannot apply to v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-22 Thread Oscar Mateo
On 2/21/2018 10:17 PM, Sagar Arun Kamble wrote: Looks good to me. Few cosmetic changes suggested below. With those addressed: Reviewed-by: Sagar Arun Kamble On 2/22/2018 5:05 AM, Oscar Mateo wrote: In Gen11, the Video Decode engines (aka VDBOX, aka VCS, aka BSD)

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

2018-02-21 Thread Sagar Arun Kamble
Looks good to me. Few cosmetic changes suggested below. With those addressed: Reviewed-by: Sagar Arun Kamble On 2/22/2018 5:05 AM, Oscar Mateo wrote: In Gen11, the Video Decode engines (aka VDBOX, aka VCS, aka BSD) and the Video Enhancement engines (aka VEBOX, aka