Re: [Intel-gfx] [PATCH] drm/i915/vlv: Added/removed Render specific Hw Workarounds for VLV

2014-01-20 Thread Jani Nikula
On Sun, 19 Jan 2014, Goel, Akash akash.g...@intel.com wrote: Frankly, I don't know much about these particular workarounds, but for bisecting any regressions it would probably be a good idea to split the patch per workaround touched. Sorry for late response on this, actually we have done

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Added/removed Render specific Hw Workarounds for VLV

2014-01-20 Thread Goel, Akash
Really? WaReadAfterWriteHazard in intel_ring_flush_all_caches() and WaTlbInvalidateStoreDataBefore in intel_ring_invalidate_all_caches()? Sorry for this lapse, we have already identified this, will cover this change inside the VLV platform check. My opinion still stands. I think all

Re: [Intel-gfx] [PATCH] drm/gem: Always initialize the gem object in object_init

2014-01-20 Thread David Herrmann
Hi On Mon, Jan 20, 2014 at 8:21 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: At least drm/i915 expects that the obj-dev pointer is set even in failure paths. Specifically when the shmem initialization fails we call i915_gem_object_free which needs to deref obj-base.dev to get at the slab

Re: [Intel-gfx] [PATCH] drm/gem: Always initialize the gem object in object_init

2014-01-20 Thread Chris Wilson
On Mon, Jan 20, 2014 at 08:21:54AM +0100, Daniel Vetter wrote: At least drm/i915 expects that the obj-dev pointer is set even in failure paths. Specifically when the shmem initialization fails we call i915_gem_object_free which needs to deref obj-base.dev to get at the slab pointer in the

Re: [Intel-gfx] [PATCH] drm/i915: Wait for completion of pending flips when starved of fences

2014-01-20 Thread Chris Wilson
On Sun, Jan 19, 2014 at 10:55:26PM +0100, Daniel Vetter wrote: On Sun, Jan 19, 2014 at 10:20 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On older generations (gen2, gen3) the GPU requires fences for many operations, such as blits. The display hardware also requires fences for

[Intel-gfx] [PATCH 1/2] drm/i915: Wait for completion of pending flips when starved of fences

2014-01-20 Thread Chris Wilson
On older generations (gen2, gen3) the GPU requires fences for many operations, such as blits. The display hardware also requires fences for scanouts and this leads to a situation where an arbitrary number of fences may be pinned by old scanouts following a pageflip but before we have executed the

Re: [Intel-gfx] [PATCH] drm/i915: Wait for completion of pending flips when starved of fences

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 09:49:24AM +, Chris Wilson wrote: On Sun, Jan 19, 2014 at 10:55:26PM +0100, Daniel Vetter wrote: On Sun, Jan 19, 2014 at 10:20 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On older generations (gen2, gen3) the GPU requires fences for many operations,

Re: [Intel-gfx] [PATCH] drm/i915: Wait for completion of pending flips when starved of fences

2014-01-20 Thread Chris Wilson
On Mon, Jan 20, 2014 at 11:37:42AM +0100, Daniel Vetter wrote: On Mon, Jan 20, 2014 at 09:49:24AM +, Chris Wilson wrote: On Sun, Jan 19, 2014 at 10:55:26PM +0100, Daniel Vetter wrote: Also there's a certain chance we'll starve the unpin work, similar to the issues around flushing the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Kill dev_priv-irq_received

2014-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2014 at 11:18:53AM +, Chris Wilson wrote: On Fri, Jan 17, 2014 at 11:22:52AM +, Chris Wilson wrote: On Fri, Jan 17, 2014 at 11:35:16AM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Not sure anyone cares about

[Intel-gfx] [PATCH v4 0/3] VLV Turbo/rps + RC6 workaround

2014-01-20 Thread deepak . s
From: Deepak S deepa...@intel.com Below patches addes WA to set Gfx freq while clock are down. Also, added a WA to enables both RC6 and Turbo work together. Deepak S (3): drm/i915: Disable/Enable PM Intrrupts based on the current freq. drm/i915/vlv: WA to fix Voltage not getting dropped to

[Intel-gfx] [PATCH v3 2/3] drm/i915/vlv: WA to fix Voltage not getting dropped to Vmin when Gfx is power gated.

2014-01-20 Thread deepak . s
From: Deepak S deepa...@intel.com When we enter RC6 and GFX Clocks are off, the voltage remains higher than Vmin. When we try to set the freq to RPe, it might fail since the Gfx clocks are down. So to fix this in Gfx idle, Bring the GFX clock up and set the freq to RPe then move GFx down. v2:

[Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: WA for Turbo and RC6 to work together.

2014-01-20 Thread deepak . s
From: Deepak S deepa...@intel.com With RC6 enabled, BYT has an HW issue in determining the right Gfx busyness. WA for Turbo + RC6: Use SW based Gfx busy-ness detection to decide on increasing/decreasing the freq. This logic will monitor C0 counters of render/media power-wells over EI period and

[Intel-gfx] [PATCH v4 1/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq.

2014-01-20 Thread deepak . s
From: Deepak S deepa...@intel.com When current delay is already at max delay, Let's disable the PM UP THRESHOLD INTRRUPTS, so that we will not get further interrupts until current delay is less than max delay, Also request for the PM DOWN THRESHOLD INTRRUPTS to indicate the decrease in clock

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Kill dev_priv-irq_received

2014-01-20 Thread Chris Wilson
On Mon, Jan 20, 2014 at 01:26:55PM +0200, Ville Syrjälä wrote: On Mon, Jan 20, 2014 at 11:18:53AM +, Chris Wilson wrote: On Fri, Jan 17, 2014 at 11:22:52AM +, Chris Wilson wrote: On Fri, Jan 17, 2014 at 11:35:16AM +0200, ville.syrj...@linux.intel.com wrote: From: Ville

Re: [Intel-gfx] [PATCH v3] ACPI / video: Add systems that should favor native backlight interface

2014-01-20 Thread Matthew Garrett
On Mon, 2014-01-20 at 16:12 +0800, Aaron Lu wrote: 1 remove the win8 OSI check, I've seen win7 laptops that also needs to have only the GPU interface left and checking win8 doesn't make much sense now; Are we sure that those aren't simply some other bug? -- Matthew Garrett

[Intel-gfx] [PULL] drm vblank timestamping changes

2014-01-20 Thread Ville Syrjälä
Hi Dave, Here's the vblank timestamp pull request you wanted. I addressed the few bugs that Mario pointed out and added the r-bs. As it has been a while since I made the changes, I gave it a quick spin on a few different i915 machines. Fortunately everything still seems to be fine. The

Re: [Intel-gfx] [PATCH] tests: Move pm_rps to the right Makefile target

2014-01-20 Thread Jeff McGee
On Sun, Jan 19, 2014 at 02:49:19PM +0100, Daniel Vetter wrote: If it's not in the multi-test target group testrunners won't pick up on the fact that they need to enumerate subtests first. OK. I haven't yet tried piglit, so missed this detail. Thanks Jeff

Re: [Intel-gfx] [PATCH 3/6] drm/i915: reset eDP timestamps on resume

2014-01-20 Thread Paulo Zanoni
2014/1/17 Daniel Vetter dan...@ffwll.ch: On Fri, Jan 17, 2014 at 10:21 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, Jan 17, 2014 at 07:11:14PM -0200, Paulo Zanoni wrote: 2014/1/17 Chris Wilson ch...@chris-wilson.co.uk: On Fri, Jan 17, 2014 at 06:17:42PM -0200, Paulo Zanoni

[Intel-gfx] New DP vfuncs get_aux{clock_divider,send_ctl}

2014-01-20 Thread Damien Lespiau
A tiny bit of refactoring to make the code more pluggable: 1/ separate the get_aux_clock_divider() into multiple functions. I Tested this patch on IVB and HSW, the simpler to review that patch is to not look at the diff but the before/after version and follow the different code path for

[Intel-gfx] [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order

2014-01-20 Thread Damien Lespiau
So it's easier to compare what we program with the documentation, not having to jump at all. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 1/4] drm/i915: Turn get_aux_clock_divider() into per-product vfuncs

2014-01-20 Thread Damien Lespiau
A tiny clean-up to allow better code separation between platforms. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 79 drivers/gpu/drm/i915/intel_drv.h | 2 + 2 files changed, 58 insertions(+), 23

[Intel-gfx] [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send

2014-01-20 Thread Damien Lespiau
Also, move that computation outside of the for loop that tries 5 times, this value doesn't change between tries. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 59 ++--- 1 file changed, 37 insertions(+), 22

Re: [Intel-gfx] [PATCH 3/6] drm/i915: reset eDP timestamps on resume

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 01:47:51PM -0200, Paulo Zanoni wrote: 2014/1/17 Daniel Vetter dan...@ffwll.ch: On Fri, Jan 17, 2014 at 10:21 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, Jan 17, 2014 at 07:11:14PM -0200, Paulo Zanoni wrote: 2014/1/17 Chris Wilson

Re: [Intel-gfx] [PATCH 6/6] drm/i915: set the backlight panel delays registers to 1

2014-01-20 Thread Daniel Vetter
On Fri, Jan 17, 2014 at 02:57:42PM +0100, Daniel Vetter wrote: On Thu, Dec 19, 2013 at 09:39:12AM -0800, Jesse Barnes wrote: On Thu, 19 Dec 2013 14:29:44 -0200 Paulo Zanoni przan...@gmail.com wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Because we already do the wait in

Re: [Intel-gfx] [PATCH] drm/i915: Shuffle modeset reset handling around

2014-01-20 Thread Daniel Vetter
On Fri, Jan 17, 2014 at 06:14:50PM -0200, Paulo Zanoni wrote: 2014/1/16 Daniel Vetter daniel.vet...@ffwll.ch: Currently we're doing the reset handling a bit late, and we're doing it both in the driver load code and on resume. This makes it unusable for e.g. resetting the panel power

Re: [Intel-gfx] [PATCH] tests: Move pm_rps to the right Makefile target

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 09:06:40AM -0600, Jeff McGee wrote: On Sun, Jan 19, 2014 at 02:49:19PM +0100, Daniel Vetter wrote: If it's not in the multi-test target group testrunners won't pick up on the fact that they need to enumerate subtests first. OK. I haven't yet tried piglit, so

Re: [Intel-gfx] [PATCH] drm/i915: Wait for completion of pending flips when starved of fences

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 10:44:27AM +, Chris Wilson wrote: On Mon, Jan 20, 2014 at 11:37:42AM +0100, Daniel Vetter wrote: On Mon, Jan 20, 2014 at 09:49:24AM +, Chris Wilson wrote: On Sun, Jan 19, 2014 at 10:55:26PM +0100, Daniel Vetter wrote: Also there's a certain chance we'll

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Daniel Vetter
On Fri, Jan 17, 2014 at 08:09:04PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Add a mechanism by which we can evade the leading edge of vblank. This guarantees that no two sprite register writes will straddle on either side of the vblank

Re: [Intel-gfx] [PATCH 1/3] drm/i915: get basic encoder state before reading CRTC state

2014-01-20 Thread Jesse Barnes
On Sat, 18 Jan 2014 16:01:06 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Jan 17, 2014 at 01:16:56PM -0800, Jesse Barnes wrote: In DDI configs, we need to get the encoder to CRTC mapping early on so we can read out and calculate the clock state correctly, as it depends

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2014 at 05:23:39PM +0100, Daniel Vetter wrote: On Fri, Jan 17, 2014 at 08:09:04PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Add a mechanism by which we can evade the leading edge of vblank. This guarantees that no two

Re: [Intel-gfx] [PATCH] drm/edid: Populate picture aspect ratio for CEA modes

2014-01-20 Thread Ville Syrjälä
On Mon, Dec 23, 2013 at 11:27:40AM +0530, Vandana Kannan wrote: Adding picture aspect ratio for CEA modes based on CEA-861D Table 3 or CEA-861E Table 4. This is useful for filling up the detail in AVI infoframe. v2: Ville's inputs incorporated. Added picture aspect ratio as part of

[Intel-gfx] [PATCH v3] drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable devices

2014-01-20 Thread Todd Previte
More whitepsace cleanup. One caveat with this patch: current link policy dictates that the driver will train the wide and slow, i.e. max lanes at low speed. It will increase lanes and speed when the specified resolution demands greater bandwidth. Consequently, the resolution

[Intel-gfx] [PATCH v3] drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable devices

2014-01-20 Thread Todd Previte
For HSW+ platforms, enable the 5.4Ghz (HBR2) link rate for devices that support it. The sink device must report that is supports Displayport 1.2 and the HBR2 bit rate in the DPCD in order to use HBR2. Signed-off-by: Todd Previte tprev...@gmail.com --- drivers/gpu/drm/i915/intel_dp.c | 31

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 5:56 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: +{ + struct drm_device *dev = crtc-dev; + struct intel_crtc *intel_crtc = to_intel_crtc(crtc); + const struct drm_display_mode *mode = intel_crtc-config.adjusted_mode; + enum pipe pipe =

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2014 at 06:43:42PM +0100, Daniel Vetter wrote: On Mon, Jan 20, 2014 at 5:56 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: +{ + struct drm_device *dev = crtc-dev; + struct intel_crtc *intel_crtc = to_intel_crtc(crtc); + const struct drm_display_mode

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 7:38 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: We have the same problem already w/ underrun interrupts at least, no? Yeah, but iirc we've hand-waved over the issue with hopefully the bios wm setup never underruns while we take over. If it does we're screwed

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Wait for completion of pending flips when starved of fences

2014-01-20 Thread Chris Wilson
On Mon, Jan 20, 2014 at 10:17:36AM +, Chris Wilson wrote: On older generations (gen2, gen3) the GPU requires fences for many operations, such as blits. The display hardware also requires fences for scanouts and this leads to a situation where an arbitrary number of fences may be pinned by

[Intel-gfx] [PATCH 2/2] drm/i915: always check clocks when comparing pipe configs

2014-01-20 Thread Jesse Barnes
Now that we have DDI support, we can check these all the time. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 1/2] drm/i915: clock readout support for DDI v2

2014-01-20 Thread Jesse Barnes
Read out and calculate the port and pixel clocks on DDI configs as well. This means we have to grab the DP divider values and look at the port mapping to figure out which clock select reg to read out. v2: do the work from ddi_get_config (Ville) Signed-off-by: Jesse Barnes

[Intel-gfx] [PATCH] xf86-video-intel build fix for OpenBSD

2014-01-20 Thread Mark Kettenis
Commit 50a45a1cdd4d8319ba9358974d241069689591c5 introduced the use of struct stat but doesn't include sys/stat.h. Presumably that leaks in trough some other header on Linux, but on OpenBSD compilation fails because the struct isn't known. diff --git a/src/sna/kgem.c b/src/sna/kgem.c index

Re: [Intel-gfx] [PATCH] xf86-video-intel build fix for OpenBSD

2014-01-20 Thread Chris Wilson
On Mon, Jan 20, 2014 at 11:24:53PM +0100, Mark Kettenis wrote: Commit 50a45a1cdd4d8319ba9358974d241069689591c5 introduced the use of struct stat but doesn't include sys/stat.h. Presumably that leaks in trough some other header on Linux, but on OpenBSD compilation fails because the struct

[Intel-gfx] [PATCH 1/2] drm: expose subpixel order name routine

2014-01-20 Thread Jesse Barnes
Just like we have for connector type etc. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 20 include/drm/drm_crtc.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c

[Intel-gfx] [PATCH 2/2] drm/i915: add a display info file to debugfs

2014-01-20 Thread Jesse Barnes
Can be expanded up on to include all sorts of things (HDMI infoframe data, more DP status, etc). Should be useful for bug reports to get a baseline on the display config and info. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_debugfs.c | 155

[Intel-gfx] [PATCH v4] ACPI: Fix acpi_evaluate_object() return value check

2014-01-20 Thread Yijing Wang
Since acpi_evaluate_object() returns acpi_status and not plain int, ACPI_FAILURE() should be used for checking its return value. Reviewed-by: Jani Nikula jani.nik...@intel.com Signed-off-by: Yijing Wang wangyij...@huawei.com --- v3-v4: Fix spell error, add Jani Nikula reviewed-by. v2-v3: Fix

Re: [Intel-gfx] [PATCH v3] ACPI / video: Add systems that should favor native backlight interface

2014-01-20 Thread Matthew Garrett
On Tue, 2014-01-21 at 10:24 +0800, Aaron Lu wrote: On 01/20/2014 09:34 PM, Matthew Garrett wrote: On Mon, 2014-01-20 at 16:12 +0800, Aaron Lu wrote: 1 remove the win8 OSI check, I've seen win7 laptops that also needs to have only the GPU interface left and checking win8 doesn't make

Re: [Intel-gfx] [PATCH v3] ACPI / video: Add systems that should favor native backlight interface

2014-01-20 Thread Aaron Lu
On 01/21/2014 11:17 AM, Matthew Garrett wrote: On Tue, 2014-01-21 at 10:24 +0800, Aaron Lu wrote: On 01/20/2014 09:34 PM, Matthew Garrett wrote: On Mon, 2014-01-20 at 16:12 +0800, Aaron Lu wrote: 1 remove the win8 OSI check, I've seen win7 laptops that also needs to have only the GPU