[Intel-gfx] [PATCH v2] drm/atomic: Handle vblank events in atomic ioctl correctly.

2015-06-02 Thread Maarten Lankhorst
All users of async updates seem to clear clear crtc_state-event correctly, so move destroying vblank event to crtc_destroy_state. This is better than manually free'ing it in the atomic ioctl, since this code seems to do it wrong. While we're at it handle -EDEADLK from atomic_commit correctly,

Re: [Intel-gfx] [PATCH v2] drm/i915/vlv: fix RC6 residency time calculation

2015-06-02 Thread Imre Deak
On ma, 2015-06-01 at 12:01 -0700, Rodrigo Vivi wrote: On Mon, Jun 1, 2015 at 12:32 AM, Imre Deak imre.d...@intel.com wrote: The divider value to convert from CZ clock rate to ms needs a +1 adjustment on VLV just like on CHV. This matches both the spec and the accuracy test by

Re: [Intel-gfx] [PATCH] drm/i915: Don't check modeset state in the hw state force restore path

2015-06-02 Thread Maarten Lankhorst
Op 02-06-15 om 09:12 schreef Jani Nikula: On Mon, 01 Jun 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: Since the force restore logic will restore the CRTCs state one at a time, it is possible that the state will be inconsistent until the whole operation

[Intel-gfx] [PATCH v5 5/8] drm/i915: Don't enable IPS when pixel rate exceeds 95%

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns. There's no similar restriction listed for HSW, so leave that one alone for now. v2: Add

[Intel-gfx] [PATCH v5 4/8] drm/i915: Store max cdclk value in dev_priv

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com Keep the cdclk maximum supported frequency around in dev_priv so that we can verify certain things against it before actually changing the cdclk frequency. For now only VLV/CHV have support changing cdclk frequency, so other plarforms get to

[Intel-gfx] [PATCH v5 6/8] drm/i915: Add IS_BDW_ULX

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com We need to tell BDW ULT and ULX apart. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com v2: Rebased to the latest v3: Rebased to the latest Signed-off-by: Mika Kahola mika.kah...@intel.com Author:Ville Syrjälä

[Intel-gfx] [PATCH v5 7/8] drm/i915: BDW clock change support

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com Add support for changing cdclk frequency during runtime on BDW. The procedure is quite a bit different on BDW from the one on HSW, so add a separate function for it. Also with IPS enabled the actual pixel rate mustn't exceed 95% of cdclk, so take

[Intel-gfx] [PATCH v5 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com ilk_get_aux_clock_divider() is now a subset of hsw_get_aux_clock_divider() so unify them. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com v2: Rebased to the latest v3: Rebased to the latest Signed-off-by: Mika Kahola

[Intel-gfx] [PATCH v5 1/8] drm/i915: Cache current cdclk frequency in dev_priv

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com Rather that extracting the current cdclk freuqncy every time someone wants to know it, cache the current value and use that. VLV/CHV already stored a cached value there so just expand that to cover all platforms. Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH v5 8/8] drm/i915: HSW cdclk support

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com Implement support for changing the cdclk frequency during runtime on HSW. VLV/CHV already have support for this, so we can follow their example for the most part. Only the actual hardware programming differs, the rest is pretty much the same. The

[Intel-gfx] [PATCH v5 2/8] drm/i915: Use cached cdclk value

2015-06-02 Thread Mika Kahola
From: Ville Syrjälä ville.syrj...@linux.intel.com Rather than reading out the current cdclk value use the cached value we have tucked away in dev_priv. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com v2: Rebased to the latest v3: Rebased to the latest Signed-off-by: Mika Kahola

[Intel-gfx] [PATCH v5 0/8] All sort of cdclk stuff

2015-06-02 Thread Mika Kahola
This patch series rebases Ville's original cdclk patch series excluding the ones that has already been reviewed. http://lists.freedesktop.org/archives/intel-gfx/2014-November/055633.html The patches are rebased to the latest drm-intel-nightly. The major change to the original series is the patch

Re: [Intel-gfx] [PATCH 00/24] Convert to atomic, part 3.

2015-06-02 Thread Maarten Lankhorst
Op 01-06-15 om 15:27 schreef Maarten Lankhorst: This patch series requires the following prerequisites: [PATCH v4 00/27] Convert to atomic, part 2 [PATCH] drm/atomic: Clear crtc_state-active in drm_atomic_helper_set_config. Now that suspend/restore is atomic it's time to clean up some

Re: [Intel-gfx] [PATCH v4 19/27] drm/i915: Read hw state into an atomic state struct, v2.

2015-06-02 Thread Maarten Lankhorst
Op 01-06-15 om 23:47 schreef Matt Roper: On Mon, Jun 01, 2015 at 12:50:03PM +0200, Maarten Lankhorst wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com To make this work we load the new hardware state into the atomic_state, then swap it with the sw state. This

[Intel-gfx] [PATCH v3] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread Jani Nikula
Passive DP-DVI/HDMI dongles on DP++ ports show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK the first attempt even though the transaction is valid and they support the DDC

Re: [Intel-gfx] [PATCH] drm/i915: Don't check modeset state in the hw state force restore path

2015-06-02 Thread Ander Conselvan De Oliveira
On Tue, 2015-06-02 at 09:27 +0200, Maarten Lankhorst wrote: Op 02-06-15 om 09:12 schreef Jani Nikula: On Mon, 01 Jun 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: Since the force restore logic will restore the CRTCs state one at a time, it is possible

Re: [Intel-gfx] [PATCH 05/21] drm/i915/gtt: Don't leak scratch page on mapping error

2015-06-02 Thread Joonas Lahtinen
On pe, 2015-05-22 at 20:04 +0300, Mika Kuoppala wrote: Free the scratch page if dma mapping fails. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com Reviewed-by: Joonas Lahtinen joonas.lahti...@linux.intel.com --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +++- 1 file changed, 3

Re: [Intel-gfx] [PATCH] drm/i915/skl: changed the filename of csr firmware

2015-06-02 Thread Timo Aaltonen
On 27.05.2015 14:34, Daniel Vetter wrote: On Tue, May 26, 2015 at 05:21:56PM -0700, Rodrigo Vivi wrote: On Thu, May 21, 2015 at 5:04 AM, Animesh Manna animesh.ma...@intel.com wrote: Naming convention of csr firmware will be - platform_dmc_api-version_minor-version.bin Accordingly updated

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix command parser to validate multiple register access with the same command.

2015-06-02 Thread Zhigang Gong
The patchset LGTM and works well with beignet. The 80%+ performance regression issue in darktable also has been fixed after this patchset applied and enable the atomic in L3 at beignet side. So, Reviewed-by: Zhigang Gong zhigang.g...@linux.intel.com Thanks, Zhigang Gong. -Original

Re: [Intel-gfx] [PATCH] drm/i915: Don't check modeset state in the hw state force restore path

2015-06-02 Thread Jani Nikula
On Mon, 01 Jun 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: Since the force restore logic will restore the CRTCs state one at a time, it is possible that the state will be inconsistent until the whole operation finishes. A call to intel_modeset_check_state()

Re: [Intel-gfx] [PATCH 03/55] drm/i915: i915_add_request must not fail

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com The i915_add_request() function is called to keep track of work that has been written to the ring buffer. It adds epilogue commands to track progress (seqno updates and such), moves the request

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915: Enable default_phase in GCP when possible

2015-06-02 Thread Konduru, Chandra
@@ -560,6 +560,49 @@ static bool hdmi_sink_is_deep_color(struct drm_encoder *encoder) return false; } +/* + * Determine if default_phase=1 can be indicated in the GCP infoframe. + * + * From HDMI specification 1.4a: + * - The first pixel of each Video Data Period

Re: [Intel-gfx] [PATCH v2 1/7] drm/i915/gen8: Add infrastructure to initialize WA batch buffers

2015-06-02 Thread Siluvery, Arun
On 01/06/2015 11:22, Daniel, Thomas wrote: Indeed, allocating an extra scratch page in the context would simplify vma/mm management. A trick might be to allocate the scratch page at the start, then offset the lrc regs etc - that would then be consistent amongst gen and be easy enough to extend

Re: [Intel-gfx] [PATCH 18/55] drm/i915: Add explicit request management to i915_gem_init_hw()

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com Now that a single per ring loop is being done for all the different intialisation steps in i915_gem_init_hw(), it is possible to add proper request management as well. The last remaining issue is

Re: [Intel-gfx] [PATCH 54/55] drm/i915: Remove the now obsolete 'i915_gem_check_olr()'

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:44, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com As there is no OLR to check, the check_olr() function is now a no-op and can be removed. For: VIZ-5115 Signed-off-by: John Harrison john.c.harri...@intel.com ---

Re: [Intel-gfx] [PATCH 02/55] drm/i915: Reserve ring buffer space for i915_add_request() commands

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com It is a bad idea for i915_add_request() to fail. The work will already have been send to the ring and will be processed, but there will not be any tracking or management of that work. The only

Re: [Intel-gfx] [PATCH 22/55] drm/i915: Update deferred context creation to do explicit request management

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com In execlist mode, context initialisation is deferred until first use of the given context. This is because execlist mode has per ring context state and thus many more context storage objects than

Re: [Intel-gfx] [PATCH 25/55] drm/i915: Update i915_gem_object_sync() to take a request structure

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com The plan is to pass requests around as the basic submission tracking structure rather than rings and contexts. This patch updates the i915_gem_object_sync() code path. v2: Much more complex

Re: [Intel-gfx] [PATCH v2 1/7] drm/i915/gen8: Add infrastructure to initialize WA batch buffers

2015-06-02 Thread Dave Gordon
On 02/06/15 19:36, Siluvery, Arun wrote: On 01/06/2015 11:22, Daniel, Thomas wrote: Indeed, allocating an extra scratch page in the context would simplify vma/mm management. A trick might be to allocate the scratch page at the start, then offset the lrc regs etc - that would then be

[Intel-gfx] [PATCH] drm/i915: Initialize HWS page address after GPU reset

2015-06-02 Thread Arun Siluvery
After GPU reset, HW is losing the address of HWS page in the register. The page itself is valid except that HW is not aware of its location. [ 64.368623] [drm:gen8_init_common_ring [i915]] *ERROR* HWS Page address = 0x [ 64.368655] [drm:gen8_init_common_ring [i915]] *ERROR* HWS Page

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: Disable all infoframes when turning off the HDMI port

2015-06-02 Thread Konduru, Chandra
-Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Tuesday, June 02, 2015 4:11 AM To: Konduru, Chandra Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: Disable all infoframes when turning off the HDMI port On

Re: [Intel-gfx] [PATCH 13/55] drm/i915: Add flag to i915_add_request() to skip the cache flush

2015-06-02 Thread Tomas Elf
On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com In order to explcitly track all GPU work (and completely remove the outstanding lazy request), it is necessary to add extra i915_add_request() calls to various places. Some of these do not need

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Send GCP infoframes for deep color HDMI sinks

2015-06-02 Thread Konduru, Chandra
@@ -541,6 +541,66 @@ static void g4x_set_infoframes(struct drm_encoder *encoder, intel_hdmi_set_hdmi_infoframe(encoder, adjusted_mode); } +static bool hdmi_sink_is_deep_color(struct drm_encoder *encoder) { Some static functions are prefixed but this isn't. Can you add prefix?

Re: [Intel-gfx] [PATCH] perf/x86/intel/pt: Fix lockdep interaction

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6523 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH v5] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6525 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Apply WaDisableAsyncFlipPerfMode via LRIs on gen8

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6524 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

[Intel-gfx] [PATCH] drm/i915/skl: Implement WaBarrierPerformanceFixDisable (again)

2015-06-02 Thread Ben Widawsky
in commit 65ca7514e21adbee25b8175fc909759c735d00ff Author: Damien Lespiau damien.lesp...@intel.com Date: Mon Feb 9 19:33:22 2015 + drm/i915/skl: Implement WaBarrierPerformanceFixDisable The workaround ended up in the chv workarounds. Not sure what the reason or history of that is, but

Re: [Intel-gfx] [PATCH 03/24] drm/i915: clean up intel_sanitize_crtc

2015-06-02 Thread Matt Roper
On Mon, Jun 01, 2015 at 03:27:06PM +0200, Maarten Lankhorst wrote: Apply force if needed. It's not clear to me what this means; can you elaborate? It seems that 'force' in the context of intel_crtc_control() means we're updating the 'enable' field as well, not just the 'active' field. During

Re: [Intel-gfx] [PATCH 07/24] drm/i915: Add a simple atomic crtc check function.

2015-06-02 Thread Matt Roper
On Mon, Jun 01, 2015 at 03:27:10PM +0200, Maarten Lankhorst wrote: Move the check for encoder cloning here. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com --- drivers/gpu/drm/i915/intel_atomic.c | 5 +- drivers/gpu/drm/i915/intel_display.c | 131

Re: [Intel-gfx] [PATCH 04/24] drm/i915: Update power domains only on affected crtc's.

2015-06-02 Thread Matt Roper
On Mon, Jun 01, 2015 at 03:27:07PM +0200, Maarten Lankhorst wrote: Use for_each_crtc_state to only touch affected crtc's. In order to make sure that the initial power is still set correctly we make sure modeset_update_crtc_power_domains is called during the initial modeset. Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Initialize HWS page address after GPU reset

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6526 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 08/24] drm/i915: Do not add planes from intel_atomic_setup_scalers.

2015-06-02 Thread Konduru, Chandra
-Original Message- From: Roper, Matthew D Sent: Tuesday, June 02, 2015 6:30 PM To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org; Konduru, Chandra Subject: Re: [Intel-gfx] [PATCH 08/24] drm/i915: Do not add planes from intel_atomic_setup_scalers. On Mon, Jun 01, 2015 at

Re: [Intel-gfx] [PATCH] drm/i915/bxt: edp1.4 Intermediate Freq support

2015-06-02 Thread Jindal, Sonika
Hi Vandana, Can you please review the v6 of this patch? This was rebased recently on top of your patch: commit b6dc71f38a84e36c5445b95f9f7a2dac6b25636f Author: Vandana Kannan vandana.kan...@intel.com Date: Wed May 13 12:18:52 2015 +0530 drm/i915/bxt: Port PLL programming BUN

Re: [Intel-gfx] [PATCH] drm/i915/skl: Implement WaBarrierPerformanceFixDisable (again)

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6527 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread Ville Syrjälä
On Tue, Jun 02, 2015 at 11:29:23AM +0300, Jani Nikula wrote: Passive DP-DVI/HDMI dongles on DP++ ports show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK the first

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Initialize Color Manager

2015-06-02 Thread Jindal, Sonika
On 6/2/2015 1:22 AM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com Color Manager is an extension in i915 driver to handle color correction and enhancements across various Intel platforms. This patch initializes color manager framework by : 1. Adding two new files,

Re: [Intel-gfx] [PATCH] perf/x86/intel/pt: Fix lockdep interaction

2015-06-02 Thread Tvrtko Ursulin
Oops, didn't mean to send this here since it is not graphics related. But it does happen on SKL so maybe it will be useful for someone. Tvrtko On 06/02/2015 12:37 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Since this drivers creates attributes on the heap,

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-02 Thread Daniel Stone
Hi, On 2 June 2015 at 12:38, Jindal, Sonika sonika.jin...@intel.com wrote: On 6/2/2015 1:22 AM, Kausal Malladi wrote: +int drm_mode_crtc_update_color_property(struct drm_device *dev, + struct drm_property_blob **blob, + size_t length, const void *color_data, +

Re: [Intel-gfx] [PATCH 07/21] drm/i915/gtt: Introduce i915_page_dir_dma_addr

2015-06-02 Thread Michel Thierry
On 5/22/2015 6:05 PM, Mika Kuoppala wrote: The legacy mode mm switch and the execlist context assignment needs dma address for the page directories. Introduce a function that encapsulates the scratch_pd dma fallback if no pd is found. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com

Re: [Intel-gfx] [PATCH v5 0/8] All sort of cdclk stuff

2015-06-02 Thread Damien Lespiau
On Tue, Jun 02, 2015 at 10:20:58AM +0300, Mika Kahola wrote: This patch series rebases Ville's original cdclk patch series excluding the ones that has already been reviewed. FYI, When a patch that has been reviewed is resent, we usually but the r-b tags tags along (yes, I know, confusing

[Intel-gfx] Warning: Broadwell/i915: Unclaimed register detected before reading register 0x130040

2015-06-02 Thread Dominik Brodowski
Hey, this just popped up in the dmesg of my Dell XPS 13 -- the system seems to run well, but still, it asks about being cut and sent, so here it is. It is on 4.1.0-rc4+ (Linus' tree as of May 24th, around 3pm UTC -- don't have the git commit ID anymore). [ cut here ]

[Intel-gfx] EDID problem

2015-06-02 Thread Engin Firat
Hello, I want to use custom EDID for one of my monitors. This because the monitor has a broken EDID structure. I have been trying to use a custom EDID (a binary message was saved before) within Xorg.conf. Is this possible? I have installed the drivers by using : Intel(R) Graphics Installer for

Re: [Intel-gfx] [PATCH 06/21] drm/i915/gtt: Remove _single from page table allocator

2015-06-02 Thread Joonas Lahtinen
On pe, 2015-05-22 at 20:04 +0300, Mika Kuoppala wrote: We are always allocating a single page. No need to be verbose so remove the suffix. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com Reviewed-by: Joonas Lahtinen joonas.lahti...@linux.intel.com ---

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: Disable all infoframes when turning off the HDMI port

2015-06-02 Thread Ville Syrjälä
On Mon, Jun 01, 2015 at 10:48:03PM +, Konduru, Chandra wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of ville.syrj...@linux.intel.com Sent: Tuesday, May 05, 2015 7:06 AM To: intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Add Set property interface for CRTC

2015-06-02 Thread Jindal, Sonika
On 6/2/2015 1:22 AM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds set property interface for Intel CRTC. This interface will be used to set color correction DRM properties. Signed-off-by: Shashank Sharma shashank.sha...@intel.com Signed-off-by: Kausal

[Intel-gfx] [PATCH] drm/i915: Include G4X/VLV/CHV in self refresh status

2015-06-02 Thread Ander Conselvan de Oliveira
Add all missing platforms handled by intel_set_memory_cxsr() to the i915_sr_status debugfs entry. v2: Add G4X too. (Ville) Clarify the change also affects CHV. (Ander) References: https://bugs.freedesktop.org/show_bug.cgi?id=89792 Signed-off-by: Ander Conselvan de Oliveira

Re: [Intel-gfx] [PATCH 4/7] drm: Add Gamma correction structure

2015-06-02 Thread Jindal, Sonika
On 6/2/2015 1:22 AM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch adds a new structure in DRM layer for Gamma color correction. This structure will be used by all user space agents to configure appropriate Gamma precision and Gamma level. struct

[Intel-gfx] intel_check_page_flip() - WARN_ON(!in_interrupt())

2015-06-02 Thread Shuah Khan
I am seeing the following in the dmesg on 4.0.4 with rt patch [5.720319] [ cut here ] [5.720347] WARNING: CPU: 6 PID: 466 at drivers/gpu/drm/i915/intel_display.c:9748 intel_check_page_flip+0xaa/0xf0 [i915]() [5.720349] WARN_ON(!in_interrupt()) [5.720350]

Re: [Intel-gfx] [PATCH 06/21] drm/i915/gtt: Remove _single from page table allocator

2015-06-02 Thread Michel Thierry
On 5/22/2015 6:04 PM, Mika Kuoppala wrote: We are always allocating a single page. No need to be verbose so remove the suffix. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com I saw another of your patches will take care of i915_dma_map_single/i915_dma_unmap_single... Reviewed-by: Michel

[Intel-gfx] [PATCH v4] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread Jani Nikula
Passive DP-DVI/HDMI dongles on DP++ ports show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK the first attempt even though the transaction is valid and they support the DDC

Re: [Intel-gfx] [PATCH v5 8/8] drm/i915: HSW cdclk support

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6518 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix command parser to validate multiple register access with the same command.

2015-06-02 Thread Francisco Jerez
Zhigang Gong zhigang.g...@linux.intel.com writes: The patchset LGTM and works well with beignet. The 80%+ performance regression issue in darktable also has been fixed after this patchset applied and enable the atomic in L3 at beignet side. So, Reviewed-by: Zhigang Gong

Re: [Intel-gfx] [PATCH] drm/i915: Include G4X/VLV/CHV in self refresh status

2015-06-02 Thread Ville Syrjälä
On Tue, Jun 02, 2015 at 02:17:47PM +0300, Ander Conselvan de Oliveira wrote: Add all missing platforms handled by intel_set_memory_cxsr() to the i915_sr_status debugfs entry. v2: Add G4X too. (Ville) Clarify the change also affects CHV. (Ander) References:

Re: [Intel-gfx] [PATCH 0/7] Color Manager Implementation

2015-06-02 Thread Damien Lespiau
On Tue, Jun 02, 2015 at 01:22:42AM +0530, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch set adds color manager implementation in drm/i915 layer. Is anyone working on tests/test plan? Thanks, -- Damien ___

Re: [Intel-gfx] [PATCH 4/7] drm: Add Gamma correction structure

2015-06-02 Thread Daniel Stone
Hi, On 2 June 2015 at 12:25, Jindal, Sonika sonika.jin...@intel.com wrote: On 6/2/2015 1:22 AM, Kausal Malladi wrote: struct drm_intel_gamma { __u32 flags; (The flag variable will indicate if the property to be set/get is Gamma or DeGamma) __u32 gamma_level;

Re: [Intel-gfx] [PATCH 0/7] Color Manager Implementation

2015-06-02 Thread Sharma, Shashank
Hi Damien, Yes we are getting the IGT's ready, and already we have a test tool to apply CSC/Gamma already, which we used for ULT. As discussed in the parallel forums, we will finally use Chrome UI to test the end-to-end UI level effects Regards Shashank -Original Message- From:

Re: [Intel-gfx] [PATCH 11/21] drm/i915/gtt: Introduce fill_page_dma()

2015-06-02 Thread Michel Thierry
On 5/22/2015 6:05 PM, Mika Kuoppala wrote: When we setup page directories and tables, we point the entries to a to the next level scratch structure. Make this generic by introducing a fill_page_dma which maps and flushes. We also need 32 bit variant for legacy gens. v2: Fix flushes and handle

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-02 Thread Jindal, Sonika
On 6/2/2015 1:22 AM, Kausal Malladi wrote: From: Kausal Malladi kausal.mall...@intel.com This patch does the following: 1. Adds the core function to program Gamma correction values for CHV/BSW platform 2. Adds Gamma correction macros/defines 3. Adds drm_mode_crtc_update_color_property

[Intel-gfx] [PATCH] perf/x86/intel/pt: Fix lockdep interaction

2015-06-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Since this drivers creates attributes on the heap, lockdep gets upset and disabled itself. Fix by setting ignore_lockdep flags for problematic attributes. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Alexander Shishkin

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915: Enable default_phase in GCP when possible

2015-06-02 Thread Ville Syrjälä
On Mon, Jun 01, 2015 at 09:49:53PM +, Konduru, Chandra wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of ville.syrj...@linux.intel.com Sent: Tuesday, May 05, 2015 7:06 AM To: intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915: Include G4X/VLV/CHV in self refresh status

2015-06-02 Thread Jani Nikula
On Tue, 02 Jun 2015, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jun 02, 2015 at 02:17:47PM +0300, Ander Conselvan de Oliveira wrote: Add all missing platforms handled by intel_set_memory_cxsr() to the i915_sr_status debugfs entry. v2: Add G4X too. (Ville) Clarify the

Re: [Intel-gfx] [PATCH 10/21] drm/i915/gtt: Remove superfluous free_pd with gen6/7

2015-06-02 Thread Michel Thierry
On 5/22/2015 6:05 PM, Mika Kuoppala wrote: This has slipped in somewhere but it was harmless as we check the page pointer before teardown. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com Right, free_pd is only for gen8+. Reviewed-by: Michel Thierry michel.thie...@intel.com ---

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Send GCP infoframes for deep color HDMI sinks

2015-06-02 Thread Ville Syrjälä
On Mon, Jun 01, 2015 at 09:49:40PM +, Konduru, Chandra wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of ville.syrj...@linux.intel.com Sent: Tuesday, May 05, 2015 7:06 AM To: intel-gfx@lists.freedesktop.org

[Intel-gfx] [PATCH 3/3] drm/i915: Apply WaDisableAsyncFlipPerfMode via LRIs on gen8

2015-06-02 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com MI_MODE is saved in the logical context so WaDisableAsyncFlipPerfMode must be applied using LRIs on gen8. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 10 -- 1 file changed, 8

[Intel-gfx] [PATCH 1/3] drm/i915: Move WaBarrierPerformanceFixDisable:skl to skl code from chv code

2015-06-02 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com commit 65ca7514e21adbee25b8175fc909759c735d00ff Author: Damien Lespiau damien.lesp...@intel.com Date: Mon Feb 9 19:33:22 2015 + drm/i915/skl: Implement WaBarrierPerformanceFixDisable got misapplied and the code landed in

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gtt: Introduce struct i915_page_dma

2015-06-02 Thread Michel Thierry
On 5/22/2015 6:05 PM, Mika Kuoppala wrote: All our paging structures have struct page and dma address for that page. Add struct for page/dma address pairs and use it to make the setup and teardown for different paging structures identical. Include the page directory offset also in the struct

Re: [Intel-gfx] [PATCH i-g-t] gem_userptr_benchmark: Test overlapping bo mmu notifier performance impact

2015-06-02 Thread Chris Wilson
On Mon, Jun 01, 2015 at 11:11:15AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Current userptr kernel implementation downgrades tracking VMA ranges (real userspace ones) to an inefficient linear walk for any process which has instantiated overlapping userptr

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move WaBarrierPerformanceFixDisable:skl to skl code from chv code

2015-06-02 Thread Damien Lespiau
On Tue, Jun 02, 2015 at 03:37:35PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com commit 65ca7514e21adbee25b8175fc909759c735d00ff Author: Damien Lespiau damien.lesp...@intel.com Date: Mon Feb 9 19:33:22 2015 + drm/i915/skl:

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gtt: Rename unmap_and_free_px to free_px

2015-06-02 Thread Michel Thierry
On 5/22/2015 6:05 PM, Mika Kuoppala wrote: All the paging structures are now similar and mapped for dma. The unmapping is taken care of by common accessors, so don't overload the reader with such details. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com ---

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6519 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH v4] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread Ville Syrjälä
On Tue, Jun 02, 2015 at 01:42:52PM +0300, Jani Nikula wrote: Passive DP-DVI/HDMI dongles on DP++ ports show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK the first

Re: [Intel-gfx] [PATCH 11/21] drm/i915/gtt: Introduce fill_page_dma()

2015-06-02 Thread Ville Syrjälä
On Tue, Jun 02, 2015 at 03:51:26PM +0100, Michel Thierry wrote: On 5/22/2015 6:05 PM, Mika Kuoppala wrote: When we setup page directories and tables, we point the entries to a to the next level scratch structure. Make this generic by introducing a fill_page_dma which maps and flushes. We

Re: [Intel-gfx] [PATCH v4] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6520 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH v5 1/8] drm/i915: Cache current cdclk frequency in dev_priv

2015-06-02 Thread Jani Nikula
On Tue, 02 Jun 2015, Mika Kahola mika.kah...@intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Rather that extracting the current cdclk freuqncy every time someone wants to know it, cache the current value and use that. VLV/CHV already stored a cached value there so just

[Intel-gfx] [PATCH v5] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread Jani Nikula
Passive DP-DVI/HDMI dongles on DP++ ports show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK the first attempt even though the transaction is valid and they support the DDC

Re: [Intel-gfx] [PATCH v5] drm/i915: Fix DDC probe for passive adapters

2015-06-02 Thread Jani Nikula
On Tue, 02 Jun 2015, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jun 02, 2015 at 07:21:15PM +0300, Jani Nikula wrote: Passive DP-DVI/HDMI dongles on DP++ ports show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When

Re: [Intel-gfx] [PATCH] drm/i915: Include G4X/VLV/CHV in self refresh status

2015-06-02 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6522 -Summary- Platform Delta drm-intel-nightly Series Applied PNV