Re: [Intel-gfx] [PATCH 4/5] drm/i915: Support for pread/pwrite from/to non shmem backed objects

On Wed, Sep 23, 2015 at 04:21:22PM +0530, ankitprasad.r.sha...@intel.com wrote: > From: Ankitprasad Sharma > > This patch adds support for extending the pread/pwrite functionality > for objects not backed by shmem. The access will be made through > gtt interface.

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

On Thu, Sep 17, 2015 at 12:42:44PM +0100, Thomas Wood wrote: > Add a script to take a piglit results file and create a list of tests > that ran in under 60 seconds. This list can be used by the --test-list > option of piglit. > > v2: exclude incomplete tests > > Signed-off-by: Thomas Wood

Re: [Intel-gfx] [PATCH] drm/i915: Don't leak VBT mode data

On Wed, Sep 23, 2015 at 02:02:03PM +0300, Jani Nikula wrote: > On Wed, 23 Sep 2015, Daniel Vetter wrote: > > On Tue, Sep 15, 2015 at 10:50:45AM +0300, Jani Nikula wrote: > >> On Tue, 15 Sep 2015, Matt Roper wrote: > >> > We allocate memory for LVDS

Re: [Intel-gfx] [RFC PATCH] drm/i915: Consider SPLL as another shared pll.

Op 23-09-15 om 14:42 schreef Daniel Vetter: > On Wed, Sep 16, 2015 at 09:23:59AM +0200, Maarten Lankhorst wrote: >> When diagnosing a unrelated bug for someone on irc, it would seem the >> hardware can >> be brought up by the BIOS with the embedded displayport using the SPLL for >> spread

Re: [Intel-gfx] [PATCH 3/7] drm/i915: s/mode/adjusted_mode/ in functions that really get passed the adjusted_mode

On Wed, Sep 23, 2015 at 02:12:18PM +0300, Mika Kahola wrote: > On Tue, 2015-09-08 at 13:40 +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Rename the function argument to 'adjusted_mode' whenever the function > > only ever gets passed

Re: [Intel-gfx] [PATCH i-g-t v2] scripts: add quick-testlist.py

On Thu, Sep 17, 2015 at 04:47:06PM +0100, Thomas Wood wrote: > On 17 September 2015 at 13:43, Chris Wilson wrote: > > On Thu, Sep 17, 2015 at 01:16:18PM +0100, Thomas Wood wrote: > >> On 17 September 2015 at 13:09, Chris Wilson > >> wrote: >

Re: [Intel-gfx] [RFC PATCH] drm/i915: Consider SPLL as another shared pll.

On Wed, Sep 16, 2015 at 09:23:59AM +0200, Maarten Lankhorst wrote: > When diagnosing a unrelated bug for someone on irc, it would seem the > hardware can > be brought up by the BIOS with the embedded displayport using the SPLL for > spread spectrum. > > Right now this is not handled well in

Re: [Intel-gfx] [PATCH 09/23] drm/i915: Register pipe color capabilities

On Wed, Sep 23, 2015 at 02:05:25PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 9/22/2015 6:54 PM, Daniel Vetter wrote: > >On Wed, Sep 16, 2015 at 11:07:06PM +0530, Shashank Sharma wrote: > >>DRM color manager contains these color properties: > >> > >>1.

Re: [Intel-gfx] regression/bug introduced by commit [0e572fe7383a376992364914694c39aa7fe44c1d] drm/i915: runtime PM support for DPMS

Another one for Jairo. -Daniel On Thu, Sep 17, 2015 at 03:19:44PM +0200, Frank de Jong wrote: > Hello, > > A regression/bug was introduced by commit > [0e572fe7383a376992364914694c39aa7fe44c1d] drm/i915: runtime PM support for > DPMS. > It causes my linux box to emit PATA and NIC errors (PCI bus

Re: [Intel-gfx] [regression] Re: Linux 4.3-rc1

On 09/23/2015 02:56 AM, Daniel Vetter wrote: > Another regression for Jairo to track. > -Daniel Saw the same problem in 4.3-rc2 as well. Not a one time deal and easily reproducible. thanks, -- Shuah > > On Tue, Sep 15, 2015 at 03:26:13AM +0200, Sedat Dilek wrote: >> Hi, >> >> I have reported

Re: [Intel-gfx] [PATCH] drm/i915: Don't leak VBT mode data

On Wed, 23 Sep 2015, Daniel Vetter wrote: > On Tue, Sep 15, 2015 at 10:50:45AM +0300, Jani Nikula wrote: >> On Tue, 15 Sep 2015, Matt Roper wrote: >> > We allocate memory for LVDS modes while parsing the VBT at startup, but >> > never free this memory

Re: [Intel-gfx] [regression] [git pull] drm for 4.3

Hey, Dave Jones schreef op di 22-09-2015 om 21:49 [-0400]: > On Tue, Sep 22, 2015 at 09:15:58AM -0700, Matt Roper wrote: > > On Tue, Sep 22, 2015 at 05:13:55PM +0200, Daniel Vetter wrote: > > > On Tue, Sep 22, 2015 at 08:00:17AM -0700, Jesse Barnes wrote: > > > > Cc'ing Maarten and Matt; I'm

[Intel-gfx] [PATCH 3/5] drm/i915: Make wait_for_flips interruptible.

Move it from intel_crtc_atomic_commit to prepare_plane_fb. Waiting is done before committing, otherwise it's too late to undo the changes. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 2 - drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 0/5] drm/i915: Interruptible framebuffer pinning.

With the changes to drm/core to preserve framebuffers there is no more barrier for allowing pin to fail with -ERESTARTSYS. Modesetting while the gpu died should still be allowed, so any -EIO during pin stage will be eaten. Some display related waits that were previously uninterruptible can now

[Intel-gfx] [PATCH 5/5] drm/i915: Wait for object idle without locks in atomic_commit.

Make pinning and waiting a separate step, and wait for object idle without struct_mutex held. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 2 - drivers/gpu/drm/i915/i915_gem.c | 6 ---

[Intel-gfx] [PATCH 1/5] drm/i915: Make plane fb tracking work correctly, v2.

atomic->disabled_planes is a hack that had to exist because prepare_fb was only called when a new fb was set. This messed up fb tracking in some circumstances like aborts from interruptible waits. As a result interruptible waiting in prepare_plane_fb was forbidden, but other errors could still

[Intel-gfx] [PATCH 2/5] drm/i915: Make prepare_plane_fb fully interruptible.

Now that we agreed on not preserving framebuffers pinning is finally allowed to fail because of signals. Use this to make pinning and acquire the mutex in an interruptible way too. Unpinning is still uninterruptible, because it happens as a cleanup of old state, or undoing pins after one of the

[Intel-gfx] [PATCH 4/5] drm/i915: Change locking for struct_mutex.

Only acquire the struct_mutex once, and interruptibly. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value

On ke, 2015-09-23 at 09:37 +0530, Jindal, Sonika wrote: > > On 9/23/2015 1:02 AM, Imre Deak wrote: > > On Wed, 2015-09-23 at 00:01 +0530, Sivakumar Thulasimani wrote: > >> > >> On 9/22/2015 6:32 PM, Imre Deak wrote: > >>> On ma, 2015-09-21 at 23:00 +0530, Sivakumar Thulasimani wrote: >

[Intel-gfx] [PATCH] libdrm: Use userspace compatible type in fourcc_mod_code macro

From: Tvrtko Ursulin __u64 should be used instead of u64. Kernel headers originally pulled in: commit 8983fe5497e89a3ffaba3ad1ee06a30a1c7e6daf Author: Tvrtko Ursulin Date: Mon Aug 3 10:48:03 2015 +0100 libdrm: Add framebuffer

Re: [Intel-gfx] [PATCH 04/23] drm: Add drm structures for palette color property

On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 9/22/2015 6:38 PM, Daniel Vetter wrote: > >On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote: > >>From: Kausal Malladi > >> > >>This patch adds new structures in

[Intel-gfx] [PATCH 2/5] drm/i915/skl: Refuse to load outdated dmc firmware

There is known issue on GT interrupt delivery with DC6 and firmwares <1.21. There is a suspicion that this causes spurious gpu hangs on driver init and with some workloads, as upgrading the firmware to 1.21 makes these problems disappear. As of now the current version included in distribution

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Fix fb object's frontbuffer-bits

On Wed, Sep 23, 2015 at 03:07:21PM +0530, Kamble, Sagar A wrote: > > > On 9/23/2015 1:51 PM, Daniel Vetter wrote: > >On Wed, Sep 16, 2015 at 12:46:24PM -0300, Paulo Zanoni wrote: > >>2015-09-14 14:16 GMT-03:00 Daniel Vetter : > >>>On Mon, Sep 14, 2015 at 09:35:42PM +0530, Sagar

Re: [Intel-gfx] [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset

On Tue, 01 Sep 2015, Uma Shankar wrote: > @@ -5057,13 +5060,16 @@ static void haswell_crtc_enable(struct drm_crtc *crtc) > if (intel_crtc->config->has_pch_encoder) > lpt_pch_enable(crtc); > > - if (intel_crtc->config->dp_encoder_is_mst) > + if

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

On Wed, Sep 23, 2015 at 10:43:00AM +0200, Daniel Vetter wrote: > On Mon, Sep 21, 2015 at 10:00:45AM +0200, Patrik Jakobsson wrote: > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > > > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > > > We need to be able

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add support for stealing purgable stolen pages

On Wed, Sep 23, 2015 at 10:30:51AM +0100, Tvrtko Ursulin wrote: > > On 09/23/2015 10:28 AM, Daniel Vetter wrote: > >On Wed, Sep 16, 2015 at 02:31:38PM +0530, Ankitprasad Sharma wrote: > >>On Tue, 2015-09-15 at 16:14 +0100, Tvrtko Ursulin wrote: > >>>On 09/15/2015 09:33 AM,

Re: [Intel-gfx] [PATCH 02/23] drm: Add structure for querying palette color capabilities

On Wed, Sep 23, 2015 at 11:57:58AM +, Sharma, Shashank wrote: > This would be an interface/design change, to change from one blob of > correction property, to split into multiple query properties for > palette_before_blob and palette_after_blob. Please let me know if this > is really required

Re: [Intel-gfx] [PATCH] drm/i915: Add primary plane to mask if it's visible

On Wed, 23 Sep 2015, Daniel Vetter wrote: > On Tue, Sep 15, 2015 at 02:28:54PM +0200, Maarten Lankhorst wrote: >> This fixes the warnings like >> >> "plane A assertion failure, should be disabled but not" >> >> that on the initial modeset during boot. This can happen if >> the

[Intel-gfx] [PATCH v7 0/5] Support for creating/using Stolen memory backed objects

From: Ankitprasad Sharma This patch series adds support for creating/using Stolen memory backed objects. Despite being a unified memory architecture (UMA) some bits of memory are more equal than others. In particular we have the thorny issue of stolen memory,

Re: [Intel-gfx] [PATCH] drm/i915: Add primary plane to mask if it's visible

Hey, Op 23-09-15 om 12:29 schreef Jani Nikula: > On Wed, 23 Sep 2015, Daniel Vetter wrote: >> On Tue, Sep 15, 2015 at 02:28:54PM +0200, Maarten Lankhorst wrote: >>> This fixes the warnings like >>> >>> "plane A assertion failure, should be disabled but not" >>> >>> that on the

[Intel-gfx] [PATCH 3/5] drm/i915: Add support for stealing purgable stolen pages

From: Chris Wilson If we run out of stolen memory when trying to allocate an object, see if we can reap enough purgeable objects to free up enough contiguous free space for the allocation. This is in principle very much like evicting objects to free up enough contiguous space in the vma when

[Intel-gfx] [PATCH 5/5] drm/i915: Propagating correct error codes to the userspace

From: Ankitprasad Sharma Propagating correct error codes to userspace by using ERR_PTR and PTR_ERR macros for stolen memory based object allocation. We generally return -ENOMEM to the user whenever there is a failure in object allocation. This patch helps user to

[Intel-gfx] [PATCH 4/5] drm/i915: Support for pread/pwrite from/to non shmem backed objects

From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover prime objects as well as stolen memory backed objects but for userptr

[Intel-gfx] [PATCH 1/5] drm/i915: Clearing buffer objects via CPU/GTT

From: Ankitprasad Sharma This patch adds support for clearing buffer objects via CPU/GTT. This is particularly useful for clearing out the non shmem backed objects. Currently intend to use this only for buffers allocated from stolen region. v2: Added kernel doc

[Intel-gfx] [PATCH 2/5] drm/i915: Support for creating Stolen memory backed objects

From: Ankitprasad Sharma Extend the drm_i915_gem_create structure to add support for creating Stolen memory backed objects. Added a new flag through which user can specify the preference to allocate the object from stolen memory, which if set, an attempt will be

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only check pipe state for fast modeset when it's possible.

Op 16-09-15 om 20:48 schreef Jesse Barnes: > On 09/14/2015 02:30 AM, Maarten Lankhorst wrote: >> +if (!crtc_state->connectors_changed && >> +!crtc_state->active_changed && >> +crtc_state->active && >> +

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add support for stealing purgable stolen pages

On Wed, Sep 23, 2015 at 04:21:21PM +0530, ankitprasad.r.sha...@intel.com wrote: > From: Chris Wilson > > If we run out of stolen memory when trying to allocate an object, see if > we can reap enough purgeable objects to free up enough contiguous free > space for the allocation. This is in

Re: [Intel-gfx] [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset

On Wed, 23 Sep 2015, Daniel Vetter wrote: > On Mon, Sep 21, 2015 at 10:41:58AM +, Shankar, Uma wrote: >> >> >> >-Original Message- >> >From: Nikula, Jani >> >Sent: Friday, September 18, 2015 7:48 PM >> >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >> >Cc:

Re: [Intel-gfx] [PATCH 04/23] drm: Add drm structures for palette color property

On Wed, Sep 23, 2015 at 06:29:31PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 9/23/2015 6:19 PM, Daniel Vetter wrote: > >On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote: > >>Regards > >>Shashank > >> > >>On 9/22/2015 6:38 PM, Daniel Vetter wrote: > >>>On Wed, Sep

Re: [Intel-gfx] [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset

On Wed, Sep 23, 2015 at 03:43:35PM +0300, Jani Nikula wrote: > On Wed, 23 Sep 2015, Daniel Vetter wrote: > > On Mon, Sep 21, 2015 at 10:41:58AM +, Shankar, Uma wrote: > >> > >> > >> >-Original Message- > >> >From: Nikula, Jani > >> >Sent: Friday, September 18, 2015

Re: [Intel-gfx] [PATCH] drm/i915: eDP HPD connected check to reduce T3 time

On Tue, Sep 22, 2015 at 02:34:02PM -0700, Clint Taylor wrote: > On 09/22/2015 10:27 AM, Ville Syrjälä wrote: > > On Tue, Sep 22, 2015 at 10:09:39AM -0700, clinton.a.tay...@intel.com wrote: > >> From: Clint Taylor > >> > >> To reduce eDP T3 time check for digital port

Re: [Intel-gfx] [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro

On Wed, Sep 23, 2015 at 10:10:31AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __u64 should be used instead of u64. > > Feature originally added in: > > commit e3eb3250d84ef97b766312345774367b6a310db8 > Author: Rob Clark > Date: Thu

Re: [Intel-gfx] [PATCH 02/23] drm: Add structure for querying palette color capabilities

This would be an interface/design change, to change from one blob of correction property, to split into multiple query properties for palette_before_blob and palette_after_blob. Please let me know if this is really required ? Regards Shashank -Original Message- From: Smith, Gary K

Re: [Intel-gfx] [PATCH] drm/i915: Add primary plane to mask if it's visible

On Wed, 23 Sep 2015, Maarten Lankhorst wrote: > Hey, > > Op 23-09-15 om 12:29 schreef Jani Nikula: >> On Wed, 23 Sep 2015, Daniel Vetter wrote: >>> On Tue, Sep 15, 2015 at 02:28:54PM +0200, Maarten Lankhorst wrote: This fixes the warnings

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form.

On Thu, Sep 17, 2015 at 05:17:24PM +, Winiarski, Michal wrote: > On śro, 2015-09-16 at 11:50 +0200, Michał Winiarski wrote: > > According to bspec, some parts of HW expect the addresses to be in > > a canonical form where bits [63:48] == [47]. > > If we're using 32b addressing, we never need

[Intel-gfx] [PATCH i-g-t v2] gem_ppgtt: Test VMA leak on context destruction

From: Tvrtko Ursulin Test that VMAs associated with a context are cleaned up when contexts are destroyed. In practice this emulates the leak seen between fbcon and X server. Every time the X server exits we gain one VMA on the fbcon frame buffer object as externally

Re: [Intel-gfx] [PATCH 3/7] drm/i915: s/mode/adjusted_mode/ in functions that really get passed the adjusted_mode

On Tue, 2015-09-08 at 13:40 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Rename the function argument to 'adjusted_mode' whenever the function > only ever gets passed the adjusted_mode. > What was the reason why we need to rename the

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Propagating correct error codes to the userspace

On Wed, Sep 23, 2015 at 04:21:23PM +0530, ankitprasad.r.sha...@intel.com wrote: > From: Ankitprasad Sharma > > Propagating correct error codes to userspace by using ERR_PTR and > PTR_ERR macros for stolen memory based object allocation. We generally > return

Re: [Intel-gfx] [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction

Hi, On 09/18/2015 12:17 PM, Thomas Wood wrote: On 11 September 2015 at 15:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Test that VMAs associated with a context are cleaned up when contexts are destroyed. In practice this emulates

Re: [Intel-gfx] [PATCH 04/23] drm: Add drm structures for palette color property

Regards Shashank On 9/23/2015 6:19 PM, Daniel Vetter wrote: On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote: Regards Shashank On 9/22/2015 6:38 PM, Daniel Vetter wrote: On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote: From: Kausal Malladi

Re: [Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

On Wed, Sep 23, 2015 at 01:52:21PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 9/22/2015 6:45 PM, Daniel Vetter wrote: > >On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote: > >>I915 driver registers gamma correction as palette correction > >>property with DRM layer.

[Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

Propagate the real error from drm_gem_object_init(). Note this also fixes some confusion in the error return from i915_gem_alloc_object... Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 12 +++- drivers/gpu/drm/i915/i915_gem_context.c

Re: [Intel-gfx] [PATCH] drm/i915/bios: handle MIPI Sequence Block v3+ gracefully

On Thu, Sep 17, 2015 at 04:42:07PM +0300, Jani Nikula wrote: > The VBT MIPI Sequence Block version 3 has forward incompatible changes: > > First, the block size in the header has been specified reserved, and the > actual size is a separate 32-bit value within the block. The current >

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW context corruption due to coherency problem

On Fri, Sep 18, 2015 at 10:02:24AM +0100, Chris Wilson wrote: > On Thu, Sep 17, 2015 at 07:17:44PM +0300, Imre Deak wrote: > > The execlist context object is mapped with a CPU/GPU coherent mapping > > everywhere, but on BXT A stepping due to a HW issue the coherency is not > > guaranteed. To work

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/CTS in modeset

Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, September 23, 2015 4:41 PM > To: Jani Nikula > Cc: Yang, Libin; alsa-de...@alsa-project.org; intel- > g...@lists.freedesktop.org; daniel.vet...@ffwll.ch; > ville.syrj...@linux.intel.com >

[Intel-gfx] [PATCH 3/4] drm/i915: Only run commit when crtc is active, v2.

The crtc->active guards are no longer needed now that all state updates are outside the commit. Changes since v1: - Only check crtc->state->active before calling commit_planes_on_crtc. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Update legacy primary state outside the commit hook.

Op 14-09-15 om 16:26 schreef Daniel Vetter: > On Mon, Sep 14, 2015 at 03:16:20PM +0200, Maarten Lankhorst wrote: >> Op 14-09-15 om 15:13 schreef Daniel Vetter: >>> On Mon, Sep 14, 2015 at 11:52:26AM +0200, Maarten Lankhorst wrote: Op 10-09-15 om 17:41 schreef Daniel Vetter: > On Thu, Sep

[Intel-gfx] [PATCH 2/2] drm/i915: Call non-locking version of drm_kms_helper_poll_enable(), v2

drm_kms_helper_poll_enable() is called from a context in intel_hpd_irq_storm_disable() where the the mode_config mutex is already locked. When this function was converted to lock this mutex in commit 8c4ccc4ab6f6 ("drm/probe-helper: Grab mode_config.mutex in poll_init/enable") a deadlock occurred.

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW context corruption due to coherency problem

On Wed, Sep 23, 2015 at 02:39:13PM +0100, Chris Wilson wrote: > On Wed, Sep 23, 2015 at 03:35:59PM +0200, Daniel Vetter wrote: > > On Fri, Sep 18, 2015 at 10:02:24AM +0100, Chris Wilson wrote: > > > On Thu, Sep 17, 2015 at 07:17:44PM +0300, Imre Deak wrote: > > > > The execlist context object is

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ignore "digital output" and "not HDMI output" bits for eDP detection

On Wed, Sep 23, 2015 at 05:08:15PM +0300, Jani Nikula wrote: > On Fri, 11 Sep 2015, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Ignore DEVICE_TYPE_NOT_HDMI_OUTPUT and DEVICE_TYPE_DIGITAL_OUTPUT when > > trying to determine the presence of

Re: [Intel-gfx] [PATCH 10/43] drm/i915: Parametrize CSR_PROGRAM registers

On Wed, Sep 23, 2015 at 05:15:55PM +0300, Mika Kuoppala wrote: > ville.syrj...@linux.intel.com writes: > > > From: Ville Syrjälä > > > > Signed-off-by: Ville Syrjälä > > Reviewed-by: Mika Kuoppala Merged

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Support NV12 in rotated GGTT mapping

On Mon, Sep 21, 2015 at 02:14:47PM +0300, Joonas Lahtinen wrote: > On ma, 2015-09-21 at 10:45 +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Just adding the rotated UV plane at the end of the rotated Y plane. > > > > v2: Rebase. > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Clean up intel_plane->plane usage

On Fri, Sep 18, 2015 at 11:48:30AM +0300, Ville Syrjälä wrote: > On Thu, Sep 17, 2015 at 06:55:21PM -0700, Matt Roper wrote: > > intel_plane->plane has inconsistent meanings across the driver: > > * For primary planes, intel_plane->plane is usually the pipe number > >(except for old platforms

Re: [Intel-gfx] [PATCH] drm/i915/bios: handle MIPI Sequence Block v3+ gracefully

Reviewed-by: Deepak M >-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel >Vetter >Sent: Wednesday, September 23, 2015 7:02 PM >To: Nikula, Jani >Cc: intel-gfx@lists.freedesktop.org; Deepak, M >Subject: Re: [Intel-gfx] [PATCH]

[Intel-gfx] [PATCH 1/2] drm: Add a non-locking version of drm_kms_helper_poll_enable(), v2

drm_kms_helper_poll_enable() was converted to lock the mode_config mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f ("drm/probe-helper: Grab mode_config.mutex in poll_init/enable"). This disregarded the cases where this function is called from a context where this mutex is already locked.

Re: [Intel-gfx] [PATCH 10/43] drm/i915: Parametrize CSR_PROGRAM registers

ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_csr.c | 7 +++ > 1 file changed, 3

Re: [Intel-gfx] [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset

>-Original Message- >From: Nikula, Jani >Sent: Wednesday, September 23, 2015 6:24 PM >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >Cc: Kumar, Shobhit; Deak, Imre; Sharma, Shashank; Shankar, Uma >Subject: Re: [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in >CRTC

Re: [Intel-gfx] [PATCH] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt, v2

On Wed, Sep 23, 2015 at 04:15:27PM +0200, Egbert Eich wrote: > An HPD interrupt may fire while we are in a function that changes > the PORT_HOTPLUG_EN register - especially when an HPD interrupt > storm occurs. > Since the interrupt handler changes the enabled HPD lines when it > detects such a

Re: [Intel-gfx] [PATCH] drm/i915: Do not hardcode s_max, ss_max and eu_mask for BXT

On Fri, Sep 18, 2015 at 05:37:48PM +0100, Arun Siluvery wrote: > On 17/09/2015 19:26, Dongwon Kim wrote: > >We can calculate BXT values correctly from GFX fuse values without > >hardcoding special limits. > > > >Cc: Imre Deak > >Cc: Matthew D Roper

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure we don't detect eDP on g4x

On Fri, 11 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We don't support eDP on g4x, so let's not even look at the VBT > to determine the port type, just in case the VBT is bonkers > on some g4x machines and indicates the precense of eDP.

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW context corruption due to coherency problem

On Wed, Sep 23, 2015 at 04:57:48PM +0300, Imre Deak wrote: > On ke, 2015-09-23 at 14:39 +0100, Chris Wilson wrote: > > On Wed, Sep 23, 2015 at 03:35:59PM +0200, Daniel Vetter wrote: > > > On Fri, Sep 18, 2015 at 10:02:24AM +0100, Chris Wilson wrote: > > > > On Thu, Sep 17, 2015 at 07:17:44PM

Re: [Intel-gfx] [PATCH v6 0/4] Support for creating/using Stolen memory backed objects

On Tue, Sep 15, 2015 at 02:03:23PM +0530, ankitprasad.r.sha...@intel.com wrote: > From: Ankitprasad Sharma > > This patch series adds support for creating/using Stolen memory backed > objects. Note that we still need something like

[Intel-gfx] [PATCH] drm/i915: Consider HW CSB write pointer before resetting the sw read pointer

A previous commit resets the Context Status Buffer (CSB) read pointer in ring init commit c0a03a2e4c4e ("drm/i915: Reset CSB read pointer in ring init") This is generally correct, but this pointer is not reset after suspend/resume in some platforms (cht). In this case, the driver should read

Re: [Intel-gfx] [PATCH] drm/i915: Remove extraneous request cancel.

On Mon, Sep 21, 2015 at 02:31:59PM +0100, Tvrtko Ursulin wrote: > > On 09/21/2015 02:02 PM, Nick Hoath wrote: > >Remove extraneous request cancel in request allocation failure path > >in intel_lr_context_deferred_alloc (Tvrtko Ursulin) > > > >Signed-off-by: Nick Hoath >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only check pipe state for fast modeset when it's possible.

Op 14-09-15 om 19:10 schreef Daniel Stone: > Hi, > > On 14 September 2015 at 10:30, Maarten Lankhorst > wrote: >> @@ -13013,14 +13013,15 @@ static int intel_atomic_check(struct drm_device >> *dev, >> if (ret) >> return

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ignore "digital output" and "not HDMI output" bits for eDP detection

On Fri, 11 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Ignore DEVICE_TYPE_NOT_HDMI_OUTPUT and DEVICE_TYPE_DIGITAL_OUTPUT when > trying to determine the presence of eDP based on the VBT child device > type. Apparently a significant

[Intel-gfx] [PATCH 2/2] drm/i915: Fix primary_get_hw_state for gen9+.

On skylake and broxton the old registers are no longer in use. Instead it uses universal planes, fix primary_get_hw to use the correct registers. Signed-off-by: Maarten Lankhorst Cc: sta...@vger.kernel.org #v4.2+ --- drivers/gpu/drm/i915/intel_display.c | 5

[Intel-gfx] [PATCH 1/2] drm/i915: Add primary plane to mask if it's visible

This fixes the warnings like "plane A assertion failure, should be disabled but not" that on the initial modeset during boot. This can happen if the primary plane is enabled by the firmware, but inheriting it fails because the DMAR is active or for other reasons. Most likely caused by commit

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW context corruption due to coherency problem

On Wed, Sep 23, 2015 at 03:35:59PM +0200, Daniel Vetter wrote: > On Fri, Sep 18, 2015 at 10:02:24AM +0100, Chris Wilson wrote: > > On Thu, Sep 17, 2015 at 07:17:44PM +0300, Imre Deak wrote: > > > The execlist context object is mapped with a CPU/GPU coherent mapping > > > everywhere, but on BXT A

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW context corruption due to coherency problem

On ke, 2015-09-23 at 14:39 +0100, Chris Wilson wrote: > On Wed, Sep 23, 2015 at 03:35:59PM +0200, Daniel Vetter wrote: > > On Fri, Sep 18, 2015 at 10:02:24AM +0100, Chris Wilson wrote: > > > On Thu, Sep 17, 2015 at 07:17:44PM +0300, Imre Deak wrote: > > > > The execlist context object is mapped

[Intel-gfx] [PATCH] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt, v2

An HPD interrupt may fire while we are in a function that changes the PORT_HOTPLUG_EN register - especially when an HPD interrupt storm occurs. Since the interrupt handler changes the enabled HPD lines when it detects such a storm the read-modify-write cycles may interfere. To avoid this, shiled

[Intel-gfx] [PATCH 4/4] drm/i915: Only call commit_planes when there are things to commit.

The atomic helpers set planes_changed on a crtc_state if there is any plane_state bound to that crtc. If there's none and there is no pipe update required the crtc has nothing to update, so vblank evasion can be skipped. Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW context corruption due to coherency problem

On Wed, Sep 23, 2015 at 03:58:37PM +0200, Daniel Vetter wrote: > On Wed, Sep 23, 2015 at 02:39:13PM +0100, Chris Wilson wrote: > > On Wed, Sep 23, 2015 at 03:35:59PM +0200, Daniel Vetter wrote: > > > On Fri, Sep 18, 2015 at 10:02:24AM +0100, Chris Wilson wrote: > > > > On Thu, Sep 17, 2015 at

Re: [Intel-gfx] [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset

>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Wednesday, September 23, 2015 6:42 PM >To: Nikula, Jani >Cc: Daniel Vetter; Shankar, Uma; intel-gfx@lists.freedesktop.org; Kumar, >Shobhit >Subject: Re: [Intel-gfx] [BXT MIPI PATCH

Re: [Intel-gfx] [PATCH 1/2] drm: Add a non-locking version of drm_kms_helper_poll_enable(), v2

On Wed, Sep 23, 2015 at 04:13:00PM +0200, Egbert Eich wrote: > drm_kms_helper_poll_enable() was converted to lock the mode_config > mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f > ("drm/probe-helper: Grab mode_config.mutex in poll_init/enable"). > > This disregarded the cases where

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Update revision id for BXT C0

On Mon, Sep 21, 2015 at 03:21:48PM +0300, Imre Deak wrote: > On pe, 2015-09-18 at 17:52 +0100, Arun Siluvery wrote: > > Cc: Nick Hoath > > Cc: Imre Deak > > Signed-off-by: Arun Siluvery > > Reviewed-by: Imre Deak

[Intel-gfx] [PATCH 0/4] Remainder of 'Nuke legacy state' patch series.

Some patches from that series didn't get applied, so resending it here with some fixes. First patch moves legacy primary state updates outside of the commit hook, which leaves only stuff related to plane hw updates inside it. Patch 2 is a fixup required for patch 3, and patch 4 is a minor

[Intel-gfx] [PATCH 1/4] drm/i915: Update legacy primary state outside the commit hook, v2.

This should allow not running plane commit when the crtc is off. While the atomic helpers update those, crtc->x/y is only updated during modesets, and primary plane is updated after this function returns. Unfortunately non-atomic watermarks and fbc still depend on this state inside i915, so it

[Intel-gfx] [PATCH 2/4] drm/i915: Only commit active planes when updating planes during reset.

In the next commit commit_plane will no longer check if the crtc is active. To prevent issues with legacy page flips the check should be performed inside update_primary_planes. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 3 +--

[Intel-gfx] [PATCH] drm/i915: Reset dpll_hw_state when selecting a new pll on hsw

Using 2 connectors (DVI and VGA) will cause wrpll to be set for INTEL_OUTPUT_HDMI but never reset if switching to INTEL_OUTPUT_VGA Supresses errors like these: [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in dpll_hw_state.wrpll Signed-off-by: Gabriel Feceoru

Re: [Intel-gfx] [PATCH 5/7] drm/i915: fix FBC buffer size checks

On Wed, Sep 23, 2015 at 12:52:25PM -0300, Paulo Zanoni wrote: > According to my experiments, the maximum sizes mentioned in the > specification delimit how far in the buffer the hardware tracking can > go. And the hardware seems to calculate the size based on the plane > address and x/y offsets we

Re: [Intel-gfx] [PATCH v7 0/5] Support for creating/using Stolen memory backed objects

On Wed, Sep 23, 2015 at 05:19:04PM +0100, Chris Wilson wrote: > On Wed, Sep 23, 2015 at 05:14:25PM +0100, Chris Wilson wrote: > > As far as users go, I'm dubious as to the merits of using stolen (and so > > have not written patches for the ddx/mesa) simply because we do not have > > CPU access to

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 1/5] drm/i915/skl: Added a check for the hardware status of csr fw before loading.

acpi_target_system_state() seems to be almost the thing we're looking for, except that it's only valid in the suspend callbacks since it gets reset to ACPI_STATE_S0 when resuming. So probably we want something else ... -Daniel On Wed, Sep 23, 2015 at 6:28 PM, Daniel Vetter

[Intel-gfx] [BXT MIPI PATCH v4 11/14] drm/i915/bxt: Modify BXT BLC according to VBT changes

From: Sunil Kamath Latest VBT mentions which set of registers will be used for BLC, as controller number field. Making use of this field in BXT BLC implementation. Also, the registers are used in case control pin indicates display DDI. Adding a check for this. According

[Intel-gfx] [PATCH 3/7] drm/i915: don't allocate fbcon from stolen memory if it's too big

Technology has evolved and now we have eDP panels with 3200x1800 resolution. In the meantime, the BIOS guys didn't change the default 32mb for stolen memory. On top of that, we can't assume our users will be able to increase the default stolen memory size to more than 32mb - I'm not even sure all

[Intel-gfx] [PATCH 7/7] drm/i915: extract fbc_supported()

Make it clear that we're checking whether FBC is supported or not. The fact that the vfunc is not NULL is just a consequence. Another name option would have been fbc_initialized(). Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_fbc.c | 17 +++--

Re: [Intel-gfx] [PATCH] drm/i915: Do not update pipe state when crtc is inactive.

On Wed, Sep 23, 2015 at 01:33:29PM +0300, Jani Nikula wrote: > On Wed, 23 Sep 2015, Maarten Lankhorst > wrote: > > Op 23-09-15 om 11:01 schreef Jani Nikula: > >> On Tue, 22 Sep 2015, Maarten Lankhorst > >> wrote: > >>>

Re: [Intel-gfx] [PATCH] drm/i915: Stop calling intel_prepare_ddi during power well initialization.

On Tue, Sep 22, 2015 at 08:03:59AM -0700, Rodrigo Vivi wrote: > The comment removed along with the calls explains why they shouldn't be here: > > /* DDI buffer programming unnecessary during driver-load/resume > * as it's already done during modeset initialization then. > * It's also invalid

[Intel-gfx] [PATCH i-g-t] lib: add igt_debugfs_search

Add igt_debugfs_search to search each line in a debugfs file for a specified substring. Signed-off-by: Thomas Wood --- lib/igt_debugfs.c | 31 +++ lib/igt_debugfs.h | 1 + tests/gem_ppgtt.c | 35

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't allocate fbcon from stolen memory if it's too big

On Wed, Sep 23, 2015 at 12:52:23PM -0300, Paulo Zanoni wrote: > Technology has evolved and now we have eDP panels with 3200x1800 > resolution. In the meantime, the BIOS guys didn't change the default > 32mb for stolen memory. On top of that, we can't assume our users will > be able to increase the

  1   2   3   >