Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-22 Thread Sean Paul
On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare wrote: > This is RFC patch for adding a connector link-status property > and making it atomic by adding it to the drm_connector_state. > This is to make sure its wired properly in drm_atomic_connector_set_property > and

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhi Wang
Thanks Michał! Have a good day. :P On 11/22/16 22:39, Michał Winiarski wrote: On Mon, Nov 21, 2016 at 07:44:26PM +0800, Zhi Wang wrote: a PT page will be released if it doesn't contain any meaningful mappings during PPGTT page table shrinking. The PT entry in the upper level will be set to a

[Intel-gfx] [PATCH v2] drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Chris Wilson
Just a couple of naked 64bit divides causing link errors on 32bit builds, with: ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined! v2: do_div() is only u64/u32, we need a u32/u64! Reported-by: kbuild test robot Fixes: d79651522e89 ("drm/i915: Enable

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915/perf: Wrap 64bit divides in do_div() > URL : https://patchwork.freedesktop.org/series/15769/ > State : warning > > == Summary == > > Series 15769v1 drm/i915/perf: Wrap 64bit divides in do_div() >

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Wang, Zhi A
Hi Chris, thanks for the reply! Without this patch, we have to do pattern scan to identify if the page is still being used as a PT page. :( It's complicated. Originally, all the guest shadow PPGTT pages will be set to write-protected by HV. When guest makes a change in its page table, it will

Re: [Intel-gfx] [PATCH] lib/debugobjects: Export for use in modules

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 04:53:09PM -0800, Andrew Morton wrote: > On Tue, 22 Nov 2016 14:30:39 + Chris Wilson > wrote: > > > Drivers, or other modules, that use a mixture of objects (especially > > objects embedded within other objects) would like to take advantage

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Tian, Kevin
It's also the style how CPU page table is managed... > From: Wang, Zhi A > Sent: Wednesday, November 23, 2016 3:37 PM > > Hi Chris, thanks for the reply! Without this patch, we have to do pattern > scan to identify > if the page is still being used as a PT page. :( It's complicated. > >

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhenyu Wang
On 2016.11.22 14:38:19 +, Chris Wilson wrote: > On Tue, Nov 22, 2016 at 09:29:40PM +0800, Zhi Wang wrote: > > Hi guys: > > Would you mind to have a quick review on this patch? :P The > > linux guest under GVT-g couldn't boot up without this patch in the > > newer kernel. > > > > Thanks, >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make GPU pages movable

2016-11-22 Thread Hugh Dickins
On Tue, 22 Nov 2016, Matthew Auld wrote: > On 9 November 2016 at 18:36, Hugh Dickins wrote: > > On Wed, 9 Nov 2016, Daniel Vetter wrote: > >> > >> Hi all -mm folks! > >> > >> Any feedback on these two? It's kinda an intermediate step towards a > >> full-blown gemfs, and I think

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 05:15:59PM -0800, Manasi Navare wrote: > On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > > > On Mon, Nov 21, 2016 at

Re: [Intel-gfx] [PATCH 3/4] drm/i915/lspcon: Wait for expected LSPCON mode to settle

2016-11-22 Thread Sharma, Shashank
R-B: Shashank Sharma Regards Shashank -Original Message- From: Deak, Imre Sent: Tuesday, November 22, 2016 9:47 PM To: Sharma, Shashank ; intel-gfx@lists.freedesktop.org Cc: Ville Syrjälä ; Nikula,

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-22 Thread Manasi Navare
On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > > On Mon, Nov 21, 2016 at 10:38:20AM +0100, Daniel Vetter wrote: > > > > On Fri, Nov 18, 2016 at

[Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-22 Thread Manasi Navare
This is RFC patch for adding a connector link-status property and making it atomic by adding it to the drm_connector_state. This is to make sure its wired properly in drm_atomic_connector_set_property and drm_atomic_connector_get_property functions. Cc: Jani Nikula

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm: Add a new connector atomic property for link status

2016-11-22 Thread Patchwork
== Series Details == Series: drm: Add a new connector atomic property for link status URL : https://patchwork.freedesktop.org/series/15781/ State : warning == Summary == Series 15781v1 drm: Add a new connector atomic property for link status

Re: [Intel-gfx] [PATCH 2/4] drm/i915/lspcon: Add dp_to_lspcon helper()

2016-11-22 Thread Sharma, Shashank
Regards Shashank On 11/22/2016 12:45 AM, Imre Deak wrote: We need to get to LSPCON in the next patch, so factor out the helper for it. While at it also remove the redundant GEN9 check. Cc: Shashank Sharma Signed-off-by: Imre Deak ---

Re: [Intel-gfx] [PATCH] drm/i915: Moving scaler numbers to runtime init

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 04:26:18PM +0530, Nabendu Maiti wrote: > Numbers of scalers initialization is moved to runtime init for platform > specific initialization. > > Signed-off-by: Nabendu Maiti > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- >

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 11:54:57AM +, Brian Starkey wrote: > On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote: > >On Tue, Nov 22, 2016 at 10:53:51AM +, Brian Starkey wrote: > >>Hi Gustavo, > >> > >>A little late to the party here, but I was blocked by our internal >

[Intel-gfx] [PATCH i-g-t v9 07/21] tests/sw_sync: Add subtest test_sync_merge

2016-11-22 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge that tests merging fences and the validity of the resulting merged fence. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 67

Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Add i915 perf infrastructure

2016-11-22 Thread Daniel Vetter
On Wed, Nov 09, 2016 at 08:00:06PM +, Matthew Auld wrote: > On 7 November 2016 at 19:49, Robert Bragg wrote: > > Adds base i915 perf infrastructure for Gen performance metrics. > > > > This adds a DRM_IOCTL_I915_PERF_OPEN ioctl that takes an array of uint64 > >

[Intel-gfx] [PATCH i-g-t v9 10/21] tests/sw_sync: Add subtest test_sync_multi_consumer_producer

2016-11-22 Thread robert . foss
From: Robert Foss This test verifies that stressing the kernel by creating multiple consumer/producer threads that wait on a single timeline to be incremented by another conumer/producer thread does not fail. And that the order amongst the threads is maintained.

[Intel-gfx] [PATCH i-g-t v9 15/21] tests/sw_sync: Add subtest test_timeline_closed

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies that the fences of a timeline are not signalled when a timelne is closed. Signed-off-by: Robert Foss --- tests/sw_sync.c | 17 + 1 file changed, 17 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v9 12/21] tests/sw_sync: Add subtest test_sync_multi_timeline_wait

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies that waiting, timing out on a wait and that counting fences in various states works. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 66

[Intel-gfx] [PATCH i-g-t v9 04/21] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline

2016-11-22 Thread robert . foss
From: Robert Foss This subtests tests that creating fences on negative timelines fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v9 17/21] lib/sw_sync: Add igt_require_sw_sync to enable skipping on no sw_sync support

2016-11-22 Thread robert . foss
From: Robert Foss Add igt_require_sw_sync to provide tests to skip if sw_sync support isn't available on the host machine. Signed-off-by: Robert Foss --- lib/sw_sync.c | 22 ++ lib/sw_sync.h | 1 + 2 files changed, 23

[Intel-gfx] [PATCH i-g-t v9 18/21] tests/sw_sync: Add igt_require check for sw_sync feature

2016-11-22 Thread robert . foss
From: Robert Foss Make sure that this test is skipped if the sw_sync feature is missing from the host system. Signed-off-by: Robert Foss --- lib/sw_sync.c | 1 + tests/sw_sync.c | 3 +++ 2 files changed, 4 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v9 06/21] tests/sw_sync: Add subtest test_sync_busy

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies that waiting on fences works properly. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 51 +++ 1 file

[Intel-gfx] [PATCH i-g-t v9 19/21] tests/sw_sync: Add subtest test_sync_merge_invalid

2016-11-22 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge_invalid that tests merging invalid fences. Signed-off-by: Robert Foss --- tests/sw_sync.c | 41 + 1 file changed, 41 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t v9 01/21] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-11-22 Thread robert . foss
From: Robert Foss Base functions to help testing the Sync File Framework (explicit fencing mechanism ported from Android). These functions allow you to create, use and destroy timelines and fences. Signed-off-by: Robert Foss Signed-off-by:

[Intel-gfx] [PATCH i-g-t v9 09/21] tests/sw_sync: Add subtest test_sync_multi_consumer

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies the access ordering of multiple consumer threads. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 103

[Intel-gfx] [PATCH i-g-t v9 16/21] tests/sw_sync: Add subtest test_timeline_closed_signaled

2016-11-22 Thread robert . foss
From: Robert Foss Add subtest test_timeline_closed_signaled that verifies that a signaled fence stays signaled after its timeline has been closed. Signed-off-by: Robert Foss --- tests/sw_sync.c | 18 ++ 1 file changed, 18

[Intel-gfx] [PATCH i-g-t v9 21/21] tests/sw_sync: Add subtest test_sync_busy_unixsocket

2016-11-22 Thread robert . foss
From: Robert Foss Add subtest test_sync_busy_fork which increments the timeline in a forked child process, where the timeline fd has been sent through a UNIX socket. Signed-off-by: Robert Foss --- tests/sw_sync.c | 103

Re: [Intel-gfx] [PATCH v9 11/11] drm/i915: Add a kerneldoc summary for i915_perf.c

2016-11-22 Thread Daniel Vetter
On Mon, Nov 07, 2016 at 07:49:57PM +, Robert Bragg wrote: > In particular this tries to capture for posterity some of the early > challenges we had with using the core perf infrastructure in case we > ever want to revisit adapting perf for device metrics. > > Cc: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Moving scaler numbers to runtime init (rev2)

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915: Moving scaler numbers to runtime init (rev2) URL : https://patchwork.freedesktop.org/series/15726/ State : success == Summary == Series 15726v2 drm/i915: Moving scaler numbers to runtime init

[Intel-gfx] [PATCH i-g-t v9 20/21] tests/sw_sync: Add subtest test_sync_busy_fork

2016-11-22 Thread robert . foss
From: Robert Foss Add subtest test_sync_busy_fork which increments the timeline in a forked child process. Signed-off-by: Robert Foss --- tests/sw_sync.c | 39 +++ 1 file changed, 39 insertions(+) diff

Re: [Intel-gfx] [PATCH v2] drm/i915: don't whitelist oacontrol in cmd parser

2016-11-22 Thread Daniel Vetter
On Tue, Nov 08, 2016 at 12:51:48PM +, Robert Bragg wrote: > This v2 patch bumps the command parser version so it can be referenced in > corresponding i-g-t gem_exec_parse changes. > > --- >8 --- Scissors cut everything below, not everything above, hence next time around pls switch around

Re: [Intel-gfx] [PATCH v5 4/8] drm/i915/bxt: Enable IPC support

2016-11-22 Thread Mahesh Kumar
Hi, On Tuesday 22 November 2016 12:16 AM, Paulo Zanoni wrote: Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: This patch adds IPC support for platforms. This patch enables IPC only for BXT/KBL platform as for SKL recommendation is to keep is disabled. IPC (Isochronous Priority

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add a helper function to return DP link rate index

2016-11-22 Thread Jani Nikula
On Tue, 22 Nov 2016, Manasi Navare wrote: > Common rates array is used to keep track of common rates > supported between DP sink and source. This helper function > returns the index of a specific link rate in this common rates > array. > > This is in prep with patches

[Intel-gfx] [PATCH v2 36/37] drm: Add mode_config .get_format_info() hook

2016-11-22 Thread ville . syrjala
From: Ville Syrjälä Allow drivers to return a custom drm_format_info structure for special fb layouts. We'll use this for the compression control surface in i915. v2: Fix drm_get_format_info() kernel doc (Laurent) Don't pass 'dev' to the new hook (Laurent)

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Brian Starkey
On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote: On Tue, Nov 22, 2016 at 12:37:47PM +, Brian Starkey wrote: On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote: > On Tue, Nov 22, 2016 at 11:54:57AM +, Brian Starkey wrote: > > On Tue, Nov 22, 2016 at 11:06:00AM

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 01:50:53PM +, Brian Starkey wrote: > On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote: > > On Tue, Nov 22, 2016 at 12:37:47PM +, Brian Starkey wrote: > > > On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote: > > > > On Tue, Nov 22, 2016 at

[Intel-gfx] [PATCH] drm/i915: Remove all ->config dereferences from intel_hdmi

2016-11-22 Thread Maarten Lankhorst
We can now obtain the relevant crtc_state/conn_state from the relevant callbacks, which means all the ->config accesses can be removed and the code cleaned up. Also fixes the following WARN_ON, because we don't have to iterate atomic connectors any more: [ 1562.981768] [ cut here

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Brian Starkey
On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote: On Tue, Nov 22, 2016 at 11:54:57AM +, Brian Starkey wrote: On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote: >On Tue, Nov 22, 2016 at 10:53:51AM +, Brian Starkey wrote: >>Hi Gustavo, >> >>A little late to the

[Intel-gfx] [PATCH igt] stubs/drm: Add drm_intel_gem_context_get_id stub

2016-11-22 Thread Robert Bragg
The plan is to use this api in i915-perf tests so this adds the corresponding stub in case libdrm was built with libdrm_intel disabled. Signed-off-by: Robert Bragg --- lib/stubs/drm/intel_bufmgr.c | 7 +++ lib/stubs/drm/intel_bufmgr.h | 2 ++ 2 files changed, 9

Re: [Intel-gfx] [PATCH igt] stubs/drm: Add drm_intel_gem_context_get_id stub

2016-11-22 Thread Matthew Auld
On 22 November 2016 at 13:02, Robert Bragg wrote: > The plan is to use this api in i915-perf tests so this adds the > corresponding stub in case libdrm was built with libdrm_intel disabled. > > Signed-off-by: Robert Bragg Reviewed-by: Matthew Auld

[Intel-gfx] [PATCH i-g-t v9 11/21] tests/sw_sync: Add subtest test_sync_random_merge

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies that creating many timelines and merging random fences from each timeline with eachother results in merged fences that are fully functional. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom

[Intel-gfx] [PATCH i-g-t v9 13/21] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer

2016-11-22 Thread robert . foss
From: Robert Foss This subtest runs a single consumer thread and multiple producer thread that are synchronized using multiple timelines. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 139

[Intel-gfx] [PATCH i-g-t v9 00/21] Implement sw_sync test

2016-11-22 Thread robert . foss
From: Robert Foss This series implements the sw_sync test and the lib/sw_sync helper functions for said test. The sw_sync subtests range from very basic tests of the sw_sync functionality, to stress testing and randomized tests. Changes since v1: Added "Reviewed-by:

[Intel-gfx] [PATCH i-g-t v9 03/21] tests/sw_sync: Add subtest test_alloc_fence

2016-11-22 Thread robert . foss
From: Robert Foss Add subtest alloc_fence that verifies that it's possible to allocate a fence on a timeline. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 16 1 file

[Intel-gfx] [PATCH i-g-t v9 05/21] tests/sw_sync: Add subtest test_alloc_merge_fence

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies that merging two fences works in the simples possible case. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 23 +++ 1 file

[Intel-gfx] [PATCH i-g-t v9 08/21] tests/sw_sync: Add subtest test_sync_merge_same

2016-11-22 Thread robert . foss
From: Robert Foss This subtest verifies merging a fence with itself does not fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 27 +++ 1 file changed, 27

[Intel-gfx] [PATCH i-g-t v9 14/21] tests/sw_sync: Add subtest test_sync_expired_merge

2016-11-22 Thread robert . foss
From: Rafael Antognolli This test creates an already expired fence, then creates a merged fence out of that expired one (passed twice to the merge operation), and finally closes the merged fence. It shows that if the refcounts are wrong on the original expired fence,

[Intel-gfx] [PATCH i-g-t v9 02/21] test/sw_sync: Add sw_sync test

2016-11-22 Thread robert . foss
From: Robert Foss Add initial tests for sw_sync. Signed-off-by: Robert Foss Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom --- tests/Makefile.sources | 1 + tests/sw_sync.c

Re: [Intel-gfx] HDMI output on Gigabyte BRiX i7-5500

2016-11-22 Thread Jani Nikula
On Mon, 21 Nov 2016, Chris Lovett wrote: > It has Intel HD 5500 graphics, the mini display port works, but the larger > HDMI output port produces nothing. I know my HDMI cable and monitor are > good because my Raspberry Pi has no problem showing up on it. Please file a bug

Re: [Intel-gfx] [PATCH v5 5/8] drm/i915/skl+: change WM calc to fixed point 16.16

2016-11-22 Thread Paulo Zanoni
Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > This patch changes Watermak calculation to fixed point calculation. > Problem with current calculation is during plane_blocks_per_line > calculation we divide intermediate blocks with min_scanlines and > takes floor of the result because

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 12:37:47PM +, Brian Starkey wrote: > On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote: > > On Tue, Nov 22, 2016 at 11:54:57AM +, Brian Starkey wrote: > > > On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote: > > > >On Tue, Nov 22, 2016 at

Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Add i915 perf infrastructure

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 02:29:18PM +0100, Daniel Vetter wrote: > On Wed, Nov 09, 2016 at 08:00:06PM +, Matthew Auld wrote: > > On 7 November 2016 at 19:49, Robert Bragg wrote: > > > Adds base i915 perf infrastructure for Gen performance metrics. > > > > > > This adds a

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhi Wang
Hi guys: Would you mind to have a quick review on this patch? :P The linux guest under GVT-g couldn't boot up without this patch in the newer kernel. Thanks, Zhi. On 11/21/16 19:44, Zhi Wang wrote: a PT page will be released if it doesn't contain any meaningful mappings during PPGTT page

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Correct dual-link MIPI port control.

2016-11-22 Thread Ville Syrjälä
On Mon, Nov 21, 2016 at 02:24:06PM -0800, Bob Paauwe wrote: > For BXT, there is only one bit that enables/disables dual-link mode > and not different bits depending on which pipe is being used. > > Signed-off-by: Bob Paauwe > --- > drivers/gpu/drm/i915/intel_dsi.c | 5

Re: [Intel-gfx] [PATCH] drm/i915: Remove all ->config dereferences from intel_hdmi

2016-11-22 Thread Ville Syrjälä
On Tue, Nov 22, 2016 at 01:38:51PM +0100, Maarten Lankhorst wrote: > We can now obtain the relevant crtc_state/conn_state from the > relevant callbacks, which means all the ->config accesses > can be removed and the code cleaned up. > > Also fixes the following WARN_ON, because we don't have to

Re: [Intel-gfx] [PATCH 1/4] drm/i915/lspcon: Ensure AUX CH is awake while in DP Sleep state

2016-11-22 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 11/22/2016 12:45 AM, Imre Deak wrote: Some LSPCON adaptors won't properly wake up in response to an AUX request after the adaptor was placed to a DP Sink Sleep state (via writing 0x2 to DP_SET_POWER). Based on the DP 1.4 specification 5.2.5, the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Moving scaler numbers to runtime init

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915: Moving scaler numbers to runtime init URL : https://patchwork.freedesktop.org/series/15726/ State : success == Summary == Series 15726v1 drm/i915: Moving scaler numbers to runtime init

[Intel-gfx] [PATCH] drm/i915: Moving no of scalers initialization to runtime init

2016-11-22 Thread Nabendu Maiti
Number of scalers initialization is moved to runtime init from intel_crtc_init for platform specific initialization. Signed-off-by: Nabendu Maiti --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 1 +

[Intel-gfx] [PATCH] drm/i915: Moving scaler numbers to runtime init

2016-11-22 Thread Nabendu Maiti
Numbers of scalers initialization is moved to runtime init for platform specific initialization. Signed-off-by: Nabendu Maiti --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 1 +

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 10:53:51AM +, Brian Starkey wrote: > Hi Gustavo, > > A little late to the party here, but I was blocked by our internal > contributions process... > > I didn't see these end up in my checkout yet though, so I guess they > aren't picked up yet. > > On Mon, Nov 14,

Re: [Intel-gfx] [PATCH 06/12] lib/igt_kms: Add support for the IN_FENCE_FD property

2016-11-22 Thread Brian Starkey
Hi, On Mon, Nov 14, 2016 at 06:59:20PM +0900, Gustavo Padovan wrote: From: Robert Foss Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. Signed-off-by: Robert Foss --- lib/igt_kms.c | 20

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Brian Starkey
On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote: On Tue, Nov 22, 2016 at 10:53:51AM +, Brian Starkey wrote: Hi Gustavo, A little late to the party here, but I was blocked by our internal contributions process... I didn't see these end up in my checkout yet though, so I guess

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make skl_write_{plane, cursor}_wm() static

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915: Make skl_write_{plane, cursor}_wm() static URL : https://patchwork.freedesktop.org/series/15767/ State : success == Summary == Series 15767v1 drm/i915: Make skl_write_{plane, cursor}_wm() static

[Intel-gfx] [PATCH 1/5] drm/i915: Add support for DP link training compliance

2016-11-22 Thread Manasi Navare
This patch adds support to handle automated DP compliance link training test requests. This patch has been tested with Unigraf DPR-120 DP Compliance device for testing Link Training Compliance. After we get a short pulse Compliance test request, test request values are read and hotplug uevent is

[Intel-gfx] [PATCH 4/5] drm: Add definitions for DP compliance Video pattern tests

2016-11-22 Thread Manasi Navare
Cc: dri-de...@lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- include/drm/drm_dp_helper.h | 16 +++- 1 file

[Intel-gfx] [PATCH 0/5] Add Automation support for DP compliance testing

2016-11-22 Thread Manasi Navare
DP 1.2 compliance testing can be acheived using DPR-120's CTS suite. This compliance unit sends a short pulse to initiate link training and video pattern generation compliance tests and sends a long pulse to initate EDID compliance tests. It also sets the AUTOMATED TEST REQUEST bit in Device IRQ

[Intel-gfx] [PATCH 2/5] drm/i915: Fixes to support DP Compliance EDID tests

2016-11-22 Thread Manasi Navare
This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Video Mode requested in the EDID test handler for the EDID Read test (CTS 4.2.2.3) should be set to PREFERRED as per the CTS spec. Signed-off-by: Manasi

[Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

2016-11-22 Thread Manasi Navare
The intel_dp_autotest_video_pattern() function gets invoked through the compliance test handler on a HPD short pulse if the test type is set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers reads to read the requested test pattern, video pattern resolution, frame rate and bits per color

[Intel-gfx] [PATCH 3/5] Add support for forcing 6 bpc on DP pipes.

2016-11-22 Thread Manasi Navare
From: Jim Bride For DP compliance we need to be able to control the output color type for the pipe associated with the DP port. When a specific DP compliance test is requested with specific BPC value, we read the BPC value from the DPCD register and store it in the

[Intel-gfx] [PATCH] drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Chris Wilson
Just a couple of naked 64bit divides causing link errors on 32bit builds, with: ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined! Reported-by: kbuild test robot Fixes: d79651522e89 ("drm/i915: Enable i915 perf stream for Haswell OA unit")

Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

2016-11-22 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Chris Wilson >Sent: Tuesday, November 22, 2016 9:06 AM >To: Hiler, Arkadiusz >Cc: intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH]

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915/perf: Wrap 64bit divides in do_div() URL : https://patchwork.freedesktop.org/series/15769/ State : warning == Summary == Series 15769v1 drm/i915/perf: Wrap 64bit divides in do_div() https://patchwork.freedesktop.org/api/1.0/series/15769/revisions/1/mbox/

Re: [Intel-gfx] [PATCH] drm/i915: Make skl_write_{plane, cursor}_wm() static

2016-11-22 Thread Lyude Paul
Reviewed-by: Lyude On Tue, 2016-11-22 at 22:21 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Someone forgot to make skl_write_{plane,cursor}_wm() static when > removing the prototypes from the header. Sparse isn't

[Intel-gfx] [PATCH] drm/i915: Make skl_write_{plane, cursor}_wm() static

2016-11-22 Thread ville . syrjala
From: Ville Syrjälä Someone forgot to make skl_write_{plane,cursor}_wm() static when removing the prototypes from the header. Sparse isn't pleased. Cc: Maarten Lankhorst Cc: Lyude Cc: Matt Roper

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use enum plane_id in SKL wm code

2016-11-22 Thread Lyude Paul
Looks good to me Reviewed-by: Lyude On Tue, 2016-11-22 at 18:01 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Nuke skl_wm_plane_id() and just use the new intel_plane->id. > > v2: Convert skl_write_plane_wm() as well >

[Intel-gfx] [PATCH] lib/debugobjects: Export for use in modules

2016-11-22 Thread Chris Wilson
Drivers, or other modules, that use a mixture of objects (especially objects embedded within other objects) would like to take advantage of the debugobjects facilities to help catch misuse. Currently, the debugobjects interface is only available to builtin drivers and requires a set of

[Intel-gfx] [PATCH] drm/i915: Integrate i915_sw_fence with debugobjects

2016-11-22 Thread Chris Wilson
Add the tracking required to enable debugobjects to improve error detection in BAT. The debugobject interface lets us to track the lifetime of the fences even while being embedded into larger structs, i.e. to check they are not used after they have been released. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v5 4/8] drm/i915/bxt: Enable IPC support

2016-11-22 Thread Paulo Zanoni
Em Ter, 2016-11-22 às 19:05 +0530, Mahesh Kumar escreveu: > Hi, > > > On Tuesday 22 November 2016 12:16 AM, Paulo Zanoni wrote: > > > > Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: > > > > > > This patch adds IPC support for platforms. This patch enables IPC > > > only for BXT/KBL

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/debugobjects: Export for use in modules

2016-11-22 Thread Patchwork
== Series Details == Series: lib/debugobjects: Export for use in modules URL : https://patchwork.freedesktop.org/series/15743/ State : success == Summary == Series 15743v1 lib/debugobjects: Export for use in modules https://patchwork.freedesktop.org/api/1.0/series/15743/revisions/1/mbox/

Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Add i915 perf infrastructure

2016-11-22 Thread Robert Bragg
On Tue, Nov 22, 2016 at 1:31 PM, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 02:29:18PM +0100, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 08:00:06PM +, Matthew Auld wrote: > > > On 7 November 2016 at 19:49, Robert Bragg > wrote: > > > > Adds

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-22 Thread Mika Kuoppala
Chris Wilson writes: > In order to prevent a race between the old callback submitting an > incomplete request and i915_gem_set_wedged() installing its nop handler, > we must ensure that the swap occurs when the machine is idle > (stop_machine). > > v2: move context lost

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 09:29:40PM +0800, Zhi Wang wrote: > Hi guys: > Would you mind to have a quick review on this patch? :P The > linux guest under GVT-g couldn't boot up without this patch in the > newer kernel. > > Thanks, > Zhi. > > On 11/21/16 19:44, Zhi Wang wrote: > >a PT page will

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Michał Winiarski
On Mon, Nov 21, 2016 at 07:44:26PM +0800, Zhi Wang wrote: > a PT page will be released if it doesn't contain any meaningful mappings > during PPGTT page table shrinking. The PT entry in the upper level will > be set to a scratch entry. > > Normally this works nicely, but in virtualization world,

[Intel-gfx] [CI 4/4] drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-22 Thread Chris Wilson
In order to prevent a race between the old callback submitting an incomplete request and i915_gem_set_wedged() installing its nop handler, we must ensure that the swap occurs when the machine is idle (stop_machine). v2: move context lost from out of BKL. Signed-off-by: Chris Wilson

[Intel-gfx] [CI 1/4] drm/i915: Don't deref context->file_priv ERR_PTR upon reset

2016-11-22 Thread Chris Wilson
When a user context is closed, it's file_priv backpointer is replaced by ERR_PTR(-EBADF); be careful not to chase this invalid pointer after a hang and a GPU reset. Signed-off-by: Chris Wilson Fixes: b083a0870c79 ("drm/i915: Add per client max context ban limit") Cc:

[Intel-gfx] [CI 3/4] drm/i915: Complete requests in nop_submit_request

2016-11-22 Thread Chris Wilson
Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer transfer onto execution timeline to actual hw submission") the global seqno advance was deferred until the submit_request callback. After wedging the GPU, we were installing a nop_submit_request handler (to avoid waking up the

Re: [Intel-gfx] [PATCH 07/12] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2016-11-22 Thread Brian Starkey
On Tue, Nov 22, 2016 at 02:56:49PM +0100, Daniel Vetter wrote: On Tue, Nov 22, 2016 at 01:50:53PM +, Brian Starkey wrote: On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 12:37:47PM +, Brian Starkey wrote: > > On Tue, Nov 22, 2016 at 12:10:52PM

Re: [Intel-gfx] [PATCH v5 5/8] drm/i915/skl+: change WM calc to fixed point 16.16

2016-11-22 Thread Mahesh Kumar
On Tuesday 22 November 2016 06:12 PM, Paulo Zanoni wrote: Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: This patch changes Watermak calculation to fixed point calculation. Problem with current calculation is during plane_blocks_per_line calculation we divide intermediate blocks

Re: [Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages

2016-11-22 Thread Mauro Carvalho Chehab
Em Mon, 14 Nov 2016 09:55:48 + Chris Wilson escreveu: > On Fri, Nov 11, 2016 at 08:50:17AM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Scatterlist entries have an unsigned int for the offset so > > correct the

Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Add i915 perf infrastructure

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 02:02:38PM +, Robert Bragg wrote: > On Tue, Nov 22, 2016 at 1:31 PM, Daniel Vetter wrote: > > > On Tue, Nov 22, 2016 at 02:29:18PM +0100, Daniel Vetter wrote: > > > On Wed, Nov 09, 2016 at 08:00:06PM +, Matthew Auld wrote: > > > > On 7 November

Re: [Intel-gfx] [PATCH 3/4] drm/i915/lspcon: Wait for expected LSPCON mode to settle

2016-11-22 Thread Sharma, Shashank
Regards Shashank On 11/22/2016 12:45 AM, Imre Deak wrote: Some LSPCON adaptors may return an incorrect LSPCON mode right after waking from DP Sleep state. This is the case at least for the ParadTech PS175 adaptor, both when waking because of exiting the DP Sleep to active state, or due to any

Re: [Intel-gfx] [PATCH] drm/i915: Don't deref context->file_priv ERR_PTR upon reset

2016-11-22 Thread Mika Kuoppala
Chris Wilson writes: > When a user context is closed, it's file_priv backpointer is replaced by > ERR_PTR(-EBADF); be careful not to chase this invalid pointer after a > hang and a GPU reset. > > Signed-off-by: Chris Wilson > Fixes:

[Intel-gfx] [CI 2/4] drm/i915: Disable hangcheck when wedged

2016-11-22 Thread Chris Wilson
If the gpu reset fails and the machine is terminally wedged, further hangchecks achieve nothing but noise. Disable them, with a corollary that we re-enable hangchecking after a successful GPU reset in case the user is artificially bringing the machine back to life through the debug interface.

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/debugobjects: Export for use in modules (rev2)

2016-11-22 Thread Patchwork
== Series Details == Series: lib/debugobjects: Export for use in modules (rev2) URL : https://patchwork.freedesktop.org/series/15743/ State : success == Summary == Series 15743v2 lib/debugobjects: Export for use in modules

Re: [Intel-gfx] [PATCH v2] drm/i915: don't whitelist oacontrol in cmd parser

2016-11-22 Thread Robert Bragg
On Tue, Nov 22, 2016 at 1:34 PM, Daniel Vetter wrote: > On Tue, Nov 08, 2016 at 12:51:48PM +, Robert Bragg wrote: > > This v2 patch bumps the command parser version so it can be referenced in > > corresponding i-g-t gem_exec_parse changes. > > > > --- >8 --- > > Scissors cut

[Intel-gfx] [PATCH] lib/debugobjects: Export for use in modules

2016-11-22 Thread Chris Wilson
Drivers, or other modules, that use a mixture of objects (especially objects embedded within other objects) would like to take advantage of the debugobjects facilities to help catch misuse. Currently, the debugobjects interface is only available to builtin drivers and requires a set of

  1   2   >