[Intel-gfx] [PATCH i-g-t] Add atomic modesetting testlist

From: ramibh This is atomic modesetting acceptance tests added to feat_profile.json. Wating for your feedback. --- tests/feat_profile.json | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/feat_profile.json b/tests/feat_profile.json

[Intel-gfx] [PATCH 3/3] drm/i915: Skip modeset locking when atomic pageflips are used.

With the atomic helper for pageflips there are no CS flips when that require resetting, so on most platforms we can completely skip the locking. Because we may end up reverting the page_flip patch add an explicit function pointer check so that if someone reverts the page flip patch there will not

[Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

When writing some testcases for nonblocking modesets. I found out that the infinite wait on the old fb was causing issues. A nonblocking modeset with a hang on the old fb, followed by a blocking update was enough to trigger it. For old platforms patch 2 is needed else

[Intel-gfx] [PATCH 2/3] drm/i915: Set a timeout when waiting for fence on the old fb

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7c19b3c7a4ee..35d25e58a37e 100644

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/glk: Plane color correction register changes

On Thu, Jan 26, 2017 at 01:24:22PM +0200, Ander Conselvan de Oliveira wrote: > In Geminilake, the bits for enabling pipe csc, pipe gamma and plane > gamma moved to a new register. So update the plane update functions > to set the right bits. > > Pipe CSC is kept disabled though, since enabling

Re: [Intel-gfx] [PATCH v3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

On Thu, Jan 26, 2017 at 11:16:58AM +0200, Ander Conselvan de Oliveira wrote: > Apply workarounds to Geminilake, and annotate those that are applied > unconditionally when they apply to GLK based on the workaround database. > > v2: Fix commit message typos. (David) > v3: Rebase. > Cc: David

Re: [Intel-gfx] [PATCH] drm/i915: Remove early pre-production RPS workarounds for BXT

Em Qua, 2017-01-25 às 17:26 +, Chris Wilson escreveu: > Remove WaGsvDisableTurbo and WaRsUseTimeoutMode as these were only > for > pre-production Broxton devices, and this code is now defunct. Can you please also patch intel_detect_preproduction_hw()? Thanks, Paulo > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

Em Qui, 2017-01-26 às 15:02 +0200, Ville Syrjälä escreveu: > On Thu, Jan 26, 2017 at 12:50:28PM +, Chris Wilson wrote: > > > > As we add new generations, we should keep detecting new system > > development platforms that were temporarily enabled (via > > "i915.alpha_support") and now

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

On Thu, Jan 26, 2017 at 03:02:14PM +0200, Ville Syrjälä wrote: > On Thu, Jan 26, 2017 at 12:50:28PM +, Chris Wilson wrote: > > As we add new generations, we should keep detecting new system > > development platforms that were temporarily enabled (via > > "i915.alpha_support") and now

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

On Thu, 26 Jan 2017 14:58:55 +0100, Ville Syrjälä wrote: > > On Wed, Jan 25, 2017 at 01:56:35PM +0100, Takashi Iwai wrote: > > Hi, > > > > we've got a bug report about the blank monitor on Cherry Trail > > machines. And, Intel team (Cc'ed) spotted out that this seems > > triggered by DPMS

[Intel-gfx] [PATCH 1/3] drm/atomic: Bump timeout for waiting for hw_done to 90s in swap_state

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index b535f782b2c0..34338678db26

Re: [Intel-gfx] [PATCH] drm/i915: fix use-after-free in page_flip_completed()

On Thu, Jan 26, 2017 at 05:32:11PM +0300, Andrey Ryabinin wrote: > page_flip_completed() dereferences 'work' variable after executing > queue_work(). This is not safe as the 'work' item might be already freed > by queued work: > > BUG: KASAN: use-after-free in page_flip_completed+0x3ff/0x490

Re: [Intel-gfx] [PATCH 1/6] dim: Update docs

On Thu, 26 Jan 2017, Daniel Vetter wrote: > - Remove branch overview, instead link to drm-intel and drm-misc > pages. > > - Move quickstart to the top, to make it easier to find. > > - Make quickstart generic, we use dim for other stuff than drm-intel > now. > > -

Re: [Intel-gfx] [PATCH i-g-t v2 32/33] tests/kms_plane_lowres: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_plane_lowres.c | 27

[Intel-gfx] ✓ Fi.CI.BAT: success for Geminilake pipe CSC

== Series Details == Series: Geminilake pipe CSC URL : https://patchwork.freedesktop.org/series/18596/ State : success == Summary == Series 18596v1 Geminilake pipe CSC https://patchwork.freedesktop.org/api/1.0/series/18596/revisions/1/mbox/ fi-bdw-5557u total:247 pass:233 dwarn:0

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

On Thu, 26 Jan 2017, Chris Wilson wrote: > On Thu, Jan 26, 2017 at 03:18:28PM +0200, Jani Nikula wrote: >> On Thu, 26 Jan 2017, Chris Wilson wrote: >> > As we add new generations, we should keep detecting new system >> > development platforms

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

On Wed, Jan 25, 2017 at 01:56:35PM +0100, Takashi Iwai wrote: > Hi, > > we've got a bug report about the blank monitor on Cherry Trail > machines. And, Intel team (Cc'ed) spotted out that this seems > triggered by DPMS transition. A patch like below actually fixes the > problem. > > Of course

Re: [Intel-gfx] [PATCH] drm/i915: Retire an active batch pool object rather than allocate new

Chris Wilson writes: > Since obj->active_count is only updated upon retirement, if we see an > active object in the batch pool, double check that is still active > before deciding to allocate a new object. > > Signed-off-by: Chris Wilson > ---

Re: [Intel-gfx] [PATCH i-g-t v2 31/33] tests/kms_ccs: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_ccs.c | 4 ++-- >  1 file changed,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Report the failure to write to the punit (rev2)

== Series Details == Series: series starting with [v2] drm/i915: Report the failure to write to the punit (rev2) URL : https://patchwork.freedesktop.org/series/18549/ State : success == Summary == Series 18549v2 Series without cover letter

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

On Thu, 26 Jan 2017, Chris Wilson wrote: > As we add new generations, we should keep detecting new system > development platforms that were temporarily enabled (via > "i915.alpha_support") and now superseded by production systems. To make > it easier to add more

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Also clear the punit's PDATA sideband register

Chris Wilson writes: > As the previous punit i/o may have failed, the contents of the PDATA are > undefined. Always clear it to 0 prior to sending the command. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround (rev3)

== Series Details == Series: series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround (rev3) URL : https://patchwork.freedesktop.org/series/17904/ State : success == Summary == Series 17904v3 Series without cover letter

[Intel-gfx] [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

Preproduction sdv are not supported beyond the release of production hardware, and continued use is ill-advised. Mark the kernel as tainted to reinforce the error. Signed-off-by: Chris Wilson Cc: "Zanoni, Paulo R" Cc: Rodrigo Vivi

[Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

As we add new generations, we should keep detecting new system development platforms that were temporarily enabled (via "i915.alpha_support") and now superseded by production systems. To make it easier to add more platforms, split the if into a series of logical operations. Signed-off-by: Chris

Re: [Intel-gfx] [PATCH] drm/i915: Retire an active batch pool object rather than allocate new

On Thu, Jan 26, 2017 at 04:25:25PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > Since obj->active_count is only updated upon retirement, if we see an > > active object in the batch pool, double check that is still active > > before deciding to allocate a new

[Intel-gfx] [drm-intel:drm-intel-nightly 1414/1425] drivers/gpu/drm/drm_modes.c:909:20: warning: 'adjusted.base.id' is used uninitialized in this function

tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: 3778ca36c6b4e894b581d4f56abe6bbafe927e96 commit: 196cd5d3758cbf587fc0254cae7132d95993461e [1414/1425] drm: s/drm_crtc_get_hv_timings/drm_mode_get_hv_timings/ config: i386-defconfig (attached as .config) compiler: gcc-6

Re: [Intel-gfx] [PATCH i-g-t v2 30/33] tests/prime_mmap_kms: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/prime_mmap_kms.c | 2 +- >  1 file

Re: [Intel-gfx] [PATCH i-g-t v2 29/33] tests/kms_vblank: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_vblank.c | 4 ++-- >  1 file

Re: [Intel-gfx] [PATCH i-g-t v2 33/33] lib/igt_kms: Remove code obsoleted by dyn n_planes implementation

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:34 -0500, Robert Foss wrote: > Due to the dyn n_planes implementation some attributes and functions > were made obsolete and cand be removed. > > However to keep all of the tests building the obsolete code is > removed

Re: [Intel-gfx] [PATCH i-g-t v2 25/33] tests/kms_rmfb: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_rmfb.c | 2 +- >  1 file changed,

Re: [Intel-gfx] [PATCH i-g-t v2 24/33] tests/kms_pwrite_crc: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_pwrite_crc.c | 2 +- >  1 file

Re: [Intel-gfx] [PATCH i-g-t v2 26/33] tests/kms_rotation_crc: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_rotation_crc.c | 63

Re: [Intel-gfx] [PATCH i-g-t v2 27/33] tests/kms_sink_crc_basic: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_sink_crc_basic.c | 2 +- >  1 file

[Intel-gfx] [PATCH] drm/i915: Retire an active batch pool object rather than allocate new

Since obj->active_count is only updated upon retirement, if we see an active object in the batch pool, double check that is still active before deciding to allocate a new object. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_batch_pool.c | 29

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/glk: Program pipe gamma and degamma tables

On Thu, Jan 26, 2017 at 01:24:24PM +0200, Ander Conselvan de Oliveira wrote: > The gamma tables in Geminilake were changed. There is no split-gamma > mode. Instead, there is a dedicated degamma table that is enabled > whenever pipe CSC is enabled. > > The dedicated gamma table has 16 bit

[Intel-gfx] [PATCH v2 3/5] drm/i915: Split broadwell_load_luts() into smaller functions

Split the logic for progamming each LUT out of broadwell_load_luts(), so we can reuse part of it for geminilake. Cc: Ville Syrjälä Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_reg.h| 1 +

[Intel-gfx] [PATCH v2 1/5] drm/i915: Disable plane gamma in SKL+ sprite planes

The plane gamma tables are never programmed, so just disable it, like it is done for the primary plane. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sprite.c | 1 + 1

[Intel-gfx] [PATCH v2 2/5] drm/i915/glk: Plane color correction register changes

In Geminilake, the bits for enabling pipe csc, pipe gamma and plane gamma moved to a new register. So update the plane update functions to set the right bits. Pipe CSC is kept disabled though, since enabling that also enables the dedicated degamma table, and that is not properly programmed yet,

[Intel-gfx] [PATCH v2 4/5] drm/i915/glk: Program pipe gamma and degamma tables

The gamma tables in Geminilake were changed. There is no split-gamma mode. Instead, there is a dedicated degamma table that is enabled whenever pipe CSC is enabled. The dedicated gamma table has 16 bit precision but doesn't support separate channels. Since that doesn't match the per-channel

[Intel-gfx] [PATCH v2 5/5] drm/i915/glk: Enable pipe CSC

Now that the pre-csc degamma table is set up correctly in Geminilake, pipe CSC can be enabled without causing a black screen. v2: Rebase. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 1 +

[Intel-gfx] [PATCH v2 0/5] Geminilake pipe CSC

Ander Conselvan de Oliveira (5): drm/i915: Disable plane gamma in SKL+ sprite planes drm/i915/glk: Plane color correction register changes drm/i915: Split broadwell_load_luts() into smaller functions drm/i915/glk: Program pipe gamma and degamma tables drm/i915/glk: Enable pipe CSC

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

On Thu, Jan 26, 2017 at 01:16:03PM +, Chris Wilson wrote: > On Thu, Jan 26, 2017 at 03:02:14PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 26, 2017 at 12:50:28PM +, Chris Wilson wrote: > > > As we add new generations, we should keep detecting new system > > > development platforms that

Re: [Intel-gfx] [PATCH i-g-t v2 28/33] tests/kms_universal_plane: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_universal_plane.c | 18

[Intel-gfx] [PATCH 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines

Extend intel_detect_preproduction_hw() to include BXT A and B steppings. Signed-off-by: Chris Wilson Cc: "Zanoni, Paulo R" Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

On Thu, Jan 26, 2017 at 12:50:28PM +, Chris Wilson wrote: > As we add new generations, we should keep detecting new system > development platforms that were temporarily enabled (via > "i915.alpha_support") and now superseded by production systems. To make > it easier to add more platforms,

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

On Sat, 21 Jan 2017, Manasi Navare wrote: > This patch series addresses all the review comments from the previous series: > https://patchwork.freedesktop.org/series/18256/ > > On top of that it also adds a fix for CRC mismatches seen during > 18bpp video pattern

[Intel-gfx] [PATCH] i965: Share the workaround bo between all contexts

Since the workaround bo is used strictly as a write-only buffer, we need only allocate one per screen and use the same one from all contexts. (The caveat here is during extension initialisation, where we write into and read back register values from the buffer, but that is performed only once for

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Split broadwell_load_luts() into smaller functions

On Thu, Jan 26, 2017 at 01:24:23PM +0200, Ander Conselvan de Oliveira wrote: > Split the logic for progamming each LUT out of broadwell_load_luts(), so > we can reuse part of it for geminilake. > > Cc: Ville Syrjälä > Signed-off-by: Ander Conselvan de Oliveira >

Re: [Intel-gfx] [PATCH v2] drm/i915: Report the failure to write to the punit

Chris Wilson writes: > The write to the punit may fail, so propagate the error code back to its > callers. Of particular interest are the RPS writes, so add appropriate > user error codes and logging. > > v2: Add DEBUG for failed frequency changes during RPS. > >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

On Thu, 26 Jan 2017, Chris Wilson wrote: > Preproduction sdv are not supported beyond the release of production > hardware, and continued use is ill-advised. Mark the kernel as tainted > to reinforce the error. > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

On Thu, Jan 26, 2017 at 03:18:28PM +0200, Jani Nikula wrote: > On Thu, 26 Jan 2017, Chris Wilson wrote: > > As we add new generations, we should keep detecting new system > > development platforms that were temporarily enabled (via > > "i915.alpha_support") and now

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Share the workaround bo between all contexts

On Thu 26 Jan 2017, Chris Wilson wrote: > Since the workaround bo is used strictly as a write-only buffer, we need > only allocate one per screen and use the same one from all contexts. > > (The caveat here is during extension initialisation, where we write into > and read back register values

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Share the workaround bo between all contexts

On Thu, Jan 26, 2017 at 09:39:51AM -0800, Chad Versace wrote: > On Thu 26 Jan 2017, Chris Wilson wrote: > > Since the workaround bo is used strictly as a write-only buffer, we need > > only allocate one per screen and use the same one from all contexts. > > > > (The caveat here is during

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Wait for pending modesets to complete before trying link training

On Mon, Jan 09, 2017 at 06:06:57PM +0100, Maarten Lankhorst wrote: > We're protected by the connection_mutex lock against blocking modesets, > but nonblocking modesets are performed without any locking. This is > causing WARN in drm_wait_for_vblank and in general it's better to wait > before

Re: [Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

> It sucks, but I guess this is better than dead machines. I'd say let's > wait another 1-2 weeks for tested-bys to trickle in, and if it does fix > the problem then let's apply it. rps keeps on sucking, that's > unfortunately not news at all. > > Acked-by: Daniel Vetter

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

On Thu, Jan 26, 2017 at 04:59:21PM +0100, Maarten Lankhorst wrote: > When writing some testcases for nonblocking modesets. I found out that the > infinite wait on the old fb was causing issues. > > A nonblocking modeset with a hang on the old fb, followed by a blocking > update was enough to

Re: [Intel-gfx] [PATCH 1/3] drm/atomic: move waiting for hw_done to a helper

On Mon, Jan 09, 2017 at 06:06:56PM +0100, Maarten Lankhorst wrote: > This will allow i915 to perform a wait on pending modeset using the > same code. I don't like commit messages that refer to the subject like this. I can't even see the subject when I'm replying so I have approximately zero idea

Re: [Intel-gfx] [PATCH 4/4] drm: Resurrect atomic rmfb code, v2

On Thu, Jan 26, 2017 at 10:55:51AM +0100, Maarten Lankhorst wrote: > Op 25-01-17 om 19:05 schreef Sinclair Yeh: > > On Wed, Jan 25, 2017 at 09:36:36AM +0100, Maarten Lankhorst wrote: > >> Op 25-01-17 om 09:09 schreef Thomas Hellstrom: > >>> On 01/25/2017 05:54 AM, Daniel Vetter wrote: > On

[Intel-gfx] [PATCH v4 13/14] drm/i915: Replace the .modeset_commit_cdclk() hook with a more direct .set_cdclk() hook

From: Ville Syrjälä With the cdclk state, all the .modeset_commit_cdclk() hooks are now pointless wrappers. Let's replace them with just a .set_cdclk() function pointer. However let's wrap that in a small helper that does the state comparison and prints a unified

[Intel-gfx] [RFC PATCH 5/5] ALSA: x86: hdmi: hack to enable DP audio on CHT

Somehow the configuration register that the audio driver needs to use depends on the port/pipe combination. Adding the pipe information to the notify() call isn't helping, the pipe value is -1 (illegal). FIXME: does this require a change in the pdata or a handshake with i915? Signed-off-by:

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Share the workaround bo between all contexts

On Thu, Jan 26, 2017 at 09:39:51AM -0800, Chad Versace wrote: > On Thu 26 Jan 2017, Chris Wilson wrote: > > Since the workaround bo is used strictly as a write-only buffer, we need > > only allocate one per screen and use the same one from all contexts. > > > > (The caveat here is during

Re: [Intel-gfx] [PATCH 0/5] drm/edid: Improve RGB limited range handling a bit

On Wed, Jan 11, 2017 at 02:57:20PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > While reading the HDMI 2.0 spec I noticed some new things related to > the RGB quantization range stuff, and after cross checking with > CEA-861-F I spotted a

[PATCH v1½ 13/13] drm/i915/dp: use readb and writeb calls for single byte DPCD access

This is what we have the readb and writeb variants for. Do some minor return value and variable cleanup while at it. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[PATCH v1½ 10/13] drm/i915/dp: add functions for max common link rate and lane count

These are the theoretical maximums common for source and sink. These are the maximums we should start with. They may be degraded in case of link training failures, and the dynamic link values are stored separately. Cc: Manasi Navare Cc: Ville Syrjälä

[PATCH v1½ 08/13] drm/i915/dp: do not limit rate seek when not needed

In link training fallback, we're trying to find a rate that we know is in a sorted array of common link rates. We don't need to limit the array using the max rate. For test request, the DP CTS doesn't say we should limit the rate based on earlier fallback. Cc: Manasi Navare

[PATCH v1½ 06/13] drm/i915/dp: use the sink rates array for max sink rates

Looking at DPCD DP_MAX_LINK_RATE may be completely bogus for eDP 1.4 which is allowed to use link rate select method and have 0 in max link rate. With this change, it makes sense to store the max rate as the actual rate rather than as a bw code. Cc: Manasi Navare Cc:

[PATCH v1½ 02/13] drm/i915/dp: return errors from rate_to_index()

We shouldn't silently use the first element if we can't find the rate we're looking for. Make rate_to_index() more generally useful, and fallback to the first element in the caller, with a big warning. Cc: Manasi Navare Cc: Ville Syrjälä

[PATCH v1½ 11/13] drm/i915/mst: use max link not sink lane count

The source might not support as many lanes as the sink, or the link training might have failed at higher lane counts. Take these into account. Cc: Dhinakaran Pandiyan Cc: Manasi Navare Cc: Ville Syrjälä

[Intel-gfx] [RFC PATCH 0/5] DisplayPort Audio on Cherrytrail

The following patches enable DisplayPort Audio on Cherrytrail machines when applied on top of Takashi's topic/intel-lpe-audio branch (tested on Zotac PI330) There are a couple of opens where I could use some help: - is it necessary to set a valid_bit which is used only for DP audio? - is the

[Intel-gfx] [RFC PATCH 4/5] drm: i915: add DisplayPort amp unmute for LPE audio mode

Enable chicken bit on LPE mode setup and unmute amp on notification FIXME: should these two phases done somewhere else? Signed-off-by: Pierre-Louis Bossart --- drivers/gpu/drm/i915/i915_reg.h| 12 drivers/gpu/drm/i915/intel_lpe_audio.c

[Intel-gfx] [RFC PATCH 1/5] drm: i915: add DP support in LPE audio mode

If DisplayPort is detected, pass flag and link rate to audio driver Signed-off-by: Pierre-Louis Bossart --- drivers/gpu/drm/i915/i915_drv.h| 3 ++- drivers/gpu/drm/i915/intel_audio.c | 19 +++

[Intel-gfx] [RFC PATCH 3/5] ALSA: x86: intel_hdmi: set config bitfields for DP mode

These bits were set in legacy and not in upstream code, and are apparently tested for when writing a config in DP mode FIXME: is this even needed? Signed-off-by: Pierre-Louis Bossart --- sound/x86/intel_hdmi_audio.c | 2 ++ 1 file changed, 2 insertions(+)

[Intel-gfx] [RFC PATCH 2/5] ALSA: x86: intel_hdmi: add definitions and logic for DP audio

Imported from legacy patches Note: the new code doesn't assume a modified ELD but an explicit notification that DP is present. It appears that the i915 code does change the ELD so we could use the ELD-based tests to check for DP audio Signed-off-by: Pierre-Louis Bossart

[Intel-gfx] [PATCH v2 03/14] drm/i915: s/get_display_clock_speed/get_cdclk/

From: Ville Syrjälä Rename the .get_display_clock_speed() hook to .get_cdclk(). .get_cdclk() is more specific (which clock) and it's much shorter. v2: Deal with IS_GEN9_BC() Signed-off-by: Ville Syrjälä Reviewed-by: Ander Conselvan

[Intel-gfx] [PATCH] drm/i915: make i915_stolen_to_physical() return phys_addr_t

The i915_stolen_to_physical() function has 'unsigned long' as its return type but it returns the 'base' variable, which is of type 'u32'. The only place where this function is called assigns the returned value to dev_priv->mm.stolen_base, which is of type 'phys_addr_t'. The return value is

Re: [Intel-gfx] [PATCH v2 9/9] drm/dp: Track MST link bandwidth

On Wed, Jan 25, 2017 at 09:00:02PM +, Pandiyan, Dhinakaran wrote: > On Wed, 2017-01-25 at 07:15 +0100, Daniel Vetter wrote: > > On Tue, Jan 24, 2017 at 03:49:37PM -0800, Dhinakaran Pandiyan wrote: > > > Use the added helpers to track MST link bandwidth for atomic modesets. > > > Link bw is

[Intel-gfx] [PATCH v2] drm/i915/glk: Turn on workarounds that apply to Geminilake too

Apply workarounds to Geminilake, and annotate those that are applied unconditionally when they apply to GLK based on the workaround database. v2: Fix commit message typos. (David) Cc: David Weinehall Cc: Rodrigo Vivi Signed-off-by: Ander

Re: [Intel-gfx] [bug report] drm/i915/gvt/kvmgt: add vfio/mdev support to KVMGT

On Thu, Jan 26, 2017 at 03:21:06PM +0800, Jike Song wrote: > Curious what static checker do you use? I actually checked it with sparse but > this was not reported. It's some unreleased Smatch stuff. It's not really useful except that it's a good stress tester for Smatch to see if it's doing

Re: [Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

On Wed, Jan 25, 2017 at 08:47:09PM +, Pandiyan, Dhinakaran wrote: > On Wed, 2017-01-25 at 06:59 +0100, Daniel Vetter wrote: > > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote: > > > +#define for_each_private_obj(__state, obj, obj_state, __i, __funcs) > > > \ > > > +

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/gvt/kvmgt: remove useless code

== Series Details == Series: drm/i915/gvt/kvmgt: remove useless code URL : https://patchwork.freedesktop.org/series/18581/ State : warning == Summary == Series 18581v1 drm/i915/gvt/kvmgt: remove useless code https://patchwork.freedesktop.org/api/1.0/series/18581/revisions/1/mbox/ Test

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave - More fixes than I'd like at this stage, but I think the holidays and conferences have delayed finding and fixing the stuff a bit. Almost all of them have Fixes: tags, so it's not just random fixes, we can point fingers at the commits that broke stuff. There's an ABI fix to GVT from

Re: [Intel-gfx] [GIT PULL] GVT-g fixes for 4.10-rc5

On Mon, Jan 16, 2017 at 11:34:46AM +0200, Jani Nikula wrote: > On Mon, 16 Jan 2017, Zhenyu Wang wrote: > > Hi, > > > > This pull contains vGPU/mdev reset fixes from Changbin to fix vGPU hang > > for VM reboot and vGPU/mdev instance reuse issues that might impact usage. >

Re: [Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

On Wed, Jan 25, 2017 at 04:33:16PM -0500, Harry Wentland wrote: > On 2017-01-25 12:59 AM, Daniel Vetter wrote: > > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote: > >> +struct drm_private_state_funcs { > > > > I also wonder whether we shouldn't give this a drm_atomic_ prefix

Re: [Intel-gfx] [PATCH v2 8/9] drm/dp: Release DP MST shared link bandwidth

On Wed, Jan 25, 2017 at 08:53:18PM +, Pandiyan, Dhinakaran wrote: > On Wed, 2017-01-25 at 07:16 +0100, Daniel Vetter wrote: > > On Tue, Jan 24, 2017 at 03:49:36PM -0800, Dhinakaran Pandiyan wrote: > > > Implement the ->atomic_release() callback to release the shared link > > > bandwidth that

Re: [Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

On Wed, Jan 25, 2017 at 02:31:08PM +0200, Mika Kuoppala wrote: > Certain Baytrails, namely the 4 cpu core variants, have been > plaqued by spurious system hangs, mostly occurring with light loads. > > Multiple bisects by various people point to a commit which changes the > reclocking strategy for

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround (rev2)

== Series Details == Series: series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround (rev2) URL : https://patchwork.freedesktop.org/series/17904/ State : failure == Summary == CC [M] drivers/gpu/drm/i915/gvt/cfg_space.o CC [M]

Re: [Intel-gfx] [PATCH] drm/i915: Remove early pre-production RPS workarounds for BXT

On Thu, Jan 26, 2017 at 09:30:14AM +0200, Joonas Lahtinen wrote: > On ke, 2017-01-25 at 17:26 +, Chris Wilson wrote: > > Remove WaGsvDisableTurbo and WaRsUseTimeoutMode as these were only for > > pre-production Broxton devices, and this code is now defunct. > > > > Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 1/6] dim: Update docs

- Remove branch overview, instead link to drm-intel and drm-misc pages. - Move quickstart to the top, to make it easier to find. - Make quickstart generic, we use dim for other stuff than drm-intel now. - s/drm-intel-rerere/drm-rerere/ - Remove the section about resolving conflicts, that's

[Intel-gfx] [PATCH 4/6] dim: Add git_is_current_branch helper

And use it everywhere. Found a few more places that don't use the usual style. Signed-off-by: Daniel Vetter --- dim | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/dim b/dim index cf61dc412652..73fb32c4d5ab 100755 --- a/dim +++ b/dim @@

[Intel-gfx] [PATCH 6/6] dim: Don't try to create branches in update_branches

Avoids sprawnling branches everywhere, and makes the script faster for folks who don't need everything. We already skip remotes, so this is in line with what's there. Signed-off-by: Daniel Vetter --- dim | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 3/6] dim: Also allow git urls

Maybe there's only a read-only remote available, and with the drm-misc/-intel split that's perfectly fine. Signed-off-by: Daniel Vetter --- dim | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/dim b/dim index

[Intel-gfx] [PATCH 5/6] dim: Add helper for checking for a branch

And roll it out. Signed-off-by: Daniel Vetter --- dim | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/dim b/dim index 73fb32c4d5ab..c5c46e9c767a 100755 --- a/dim +++ b/dim @@ -307,6 +307,15 @@ function git_is_current_branch #

[Intel-gfx] [PATCH 2/6] dim: don't check everything in dim setup

Laurent got mightily confused about this, and assumed he's getting volunteered as an intel maintainer because dim asks for an intel remote. With the branch autodetection we can postpone all the remote checks to when we need them. This is similar to the changes to update-branches to only update

[Intel-gfx] [PATCH v3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

Apply workarounds to Geminilake, and annotate those that are applied unconditionally when they apply to GLK based on the workaround database. v2: Fix commit message typos. (David) v3: Rebase. Cc: David Weinehall Cc: Rodrigo Vivi

Re: [Intel-gfx] [PATCH 13/15] drm/doc: Fix typos for early_unregister doc

On Wed, Jan 25, 2017 at 07:26:55AM +0100, Daniel Vetter wrote: > There's no late_unregister. While at it switch to the new canonical > reference style. > > Cc: Chris Wilson > Signed-off-by: Daniel Vetter Applied with Chris' irc-ack. -Daniel >

Re: [Intel-gfx] [PATCH 4/4] drm: Resurrect atomic rmfb code, v2

Op 25-01-17 om 19:05 schreef Sinclair Yeh: > On Wed, Jan 25, 2017 at 09:36:36AM +0100, Maarten Lankhorst wrote: >> Op 25-01-17 om 09:09 schreef Thomas Hellstrom: >>> On 01/25/2017 05:54 AM, Daniel Vetter wrote: On Tue, Jan 24, 2017 at 01:44:54PM -0800, Matt Roper wrote: > On Wed, Jan 11,

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: setup bridge for HDMI LPE audio driver

On Tue, Jan 24, 2017 at 03:25:14PM +0200, Jani Nikula wrote: > On Wed, 25 Jan 2017, Jerome Anand wrote: > > Enable support for HDMI LPE audio mode on Baytrail and > > Cherrytrail when HDaudio controller is not detected > > > > Setup minimum required resources during

[Intel-gfx] [PULL] drm-intel-next

Hi Dave, drm-intel-next-2017-01-23: Final block of feature work for 4.11: - gen8 pd cleanup from Matthew Auld - more cleanups for view/vma (Chris) - dmc support on glk (Anusha Srivatsa) - use core crc api (Tomue) - track wedged requests using fence.error (Chris) - lots of psr fixes (Nagaraju,

Re: [Intel-gfx] [PATCH 14/15] drm: s/drm_crtc_get_hv_timings/drm_mode_get_hv_timings/

On Wed, Jan 25, 2017 at 12:31:44PM -0500, Alex Deucher wrote: > On Wed, Jan 25, 2017 at 1:26 AM, Daniel Vetter wrote: > > The function operates on modes, not CRTCs. Also move it into > > drm_modes.[hc]. Spotted while reviewing CRTC docs. > > > > Signed-off-by: Daniel

  1   2   >