Re: [Intel-gfx] [PATCH] drm/i915/cnl: WA FtrEnableFastAnisoL1BankingFix

2017-09-05 Thread Oscar Mateo
On 08/29/2017 04:07 PM, Rodrigo Vivi wrote: WA to enable HW L1 Banking fix that allows aniso to operate at full sample rate. Cc: Mika Kuoppala Cc: Oscar Mateo Cc: Ben Widawsky Cc: Anuj Phogat

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/cnl: WaFbcSkipSegments (rev3)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaFbcSkipSegments (rev3) URL : https://patchwork.freedesktop.org/series/29507/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-rgb101010-draw-mmap-gtt: pass -> SKIP (shard-hsw)

[Intel-gfx] [GIT PULL] gvt fix for 4.14-rc1

2017-09-05 Thread Zhenyu Wang
Hi, here's one regression fix for 4.14-rc1 which made gvt init failed with latest linus master. Thanks. -- The following changes since commit a42894ebb50d831ec0b7ee9bee7f5a5a37bad7e1: drm/i915: Update DRIVER_DATE to 20170818 (2017-08-18 22:40:45 +0200) are available in the git repository at:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: WaFbcSkipSegments (rev4)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaFbcSkipSegments (rev4) URL : https://patchwork.freedesktop.org/series/29507/ State : success == Summary == Series 29507v4 drm/i915/cnl: WaFbcSkipSegments https://patchwork.freedesktop.org/api/1.0/series/29507/revisions/4/mbox/ Test

[Intel-gfx] [PATCH] drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk

2017-09-05 Thread Rodrigo Vivi
Skip compressing 1 segment at the end of the frame, avoid a pixel count mismatch nuke event when last active pixel and dummy pixel has same color for Odd Plane Width / Height. For both platforms Gemini Lake and Cannon Lake. v2: Use function-like macro and also use mask to clean to make sure

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Disable snooping (userptr, set-cache-level) on gen4

2017-09-05 Thread Chris Wilson
Quoting Ville Syrjälä (2017-09-05 20:01:03) > On Tue, Sep 05, 2017 at 02:47:35PM +0100, Chris Wilson wrote: > > The original gen4 has an issue where writes (both render and blt) into > > snoopable pages are lost. > > BTW is this documented somewhere, or just folk lore? I only found bspec > notes

Re: [Intel-gfx] [PATCH i-g-t] build: Define _GNU_SOURCE in Makefile.am

2017-09-05 Thread Chris Wilson
Quoting Daniel Vetter (2017-09-05 17:19:45) > In meson I want to just set this everywhere (no reason not to), and > doing so will allow us to clean up a few things. If we are keeping config.h in meson, why move -D_GNU_SOURCE to the commandline, surely the fix is that those files not including

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/4] drm/i915: Factor out setup_private_pat()

2017-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Factor out setup_private_pat() URL : https://patchwork.freedesktop.org/series/29843/ State : warning == Summary == Series 29843v1 series starting with [1/4] drm/i915: Factor out setup_private_pat()

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Re-enable GTT following a device reset

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915: Re-enable GTT following a device reset URL : https://patchwork.freedesktop.org/series/29845/ State : success == Summary == Series 29845v1 drm/i915: Re-enable GTT following a device reset

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Add support slice/subslice/eu configs

2017-09-05 Thread Oscar Mateo
On 08/31/2017 04:59 PM, Rodrigo Vivi wrote: From: Ben Widawsky Cannonlake Slice and Subslice information has changed. This Patch provided by Ben adds the proper sseu initialization. v2: This v2 done by Rodrigo includes: - Fix on Total slices count by avoiding [1][2]

Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

2017-09-05 Thread Rodrigo Vivi
On Tue, Sep 05, 2017 at 11:56:11AM +, Saarinen, Jani wrote: > Hi, > > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of Saarinen, Jani > > Sent: perjantai 1. syyskuuta 2017 12.30 > > To: Ville Syrjälä

[Intel-gfx] [PATCH 4/4] drm/i915/selftests: Introduce live tests of private PAT management

2017-09-05 Thread Zhi Wang
Introduce two live tests of private PAT managment: igt_ppat_init - This test is to check if all the PPAT configuration is written into HW. igt_ppat_get - This test performs several sub-tests on intel_ppat_get() and intel_ppat_put(). The "perfect match" test case will try to get a PPAT entry

[Intel-gfx] [PATCH 1/4] drm/i915: Factor out setup_private_pat()

2017-09-05 Thread Zhi Wang
Factor out setup_private_pat() for introducing the following patches. Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Joonas Lahtinen Signed-off-by: Zhi Wang

[Intel-gfx] [PATCH 2/4] drm/i915: Introduce private PAT management

2017-09-05 Thread Zhi Wang
The private PAT management is to support PPAT entry manipulation. Two APIs are introduced for dynamically managing PPAT entries: intel_ppat_get and intel_ppat_put. intel_ppat_get will search for an existing PPAT entry which perfectly matches the required PPAT value. If not, it will try to

[Intel-gfx] [PATCH 3/4] drm/i915: Do not allocate unused PPAT entries

2017-09-05 Thread Zhi Wang
Only PPAT entries 0/2/3/4 are using. Remove extra PPAT entry allocation during initialization. Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Chris Wilson Suggested-by: Joonas Lahtinen

[Intel-gfx] [PATCH] drm/i915: Re-enable GTT following a device reset

2017-09-05 Thread Chris Wilson
Ville Syrjälä spotted that PGETBL_CTL was losing its enable bit upon a reset. That was causing the display to show garbage on his 945gm. On my i915gm the effect was far more severe; re-enabling the display following the reset without PGETBL_CTL being enabled lead to an immediate hard hang. We do

Re: [Intel-gfx] [PATCH] drm/atomic: Move drm_crtc_commit to drm_crtc_state, v4.

2017-09-05 Thread Daniel Vetter
On Mon, Sep 04, 2017 at 05:04:56PM +0200, Maarten Lankhorst wrote: > Most code only cares about the current commit or previous commit. > Fortuantely we already have a place to track those. Move it to > drm_crtc_state where it belongs. :) > > The per-crtc commit_list is kept for places where we

Re: [Intel-gfx] [PATCH 0/4] RFC: drm: Allow driver-specific ioctls to be registered

2017-09-05 Thread Daniel Vetter
On Mon, Sep 04, 2017 at 07:06:54PM +0300, marius vlad wrote: > There isn't any dark plot behind it. > > For instance, in our use case, a DPU (Display Process Unit) which has a > blit feature (using DRM_RENDER_ALLOW) can be implemented cleanly > in a separate driver and not being dependent on the

[Intel-gfx] [PATCH i-g-t] Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT"

2017-09-05 Thread Daniel Vetter
This reverts commit effb78b382895c19d0946c217cee3602dcd94c50. cibuglog is for filtering unstable results, we can't simply opt to not test PSR. Signed-off-by: Daniel Vetter --- tests/intel-ci/fast-feedback.testlist | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_flink_basic: Add documentation for subtests

2017-09-05 Thread Belgaumkar, Vinay
On 9/4/2017 1:30 AM, Daniel Vetter wrote: On Thu, Aug 31, 2017 at 02:33:23PM -0700, Vinay Belgaumkar wrote: Added the missing IGT_TEST_DESCRIPTION and some subtest descriptions. Trying to establish a method to document subtests, it should describe the feature being tested rather than how. The

[Intel-gfx] [PATCH 1/2] drm/dp/mst: Sideband message transaction to power up/down nodes

2017-09-05 Thread Dhinakaran Pandiyan
The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions allow the source to reqest any node in a mst path or a whole path to be powered down or up. This allows drivers to target a specific sink in the MST topology, an improvement over just power managing the imediate downstream device.

[Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

2017-09-05 Thread Dhinakaran Pandiyan
Use the POWER_DOWN_PHY and POWER_UP_PHY sideband message trasactions to set power states for downstream sinks. Apart from giving us the ability to set power state for individual sinks, this fixes the below test for me $ xrandr --display :0 --output DP-2-2-8 --off $ xrandr --display :0 --output

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_flink_basic: Add documentation for subtests

2017-09-05 Thread Belgaumkar, Vinay
On 9/1/2017 4:55 AM, Arkadiusz Hiler wrote: On Thu, Aug 31, 2017 at 02:33:23PM -0700, Vinay Belgaumkar wrote: Added the missing IGT_TEST_DESCRIPTION and some subtest descriptions. Trying to establish a method to document Hey Vinay, Please add appropriate tag to the subject, as this is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Re-enable GTT following a device reset

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915: Re-enable GTT following a device reset URL : https://patchwork.freedesktop.org/series/29845/ State : success == Summary == Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#102252 Test kms_fbc_crc:

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/dp/mst: Sideband message transaction to power up/down nodes

2017-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp/mst: Sideband message transaction to power up/down nodes URL : https://patchwork.freedesktop.org/series/29853/ State : warning == Summary == Series 29853v1 series starting with [1/2] drm/dp/mst: Sideband message transaction to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/cnl: WaFbcSkipSegments (rev4)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaFbcSkipSegments (rev4) URL : https://patchwork.freedesktop.org/series/29507/ State : failure == Summary == Test gem_exec_store: Subgroup basic-render: pass -> FAIL (shard-hsw) shard-hswtotal:2265

Re: [Intel-gfx] [PATCH i-g-t v3 7/7] tests/kms_ccs: Test case for wrong aux buffer stripe size

2017-09-05 Thread Daniel Stone
Hi Gabriel, On 31 August 2017 at 07:18, Gabriel Krisman Bertazi wrote: > Two scenarios tested: > - unaligned stripe > - Stripe too small 'stride' in the commit message please. ;) But it is fine everywhere through the code. > @@ -323,7 +326,14 @@ static void

Re: [Intel-gfx] [PATCH v2 4/7] tests/kms_ccs: Test case where the CCS buffer was not provided

2017-09-05 Thread Daniel Stone
Hi Gabriel, On 31 August 2017 at 06:58, Gabriel Krisman Bertazi wrote: > @@ -321,16 +325,19 @@ static void generate_fb(data_t *data, struct igt_fb *fb, > size[1] = f.pitches[1] * ALIGN(ccs_height, 32); > > f.handles[0] =

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixed16.16 wrapper cleanup & wm optimization (rev7)

2017-09-05 Thread Patchwork
== Series Details == Series: Fixed16.16 wrapper cleanup & wm optimization (rev7) URL : https://patchwork.freedesktop.org/series/25692/ State : success == Summary == Series 25692v7 Fixed16.16 wrapper cleanup & wm optimization

Re: [Intel-gfx] [PATCH 06/23] drm/i915: introduce page_size members

2017-09-05 Thread Joonas Lahtinen
On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote: > In preparation for supporting huge gtt pages for the ppgtt, we introduce > page size members for gem objects. We fill in the page sizes by > scanning the sg table. > > v2: pass the sg_mask to set_pages > > v3: calculate the sg_mask inline

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

2017-09-05 Thread Shankar, Uma
>-Original Message- >From: Kahola, Mika >Sent: Tuesday, September 5, 2017 2:03 PM >To: Ville Syrjälä >Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma >Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT"

2017-09-05 Thread Patchwork
== Series Details == Series: Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT" URL : https://patchwork.freedesktop.org/series/29805/ State : success == Summary == IGT patchset tested on top of latest successful build 490b386ae36d393cdea514882a2437c6e964c13f scripts/run-tests.sh:

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT"

2017-09-05 Thread Patchwork
== Series Details == Series: Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT" URL : https://patchwork.freedesktop.org/series/29805/ State : failure == Summary == Test perf: Subgroup polling: pass -> FAIL (shard-hsw) fdo#102252 Test kms_flip:

Re: [Intel-gfx] [PATCH v2 6/7] tests/kms_ccs: Test case where CCS is on a different BO

2017-09-05 Thread Daniel Stone
Hi Gabriel, On 31 August 2017 at 06:58, Gabriel Krisman Bertazi wrote: > + if (data->flags & TEST_BAD_CCS_HANDLE) { > + /* Put the CCS buffer on a different BO. */ > + f.handles[0] = gem_create(data->drm_fd,

Re: [Intel-gfx] [PATCH v2 5/7] tests/kms_ccs: Test case where CCS and main buffer overlaps

2017-09-05 Thread Daniel Stone
On 31 August 2017 at 06:58, Gabriel Krisman Bertazi wrote: > @@ -321,7 +322,13 @@ static void generate_fb(data_t *data, struct igt_fb *fb, > int ccs_height = ALIGN(height, 16) / 16; > f.pitches[1] = ALIGN(ccs_width * 1, 128); >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

2017-09-05 Thread Mika Kahola
On Mon, 2017-09-04 at 18:04 +0300, Ville Syrjälä wrote: > On Mon, Sep 04, 2017 at 10:59:32AM +0300, Mika Kahola wrote: > > > > On Fri, 2017-09-01 at 16:43 +0300, Ville Syrjälä wrote: > > > > > > On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote: > > > > > > > > > > > > According to

Re: [Intel-gfx] [PATCH i-g-t] Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT"

2017-09-05 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Daniel Vetter > Sent: tiistai 5. syyskuuta 2017 9.39 > To: Intel Graphics Development > Cc: Daniel Vetter ; Vetter, Daniel

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fail addfb ioctl if color and CCS buffers overlap

2017-09-05 Thread Daniel Stone
Hi Ville, On 4 September 2017 at 17:37, Ville Syrjälä wrote: > On Thu, Aug 31, 2017 at 04:52:15PM -0300, Gabriel Krisman Bertazi wrote: >> With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset >> succeeds. > > I don't think we actually want to

Re: [Intel-gfx] [PATCH i-g-t] Revert "intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT"

2017-09-05 Thread Petri Latvala
On Tue, Sep 05, 2017 at 08:39:00AM +0200, Daniel Vetter wrote: > This reverts commit effb78b382895c19d0946c217cee3602dcd94c50. > > cibuglog is for filtering unstable results, we can't simply opt to not > test PSR. > > Signed-off-by: Daniel Vetter Acked-by: Petri

[Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"

2017-09-05 Thread Vidya Srinivas
From: Uma Shankar This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282. Disable device ready before shutdown command was added previously to avoid a split screen issue seen on dual link DSI panels. As of now, dual link is not supported and will need some rework in

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Fix GuC HW/SW state cleanup in unload path

2017-09-05 Thread Michał Winiarski
On Fri, Sep 01, 2017 at 11:02:11AM +0530, Sagar Arun Kamble wrote: > Teardown of GuC HW/SW state was not properly done in unload path. > During unload, we can rely on intel_guc_reset_prepare being done > as part of i915_gem_suspend for disabling GuC interfaces. > We will have to disable GuC

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

2017-09-05 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, September 5, 2017 6:46 PM >To: Shankar, Uma >Cc: Kahola, Mika ; Srinivas, Vidya >; intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Silence atomic update failure with DSI panel

2017-09-05 Thread Daniel Vetter
On Tue, Sep 05, 2017 at 04:35:04PM +0300, Mika Kahola wrote: > It appears that we cannot trust scanline counters when MIPI/DSI display is > connected. In CI system this appears as flickering errors that randomly > appear in test cases. To avoid this flickering, let's just silence atomic > update

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's

2017-09-05 Thread Ville Syrjälä
On Tue, Sep 05, 2017 at 02:55:31PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Tuesday, September 5, 2017 6:46 PM > >To: Shankar, Uma > >Cc: Kahola, Mika ;

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Speed up DMC firmware loading (rev4)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915: Speed up DMC firmware loading (rev4) URL : https://patchwork.freedesktop.org/series/29688/ State : success == Summary == shard-hswtotal:2255 pass:1225 dwarn:0 dfail:0 fail:15 skip:1014 time:9484s == Logs == For more details see:

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/dsi: Silence atomic update failure with DSI panel

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Silence atomic update failure with DSI panel URL : https://patchwork.freedesktop.org/series/29828/ State : warning == Summary == Test kms_flip: Subgroup wf_vblank-vs-modeset: pass -> DMESG-WARN (shard-hsw)

Re: [Intel-gfx] [PATCH i-g-t] intel_l3_parity: More helpful output in case of errors

2017-09-05 Thread Daniel Vetter
On Tue, Sep 05, 2017 at 03:39:49PM +0300, Petri Latvala wrote: > When no action is specified on the command line, print the usage help > text and exit with failure instead of SIGABRT. Fix some typos on the > usage text. > > Keep the abort() call in places where they can only be reached by >

[Intel-gfx] [PATCH i-g-t] build: Define _GNU_SOURCE in Makefile.am

2017-09-05 Thread Daniel Vetter
In meson I want to just set this everywhere (no reason not to), and doing so will allow us to clean up a few things. But that means autofoo needs to follow suit. v2: Rebase. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for RFC: meson build system support (rev3)

2017-09-05 Thread Patchwork
== Series Details == Series: RFC: meson build system support (rev3) URL : https://patchwork.freedesktop.org/series/29823/ State : failure == Summary == IGT patchset build failed on latest successful build 918863f8e3e8f49235fd2e4a36e11f386c06c11c intel_display_poller: Fix truncation of a test

[Intel-gfx] [PATCH i-g-t] demos: remove

2017-09-05 Thread Daniel Vetter
The igt testcase themselves contain plenty of demos, libdrm also contains a bunch of demos, this here just bitrots. So let's remove it. v2: Rebase. v3: Also delete demos/Makefile from configure.ac. This broke clean builds starting with autogen.sh. Signed-off-by: Daniel Vetter

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Move device_info.has_snoop into the static tables

2017-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move device_info.has_snoop into the static tables URL : https://patchwork.freedesktop.org/series/29829/ State : success == Summary == shard-hswtotal:2255 pass:1225 dwarn:0 dfail:0 fail:15 skip:1014 time:9480s ==

Re: [Intel-gfx] [PATCH i-g-t] intel_l3_parity: More helpful output in case of errors

2017-09-05 Thread Ben Widawsky
On 17-09-05 18:16:23, Daniel Vetter wrote: On Tue, Sep 05, 2017 at 03:39:49PM +0300, Petri Latvala wrote: When no action is specified on the command line, print the usage help text and exit with failure instead of SIGABRT. Fix some typos on the usage text. Keep the abort() call in places where

[Intel-gfx] [PATCH i-g-t] demos: remove

2017-09-05 Thread Daniel Vetter
The igt testcase themselves contain plenty of demos, libdrm also contains a bunch of demos, this here just bitrots. So let's remove it. v2: Rebase. Signed-off-by: Daniel Vetter --- Makefile.am | 2 +- demos/.gitignore| 1 - demos/Android.mk

[Intel-gfx] [PATCH i-g-t] tests/igt_command_line.sh: Allow testing individual tests

2017-09-05 Thread Daniel Vetter
meso will use this to run the tests for all testcases in parallel, for great speedup! v2: Fix bugs in the conversion. Oops, I broke the automake build. Signed-off-by: Daniel Vetter --- tests/igt_command_line.sh | 42 -- 1 file

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move device_info.has_snoop into the static tables

2017-09-05 Thread Ville Syrjälä
On Tue, Sep 05, 2017 at 02:47:34PM +0100, Chris Wilson wrote: > Currently we define any !llc machine as using snoop instead. However, > some platforms run into trouble using snoop that we would like to > disable, and to do so easily we want to be able to use the static > device_info tables. > >

[Intel-gfx] [PATCH] drm/i915/cnl: WaFbcSkipSegments

2017-09-05 Thread Rodrigo Vivi
Skip compressing 1 segment at the end of the frame, avoid a pixel count mismatch nuke event when last active pixel and dummy pixel has same color for Odd Plane Width / Height. v2: Use function-like macro and also use mask to clean to make sure bit 11 is 0. (Suggested by Paulo). Cc: Paulo

[Intel-gfx] [PATCH] drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk

2017-09-05 Thread Rodrigo Vivi
Skip compressing 1 segment at the end of the frame, avoid a pixel count mismatch nuke event when last active pixel and dummy pixel has same color for Odd Plane Width / Height. For both platforms Gemini Lake and Cannon Lake. v2: Use function-like macro and also use mask to clean to make sure

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: WaFbcSkipSegments (rev3)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaFbcSkipSegments (rev3) URL : https://patchwork.freedesktop.org/series/29507/ State : success == Summary == Series 29507v3 drm/i915/cnl: WaFbcSkipSegments https://patchwork.freedesktop.org/api/1.0/series/29507/revisions/3/mbox/ Test

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Constify load detect mode

2017-09-05 Thread Ville Syrjälä
On Mon, May 22, 2017 at 09:42:01AM +0200, Daniel Vetter wrote: > On Thu, May 18, 2017 at 10:38:37PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the mode used for load detection const, and adjust all relevant > > functions to

Re: [Intel-gfx] [PATCH] drm/i915: Annotate user relocs with __user

2017-09-05 Thread Ville Syrjälä
On Fri, Sep 01, 2017 at 07:54:34PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add the missing __user to the urelocs cast to fix the following sparse > warning: > i915_gem_execbuffer.c:1541:47: warning: cast removes address space of >

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Wa 1181: Fix Backlight issue

2017-09-05 Thread Pandiyan, Dhinakaran
On Wed, 2017-08-30 at 21:52 -0700, Rodrigo Vivi wrote: > From: "Vivi, Rodrigo" > > This workaround fixes a CNL PCH bug when changing > backlight from a lower frequency to a higher frequency. > > During random reboot cycles, display backlight seems to > be off/ dim for

[Intel-gfx] [PATCH] drm/i915/cnl: Allow the reg_read ioctl to read the RCS TIMESTAMP register

2017-09-05 Thread Nanley Chery
From: Ben Widawsky This enables the Mesa driver to advertise support for ARB_timer_query, and thus an OpenGL version higher than 3.2. Cc: Rodrigo Vivi Signed-off-by: Nanley Chery ---

Re: [Intel-gfx] [PATCH] drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk

2017-09-05 Thread Paulo Zanoni
Em Ter, 2017-09-05 às 11:05 -0700, Rodrigo Vivi escreveu: > Skip compressing 1 segment at the end of the frame, > avoid a pixel count mismatch nuke event when last active > pixel and dummy pixel has same color for Odd Plane > Width / Height. > > For both platforms Gemini Lake and Cannon Lake. >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Disable snooping (userptr, set-cache-level) on gen4

2017-09-05 Thread Ville Syrjälä
On Tue, Sep 05, 2017 at 02:47:35PM +0100, Chris Wilson wrote: > The original gen4 has an issue where writes (both render and blt) into > snoopable pages are lost. BTW is this documented somewhere, or just folk lore? I only found bspec notes that snooped->snooped and tiled+snooped isn't allowed.

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Allow the reg_read ioctl to read the RCS TIMESTAMP register

2017-09-05 Thread Vivi, Rodrigo
On Tue, 2017-09-05 at 11:45 -0700, Nanley Chery wrote: > From: Ben Widawsky Do we have a signed-off by him? Maybe go with you as author and suggested-by Ben? > > This enables the Mesa driver to advertise support for ARB_timer_query, and > thus an OpenGL version

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/cnl: Allow the reg_read ioctl to read the RCS TIMESTAMP register

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Allow the reg_read ioctl to read the RCS TIMESTAMP register URL : https://patchwork.freedesktop.org/series/29839/ State : failure == Summary == Series 29839v1 drm/i915/cnl: Allow the reg_read ioctl to read the RCS TIMESTAMP register

[Intel-gfx] [PATCH] drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk

2017-09-05 Thread Rodrigo Vivi
Skip compressing 1 segment at the end of the frame, avoid a pixel count mismatch nuke event when last active pixel and dummy pixel has same color for Odd Plane Width / Height. For both platforms Gemini Lake and Cannon Lake. v2: Use function-like macro and also use mask to clean to make sure

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Wa 1181: Fix Backlight issue

2017-09-05 Thread Rodrigo Vivi
On Tue, Sep 5, 2017 at 11:42 AM, Pandiyan, Dhinakaran wrote: > On Wed, 2017-08-30 at 21:52 -0700, Rodrigo Vivi wrote: >> From: "Vivi, Rodrigo" >> >> This workaround fixes a CNL PCH bug when changing >> backlight from a lower frequency to a

Re: [Intel-gfx] [PATCH] drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk

2017-09-05 Thread Paulo Zanoni
Em Ter, 2017-09-05 às 12:07 -0700, Rodrigo Vivi escreveu: > Skip compressing 1 segment at the end of the frame, > avoid a pixel count mismatch nuke event when last active > pixel and dummy pixel has same color for Odd Plane > Width / Height. > > For both platforms Gemini Lake and Cannon Lake. >

Re: [Intel-gfx] [PATCH v4] drm/i915: Speed up DMC firmware loading

2017-09-05 Thread David Weinehall
On Tue, Sep 05, 2017 at 02:25:36PM +0100, Chris Wilson wrote: > Quoting David Weinehall (2017-09-05 14:10:50) > > Currently we're doing: > > > > 1. acquire lock > > 2. write word to hardware > > 3. release lock > > 4. repeat from 1 > > > > to load the DMC firmware. Due to the cost of

Re: [Intel-gfx] [PATCH] drm/i915: Try harder to finish the idle-worker

2017-09-05 Thread Tejun Heo
On Mon, Sep 04, 2017 at 10:35:49AM +0200, Daniel Vetter wrote: > On Fri, Sep 01, 2017 at 03:11:23PM +0100, Chris Wilson wrote: > > If a worker requeues itself, it may switch to a different kworker pool, > > which flush_work() considers as complete. To be strict, we then need to > > keep flushing

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Speed up DMC firmware loading (rev4)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915: Speed up DMC firmware loading (rev4) URL : https://patchwork.freedesktop.org/series/29688/ State : success == Summary == Series 29688v4 drm/i915: Speed up DMC firmware loading https://patchwork.freedesktop.org/api/1.0/series/29688/revisions/4/mbox/ Test

[Intel-gfx] [PATCH] drm/i915/dsi: Silence atomic update failure with DSI panel

2017-09-05 Thread Mika Kahola
It appears that we cannot trust scanline counters when MIPI/DSI display is connected. In CI system this appears as flickering errors that randomly appear in test cases. To avoid this flickering, let's just silence atomic update failure in case with DSI panel. Bugzilla:

Re: [Intel-gfx] [PATCH] drm/i915: Try harder to finish the idle-worker

2017-09-05 Thread Chris Wilson
Quoting Tejun Heo (2017-09-05 14:36:28) > On Mon, Sep 04, 2017 at 10:35:49AM +0200, Daniel Vetter wrote: > > On Fri, Sep 01, 2017 at 03:11:23PM +0100, Chris Wilson wrote: > > > If a worker requeues itself, it may switch to a different kworker pool, > > > which flush_work() considers as complete.

[Intel-gfx] [PATCH 1/2] drm/i915: Move device_info.has_snoop into the static tables

2017-09-05 Thread Chris Wilson
Currently we define any !llc machine as using snoop instead. However, some platforms run into trouble using snoop that we would like to disable, and to do so easily we want to be able to use the static device_info tables. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 2/2] drm/i915: Disable snooping (userptr, set-cache-level) on gen4

2017-09-05 Thread Chris Wilson
The original gen4 has an issue where writes (both render and blt) into snoopable pages are lost. We've previously worked around this in userspace (ddx, igt) by simply not requesting snoopable buffers, but upon rediscovering this problem for a third time, make the kernel reject such requests with

Re: [Intel-gfx] [PATCH] drm/i915: Try harder to finish the idle-worker

2017-09-05 Thread Tejun Heo
Hello, On Tue, Sep 05, 2017 at 02:43:14PM +0100, Chris Wilson wrote: > > Can't you use cancel[_delayed]_work_sync()? > > We then need a loop like: > > do { > if (cancel_delayed_work_sync(wrk)) > do_work(wrk); > else >

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable per-engine reset for Broxton

2017-09-05 Thread Chris Wilson
Quoting Chris Wilson (2017-08-21 15:55:34) > Quoting Michel Thierry (2017-08-18 18:23:42) > > The corruption in CSB mmio reads we were seeing has been tracked down to > > incorrectly touching forcewake of all domains, following an engine reset. > > It is still a mistery why we only catched this in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Silence atomic update failure with DSI panel

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Silence atomic update failure with DSI panel URL : https://patchwork.freedesktop.org/series/29828/ State : success == Summary == Series 29828v1 drm/i915/dsi: Silence atomic update failure with DSI panel

Re: [Intel-gfx] [PATCH i-g-t 1/3] Use PATH_MAX to fix some sprintf-into-short-buffers warnings.

2017-09-05 Thread Daniel Vetter
On Mon, Sep 04, 2017 at 10:49:46AM +0200, Daniel Vetter wrote: > On Sat, Sep 02, 2017 at 09:38:51PM -0700, Eric Anholt wrote: > > Signed-off-by: Eric Anholt > > --- > > > > This little series cleans up many compiler warnings I saw when testing > > danvet's meson branch. > > On

Re: [Intel-gfx] [PATCH] drm/i915/edp: Increase T12 panel delay to 900 ms to fix DP AUX CH timeouts

2017-09-05 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Saarinen, Jani > Sent: perjantai 1. syyskuuta 2017 12.30 > To: Ville Syrjälä ; Navare, Manasi D > > Cc: Sarvela, Tomi P

Re: [Intel-gfx] [PATCH i-g-t] tests/tools_test: check if l3_parity is supported

2017-09-05 Thread Petri Latvala
On Tue, Sep 05, 2017 at 02:52:05PM +0300, Abdiel Janulgue wrote: > This is a wrapper for tools/intel_l3_parity which fails if l3_parity > is not supported in the kernel. Check support before executing test. > > bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650 > Signed-off-by: Abdiel

[Intel-gfx] [PATCH i-g-t 05/22] tests/gem_spin_batch: Fix warning

2017-09-05 Thread Daniel Vetter
Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter --- tests/gem_spin_batch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_spin_batch.c b/tests/gem_spin_batch.c index 941aa1399ae1..09bb3cb37108 100644 ---

[Intel-gfx] [PATCH i-g-t 10/22] demos: remove

2017-09-05 Thread Daniel Vetter
The igt testcase themselves contain plenty of demos, libdrm also contains a bunch of demos, this here just bitrots. So let's remove it. Signed-off-by: Daniel Vetter --- Makefile.am | 2 +- demos/.gitignore| 1 - demos/Android.mk| 32 --

[Intel-gfx] [PATCH i-g-t 11/22] assembler/test: Prep work for meson

2017-09-05 Thread Daniel Vetter
Again we want to be able to run each testcase individually. Also, we need to make sure the target directory for the temp files exists - meson always builds with a build-dir outside of the source tree. Signed-off-by: Daniel Vetter --- assembler/test/run-test.sh | 16

[Intel-gfx] [PATCH i-g-t 09/22] lib/uwildmat: Use include paths

2017-09-05 Thread Daniel Vetter
meson runs gcc from where meson.build that includes those files is, which means we need to add the directory ourselves. For automake it doesn't matter, so let's just do it for simplicity. Signed-off-by: Daniel Vetter --- lib/uwildmat/uwildmat.c | 2 +- 1 file changed,

[Intel-gfx] [PATCH i-g-t 06/22] lib: prefix frame_dump_path

2017-09-05 Thread Daniel Vetter
Just a bit of ocd for anything non-static. Signed-off-by: Daniel Vetter --- lib/igt_core.c | 12 ++-- lib/igt_core.h | 2 +- lib/igt_frame.c | 10 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index

[Intel-gfx] [PATCH i-g-t 07/22] lib: clean up header includes

2017-09-05 Thread Daniel Vetter
Just a bit of OCD, I like it when connections within library modules are a bit more obvious. igt.h is ok for tests, but let's use individual include lines for libraries consistently. Also order standard includes before igt ones. Signed-off-by: Daniel Vetter ---

[Intel-gfx] [PATCH i-g-t 13/22] lib/ioctl_wrappers: make the valgrind wrapper always emit a statement:w

2017-09-05 Thread Daniel Vetter
gcc complains otherwise about empty ; statements ... Signed-off-by: Daniel Vetter --- lib/ioctl_wrappers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index b4d6210d5942..48750427a0c1 100644 ---

[Intel-gfx] [PATCH i-g-t 15/22] meson: Add some compiler flags to reduce warnings.

2017-09-05 Thread Daniel Vetter
From: Eric Anholt These warnings are apparently new compared to the autotools build. We can fix the things they complain about later, if we want. Signed-off-by: Eric Anholt Signed-off-by: Daniel Vetter --- meson.build | 11

[Intel-gfx] [PATCH i-g-t 12/22] meson: basic build system support

2017-09-05 Thread Daniel Vetter
Why? Because it's fast. Like really, really fast. Some data (from a snb laptop, so rather lower-powered): - Incremental build after $ touch lib/igt_core.c with meson: 0.6s It notices that the symbol list of the libigt.so hasn't changed and doesn't bother re-linking the almost 300 binaries

[Intel-gfx] [PATCH i-g-t 14/22] tests/kms_plane: Appease gcc -Wempty-body

2017-09-05 Thread Daniel Vetter
Not exactly sure what's the point, but oh well. Signed-off-by: Daniel Vetter --- tests/kms_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 927d5d37fece..812497500d2d 100644 --- a/tests/kms_plane.c

[Intel-gfx] [PATCH i-g-t 00/22] RFC: meson build system support

2017-09-05 Thread Daniel Vetter
Hi all, Ok, this time around a proper patch series with cover letter and a pile of fixes (bunch of them thanks to Eric) thrown on top. The motivation for this has 2 primary reasons: - I want a build system that's fast, especially for hacking on the library. Currently with over 300 binaries

[Intel-gfx] [PATCH i-g-t 03/22] build: use HAVE_LIBGEN_H consistently

2017-09-05 Thread Daniel Vetter
Also, we are _GNU_SOURCE, so simplify the conditions accordingly. The next patch will remove _GNU_SOURCE everywhere else. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter --- lib/drmtest.c| 4 +--- lib/igt_aux.c| 4 +---

[Intel-gfx] [PATCH i-g-t 02/22] build: Nuke #ifdef HAVE_CONFIG_H cargo-cult

2017-09-05 Thread Daniel Vetter
We have it. Daniel Stone said the #ifdef HAVE_CONFIG_H comes from the X11 transition to the modular build, where in the imake -> modular build transition config.h wasn't universally available. Now we just make this a requirement (so yeah Android better generate one too). v2: Improve commit

[Intel-gfx] [PATCH i-g-t 01/22] build: Define _GNU_SOURCE in Makefile.am

2017-09-05 Thread Daniel Vetter
In meson I want to just set this everywhere (no reason not to), and doing so will allow us to clean up a few things. But that means autofoo needs to follow suit. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter --- benchmarks/Makefile.am | 2 +-

[Intel-gfx] [PATCH i-g-t 04/22] build: remove _GNU_SOURCE from source files

2017-09-05 Thread Daniel Vetter
We are, the build system takes care of that. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter --- benchmarks/gem_exec_tracer.c | 2 -- benchmarks/gem_latency.c | 1 - benchmarks/gem_syslatency.c| 2 -- lib/igt_fb.c | 1

[Intel-gfx] [PATCH i-g-t 08/22] tests/igt_command_line.sh: Allow testing individual tests

2017-09-05 Thread Daniel Vetter
meso will use this to run the tests for all testcases in parallel, for great speedup! Signed-off-by: Daniel Vetter --- tests/igt_command_line.sh | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t 18/22] meson: detect cc flags

2017-09-05 Thread Daniel Vetter
Somehow my gcc has a different idea of what no-implicit-fallthrough should look like than the one Eric used. fixup compiler flags Signed-off-by: Daniel Vetter --- meson.build | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command (rev2)

2017-09-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Fix error on DSI video mode command (rev2) URL : https://patchwork.freedesktop.org/series/29658/ State : success == Summary == Series 29658v2 drm/i915/dsi: Fix error on DSI video mode command

  1   2   >