Re: [Intel-gfx] [PATCH 0/4] HDCP1.4 implementation enhancement

2018-01-18 Thread Sean Paul
On Wed, Jan 17, 2018 at 9:48 PM, Ramalingam C wrote: > This series extends the HDCP1.4 support for few more intel platforms. > And also addresses few gaps found in the base HDCP1.4 implementation w.r.t > HDCP1.4 specification. > Thanks for the patches, Ram. I've applied

Re: [Intel-gfx] [PATCH 2/4] drm/i915: II stage HDCP auth for repeater only

2018-01-18 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Friday, January 19, 2018 3:54 AM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; seanp...@chromium.org; > daniel.vet...@ffwll.ch; Vivi, Rodrigo ;

Re: [Intel-gfx] [PATCH 3/5] drm/vblank: Do not update vblank count if interrupts are already disabled.

2018-01-18 Thread Rodrigo Vivi
On Fri, Jan 12, 2018 at 09:57:05PM +, Dhinakaran Pandiyan wrote: > Updating vblank counts requires register reads and these reads may not > return meaningful values if the device was in a low power state after > vblank interrupts were last disabled. So, update the count only if vblank >

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-18 Thread Maarten Lankhorst
Op 17-01-18 om 19:29 schreef Sean Paul: > On Wed, Jan 17, 2018 at 12:51:08PM +0100, Maarten Lankhorst wrote: >> From: "Leo (Sunpeng) Li" >> >> During a non-blocking commit, it is possible to return before the >> commit_tail work is queued (-ERESTARTSYS, for example). >> >>

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites

2018-01-18 Thread Ville Syrjälä
On Wed, Jan 10, 2018 at 01:59:44PM +0100, Daniel Vetter wrote: > On Fri, Dec 22, 2017 at 09:22:26PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Y/Yf were dropped out from the SKL+ sprite modifier list on account > > of some watermark issues Daniel

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Add tracking for CDCLK bypass frequency

2018-01-18 Thread Patchwork
== Series Details == Series: drm/i915: Add tracking for CDCLK bypass frequency URL : https://patchwork.freedesktop.org/series/36636/ State : warning == Summary == Test kms_flip: Subgroup 2x-dpms-vs-vblank-race: pass -> DMESG-WARN (shard-hsw) Test

[Intel-gfx] [PATCH v6 02/99] page cache: Use xa_lock

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Remove the address_space ->tree_lock and use the xa_lock newly added to the radix_tree_root. Rename the address_space ->page_tree to ->pages, since we don't really care that it's a tree. Take the opportunity to rearrange the elements of

[Intel-gfx] [PATCH v6 19/99] idr: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox The IDR distinguishes between unallocated entries (read as NULL) and entries where the user has chosen to store NULL. The radix tree was modified to consider NULL entries which had tag 0 _clear_ as being allocated, but it added a lot of complexity.

[Intel-gfx] [PATCH v6 86/99] btrfs: Convert reada_zones to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox The use of the reada_lock means we have to use the xa_reserve() API. If we can avoid using reada_lock to protect this xarray, we can drop the use of that function. Signed-off-by: Matthew Wilcox --- fs/btrfs/reada.c | 54

[Intel-gfx] [PATCH v6 53/99] fs: Convert writeback to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox A couple of short loops. Signed-off-by: Matthew Wilcox --- fs/fs-writeback.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index

[Intel-gfx] [PATCH v6 77/99] fscache: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Removes another user of radix_tree_preload(). Signed-off-by: Matthew Wilcox --- fs/fscache/cookie.c | 6 +- fs/fscache/internal.h | 2 +- fs/fscache/object.c | 2 +- fs/fscache/page.c | 152

[Intel-gfx] [PATCH v6 73/99] xfs: Convert mru cache to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This eliminates a call to radix_tree_preload(). Signed-off-by: Matthew Wilcox --- fs/xfs/xfs_mru_cache.c | 72 +++--- 1 file changed, 33 insertions(+), 39 deletions(-) diff --git

[Intel-gfx] [PATCH v6 38/99] mm: Convert collapse_shmem to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox I found another victim of the radix tree being hard to use. Because there was no call to radix_tree_preload(), khugepaged was allocating radix_tree_nodes using GFP_ATOMIC. I also converted a local_irq_save()/restore() pair to disable()/enable().

[Intel-gfx] [PATCH v6 87/99] btrfs: Convert reada_extents to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Straightforward conversion. Signed-off-by: Matthew Wilcox --- fs/btrfs/reada.c | 32 +--- fs/btrfs/volumes.c | 2 +- fs/btrfs/volumes.h | 2 +- 3 files changed, 19 insertions(+), 17

[Intel-gfx] [PATCH v6 50/99] shmem: Comment fixups

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Remove the last mentions of radix tree from various comments. Signed-off-by: Matthew Wilcox --- mm/shmem.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index

[Intel-gfx] [PATCH v6 83/99] hwspinlock: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox I had to mess with the locking a bit as I converted the code from a mutex to the xa_lock. Signed-off-by: Matthew Wilcox --- drivers/hwspinlock/hwspinlock_core.c | 151 --- 1 file changed, 52

[Intel-gfx] [PATCH v6 69/99] brd: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Convert brd_pages from a radix tree to an XArray. Simpler and smaller code; in particular another user of radix_tree_preload is eliminated. Signed-off-by: Matthew Wilcox --- drivers/block/brd.c | 93

[Intel-gfx] [PATCH v6 63/99] dax: Convert dax_insert_mapping_entry to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Signed-off-by: Matthew Wilcox --- fs/dax.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index e6b25ef112f2..494e8fb7a98f 100644 --- a/fs/dax.c +++ b/fs/dax.c @@

[Intel-gfx] [PATCH v6 29/99] page cache: Convert filemap_range_has_page to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Instead of calling find_get_pages_range() and putting any reference, just use xa_find() to look for a page in the right range. Signed-off-by: Matthew Wilcox --- mm/filemap.c | 9 + 1 file changed, 1 insertion(+), 8

[Intel-gfx] [PATCH v6 26/99] page cache: Convert page cache lookups to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Introduce page_cache_pin() to factor out the common logic between the various lookup routines: find_get_entry find_get_entries find_get_pages_range find_get_pages_contig find_get_pages_range_tag find_get_entries_tag filemap_map_pages By using the

[Intel-gfx] [PATCH v6 58/99] dax: Convert lock_slot to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Signed-off-by: Matthew Wilcox --- fs/dax.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index f3463d93a6ce..8eab0b56f7f9 100644 --- a/fs/dax.c +++ b/fs/dax.c

[Intel-gfx] [PATCH v6 07/99] xarray: Add documentation

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is documentation on how to use the XArray, not details about its internal implementation. Signed-off-by: Matthew Wilcox --- Documentation/core-api/index.rst | 1 + Documentation/core-api/xarray.rst | 361

[Intel-gfx] [PATCH v6 13/99] xarray: Add xa_extract

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This function combines the functionality of radix_tree_gang_lookup() and radix_tree_gang_lookup_tagged(). It extracts entries matching the specified filter into a normal array. Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH v6 23/99] page cache: Add page_cache_range_empty function

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox btrfs has its own custom function for determining whether the page cache has any pages in a particular range. Move this functionality to the page cache, and call it from btrfs. Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH v6 52/99] fs: Convert buffer to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Mostly comment fixes, but one use of __xa_set_tag. Signed-off-by: Matthew Wilcox --- fs/buffer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index

[Intel-gfx] [PATCH v6 12/99] xarray: Add xa_for_each

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This iterator allows the user to efficiently walk a range of the array, executing the loop body once for each entry in that range that matches the filter. This commit also includes xa_find() and xa_find_above() which are helper functions for

[Intel-gfx] [PATCH v6 36/99] mm: Convert page migration to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Signed-off-by: Matthew Wilcox --- mm/migrate.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 75d19904dd9a..7122fec9b075

[Intel-gfx] [PATCH v6 37/99] mm: Convert huge_memory to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Quite a straightforward conversion. Signed-off-by: Matthew Wilcox --- mm/huge_memory.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index

[Intel-gfx] [PATCH v6 99/99] null_blk: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox We can probably avoid the call to xa_reserve() by changing the locking, but I didn't feel confident enough to do that. Signed-off-by: Matthew Wilcox --- drivers/block/null_blk.c | 87

[Intel-gfx] [PATCH v6 90/99] btrfs: Convert delayed_nodes_tree to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Rename it to just 'delayed_nodes' and remove it from the protection of btrfs_root->inode_lock. Signed-off-by: Matthew Wilcox --- fs/btrfs/ctree.h | 8 +++--- fs/btrfs/delayed-inode.c | 65

[Intel-gfx] [PATCH v6 67/99] mm: Convert cgroup writeback to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is a fairly naive conversion, leaving in place the GFP_ATOMIC allocation. By switching the locking around, we could use GFP_KERNEL and probably simplify the error handling. Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH v6 00/99] XArray version 6

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This version of the XArray has no known bugs. I have converted the radix tree test suite entirely over to the XArray and fixed all bugs that it has uncovered. There are additional tests in the test suite for the XArray, so I now claim the XArray has

[Intel-gfx] [PATCH v6 91/99] btrfs: Convert name_cache to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is a very straightforward conversion. The handling of collisions in the namecache could be better handled with an hlist, but that's a patch for another day. Signed-off-by: Matthew Wilcox --- fs/btrfs/send.c | 19

[Intel-gfx] [PATCH v6 62/99] dax: Convert dax_insert_pfn_mkwrite to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Signed-off-by: Matthew Wilcox --- fs/dax.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index b66b8c896ed8..e6b25ef112f2 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1497,21

[Intel-gfx] [PATCH v6 21/99] xarray: Add xa_reserve and xa_release

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This function simply creates a slot in the XArray for users which need to acquire multiple locks before storing their entry in the tree and so cannot use a plain xa_store(). Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH v5] drm/i915/icl: Enhanced execution list support

2018-01-18 Thread Daniele Ceraolo Spurio
From: Thomas Daniel Enhanced Execlists is an upgraded version of execlists which supports up to 8 ports. The lrcs to be submitted are written to a submit queue, which is then loaded on the HW. When writing to the ELSP register, the lrcs are written cyclically in the

[Intel-gfx] [PATCH v6 93/99] f2fs: Convert ino_root to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox I did a fairly major rewrite of __add_ino_entry(); please check carefully. Also, we can remove ino_list unless it's important to write out orphan inodes in the order they were orphaned. It may also make more sense to combine the array of

[Intel-gfx] [PATCH v6 03/99] xarray: Replace exceptional entries

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Introduce xarray value entries to replace the radix tree exceptional entry code. This is a slight change in encoding to allow the use of an extra bit (we can now store BITS_PER_LONG - 1 bits in a value entry). It is also a change in emphasis;

[Intel-gfx] [PATCH v6 08/99] xarray: Add xa_load

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This first function in the XArray API brings with it a lot of support infrastructure. The advanced API is based around the xa_state which is a more capable version of the radix_tree_iter. As the test-suite demonstrates, it is possible to use the

[Intel-gfx] [PATCH v6 49/99] shmem: Convert shmem_partial_swap_usage to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Simpler code because the xarray takes care of things like the limit and dereferencing the slot. Signed-off-by: Matthew Wilcox --- mm/shmem.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff

[Intel-gfx] [PATCH v6 01/99] xarray: Add the xa_lock to the radix_tree_root

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This results in no change in structure size on 64-bit x86 as it fits in the padding between the gfp_t and the void *. Initialising the spinlock requires a name for the benefit of lockdep, so RADIX_TREE_INIT() now needs to know the name of the radix

[Intel-gfx] [PATCH v6 61/99] dax: Convert dax_writeback_one to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Likewise easy Signed-off-by: Matthew Wilcox --- fs/dax.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index 9a30224da4d6..b66b8c896ed8 100644 --- a/fs/dax.c +++

[Intel-gfx] [PATCH v6 57/99] dax: Convert dax_unlock_mapping_entry to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Replace slot_locked() with dax_locked() and inline unlock_slot() into its only caller. Signed-off-by: Matthew Wilcox --- fs/dax.c | 48 1 file changed, 16 insertions(+), 32

[Intel-gfx] [PATCH v6 33/99] mm: Convert add_to_swap_cache to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Combine __add_to_swap_cache and add_to_swap_cache into one function since there is no more need to preload. Signed-off-by: Matthew Wilcox --- mm/swap_state.c | 93 ++--- 1

[Intel-gfx] [PATCH v6 11/99] xarray: Add xa_cmpxchg and xa_insert

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Like cmpxchg(), xa_cmpxchg will only store to the index if the current entry matches the old entry. It returns the current entry, which is usually more useful than the errno returned by radix_tree_insert(). For the users who really only want the

[Intel-gfx] [PATCH v6 27/99] page cache: Convert delete_batch to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Rename the function from page_cache_tree_delete_batch to just page_cache_delete_batch. Signed-off-by: Matthew Wilcox --- mm/filemap.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff

[Intel-gfx] [PATCH v6 96/99] dma-debug: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is an unusual way to use the xarray tags. If any other users come up, we can add an xas_get_tags() / xas_set_tags() API, but until then I don't want to encourage this kind of abuse. Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH v6 66/99] page cache: Finish XArray conversion

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox With no more radix tree API users left, we can drop the GFP flags and use xa_init() instead of INIT_RADIX_TREE(). Signed-off-by: Matthew Wilcox --- fs/inode.c | 2 +- include/linux/fs.h | 2 +- mm/swap_state.c| 2

[Intel-gfx] [PATCH v6 79/99] blk-cgroup: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This call to radix_tree_preload is awkward. At the point of allocation, we're under not only a local lock, but also under the queue lock. So we can't back out, drop the lock and retry the allocation. Replace this preload call with a call to

[Intel-gfx] [PATCH v6 82/99] s390: Convert gmap to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox The three radix trees in gmap are all converted to the XArray. This is another case where the multiple locks held mandates the use of the xa_reserve() API. The gmap_insert_rmap() function is considerably simplified by using the advanced API;

[Intel-gfx] [PATCH v6 71/99] xfs: Convert pag_ici_root to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Rename pag_ici_root to pag_ici_xa and use XArray APIs instead of radix tree APIs. Shorter code, typechecking on tag numbers, better error checking in xfs_reclaim_inode(), and eliminates a call to radix_tree_preload(). Signed-off-by: Matthew Wilcox

[Intel-gfx] [PATCH v6 40/99] pagevec: Use xa_tag_t

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Removes sparse warnings. Signed-off-by: Matthew Wilcox --- fs/btrfs/extent_io.c| 4 ++-- fs/ext4/inode.c | 2 +- fs/f2fs/data.c | 2 +- fs/gfs2/aops.c | 2 +- include/linux/pagevec.h | 8

[Intel-gfx] [PATCH v6 85/99] btrfs: Remove unused spinlock

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox The reada_lock in struct btrfs_device was only initialised, and not actually used. That's good because there's another lock also called reada_lock in the btrfs_fs_info that was quite heavily used. Remove this one. Signed-off-by: Matthew Wilcox

[Intel-gfx] [PATCH v6 35/99] mm: Convert __do_page_cache_readahead to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This one is trivial. Signed-off-by: Matthew Wilcox --- mm/readahead.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/readahead.c b/mm/readahead.c index f64b31b3a84a..66bcaffd47f0 100644 ---

[Intel-gfx] [PATCH v6 55/99] f2fs: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is a straightforward conversion. Signed-off-by: Matthew Wilcox --- fs/f2fs/data.c | 3 +-- fs/f2fs/dir.c| 5 + fs/f2fs/inline.c | 6 +- fs/f2fs/node.c | 10 ++ 4 files changed, 5

[Intel-gfx] [PATCH v6 54/99] nilfs2: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox I'm not 100% convinced that the rewrite of nilfs_copy_back_pages is correct, but it will at least have different bugs from the current version. Signed-off-by: Matthew Wilcox --- fs/nilfs2/btnode.c | 37

[Intel-gfx] [PATCH v6 81/99] i915: Convert handles_vma to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Straightforward conversion. Signed-off-by: Matthew Wilcox --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_context.c | 12 +--- drivers/gpu/drm/i915/i915_gem_context.h

[Intel-gfx] [PATCH v6 74/99] usb: Convert xhci-mem to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox The XArray API is a slightly better fit for xhci_insert_segment_mapping() than the radix tree API was. Signed-off-by: Matthew Wilcox --- drivers/usb/host/xhci-mem.c | 68 +++--

[Intel-gfx] [PATCH v6 59/99] dax: More XArray conversion

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This time, we want to convert get_unlocked_mapping_entry() to use the XArray. That has a ripple effect, causing us to change the waitqueues to hash on the address of the xarray rather than the address of the mapping (functionally equivalent), and

[Intel-gfx] [PATCH v6 64/99] dax: Convert grab_mapping_entry to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Signed-off-by: Matthew Wilcox --- fs/dax.c | 98 +--- 1 file changed, 26 insertions(+), 72 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index

[Intel-gfx] [PATCH v6 70/99] xfs: Convert m_perag_tree to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Getting rid of the m_perag_lock lets us also get rid of the call to radix_tree_preload(). This is a relatively naive conversion; we could improve performance over the radix tree implementation by passing around xa_state pointers instead of indices,

Re: [Intel-gfx] [PULL] gvt-next fixes for 4.16

2018-01-18 Thread Zhenyu Wang
On 2018.01.17 08:03:49 -0800, Rodrigo Vivi wrote: > > dim: ERROR: 0eb582541cfd7a17b6fcf9282c966c0e59efd02f is lacking mandatory > review, aborting > > Is it possible to get someone to quickly review it and fix the original > commit, like last time? > Hi, Rodrigo Zhi has quickly helped to

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-01-18 Thread Sharma, Shashank
Regards Shashank On 1/17/2018 11:57 PM, Ville Syrjälä wrote: On Fri, Jan 05, 2018 at 03:15:29PM +0530, Shashank Sharma wrote: Currently, we are using a bool in CRTC state (state->ycbcr420), to indicate modeset, that the output format is YCBCR 4:2:0. Now in order to support other YCBCR

[Intel-gfx] [PATCH v6 56/99] lustre: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Signed-off-by: Matthew Wilcox --- drivers/staging/lustre/lustre/llite/glimpse.c | 12 +--- drivers/staging/lustre/lustre/mdc/mdc_request.c | 16 2 files changed, 13 insertions(+), 15 deletions(-)

[Intel-gfx] [PATCH v6 17/99] xarray: Add MAINTAINERS entry

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Add myself as XArray and IDR maintainer. Signed-off-by: Matthew Wilcox --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 18994806e441..55ae4c0b38d5 100644 ---

[Intel-gfx] [PATCH v6 65/99] dax: Fix sparse warning

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox sparse doesn't know that follow_pte_pmd() conditionally acquires the ptl, because it's in a separate compilation unit. Move follow_pte_pmd() to mm.h where sparse can see it. Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH 4/4] drm/i915: Check for downstream topology errors

2018-01-18 Thread Ramalingam C
HDCP compliant Repeaters can support max of 127 devices and max depth of 7 for downstream topology. If these max limits are exceeded, repeater will set the topology error flags MAX_CASCADE_EXCEEDED and/or MAX_DEVS_EXCEEDED in Bstatus followed by asserting READY/CP_IRQ for HDCP transmitter. This

[Intel-gfx] [PATCH v6 05/99] xarray: Add definition of struct xarray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is a direct replacement for struct radix_tree_root. Some of the struct members have changed name; convert those, and use a #define so that radix_tree users continue to work without change. Signed-off-by: Matthew Wilcox

[Intel-gfx] [PATCH v6 04/99] xarray: Change definition of sibling entries

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Instead of storing a pointer to the slot containing the canonical entry, store the offset of the slot. Produces slightly more efficient code (~300 bytes) and simplifies the implementation. Signed-off-by: Matthew Wilcox ---

[Intel-gfx] [PATCH 5/5] drm/i915: Track whether the DP link is trained or not

2018-01-18 Thread Ville Syrjala
From: Ville Syrjälä LSPCON likes to throw short HPDs during the enable seqeunce prior to the link being trained. These obviously result in the channel CR/EQ check failing and thus we schedule a pointless hotplug work to retrain the link. Avoid that by ignoring the

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-18 Thread Sean Paul
On Wed, Jan 17, 2018 at 10:39 AM, Maarten Lankhorst wrote: > Op 17-01-18 om 19:29 schreef Sean Paul: >> On Wed, Jan 17, 2018 at 12:51:08PM +0100, Maarten Lankhorst wrote: >>> From: "Leo (Sunpeng) Li" >>> >>> During a non-blocking commit, it

[Intel-gfx] [PATCH 1/5] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook

2018-01-18 Thread Ville Syrjala
From: Ville Syrjälä Allow encoders to customize their hotplug processing by moving the intel_hpd_irq_event() code into an encoder hotplug vfunc. Currently only SDVO needs this to re-enable hotplug signalling in the SDVO chip. We'll use this same hook for DP/HDMI

[Intel-gfx] [PATCH v6 15/99] xarray: Add xas_next and xas_prev

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox These two functions move the xas index by one position, and adjust the rest of the iterator state to match it. This is more efficient than calling xas_set() as it keeps the iterator at the leaves of the tree instead of walking the iterator from the

[Intel-gfx] [PATCH v6 16/99] xarray: Add xas_create_range

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This hopefully temporary function is useful for users who have not yet been converted to multi-index entries. Signed-off-by: Matthew Wilcox --- include/linux/xarray.h | 2 ++ lib/xarray.c | 22

[Intel-gfx] [PATCH v6 09/99] xarray: Add xa_get_tag, xa_set_tag and xa_clear_tag

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox XArray tags are slightly more strongly typed than the radix tree tags, but occupy the same bits. This commit also adds the xas_ family of tag operations, for cases where the caller is already holding the lock, and xa_tagged() to ask whether any array

[Intel-gfx] [PATCH v6 39/99] mm: Convert khugepaged_scan_shmem to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Slightly shorter and easier to read code. Signed-off-by: Matthew Wilcox --- mm/khugepaged.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index

[Intel-gfx] [PATCH v6 42/99] shmem: Convert shmem_confirm_swap to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox xa_load has its own RCU locking, so we can eliminate it here. Signed-off-by: Matthew Wilcox --- mm/shmem.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index

[Intel-gfx] [PATCH v6 48/99] shmem: Convert shmem_free_swap to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is a perfect use for xa_cmpxchg(). Note the use of 0 for GFP flags; we won't be allocating memory. Signed-off-by: Matthew Wilcox --- mm/shmem.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH v6 14/99] xarray: Add xa_destroy

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This function frees all the internal memory allocated to the xarray and reinitialises it to be empty. Signed-off-by: Matthew Wilcox --- include/linux/xarray.h | 1 + lib/xarray.c | 26 ++ 2

[Intel-gfx] [PATCH v6 43/99] shmem: Convert find_swap_entry to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is a 1:1 conversion. Signed-off-by: Matthew Wilcox --- mm/shmem.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 654f367aca90..ce285ae635ea

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Only attempt to scan the requested number of shrinker slabs

2018-01-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-17 10:29:51) > > On 15/01/2018 21:24, Chris Wilson wrote: > > Since commit 4e773c3a8a69 ("drm/i915: Wire up shrinkctl->nr_scanned"), > > Sounds like it deserves this in the Fixes: tag as well? Not really, the commit maintained the old behaviour just missing an

Re: [Intel-gfx] [PATCH v2] drm/i915: Use the engine name directly in the error_state file

2018-01-18 Thread Michel Thierry
On 17/01/18 07:15, Chris Wilson wrote: Quoting Michel Thierry (2018-01-16 18:33:32) On 1/15/2018 9:15 AM, Tvrtko Ursulin wrote: On 10/01/2018 01:21, Michel Thierry wrote: Instead of using local string names that we will have to keep maintaining, use the engine->name directly. v2: Better

Re: [Intel-gfx] [PATCH v3 2/7] drm/i915: Add CRTC output format YCBCR 4:4:4

2018-01-18 Thread Sharma, Shashank
Regards Shashank On 1/17/2018 11:57 PM, Ville Syrjälä wrote: On Fri, Jan 05, 2018 at 03:15:30PM +0530, Shashank Sharma wrote: This patch adds support for YCBCR 4:4:4 CRTC output format. To do this, this patch extends the existing YCBCR 4:2:0 framework by: - Adding new parameter in for YCBCR

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook

2018-01-18 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook URL : https://patchwork.freedesktop.org/series/36645/ State : success == Summary == Series 36645v1 series starting with [1/5] drm/i915: Convert intel_hpd_irq_event()

[Intel-gfx] ✗ Fi.CI.BAT: failure for XArray version 6

2018-01-18 Thread Patchwork
== Series Details == Series: XArray version 6 URL : https://patchwork.freedesktop.org/series/36646/ State : failure == Summary == Applying: xarray: Add the xa_lock to the radix_tree_root error: sha1 information is lacking or useless (include/linux/idr.h). error: could not build fake ancestor

Re: [Intel-gfx] [PATCH v2] drm/i915: Use the engine name directly in the error_state file

2018-01-18 Thread Chris Wilson
Quoting Michel Thierry (2018-01-18 00:39:55) > On 17/01/18 07:15, Chris Wilson wrote: > > Hmm, we will need to fixup mesa/aubinator_error_decode to expect the new > > name, as it is using them to map various registers from the error state. > > Thanks for taking care of aubinator, hopefully next

Re: [Intel-gfx] [PATCH igt] igt/pm_rps: Increase load for waitboosting

2018-01-18 Thread Chris Wilson
Quoting Chris Wilson (2018-01-13 19:20:21) > The waitboost subtests encode internal knowledge of the kernel, and > should we wish to change how the kernel functions, we also need to > update the test (or reconfigure it somehow to express desired latencies > for certain workloads). One such change

Re: [Intel-gfx] [PATCH igt] igt/pm_rps: Increase load for waitboosting

2018-01-18 Thread Tvrtko Ursulin
On 13/01/2018 19:20, Chris Wilson wrote: The waitboost subtests encode internal knowledge of the kernel, and should we wish to change how the kernel functions, we also need to update the test (or reconfigure it somehow to express desired latencies for certain workloads). One such change

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP1.4 implementation enhancement

2018-01-18 Thread Patchwork
== Series Details == Series: HDCP1.4 implementation enhancement URL : https://patchwork.freedesktop.org/series/36671/ State : success == Summary == Series 36671v1 HDCP1.4 implementation enhancement https://patchwork.freedesktop.org/api/1.0/series/36671/revisions/1/mbox/ Test debugfs_test:

[Intel-gfx] ✗ Fi.CI.IGT: failure for khungtaskd: Kick stuck processes

2018-01-18 Thread Patchwork
== Series Details == Series: khungtaskd: Kick stuck processes URL : https://patchwork.freedesktop.org/series/36677/ State : failure == Summary == Test kms_atomic_transition: Subgroup plane-all-transition-nonblocking-fencing: pass -> SKIP (shard-snb) Test

Re: [Intel-gfx] [RFC 6/6] drm/i915/pmu: Add running counter

2018-01-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-18 10:41:36) > From: Tvrtko Ursulin > > We add a PMU counter to expose the number of requests currently executing > on the GPU. > > This is useful to analyze the overall load of the system. > > Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH igt] igt/pm_rps: Increase load for waitboosting

2018-01-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-18 11:37:44) > > On 13/01/2018 19:20, Chris Wilson wrote: > > The waitboost subtests encode internal knowledge of the kernel, and > > should we wish to change how the kernel functions, we also need to > > update the test (or reconfigure it somehow to express

[Intel-gfx] ✗ Fi.CI.BAT: warning for Submitted queue depth stats

2018-01-18 Thread Patchwork
== Series Details == Series: Submitted queue depth stats URL : https://patchwork.freedesktop.org/series/36685/ State : warning == Summary == Series 36685v1 Submitted queue depth stats https://patchwork.freedesktop.org/api/1.0/series/36685/revisions/1/mbox/ Test debugfs_test: Subgroup

[Intel-gfx] [PATCH v6 20/99] ida: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Use the xarray infrstructure like we used the radix tree infrastructure. This lets us get rid of idr_get_free() from the radix tree code. Signed-off-by: Matthew Wilcox --- include/linux/idr.h| 8 +-

[Intel-gfx] [PATCH v6 34/99] mm: Convert delete_from_swap_cache to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox Both callers of __delete_from_swap_cache have the swp_entry_t already, so pass that in to make constructing the XA_STATE easier. Signed-off-by: Matthew Wilcox --- include/linux/swap.h | 5 +++-- mm/swap_state.c | 24

[Intel-gfx] [PATCH v6 22/99] page cache: Convert hole search to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox The page cache offers the ability to search for a miss in the previous or next N locations. Rather than teach the XArray about the page cache's definition of a miss, use xas_prev() and xas_next() to search the page array. This should be more

[Intel-gfx] [PATCH v6 47/99] shmem: Convert shmem_alloc_hugepage to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox xa_find() is a slightly easier API to use than radix_tree_gang_lookup_slot() because it contains its own RCU locking. Signed-off-by: Matthew Wilcox --- mm/shmem.c | 14 -- 1 file changed, 4 insertions(+), 10

[Intel-gfx] [PATCH v6 75/99] md: Convert raid5-cache to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox This is the first user of the radix tree I've converted which was storing numbers rather than pointers. I'm fairly pleased with how well it came out. There's less boiler-plate involved than there was with the radix tree, so that's a win. It does

[Intel-gfx] [PATCH] khungtaskd: Kick stuck processes

2018-01-18 Thread Chris Wilson
After spotting a stuck process, and having decided not to panic, give the task a kick to see if that helps it to recover (e.g. to paper over a missed wake up). References: https://bugs.freedesktop.org/show_bug.cgi?id=104009 References: https://bugs.freedesktop.org/show_bug.cgi?id=104682

[Intel-gfx] [PATCH v6 76/99] irqdomain: Convert to XArray

2018-01-18 Thread Matthew Wilcox
From: Matthew Wilcox In a non-critical path, irqdomain wants to know how many entries are stored in the xarray, so add xa_count(). This is a pretty straightforward conversion; mostly just removing now-redundant locking. The only thing of note is just how much simpler

<    1   2   3   >