[Intel-gfx] [RFC v3 2/8] drm: Add Plane Degamma properties

2018-03-09 Thread Uma Shankar
Add Plane Degamma as a blob property and plane degamma size as a range property. v2: Rebase v3: Fixed Sean, Paul's review comments. Moved the property from mode_config to drm_plane. Created a helper function to instantiate these properties and removed from drm_mode_create_standard_properties Adde

[Intel-gfx] [RFC v3 4/8] drm: Add Plane Gamma properties

2018-03-09 Thread Uma Shankar
Add plane gamma as blob property and size as a range property. v2: Rebase v3: Fixed Sean, Paul's review comments. Moved the property from mode_config to drm_plane. Created a helper function to instantiate these properties and removed from drm_mode_create_standard_properties Added property documen

[Intel-gfx] [RFC v3 5/8] drm: Define helper function for plane color enabling

2018-03-09 Thread Uma Shankar
Define helper function to enable Plane color features to attach plane color properties to plane structure. v2: Rebase v3: Modiefied the function to use updated property names. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_plane.c | 42 ++ include/d

[Intel-gfx] [RFC v3 3/8] drm: Add Plane CTM property

2018-03-09 Thread Uma Shankar
Add a blob property for plane CSC usage. v2: Rebase v3: Fixed Sean, Paul's review comments. Moved the property from mode_config to drm_plane. Created a helper function to instantiate these properties and removed from drm_mode_create_standard_properties Added property documentation as suggested by

[Intel-gfx] [RFC v3 6/8] drm/i915: Enable plane color features

2018-03-09 Thread Uma Shankar
Enable and initialize plane color features. v2: Rebase and some cleanup v3: Updated intel_plane_color_init to call drm_plane_color_create_prop function, which will in turn create plane color properties. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_drv.h | 5 + drivers

[Intel-gfx] [RFC v3 7/8] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms

2018-03-09 Thread Uma Shankar
Implement Plane Gamma feature for BDW and Gen9 platforms. v2: Used newly added drm_color_lut_ext structure for enhanced precision for Gamma LUT entries. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_pci.c | 5 +++- drivers/gpu/drm/i915/i915_reg.h | 24 +++ driv

[Intel-gfx] [RFC v3 8/8] drm/i915: Load plane color luts from atomic flip

2018-03-09 Thread Uma Shankar
Load plane color luts as part of atomic plane updates. This will be done only if the plane color luts are changed. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_atomic_plane.c | 4 drivers/gpu/drm/i915/intel_color.c| 8 drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add Plane Color Properties (rev3)

2018-03-09 Thread Patchwork
== Series Details == Series: Add Plane Color Properties (rev3) URL : https://patchwork.freedesktop.org/series/30875/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: Add Enhanced Gamma LUT precision structure +drivers/gpu/drm/drm_plane.c:433:10: warning: symbol 'drm_colo

[Intel-gfx] ✓ Fi.CI.BAT: success for Add Plane Color Properties (rev3)

2018-03-09 Thread Patchwork
== Series Details == Series: Add Plane Color Properties (rev3) URL : https://patchwork.freedesktop.org/series/30875/ State : success == Summary == Series 30875v3 Add Plane Color Properties https://patchwork.freedesktop.org/api/1.0/series/30875/revisions/3/mbox/ Known issues: Test kms_fr

Re: [Intel-gfx] [RFC] drm/i915: store all mmio bases in intel_engines

2018-03-09 Thread Daniele Ceraolo Spurio
On 09/03/18 01:53, Tvrtko Ursulin wrote: On 08/03/2018 18:46, Daniele Ceraolo Spurio wrote: On 08/03/18 01:31, Tvrtko Ursulin wrote: On 07/03/2018 19:45, Daniele Ceraolo Spurio wrote: The mmio bases we're currently storing in the intel_engines array are only valid for a subset of gens, so

Re: [Intel-gfx] [PATCH v2] drm/i915: Trim gen11_gt_irq_handler

2018-03-09 Thread Daniele Ceraolo Spurio
On 08/03/18 17:33, Chris Wilson wrote: Give the compiler a helping hand in mapping (bank,bit) to our struct intel_engine_cs by trading object code size for data cache: add/remove: 2/0 grow/shrink: 0/1 up/down: 48/-135 (-87) Function old new delta bank1

Re: [Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

2018-03-09 Thread Antonio Argenziano
On 08/03/18 17:03, Chris Wilson wrote: Quoting Antonio Argenziano (2018-03-09 00:45:42) On 08/03/18 09:13, Chris Wilson wrote: Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_f

Re: [Intel-gfx] [RFC] drm/i915: store all mmio bases in intel_engines

2018-03-09 Thread Tvrtko Ursulin
On 09/03/2018 18:47, Daniele Ceraolo Spurio wrote: On 09/03/18 01:53, Tvrtko Ursulin wrote: On 08/03/2018 18:46, Daniele Ceraolo Spurio wrote: On 08/03/18 01:31, Tvrtko Ursulin wrote: On 07/03/2018 19:45, Daniele Ceraolo Spurio wrote: The mmio bases we're currently storing in the intel_eng

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/4] drm: Add drm_any_plane_has_format()

2018-03-09 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm: Add drm_any_plane_has_format() URL : https://patchwork.freedesktop.org/series/39700/ State : failure == Summary == Possible new issues: Test kms_busy: Subgroup extended-pageflip-hang-oldfb-render-b: p

Re: [Intel-gfx] [PATCH 1/3] drm/i915/cnl; Add macro to get PORT_TX register

2018-03-09 Thread Rodrigo Vivi
On Fri, Mar 09, 2018 at 06:28:56PM +0530, Mahesh Kumar wrote: > This patch creates a new macro to get PORT_TX register for any given DW. > This will remove the need of defining register address for each port & DW. please squash patches 1 and 2. I had to open both simultaneously to review it what i

Re: [Intel-gfx] [PATCH 3/3] drm/i915/cnl: Kill _MMIO_PORT6 macro

2018-03-09 Thread Rodrigo Vivi
On Fri, Mar 09, 2018 at 06:28:58PM +0530, Mahesh Kumar wrote: > This patch replaces use of remaining _MMIO_PORT6 macro and removes the > macro. Thanks... I hope that we don't need to bring it back for the ICL patches... > > Signed-off-by: Mahesh Kumar Reviewed-by: Rodrigo Vivi > --- > drive

Re: [Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

2018-03-09 Thread Chris Wilson
Quoting Antonio Argenziano (2018-03-09 19:15:45) > > > On 08/03/18 17:03, Chris Wilson wrote: > > Quoting Antonio Argenziano (2018-03-09 00:45:42) > >> > >> > >> On 08/03/18 09:13, Chris Wilson wrote: > >>> Exercise some new API that allows applications to request that > >>> individual contexts a

Re: [Intel-gfx] [PATCH i-g-t v2] tests/perf_pmu: Use absolute tolerance in accuracy tests

2018-03-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-09 11:54:13) > From: Tvrtko Ursulin > > We need to use absolute tolerance when asserting on percentages. Relative > tolerance in this case is unfair and inaccurate since it's strictness > varies with relative target busyness. > > v2: > * Do not include spin batch

Re: [Intel-gfx] [PATCH 1/3] drm/i915/cnl; Add macro to get PORT_TX register

2018-03-09 Thread Lucas De Marchi
On Fri, Mar 09, 2018 at 11:55:47AM -0800, Rodrigo Vivi wrote: > On Fri, Mar 09, 2018 at 06:28:56PM +0530, Mahesh Kumar wrote: > > This patch creates a new macro to get PORT_TX register for any given DW. > > This will remove the need of defining register address for each port & DW. > > please squas

Re: [Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

2018-03-09 Thread Eric Anholt
Ville Syrjala writes: > From: Ville Syrjälä > > Only create framebuffers with supported format/modifier combinations by > checking that at least one plane supports the requested combination. > > Using drm_any_plane_has_format() is somewhat suboptimal for vc4 since > the planes have (mostly) unif

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/uc: Sanitize uC (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915/uc: Sanitize uC (rev2) URL : https://patchwork.freedesktop.org/series/39634/ State : failure == Summary == Possible new issues: Test drv_missed_irq: pass -> SKIP (shard-apl) Test drv_selftest: Subgroup live_guc:

[Intel-gfx] [PATCH v3 4/5] drm/dp_mst: Add drm_atomic_dp_mst_retrain_topology()

2018-03-09 Thread Lyude Paul
Retraining MST is rather difficult. In order to do it properly while guaranteeing that we'll never run into a spot where we commit a physically impossible configuration, we have to do a lot of checks on atomic commits which affect MST topologies. All of this work is going to need to be repeated for

[Intel-gfx] [PATCH v3 2/5] drm/i915: Only use one link bw config for MST topologies

2018-03-09 Thread Lyude Paul
When a DP MST link needs retraining, sometimes the hub will detect that the current link bw config is impossible and will update it's RX caps in the DPCD to reflect the new maximum link rate. Currently, we make the assumption that the RX caps in the dpcd will never change like this. This means if t

[Intel-gfx] [PATCH v3 3/5] drm/dp_mst: Add drm_dp_mst_topology_mgr_lower_link_rate()

2018-03-09 Thread Lyude Paul
Unlike SST, MST can have far more then a single display hooked up on a single port. What this also means however, is that if the DisplayPort link to the top-level MST branch device becomes unstable then every single branch device also has an unstable link. Additionally, MST has a few more steps tha

[Intel-gfx] [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

2018-03-09 Thread Lyude Paul
For a while we actually haven't had any way of retraining MST links with fallback link parameters like we do with SST. While uncommon, certain setups such as my Caldigit TS3 + EVGA MST hub require this since otherwise, they end up getting stuck in an infinite MST retraining loop. MST retraining is

[Intel-gfx] [PATCH v3 1/5] drm/i915: Move DP modeset retry work into intel_dp

2018-03-09 Thread Lyude Paul
While having the modeset_retry_work in intel_connector makes sense with SST, this paradigm doesn't make a whole ton of sense when it comes to MST since we have to deal with multiple connectors. In most cases, it's more useful to just use the intel_dp struct since it indicates whether or not we're d

[Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

2018-03-09 Thread Chris Wilson
Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_freq subtests v3: Do an up/down ramp for individual freq request, check nothing changes after each invalid request v4: Check the frequen

[Intel-gfx] [PATCH i-g-t v2] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()

2018-03-09 Thread Radhakrishna Sripada
From: Anusha Srivatsa Rework the rotate and reflect subtests by checking the crtc supported properties against the ones that the test is testing. Remove the hardcoded platform names in igt_require() v2: Make use of the property enums to get the supported rotations Cc: Radhakrishna Sripada Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for igt: Add gem_ctx_freq to exercise requesting freq on a ctx (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: igt: Add gem_ctx_freq to exercise requesting freq on a ctx (rev2) URL : https://patchwork.freedesktop.org/series/39571/ State : success == Summary == IGT patchset tested on top of latest successful build 5d71d7782a830843c7231fbd72ab3edae19b48d7 igt/gem_fd_exhaustio

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: misc fixes in headers (RESEND)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: misc fixes in headers (RESEND) URL : https://patchwork.freedesktop.org/series/39589/ State : failure == Summary == Possible new issues: Test kms_cursor_legacy: Subgroup short-flip-after-cursor-atomic-transitions: pass -

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: misc fixes in headers (RESEND)

2018-03-09 Thread Chris Wilson
Quoting Patchwork (2018-03-09 22:12:20) > == Series Details == > > Series: drm/i915: misc fixes in headers (RESEND) > URL : https://patchwork.freedesktop.org/series/39589/ > State : failure > > == Summary == > > Possible new issues: > > Test kms_cursor_legacy: > Subgroup short-fl

[Intel-gfx] [PATCH] drm/i915: Disable LVDS on Radiant P845

2018-03-09 Thread Ondrej Zary
Radiant P845 does not have LVDS, only VGA. Signed-off-by: Ondrej Zary --- drivers/gpu/drm/i915/intel_lvds.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index ef80499113ee..6939e63d8bae 100644 --- a/drivers/gpu

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915/guc: Tidy guc_log_control

2018-03-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/guc: Tidy guc_log_control URL : https://patchwork.freedesktop.org/series/39710/ State : failure == Summary == Possible new issues: Test drv_missed_irq: pass -> SKIP (shard-apl) Test drv_selfte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable LVDS on Radiant P845

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Disable LVDS on Radiant P845 URL : https://patchwork.freedesktop.org/series/39732/ State : success == Summary == Series 39732v1 drm/i915: Disable LVDS on Radiant P845 https://patchwork.freedesktop.org/api/1.0/series/39732/revisions/1/mbox/ Known iss

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add NV12 support

2018-03-09 Thread Patchwork
== Series Details == Series: Add NV12 support URL : https://patchwork.freedesktop.org/series/39670/ State : failure == Summary == Possible new issues: Test kms_chv_cursor_fail: Subgroup pipe-a-128x128-left-edge: fail -> PASS (shard-apl) Test kms_color:

Re: [Intel-gfx] [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-09 Thread Atwood, Matthew S
On Thu, 2018-03-08 at 09:22 +0200, Jani Nikula wrote: > On Wed, 07 Mar 2018, matthew.s.atw...@intel.com wrote: > > > > From: Matt Atwood > > > > DP_TRAINING_AUX_RD_INTERVAL with DP 1.3 spec changed bit scheeme > > from 8 > > bits to 7 in DPCD 0x000e. The 8th bit is used to identify extended > >

Re: [Intel-gfx] [PATCH] drm/i915: make edp optimize config

2018-03-09 Thread Atwood, Matthew S
On Fri, 2018-03-09 at 14:05 +0200, Jani Nikula wrote: > On Thu, 08 Mar 2018, matthew.s.atw...@intel.com wrote: > > > > From: Matt Atwood > > > > Previously it was assumed that eDP panels would advertise the > > lowest link > > rate required for their singular mode to function. With the > > intro

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/uc: Sanitize uC together with GEM

2018-03-09 Thread Daniele Ceraolo Spurio
On 09/03/18 08:01, Michal Wajdeczko wrote: Instead of dancing around uC on reset/suspend/resume scenarios, explicitly sanitize uC when we sanitize GEM to force uC reload and start from known beginning. v2: don't forget about reset path (Daniele) sanitize uc before gem initiated full reset

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add Plane Color Properties (rev3)

2018-03-09 Thread Patchwork
== Series Details == Series: Add Plane Color Properties (rev3) URL : https://patchwork.freedesktop.org/series/30875/ State : failure == Summary == Possible new issues: Test kms_frontbuffer_tracking: Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-wc: pass -> DM

[Intel-gfx] ✗ Fi.CI.IGT: failure for igt: Add gem_ctx_freq to exercise requesting freq on a ctx (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: igt: Add gem_ctx_freq to exercise requesting freq on a ctx (rev2) URL : https://patchwork.freedesktop.org/series/39571/ State : failure == Summary == Possible new issues: Test kms_draw_crc: Subgroup draw-method-xrgb2101010-mmap-gtt-xtiled:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable LVDS on Radiant P845

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Disable LVDS on Radiant P845 URL : https://patchwork.freedesktop.org/series/39732/ State : success == Summary == Possible new issues: Test kms_cursor_crc: Subgroup cursor-64x64-suspend: skip -> PASS (shard-snb) -

<    1   2