== Series Details ==
Series: drm/i915/icl: Add power well support
URL : https://patchwork.freedesktop.org/series/45409/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
409dfff082a1 drm/i915/icl: Add power well support
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit
== Series Details ==
Series: series starting with [1/2] drm/i915: Block enabling FBC until flips
have been completed
URL : https://patchwork.freedesktop.org/series/45349/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9425_full =
== Summary - WARNING
== Series Details ==
Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9426 =
== Summary - SUCCESS ==
No regressions found.
External URL:
Add the definition for ICL power wells and their mapping to power
domains. On ICL there are 3 power well control registers, we'll select
the correct one based on higher bits of the power well ID. The offset
for the control and status flags within this register is based on the
lower bits of the ID
== Series Details ==
Series: drm/i915/icl: Add power well support
URL : https://patchwork.freedesktop.org/series/45409/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9424_full =
== Summary - WARNING ==
Minor unknown changes coming with
On 2018-06-15 03:52 PM, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> To pick the correct MST encoder i915 wants to know which crtc is going
> to be feeding us. To that end let's pass the crtc to the .best_encoder()
> hook. The atomic variant already knows the crtc via the connector state,
>
On Tue, Jun 26, 2018 at 05:23:25PM +0200, Daniel Vetter wrote:
> On Fri, Jun 15, 2018 at 10:52:21PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > To pick the correct MST encoder i915 wants to know which crtc is going
> > to be feeding us. To that end let's pass the crtc to the
== Series Details ==
Series: drm/i915/icl: Add power well support
URL : https://patchwork.freedesktop.org/series/45409/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9424 =
== Summary - SUCCESS ==
No regressions found.
External URL:
On Fri, Jun 15, 2018 at 10:52:21PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> To pick the correct MST encoder i915 wants to know which crtc is going
> to be feeding us. To that end let's pass the crtc to the .best_encoder()
> hook. The atomic variant already knows the crtc via the
ill uprev by EOD
From: Navare, Manasi D
Sent: Monday, June 25, 2018 5:39 PM
To: Atwood, Matthew S
Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo; ble...@chromium.org;
Zanoni, Paulo R
Subject: Re: [Intel-gfx] [PATCH] drm/dp: implement
On 2018-06-26 11:01 AM, Harry Wentland wrote:
> On 2018-06-15 03:52 PM, Ville Syrjala wrote:
>> From: Ville Syrjälä
>>
>> To pick the correct MST encoder i915 wants to know which crtc is going
>> to be feeding us. To that end let's pass the crtc to the .best_encoder()
>> hook. The atomic variant
Currently ratelimit_state is protected with spin_lock. If the .lock is
taken at the moment of ___ratelimit() call, the message is suppressed to
make ratelimiting robust.
That results in the following issue issue:
CPU0 CPU1
--
On Tue, Jun 26, 2018 at 02:05:22AM -0700, Dhinakaran Pandiyan wrote:
> Depending whether PSR1 or PSR2 was configured, we print a warning if the
> corresponding control mmio indicated PSR was erroneously enabled. As
> Chris pointed out, it makes more sense to check for both the mmio's
> since we
Op 12-06-18 om 13:16 schreef Juha-Pekka Heikkila:
> Enabling of P010, P012 and P016 formats. These formats will
> extend NV12 for larger bit depths.
>
> Signed-off-by: Juha-Pekka Heikkila
Patch series looks good.
Reviewed-by: Maarten Lankhorst
I only wish we had IGT support already, I'll poke
== Series Details ==
Series: series starting with [1/2] drm/i915: Block enabling FBC until flips
have been completed
URL : https://patchwork.freedesktop.org/series/45349/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9425 =
== Summary - SUCCESS ==
No
== Series Details ==
Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a8dce76165a9 lib/ratelimit: Lockless ratelimiting
-:74: ERROR:ASSIGN_IN_IF: do not use assignment in if
On Tue, Jun 26, 2018 at 7:24 PM, Dmitry Safonov wrote:
> Currently ratelimit_state is protected with spin_lock. If the .lock is
> taken at the moment of ___ratelimit() call, the message is suppressed to
> make ratelimiting robust.
>
> That results in the following issue issue:
> CPU0
On Tue, Jun 26, 2018 at 1:47 PM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> Instead of using the .best_encoder() hook to figure out whether a given
> connector+crtc combo will work, let's instead do what userspace does and
> just iterate over all the encoders for the connector, and then
On Tue, Jun 26, 2018 at 10:40:26AM -0700, Paulo Zanoni wrote:
> Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu:
> > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote:
> > > So far we got an AUX power domain reference only for the duration
> > > of
> > > DP
> > > AUX transfers. However,
== Series Details ==
Series: Makefile: globally enable VLA warning
URL : https://patchwork.freedesktop.org/series/45421/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: Makefile: globally enable VLA warning
-
+drivers/gpu/drm/ati_pcigart.c:184:52:expected unsigned int
From: Zanoni, Paulo R
Sent: Monday, June 25, 2018 4:17 PM
To: Srivatsa, Anusha; intel-gfx@lists.freedesktop.org
Cc: Pandiyan, Dhinakaran
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support
Em Qua, 2018-06-20 às 14:36 -0700, Anusha
On Tue, Jun 26, 2018 at 10:47:09PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add drm_encoder_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs.
>
> Mostly performed with coccinelle:
> @@
> @@
> - (1< + drm_encoder_mask(
> ...)
> - )
>
> @@
> @@
>
On Tue, Jun 26, 2018 at 10:47:08PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_crtc_mask() where appropriate.
>
> Mostly performed with coccinelle:
> @@
> @@
> - (1< + drm_crtc_mask(
> ...)
> - )
>
> @@
> @@
> - 1< + drm_crtc_mask(
> ...)
>
> @@
> @@
> -
== Series Details ==
Series: series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state
parameter from disable_source()
URL : https://patchwork.freedesktop.org/series/45436/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4382 -> Patchwork_9430 =
== Summary -
On Tue, Jun 26, 2018 at 10:27:49AM +0200, Daniel Vetter wrote:
> On Mon, Jun 25, 2018 at 10:25:36PM -0700, Rodrigo Vivi wrote:
> > At some point we introduced the function pointers
> > on PSR code to help with VLV/CHV separation logic
> > because it had a different HW implementation from PSR.
> >
This is the patch I've got prepared now that fixes for all VLAs have been
sent to maintainers (some are still under review/adjustment, but there
aren't any unexplored cases left). My intention would be to have this land
at the end of the next merge window after all the pending VLA patches
have
Em Ter, 2018-06-26 às 11:32 -0700, Srivatsa, Anusha escreveu:
>
> From: Zanoni, Paulo R
> Sent: Monday, June 25, 2018 4:17 PM
> To: Srivatsa, Anusha; intel-gfx@lists.freedesktop.org
> Cc: Pandiyan, Dhinakaran
> Subject: Re: [Intel-gfx] [PATCH 1/2]
On Tue, Jun 26, 2018 at 10:47:16PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_{plane,connector}_mask() where appropriate.
>
> Cc: VMware Graphics
> Cc: Sinclair Yeh
> Cc: Thomas Hellstrom
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
>
On Tue, Jun 26, 2018 at 10:47:13PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_crtc_mask() where appropriate.
>
> Cc: Sandy Huang
> Cc: "Heiko Stübner"
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
>
On Tue, Jun 26, 2018 at 10:47:12PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_plane_mask() where appropriate.
>
> Cc: Philipp Zabel
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +-
> 1 file changed, 1
On Tue, Jun 26, 2018 at 10:47:11PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_{plane,crtc,encoder,connector}_mask() where appropriate.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/intel_display.c | 14 +++---
>
On Tue, Jun 26, 2018 at 10:47:15PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_crtc_mask() where appropriate.
>
> Cc: Eric Anholt
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++---
> 1 file changed, 3
On Tue, Jun 26, 2018 at 10:47:14PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use drm_crtc_mask() where appropriate.
>
> Cc: Maxime Ripard
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +-
>
Hi Andy, thanks for the review,
On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote
[..]
> > #define RATELIMIT_STATE_INIT(name, interval_init, burst_init)
> > {\
> > - .lock =
> > __RAW_SPIN_LOCK_UNLOCKED(name.lock), \
>
> name is now redundant,
== Series Details ==
Series: Makefile: globally enable VLA warning
URL : https://patchwork.freedesktop.org/series/45421/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4381 -> Patchwork_9427 =
== Summary - SUCCESS ==
No regressions found.
External URL:
On Tue, Jun 26, 2018 at 10:47:07PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add drm_plane_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs.
>
> Mostly performed with coccinelle:
> @@
> @@
> - (1< + drm_plane_mask(
> ...)
> - )
>
> @@
> @@
> -
From: Ville Syrjälä
Update drm_atomic_helper_commit_planes_on_crtc() to use explicit old/new
states instead of relying on obj->state.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_atomic_helper.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git
On Tue, Jun 26, 2018 at 09:03:48PM +0300, Imre Deak wrote:
> On Tue, Jun 26, 2018 at 10:40:26AM -0700, Paulo Zanoni wrote:
> > Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu:
> > > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote:
> > > > So far we got an AUX power domain reference only
From: Ville Syrjälä
Use drm_crtc_mask() where appropriate.
Mostly performed with coccinelle:
@@
@@
- (1<
---
drivers/gpu/drm/drm_crtc.c | 4 ++--
drivers/gpu/drm/drm_simple_kms_helper.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
From: Ville Syrjälä
Use drm_{plane,crtc,encoder,connector}_mask() where appropriate.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 14 +++---
drivers/gpu/drm/i915/intel_display.h | 4 ++--
drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---
3 files changed,
From: Ville Syrjälä
Use drm_plane_mask() where appropriate.
Cc: Philipp Zabel
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c
index
From: Ville Syrjälä
Add drm_encoder_mask() which returns the 1<
---
drivers/gpu/drm/drm_atomic_helper.c | 10 +-
include/drm/drm_encoder.h | 16 ++--
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
From: Ville Syrjälä
Add drm_plane_mask() which returns the 1<
---
drivers/gpu/drm/drm_atomic.c| 4 ++--
drivers/gpu/drm/drm_framebuffer.c | 2 +-
drivers/gpu/drm/drm_simple_kms_helper.c | 2 +-
include/drm/drm_plane.h | 14 --
4 files changed, 16
On Tue, Jun 26, 2018 at 10:47:10PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add drm_connector_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs.
>
> Mostly performed with coccinelle:
> @@
> @@
> - (1< + drm_connector_mask(
> ...)
> - )
>
> @@
>
== Series Details ==
Series: series starting with [01/10] drm: Add drm_plane_mask()
URL : https://patchwork.freedesktop.org/series/45433/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cf6d660dc7b3 drm: Add drm_plane_mask()
-:115: WARNING:SPACING: space prohibited between
== Series Details ==
Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess
URL : https://patchwork.freedesktop.org/series/45422/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4381_full -> Patchwork_9428_full =
== Summary - WARNING ==
Minor unknown
From: Ville Syrjälä
Daniel pointed out that there should be a way to do what userspace does
and not require any .best_encoder() stuff in the fb-helper. So this
series does just that. Well, most of the series is actually just extra
polish that happened by accident. But the real thing is in there
From: Ville Syrjälä
Instead of using the .best_encoder() hook to figure out whether a given
connector+crtc combo will work, let's instead do what userspace does and
just iterate over all the encoders for the connector, and then check
each crtc against each encoder's possible_crtcs bitmask.
Cc:
From: Ville Syrjälä
Use drm_for_each_connector_encoder_ids() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
Cc: Alex Deucher
Cc: "Christian König"
Cc: "David (ChunMing) Zhou"
Cc: Harry Wentland
Cc:
From: Ville Syrjälä
Add a convenience macro for iterating connector->encoder_ids[].
Isolates the users from the implementation details.
Also use ARRAY_SIZE() when populating the array to avoid spreading
knowledge about the array size all over.
Signed-off-by: Ville Syrjälä
---
== Series Details ==
Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess
URL : https://patchwork.freedesktop.org/series/45422/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4381 -> Patchwork_9428 =
== Summary - SUCCESS ==
No regressions found.
On Tue, Jun 26, 2018 at 8:46 PM, Dmitry Safonov wrote:
> On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote
>> > #define RATELIMIT_STATE_INIT(name, interval_init, burst_init)
>> > {\
>> > - .lock =
>> > __RAW_SPIN_LOCK_UNLOCKED(name.lock), \
>>
>>
On Tue, 2018-06-26 at 10:26 +0200, Daniel Vetter wrote:
> On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote:
> >
> > This is a lockless version of the exisiting psr_wait_for_idle().
> > We want to wait for PSR to idle out inside intel_pipe_update_start.
> > At the time of a pipe update,
On Tue, 2018-06-26 at 08:50 -0700, Rodrigo Vivi wrote:
> On Tue, Jun 26, 2018 at 02:05:22AM -0700, Dhinakaran Pandiyan wrote:
> >
> > Depending whether PSR1 or PSR2 was configured, we print a warning
> > if the
> > corresponding control mmio indicated PSR was erroneously enabled.
> > As
> > Chris
From: Ville Syrjälä
Use drm_crtc_mask() where appropriate.
Cc: Maxime Ripard
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_lvds.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
From: Ville Syrjälä
Use drm_crtc_mask() where appropriate.
Cc: Eric Anholt
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index
From: Ville Syrjälä
Use drm_crtc_mask() where appropriate.
Cc: Sandy Huang
Cc: "Heiko Stübner"
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
From: Ville Syrjälä
Add drm_connector_mask() which returns the 1<
---
drivers/gpu/drm/drm_atomic.c | 6 +++---
include/drm/drm_connector.h | 8 +++-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index
From: Ville Syrjälä
Use drm_{plane,connector}_mask() where appropriate.
Cc: VMware Graphics
Cc: Sinclair Yeh
Cc: Thomas Hellstrom
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Tue, 2018-06-26 at 10:40 -0700, Kees Cook wrote:
> This is the patch I've got prepared now that fixes for all VLAs have been
> sent to maintainers (some are still under review/adjustment, but there
> aren't any unexplored cases left). My intention would be to have this land
> at the end of the
== Series Details ==
Series: series starting with [01/10] drm: Add drm_plane_mask()
URL : https://patchwork.freedesktop.org/series/45433/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4382 -> Patchwork_9429 =
== Summary - SUCCESS ==
No regressions found.
External
On Tue, Jun 26, 2018 at 09:42:11AM +0100, Chris Wilson wrote:
> Quoting Daniel Vetter (2018-06-26 09:26:57)
> > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote:
> > > This is a lockless version of the exisiting psr_wait_for_idle().
> > > We want to wait for PSR to idle out inside
On Mon, Jun 25, 2018 at 06:37:58PM +0200, Maarten Lankhorst wrote:
> The only time we should start FBC is when we have waited a vblank
> after the atomic update.
What about front buffer tracking? Is this going to leave FBC permanently
disabled unless there are flips/plane updates?
I think there
== Series Details ==
Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9426_full =
== Summary - WARNING ==
Minor unknown changes coming with
Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu:
> On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote:
> > So far we got an AUX power domain reference only for the duration
> > of
> > DP
> > AUX transfers. However, the following suggests that we also need
> > these
> > for main link
From: Ville Syrjälä
Use drm_for_each_connector_encoder_ids() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
Cc: Ben Skeggs
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
Use drm_for_each_connector_encoder_ids() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
Cc: Alex Deucher
Cc: "Christian König"
Cc: "David (ChunMing) Zhou"
Cc: Harry Wentland
Cc:
From: Ville Syrjälä
Use drm_for_each_connector_encoder_ids() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/tilcdc/tilcdc_external.c | 5
From: Ville Syrjälä
With the fb-helper no longer relying on the non-atomic .best_encoder()
we can eliminate the hook from the MST encoder.
Cc: Dhinakaran Pandiyan
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp_mst.c | 10 --
1 file changed, 10 deletions(-)
diff --git
From: Ville Syrjälä
Use drm_for_each_connector_encoder_ids() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
Cc: Rob Clark
Cc: linux-arm-...@vger.kernel.org
Cc: freedr...@lists.freedesktop.org
Signed-off-by: Ville Syrjälä
---
On Tue, Jun 26, 2018 at 12:43:42PM -0700, Dhinakaran Pandiyan wrote:
> On Tue, 2018-06-26 at 10:26 +0200, Daniel Vetter wrote:
> > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote:
> > >
> > > This is a lockless version of the exisiting psr_wait_for_idle().
> > > We want to wait for PSR
== Series Details ==
Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess
URL : https://patchwork.freedesktop.org/series/45422/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
eebb696c2139 drm/fb-helper: Eliminate the .best_encoder() usage
b75ca3e84ab2
== Series Details ==
Series: Makefile: globally enable VLA warning
URL : https://patchwork.freedesktop.org/series/45421/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4381_full -> Patchwork_9427_full =
== Summary - FAILURE ==
Serious unknown changes coming with
eDP spec states that sink device will do a short pulse in HPD
line when there is a PSR/PSR2 error that needs to be handled by
source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.
Here taking the safest approach and disabling PSR(at least until
the next modeset),
Sink can be configured to calculate the CRC over the static frame and
compare with the CRC calculated and transmited in the VSC SDP by
source, if there is a mismatch sink will do a short pulse in HPD
and set DP_PSR_LINK_CRC_ERROR in DP_PSR_ERROR_STATUS.
Spec: 7723
v6:
andling
Sink will interrupt source when it have any PSR error.
DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR is a PSR2 but already
handling it here.
The only missing error to be handled is DP_PSR_LINK_CRC_ERROR that
will be taken in care in a futher patch.
v6:
not handling DP_PSR_LINK_CRC_ERROR here
v5:
handling
Specification requires that max time should be masked from bdw and
forward but it can be also safely enabled to hsw.
This will make PSR exits more deterministic and only when really
needed. If this was used to fix a issue in some panel than can
only self-refresh for a few seconds, that panel will
It was only used in VLV/CHV so after the removal of the PSR support
for those platforms it is not necessary any more.
v7: Rebased
Reviewed-by: Dhinakaran Pandiyan
Cc: Rodrigo Vivi
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/intel_psr.c | 5 ++---
1 file changed, 2
>-Original Message-
>From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
>Sent: Tuesday, June 26, 2018 6:01 AM
>To: Shaikh, Azhar
>Cc: intel-gfx@lists.freedesktop.org; Navare, Manasi D
>
>Subject: Re: [PATCH v2] drm/i915: Fix assert_plane() warning on bootup with
>external
On Mon, 2018-06-25 at 17:09 -0700, Rodrigo Vivi wrote:
> On Sun, Jun 24, 2018 at 10:47:41PM -0700, Dhinakaran Pandiyan wrote:
> >
> > Depending whether PSR1 or PSR2 was configured, we print a warning
> > if the
> > corresponding control mmio indicated PSR was erroneously enabled.
> > As
> > Chris
This patch adds a new callback function "verify_crc_source" which will
be used during setting the crc source in control node and while opening
data node for crc reading. This will help in avoiding setting of wrong
string for source.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
This patch implements a callback function "pre_crc_read" which will
be called before crc read. In this function driver can implement and
preparation work required for successfully reading CRC data.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
This patch implements a callback function "get_crc_sources" which
will be called during read of control node. It is an optional
callback function and if driver implements this callback, driver
should print list of available CRC sources in seq_file privided
as an input to the callback.
This patch implements "verify_crc_source" callback function for
rockchip drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 21 +
1 file changed, 21 insertions(+)
diff --git
This patch implements get_crc_sources callback, which returns list of
all the valid crc sources supported by driver in current platform.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 2 ++
This patch implements verify_crc_source callback function introduced
earlier in this series.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 3 +
drivers/gpu/drm/i915/intel_pipe_crc.c |
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680.
Don't wait for first CRC during crtc_crc_open. It avoids one frame wait
during open. If application want to wait after read call, it can use
poll/read blocking read() call.
Suggested-by: Ville Syrjälä
Signed-off-by: Mahesh Kumar
Cc:
This patch implements "verify_crc_source" callback function for
rcar drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++
1 file changed, 40 insertions(+)
diff --git
This patch make changes to allocate crc-entries buffer before
enabling CRC generation.
It moves all the failure check early in the function before setting
the source or memory allocation.
Now set_crc_source takes only two variable input, values_cnt we
already gets as part of verify_crc_source.
This patch implements "verify_crc_source" callback function for
AMD drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4
This series improves crc-core <-> driver interface.
This series adds following functionality in the crc-core
- Now control node will print all the available sources if
implemented by driver along with current source.
- Setting of sorce will fail if provided source is not supported
- cleanup
Cc: Laurent Pinchart
On 6/26/2018 11:52 AM, Mahesh Kumar wrote:
This patch make changes to allocate crc-entries buffer before
enabling CRC generation.
It moves all the failure check early in the function before setting
the source or memory allocation.
Now set_crc_source takes only two
== Series Details ==
Series: drm/i915/psr: Kill useless function pointers.
URL : https://patchwork.freedesktop.org/series/45373/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4376_full -> Patchwork_9418_full =
== Summary - WARNING ==
Minor unknown changes coming with
== Series Details ==
Series: series starting with [v6,1/2] drm/i915/psr: Lockless version of
psr_wait_for_idle
URL : https://patchwork.freedesktop.org/series/45375/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4376_full -> Patchwork_9419_full =
== Summary - WARNING ==
On Mon, Jun 25, 2018 at 10:34 PM, Chris Wilson wrote:
> Quoting Daniel Vetter (2018-06-25 17:07:54)
>> On Tue, May 29, 2018 at 09:15:22AM +0200, Daniel Vetter wrote:
>> > This reverts commit c5cab0d5fc9aa1cf14c7bc7ea88c80155e46e22f.
>> >
>> > Jani believes the noise is gone, so let's see whether
Quoting Daniel Vetter (2018-06-26 09:06:48)
> On Mon, Jun 25, 2018 at 10:34 PM, Chris Wilson
> wrote:
> > Quoting Daniel Vetter (2018-06-25 17:07:54)
> >> On Tue, May 29, 2018 at 09:15:22AM +0200, Daniel Vetter wrote:
> >> > This reverts commit c5cab0d5fc9aa1cf14c7bc7ea88c80155e46e22f.
> >> >
>
On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote:
> This is a lockless version of the exisiting psr_wait_for_idle().
> We want to wait for PSR to idle out inside intel_pipe_update_start.
> At the time of a pipe update, we should never race with any psr
> enable or disable code, which is
Cc: Laurent Pinchart
On 6/26/2018 11:52 AM, Mahesh Kumar wrote:
This patch implements "verify_crc_source" callback function for
rcar drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40
Cc:dri-de...@lists.freedesktop.org
On 6/26/2018 11:52 AM, Mahesh Kumar wrote:
This series improves crc-core <-> driver interface.
This series adds following functionality in the crc-core
- Now control node will print all the available sources if
implemented by driver along with current
== Series Details ==
Series: series starting with [v6,1/2] drm/i915/psr: Lockless version of
psr_wait_for_idle
URL : https://patchwork.freedesktop.org/series/45375/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4376 -> Patchwork_9419 =
== Summary - SUCCESS ==
No
1 - 100 of 146 matches
Mail list logo
