When RECOVERABLE is set, the kernel will attempt to automatically recover
a context after a hang. But if it is unset, the kernel will ban the
guilty context on a hang, preventing subsequent execution.
v2: Create a has_recoverable_param()
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
Quoting Mika Kuoppala (2018-10-04 14:26:16)
> Chris Wilson writes:
>
> > When RECOVERABLE is set, the kernel will attempt to automatically recover
> > a context after a hang. But if it is unset, the kernel will ban the
> > guilty context on a hang, preventing subsequent execution.
> >
> >
== Series Details ==
Series: drm/i915/icl: MBUS B credit change
URL : https://patchwork.freedesktop.org/series/50560/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10363 =
== Summary - SUCCESS ==
No regressions found.
External URL:
No functional change. But just a minor change to keep
up with Spec, since it has changed since commit c3cc39c539d4
("drm/i915/icl: program mbus during pipe enable")
The instructions previously said to program pipe's
B credit = 24 / number of pipes, which is 8 for ICL.
Now the spec gives us direct
Quoting Tvrtko Ursulin (2018-10-04 11:51:18)
> From: Tvrtko Ursulin
>
> Engine discovery query allows userspace to enumerate engines, probe their
> configuration features, all without needing to maintain the internal PCI
> ID based database.
>
> A new query for the generic i915 query ioctl is
On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote:
> Op 04-10-18 om 14:57 schreef Ville Syrjälä:
> > On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote:
> >> Do not rely on crtc->config any more. Remove the assertion from
> >> ibx_pch_dpll_disable, because we the
== Series Details ==
Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE
URL : https://patchwork.freedesktop.org/series/50561/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4931 -> IGTPW_1909 =
== Summary - SUCCESS ==
No regressions found.
External URL:
== Series Details ==
Series: Refactor and Add helper function for combophy/tc ports (rev2)
URL : https://patchwork.freedesktop.org/series/50484/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4930_full -> Patchwork_10355_full =
== Summary - SUCCESS ==
No regressions
Hi Daniel,
On Wednesday, 3 October 2018 12:08:38 EEST Daniel Vetter wrote:
> On Tue, Oct 02, 2018 at 04:53:12PM +0300, Laurent Pinchart wrote:
> > On Tuesday, 2 October 2018 16:35:10 EEST Daniel Vetter wrote:
> > > It's the default. The exported version was kinda a transition state,
> > > before
On Thu, Oct 04, 2018 at 01:59:52PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 04, 2018 at 10:03:39AM +0300, Jani Nikula wrote:
> > On Wed, 03 Oct 2018, Dhinakaran Pandiyan
> > wrote:
> > > MST is enabled by default on all platforms that support it. I don't think
> > > we should be providing a
== Series Details ==
Series: drm/i915: Only reset seqno if actually idle
URL : https://patchwork.freedesktop.org/series/50537/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4930_full -> Patchwork_10354_full =
== Summary - WARNING ==
Minor unknown changes coming with
On Thu, 2018-10-04 at 08:54 -0700, Rodrigo Vivi wrote:
> On Thu, Oct 04, 2018 at 01:59:52PM +0300, Ville Syrjälä wrote:
> > On Thu, Oct 04, 2018 at 10:03:39AM +0300, Jani Nikula wrote:
> > > On Wed, 03 Oct 2018, Dhinakaran Pandiyan <
> > > dhinakaran.pandi...@intel.com> wrote:
> > > > MST is
== Series Details ==
Series: series starting with [1/2] sysfs: constify sysfs create/remove files
harder
URL : https://patchwork.freedesktop.org/series/50558/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10362 =
== Summary - SUCCESS ==
No regressions
On 03/10/18 23:29, Chris Wilson wrote:
Quoting Daniele Ceraolo Spurio (2018-10-03 23:45:02)
On 03/10/18 08:24, Chris Wilson wrote:
Quoting Daniele Ceraolo Spurio (2018-10-03 01:12:57)
On 02/10/18 15:39, Patchwork wrote:
== Series Details ==
Series: series starting with [v2,1/3]
== Series Details ==
Series: Refactor and Add helper function for combophy/tc ports (rev2)
URL : https://patchwork.freedesktop.org/series/50484/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4930_full -> Patchwork_10356_full =
== Summary - SUCCESS ==
No regressions
On Wed, Oct 03, 2018 at 06:12:42PM +0200, Daniel Vetter wrote:
> On Wed, Oct 03, 2018 at 05:50:17PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > When we decide that a plane is attached to the wrong pipe we try
> > to turn off said plane. However we are passing around the crtc we
>
Quoting Stanislav Lisovskiy (2018-10-04 13:49:41)
> diff --git a/src/sna/sna_render.h b/src/sna/sna_render.h
> index 6669af9d..ef88d1f9 100644
> --- a/src/sna/sna_render.h
> +++ b/src/sna/sna_render.h
> @@ -139,20 +139,25 @@ struct sna_composite_op {
>
> struct {
>
On Tue, Oct 02, 2018 at 04:36:31PM +, Thomas Hellstrom wrote:
> On 10/02/2018 05:15 PM, Ville Syrjälä wrote:
> > On Tue, Oct 02, 2018 at 03:35:12PM +0200, Daniel Vetter wrote:
> >> The core _does_ the call to drm_atomic_commit for you. That's pretty
> >> much the entire point of having the
== Series Details ==
Series: drm/i915: Engine discovery query (rev6)
URL : https://patchwork.freedesktop.org/series/39958/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10358_full =
== Summary - FAILURE ==
Serious unknown changes coming with
On Wed, Oct 03, 2018 at 11:18:26AM +0200, Daniel Vetter wrote:
> It's for legacy drivers only (atomic ones should use
> drm_atomic_helper_check_plane_state() instead), and there's no users
> left except the one in the primary plane helpers.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Ville
On Wed, Oct 03, 2018 at 12:52:00PM +0530, Mahesh Kumar wrote:
> From: Vandita Kulkarni
>
> This patch adds helper function for identifying
> whether the given PLL is combo PHY PLL or not.
> This helper function is used inside various ICL
> functions to make them scalable.
>
> Signed-off-by:
Gen11 Display suports 32 planes in total. Enable the new format in context
status to be used and expanded to 32 planes.
V2: Move the WA to display WA's(Chris)
Cc: Chris Wilson
Cc: Michel Thierry
Cc: James Ausmus
Cc: Anusha Srivatsa
Signed-off-by: Radhakrishna Sripada
---
From: Anuj Phogat
Incorrect TDL's SSP address shift in SARB for 16:6 & 18:8 modes.
Disable the Sampler state prefetch functionality in the SARB by
programming 0xB000[30] to '1'. This is to be done at boot time
and the feature must remain disabled permanently.
Fixes flaky
Display WA_1405510057 asks to not enable YUV 420 HDMI
10bpc when horizontal blank size mod 8 reminder is 2.
Cc: James Ausmus
Cc: Paulo Zanoni
Cc: Rodrigo Vivi
Cc: Ville Syrjälä
Signed-off-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/intel_hdmi.c | 10 +-
1 file changed, 9
From: Oscar Mateo
Required for Bindless samplers.
Cc: Mika Kuoppala
Signed-off-by: Oscar Mateo
Signed-off-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
drivers/gpu/drm/i915/intel_workarounds.c | 3 +++
2 files changed, 5 insertions(+)
diff --git
Shader feature to prefetch binding tables does not support 16:6 18:8 BTP
formats. Enabling fault handling could result in hangs with faults.
Disabling demand prefetch would disable binding table prefetch.
V2: Fix the stepping rivision to B0(Mika)
References: HSDES#1406609255, HSDES#1406573985
From: Oscar Mateo
Required to dinamically set 'Trilinear Filter Quality Mode'
Cc: Mika Kuoppala
Signed-off-by: Oscar Mateo
Signed-off-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/intel_workarounds.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Thu, Oct 04, 2018 at 02:20:43PM +0530, Mahesh Kumar wrote:
> This patch creates a function/wrapper to check if port is combophy port
> instead of explicitly comparing ports.
>
> Changes since V1:
> - keep all intel_port_is_* helper together (Lucas)
>
> Signed-off-by: Mahesh Kumar
> Cc:
The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
definitions are unused.
Cc: Manasi Navare
Cc: Anusha Srivatsa
Cc: Rodrigo Vivi
Fixes: 7af2be6d54d4 ("drm/i915/icl: Add VIDEO_DIP registers")
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/i915_reg.h | 18
== Series Details ==
Series: drm/i915: Fix VIDEO_DIP_CTL bit shifts
URL : https://patchwork.freedesktop.org/series/50573/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10365 =
== Summary - SUCCESS ==
No regressions found.
External URL:
On Tue, Oct 02, 2018 at 03:35:10PM +0200, Daniel Vetter wrote:
> It's the default. The exported version was kinda a transition state,
> before we made this the default.
>
> To stop new atomic drivers from using it (instead of just relying on
> the default) let's unexport it.
>
> Signed-off-by:
On Wed, Oct 03, 2018 at 12:51:57PM +0530, Mahesh Kumar wrote:
> Instead of directly comparing HPD pins use intel_port_is_combophy/tc
> helper functions to distinguish between combophy/TC ports.
>
> Signed-off-by: Mahesh Kumar
> Cc: Manasi Navare
> ---
Reviewed-by: Lucas De Marchi
>
On Wed, Oct 03, 2018 at 12:52:03PM +0530, Mahesh Kumar wrote:
> DDI/TC clock-off bits are not equally distanced. TC1-3 bits are
> from offset 12 & TC4 is at offset 21.
> Create a function to choose correct clk-off bit.
>
> Signed-off-by: Mahesh Kumar
> Signed-off-by: Vandita Kulkarni
> Cc:
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode
URL : https://patchwork.freedesktop.org/series/50569/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10364 =
== Summary - SUCCESS ==
No regressions found.
On Wed, Oct 03, 2018 at 12:51:58PM +0530, Mahesh Kumar wrote:
> From: Vandita Kulkarni
>
> Use the existing port-to-id helper function, to refactor
> hence making it scalable.
>
> Signed-off-by: Vandita Kulkarni
> Signed-off-by: Mahesh Kumar
> Cc: Lucas De Marchi
> Cc: Madhav Chauhan
From: Anusha Srivatsa
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR
firmware definition macros")
Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Cc: Rodrigo Vivi
Cc:
On Thu, Oct 04, 2018 at 02:33:24PM -0400, Sean Paul wrote:
> On Tue, Oct 02, 2018 at 03:35:10PM +0200, Daniel Vetter wrote:
> > It's the default. The exported version was kinda a transition state,
> > before we made this the default.
> >
> > To stop new atomic drivers from using it (instead of
On Wed, Oct 03, 2018 at 12:51:59PM +0530, Mahesh Kumar wrote:
> From: Vandita Kulkarni
>
> Use intel_port_is_tc and intel_port_is_combophy
> functions to replace the individual port checks
> from port C to F and port A to B respectively.
>
> Signed-off-by: Vandita Kulkarni
> Signed-off-by:
On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote:
> On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote:
> > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
> > definitions are unused.
>
> If they are unused why are we fixing them instead of removing?
== Series Details ==
Series: series starting with [1/2] sysfs: constify sysfs create/remove files
harder
URL : https://patchwork.freedesktop.org/series/50558/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10362_full =
== Summary - FAILURE ==
== Series Details ==
Series: Fix legacy DPMS changes with MST (rev4)
URL : https://patchwork.freedesktop.org/series/49878/
State : failure
== Summary ==
Applying: drm/atomic_helper: Disallow new modesets on unregistered connectors
Applying: drm/nouveau: Fix nv50_mstc->best_encoder()
Applying:
The hardware can start selective update following capture of a full frame
in the remote frame buffer, there is no need to wait any longer. Set
"Frames Before SU Entry" bitfield to the default value of 1.
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_psr.c | 3 +--
1 file
PSR2 sinks that require Y coordinates for selective update also need the
Y coordinate Valid bit in VSC SDP.
Spec: eDP 1.4b VSC payload extension for PSR2 operation (Table 6-12)
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_psr.c | 2 +-
1 file changed, 1 insertion(+), 1
On Thu, Oct 04, 2018 at 10:14:17PM -, Patchwork wrote:
> == Series Details ==
>
> Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
> URL : https://patchwork.freedesktop.org/series/49678/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
>
On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote:
> On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote:
> > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote:
> > > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote:
> > > > On Thu, Oct 04, 2018 at
On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote:
> On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote:
> > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote:
> > > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan
> > > wrote:
> > > > On Thu, 2018-10-04 at
== Series Details ==
Series: series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before
selective update entry"
URL : https://patchwork.freedesktop.org/series/50593/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10371 =
== Summary - SUCCESS ==
== Series Details ==
Series: drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs
entry. (rev4)
URL : https://patchwork.freedesktop.org/series/49800/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10372 =
== Summary - SUCCESS ==
No
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/49678/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10366 =
== Summary - SUCCESS ==
No regressions found.
From: Anusha Srivatsa
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr:
restructure CSR firmware definition macros")
v4: Rodrigo fixing his own mess on commit mentioning on v3
comment above.
== Series Details ==
Series: Watermarks small fixes/improvements
URL : https://patchwork.freedesktop.org/series/50579/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915: don't apply Display WAs 1125 and 1126 to GLK/CNL+
Okay!
Commit: drm/i915: fix the transition
== Series Details ==
Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE
URL : https://patchwork.freedesktop.org/series/50561/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4667_full -> IGTPW_1909_full =
== Summary - WARNING ==
Minor unknown changes coming
Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu:
> From: Anusha Srivatsa
>
> Add missing MODULE_FIRMWARE while loading DMC ICL.
>
> v2: Add Fixes tag. (Rodrigo)
> v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr:
> restructure CSR firmware definition macros")
> v4:
== Series Details ==
Series: drm/i915: Fix VIDEO_DIP_CTL bit shifts
URL : https://patchwork.freedesktop.org/series/50573/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10365_full =
== Summary - WARNING ==
Minor unknown changes coming with
On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote:
> The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
> definitions are unused.
If they are unused why are we fixing them instead of removing? Or better,
why did we add them?
Lucas De Marchi
>
> Cc: Manasi
== Series Details ==
Series: Watermarks small fixes/improvements
URL : https://patchwork.freedesktop.org/series/50579/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10368 =
== Summary - SUCCESS ==
No regressions found.
External URL:
On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote:
> On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote:
> > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote:
> > > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan
> > > wrote:
> > > > The shifts for
As mentioned in the previous commit, we currently prevent new modesets
on recently-removed MST connectors by returning no encoder from our
->best_encoder() callback once the MST port has disappeared. This is
wrong however, because it prevents legacy modesetting users from being
able to disable
Next version of https://patchwork.freedesktop.org/series/49878/ . No
changes, except that these patches are against master so hopefully
intel's CI doesn't get confused this time.
Lyude Paul (5):
drm/atomic_helper: Disallow new modesets on unregistered connectors
drm/nouveau: Fix
Currently we set intel_connector->mst_port to NULL to signify that the
MST port has been removed from the system so that we can prevent further
action on the port such as connector probes, mode probing, etc.
However, we're going to need access to intel_connector->mst_port in
order to fixup
Since we need to be able to allow DPMS on->off prop changes after an MST
port has disappeared from the system, we need to be able to make sure we
can compute a config for the resulting atomic commit. Currently this is
impossible when the port has disappeared, since the VCPI slot searching
we try
Currently, i915 appears to rely on blocking modesets on
no-longer-present MSTB ports by simply returning NULL for
->best_encoder(), which in turn causes any new atomic commits that don't
disable the CRTC to fail. This is wrong however, since we still want to
allow userspace to disable CRTCs on
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode
URL : https://patchwork.freedesktop.org/series/50569/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10364_full =
== Summary - SUCCESS ==
No
The transition watermarks ask for Selected Result Blocks (the real
value), not Result Blocks (the integer value). Given how ceilings are
applied in both the non-transition and the transition watermarks
calculations, we can get away with assuming that Selected Result
Blocks is actually Result
BSpec does not show these WAs as applicable to GLK, and for CNL it
only shows them applicable for a super early pre-production stepping
we shouldn't be caring about anymore. Remove these so we can avoid
them on ICL too.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_pm.c | 43
This message is currently marked as DRM_DEBUG_ATOMIC. I would like it
to be DRM_DEBUG_KMS since it is more KMS than atomic, and this will
also make the message appear in the CI logs, which may or may not help
us with some FIFO underrun bugs.
Signed-off-by: Paulo Zanoni
---
On these platforms we're supposed to unconditonally pick the method 2
result instead of the minimum.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_pm.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c
The transition minimum is 14 blocks for gens 9 and 10, and 4 blocks
for gen 11. This minimum value is supposed to be added to the
configurable trans_amount. This matches both BSpec and additional
information provided by our HW engineers.
Signed-off-by: Paulo Zanoni
---
I'm investigating ICL watermarks failures and these are some of the immediate
problems I was able to find in the watermarks code. I don't think they're enough
to fix the problems our CI is able to reproduce, but I do think these changes
are worth having.
Paulo Zanoni (6):
drm/i915: don't apply
We were writing to PLANE_BUF_CFG(pipe, plane_id) twice for every
platform, and we were even using different values on the gen10- planar
case. The first write is useless since it just gets replaced with the
next one, so kill it.
There's a lot to improve in the DDB code, but let's start by avoiding
On Thu, Oct 04, 2018 at 04:03:05PM -0700, Lucas De Marchi wrote:
> On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote:
> > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
> > definitions are unused.
>
> If they are unused why are we fixing them instead of
== Series Details ==
Series: drm/i915/icl: MBUS B credit change
URL : https://patchwork.freedesktop.org/series/50560/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10363_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
== Series Details ==
Series: Fix legacy DPMS changes with MST (rev3)
URL : https://patchwork.freedesktop.org/series/49878/
State : failure
== Summary ==
Applying: drm/atomic_helper: Disallow new modesets on unregistered connectors
Applying: drm/nouveau: Fix nv50_mstc->best_encoder()
Applying:
With the exception of modesets which would switch the DPMS state of a
connector from on to off, we want to make sure that we disallow all
modesets which would result in enabling a new monitor or a new mode
configuration on a monitor if the connector for the display in question
is no longer
== Series Details ==
Series: series starting with [1/2] drm/i915/psr: Reduce PSR2 "frames before
selective update entry"
URL : https://patchwork.freedesktop.org/series/50593/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915/psr: Reduce PSR2 "frames before selective
DC5 and DC6 counter register tells about residency of DC5 and DC6.
These registers are same for SKL and ICL.
v2 : Remove csr_version check.
Added generic check regarding DC counters for Gen9 onwards. (Rodrigo)
v3 : Simplified gen checks. (Chris)
v4 : Simplified "if" ladder for multiple
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/49678/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
-:9:
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)
URL : https://patchwork.freedesktop.org/series/49678/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10367 =
== Summary - SUCCESS ==
No regressions found.
As mentioned in the previous commit, we currently prevent new modesets
on recently-removed MST connectors by returning no encoder from our
->best_encoder() callback once the MST port has disappeared. This is
wrong however, because it prevents legacy modesetting users from being
able to disable
Next version of https://patchwork.freedesktop.org/series/49877/
This fixes some rather silly bugs regarding DPMS On->Off changes failing
for connectors which were just recently destroyed.
Lyude Paul (5):
drm/atomic_helper: Disallow new modesets on unregistered connectors
drm/nouveau: Fix
With the exception of modesets which would switch the DPMS state of a
connector from on to off, we want to make sure that we disallow all
modesets which would result in enabling a new monitor or a new mode
configuration on a monitor if the connector for the display in question
is no longer
Currently, i915 appears to rely on blocking modesets on
no-longer-present MSTB ports by simply returning NULL for
->best_encoder(), which in turn causes any new atomic commits that don't
disable the CRTC to fail. This is wrong however, since we still want to
allow userspace to disable CRTCs on
Since we need to be able to allow DPMS on->off prop changes after an MST
port has disappeared from the system, we need to be able to make sure we
can compute a config for the resulting atomic commit. Currently this is
impossible when the port has disappeared, since the VCPI slot searching
we try
Currently we set intel_connector->mst_port to NULL to signify that the
MST port has been removed from the system so that we can prevent further
action on the port such as connector probes, mode probing, etc.
However, we're going to need access to intel_connector->mst_port in
order to fixup
On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote:
> On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote:
> > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote:
> > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the
> > > definitions are
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)
URL : https://patchwork.freedesktop.org/series/49678/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10367_full =
== Summary - WARNING ==
Minor unknown
== Series Details ==
Series: drm/i915: Always try to reset the GPU on takeover (rev2)
URL : https://patchwork.freedesktop.org/series/50497/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4924_full -> Patchwork_10350_full =
== Summary - WARNING ==
Minor unknown changes
On Thu, 04 Oct 2018, "Kulkarni, Vandita" wrote:
>> -Original Message-
>> From: Nikula, Jani
>> Sent: Wednesday, October 3, 2018 5:11 PM
>> To: Ville Syrjälä ; Kulkarni, Vandita
>>
>> Cc: intel-gfx@lists.freedesktop.org; Zanoni, Paulo R
>>
>> Subject: Re: [Intel-gfx] [RFC 1/3]
Instead of passing crtc and dereferencing crtc->config,
passs the correct crtc_state and obtain the crtc pointer from there.
Changes since v1:
- Move vlv/chv changes and i9xx_set_pll_dividers changes
from crtc_enable/disable patches to here.
- Add commit message.
Signed-off-by: Maarten
We're already using crtc_state here and made sure no modeset is occuring
by looking at conn_state->commit->hw_done, so there's no need to
dereference crtc->config.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 4 ++--
1 file changed, 2
Rename intel_crtc to crtc, and pass crtc_state instead of looking at
crtc->config.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
New version, already reviewed but need to get CI results before committing. :)
Maarten Lankhorst (13):
drm/i915: Remove dereferences of crtc->config in set_pipeconf/misc
functions, v2.
drm/i915: Make panel fitter functions take state
drm/i915: Make intel_set_pipe_timings/src_size take a
Instead of passing crtc and dereferencing crtc->config,
pass the correct crtc_state and obtain the crtc pointer from there.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Rename intel_crtc to crtc, and pass crtc_state so we don't have to
dereference crtc->config.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
These functions already have a pointer to the correct state,
so use it instead of crtc->config.
Changes since v1:
- Move pll changes to the pll patch.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 42 ++--
1 file
Pass the state instead of looking at crtc->config and rename intel_crtc
to crtc.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 47 ++--
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git
Pass the full state to intel_ddi_clk_select, so we can pass it
to icl_pll_to_ddi_pll_sel instead of passign the crtc and having
to dereference crtc->config
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 15 ---
1 file changed, 8
Fixing chv_set_phy_signal_level() still requires too many levels of
indirection to pass crtc_state along, but chv_data_lane_soft_reset()
already has a crtc_state we can use.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dpio_phy.c | 4 ++--
1 file
fbdev init shouldn't race with userspace since it's called from
intel_modeset_init, so it's safe to dereference crtc->state and
assume nothing changed yet.
At least not more harmful than crtc->config.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
If we look at the correct state instead of crtc->config, we can nuke the
force parameter, and we cleanup a few more users of crtc->config at the
same time.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 91 ++--
1
1 - 100 of 164 matches
Mail list logo
