Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Program SKL+ watermarks/ddb more carefully (rev7)

2018-11-15 Thread Ville Syrjälä
On Thu, Nov 15, 2018 at 04:23:46PM +0200, Ville Syrjälä wrote: > On Thu, Nov 15, 2018 at 05:21:46AM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev7) > > URL : https://patchwork.freedesktop.org/series/51878/ > > State :

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: make the aux channel macros private to the vbt parser

2018-11-15 Thread Imre Deak
On Thu, Nov 15, 2018 at 12:52:37PM +0200, Jani Nikula wrote: > Hide the aux channel macros in intel_vbt_defs.h now that their use has > been abstracted in intel_bios_port_aux_ch(). > > Cc: Imre Deak > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 7 --- >

[Intel-gfx] [PATCH v17 2/4] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests

2018-11-15 Thread Tvrtko Ursulin
From: Lionel Landwerlin Verify that the per-context dynamic SSEU uAPI works as expected. v2: Add subslice tests (Lionel) Use MI_SET_PREDICATE for further verification when available (Lionel) v3: Rename to gem_ctx_rpcs (Lionel) v4: Update kernel API (Lionel) Add 0 value test (Lionel)

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: make the aux channel macros private to the vbt parser

2018-11-15 Thread Jani Nikula
On Thu, 15 Nov 2018, Jani Nikula wrote: > On Thu, 15 Nov 2018, Imre Deak wrote: >> On Thu, Nov 15, 2018 at 12:52:37PM +0200, Jani Nikula wrote: >>> Hide the aux channel macros in intel_vbt_defs.h now that their use has >>> been abstracted in intel_bios_port_aux_ch(). >>> >>> Cc: Imre Deak >>>

[Intel-gfx] [PULL] drm-intel-fixes

2018-11-15 Thread Joonas Lahtinen
Hi Dave, Most importantly we have a fix for an incorrect EU count reported from kernel, Gen9+ scaled output fix, and avoiding OOPS on MST display systems. So looking pretty stable. Regards, Joonas PS. Had some CI turbulence for this PR as we raised the bar so that now a loss of lockdep

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: make the aux channel macros private to the vbt parser

2018-11-15 Thread Jani Nikula
On Thu, 15 Nov 2018, Imre Deak wrote: > On Thu, Nov 15, 2018 at 12:52:37PM +0200, Jani Nikula wrote: >> Hide the aux channel macros in intel_vbt_defs.h now that their use has >> been abstracted in intel_bios_port_aux_ch(). >> >> Cc: Imre Deak >> Signed-off-by: Jani Nikula >> --- >>

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h URL : https://patchwork.freedesktop.org/series/52528/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5142_full -> Patchwork_10829_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH v3] drm/i915/hdmi: Reorder structure to match specification

2018-11-15 Thread Jani Nikula
On Wed, 31 Oct 2018, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > reorder structure of 297, 594 N values to group Audio Sample Frequencies > together to make updating from HDMI specification easier. > > V2: Match patch 1/2 version > V3: Arrange by sample freq, then pixel clock. > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Program SKL+ watermarks/ddb more carefully (rev7)

2018-11-15 Thread Ville Syrjälä
On Thu, Nov 15, 2018 at 05:21:46AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev7) > URL : https://patchwork.freedesktop.org/series/51878/ > State : failure > > == Summary == > > = CI Bug Log - changes from

[Intel-gfx] [PATCH] drm/i915/selftests: Workaround an issue with unused lockdep subclass

2018-11-15 Thread Chris Wilson
lockdep insists that if we give a lock a subclass, it must be used. Failure to do so triggers a self-consistency check when reading lockdep_stats: [ 49.902002] DEBUG_LOCKS_WARN_ON(debug_atomic_read(nr_unused_locks) != nr_unused) [ 49.902009] WARNING: CPU: 3 PID: 383 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable LP3 watermarks on all SNB machines (rev2)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Disable LP3 watermarks on all SNB machines (rev2) URL : https://patchwork.freedesktop.org/series/52440/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147 -> Patchwork_10832 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH i-g-t 1/4] kms_content_protection: Fix log bug on 32-bit platforms.

2018-11-15 Thread Eric Anholt
Ville Syrjälä writes: > On Wed, Nov 14, 2018 at 02:28:29PM -0800, Eric Anholt wrote: >> long is different between 32 and 64 and should basically never be >> used. Fixes compiler warning about passing the wrong type. >> >> Signed-off-by: Eric Anholt >> --- >> tests/kms_content_protection.c |

Re: [Intel-gfx] [PATCH i-g-t 1/4] kms_content_protection: Fix log bug on 32-bit platforms.

2018-11-15 Thread Ville Syrjälä
On Thu, Nov 15, 2018 at 10:51:51AM -0800, Eric Anholt wrote: > Ville Syrjälä writes: > > > On Wed, Nov 14, 2018 at 02:28:29PM -0800, Eric Anholt wrote: > >> long is different between 32 and 64 and should basically never be > >> used. Fixes compiler warning about passing the wrong type. > >> >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Workaround an issue with unused lockdep subclass

2018-11-15 Thread Matthew Auld
On Thu, 15 Nov 2018 at 17:45, Chris Wilson wrote: > > lockdep insists that if we give a lock a subclass, it must be used. > Failure to do so triggers a self-consistency check when reading > lockdep_stats: > > [ 49.902002] DEBUG_LOCKS_WARN_ON(debug_atomic_read(nr_unused_locks) != > nr_unused) >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy URL : https://patchwork.freedesktop.org/series/52559/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147 -> Patchwork_10831 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Workaround an issue with unused lockdep subclass (rev2)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Workaround an issue with unused lockdep subclass (rev2) URL : https://patchwork.freedesktop.org/series/52551/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147 -> Patchwork_10833 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PATCH] drm/i915/selftests: Workaround an issue with unused lockdep subclass

2018-11-15 Thread Chris Wilson
lockdep insists that if we give a lock a subclass, it must be used. Failure to do so triggers a self-consistency check when reading lockdep_stats: [ 49.902002] DEBUG_LOCKS_WARN_ON(debug_atomic_read(nr_unused_locks) != nr_unused) [ 49.902009] WARNING: CPU: 3 PID: 383 at

[Intel-gfx] [PATCH] drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy

2018-11-15 Thread clinton . a . taylor
From: Clint Taylor The calibration RCOMP value in PORT_TX_DW6 in stored in dev_priv during driver init. Use this value instead of reading the register again as the power well for PORTA RCOMP register may not be enabled and will return 0x instead of the computed value. Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH 7/7] drm/i915/psr: Disable DRRS if enabled when enabling PSR from debugfs

2018-11-15 Thread Souza, Jose
On Mon, 2018-11-12 at 11:17 +0100, Maarten Lankhorst wrote: > Op 09-11-18 om 21:20 schreef José Roberto de Souza: > > If panel supports DRRS and PSR and if driver is loaded without PSR > > enabled, driver will enable DRRS as expected but if PSR is enabled > > by > > debugfs latter it will keep PSR

Re: [Intel-gfx] [PATCH] drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy

2018-11-15 Thread Atwood, Matthew S
On Thu, 2018-11-15 at 11:48 -0800, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > The calibration RCOMP value in PORT_TX_DW6 in stored in dev_priv > during > driver init. Use this value instead of reading the register again as > the > power well for PORTA RCOMP register may not be

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Disable LP3 watermarks on all SNB machines (rev2)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Disable LP3 watermarks on all SNB machines (rev2) URL : https://patchwork.freedesktop.org/series/52440/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5147_full -> Patchwork_10832_full = == Summary - FAILURE == Serious unknown

[Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-11-15 Thread Matt Roper
Third version of the series previously posted here: https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.html This version incorporates review feedback from Ville and Sean Paul. The first patch here can be merged whenever it receives review approval. The second and third

[Intel-gfx] [PATCH v3 2/3] drm: Add CRTC background color property (v2)

2018-11-15 Thread Matt Roper
Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Compositors that want a UI with a solid color background can potentially save memory bandwidth by setting the CRTC background

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for CRTC background color (rev3)

2018-11-15 Thread Patchwork
== Series Details == Series: CRTC background color (rev3) URL : https://patchwork.freedesktop.org/series/50834/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8424c4b432e2 drm/i915: Force background color to black for gen9+ (v2) 05fa1ef11dab drm: Add CRTC background color

[Intel-gfx] [PATCH v6 2/6] drm/dp_mst: Return kref_put() result from drm_dp_put_port()

2018-11-15 Thread Lyude Paul
This will let us warn if we end up freeing a port when we're not expecting to, which will make reporting erroneous usage of the new MST VCPI helpers a little easier. Signed-off-by: Lyude Paul Cc: Daniel Vetter --- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- 1 file changed, 3

[Intel-gfx] [PATCH v6 1/6] drm/dp_mst: Add some atomic state iterator macros

2018-11-15 Thread Lyude Paul
Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter --- include/drm/drm_dp_mst_helper.h | 77 + 1 file changed, 77 insertions(+) diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h index 59f005b419cf..3faceb66f5cb 100644 ---

[Intel-gfx] [PATCH v6 3/6] drm/dp_mst: Start tracking per-port VCPI allocations

2018-11-15 Thread Lyude Paul
There has been a TODO waiting for quite a long time in drm_dp_mst_topology.c: /* We cannot rely on port->vcpi.num_slots to update * topology_state->avail_slots as the port may not exist if the parent * branch device was unplugged. This should be fixed by tracking

[Intel-gfx] [PATCH v6 4/6] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()

2018-11-15 Thread Lyude Paul
It occurred to me that we never actually check this! So let's start doing that. Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_dp_mst_topology.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c

[Intel-gfx] [PATCH v6 5/6] drm/nouveau: Stop unsetting mstc->port, check connector registration

2018-11-15 Thread Lyude Paul
Same thing we did in i915, but for nouveau now. Signed-off-by: Lyude Paul Cc: Daniel Vetter --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c

[Intel-gfx] [PATCH v6 6/6] drm/nouveau: Use atomic VCPI helpers for MST

2018-11-15 Thread Lyude Paul
Currently, nouveau uses the yolo method of setting up MST displays: it uses the old VCPI helpers (drm_dp_find_vcpi_slots()) for computing the display configuration. These helpers don't take care to make sure they take a reference to the mstb port that they're checking, and additionally don't

[Intel-gfx] [PATCH v6 0/6] drm/dp_mst: Improve VCPI helpers, use in nouveau

2018-11-15 Thread Lyude Paul
This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. [sorry for still not adding your R-Bs! I ended up needing to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Workaround an issue with unused lockdep subclass (rev2)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Workaround an issue with unused lockdep subclass (rev2) URL : https://patchwork.freedesktop.org/series/52551/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147_full -> Patchwork_10833_full = == Summary - WARNING ==

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/3] drm/i915/icl: replace check for combo phy

2018-11-15 Thread Souza, Jose
Pushed to drm-intel-next-queued. On Wed, 2018-11-14 at 06:23 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v3,1/3] drm/i915/icl: replace check for > combo phy > URL : https://patchwork.freedesktop.org/series/52459/ > State : success > > == Summary == > > =

[Intel-gfx] [PATCH i-g-t v3] tests/kms_crtc_background_color: overhaul for latest ABI proposal (v3)

2018-11-15 Thread Matt Roper
CRTC background color kernel patches were written about 2.5 years ago and floated on the upstream mailing list, but since no opensource userspace materialized, we never actually merged them. However the corresponding IGT test did get merged and has basically been dead code ever since. A couple

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy URL : https://patchwork.freedesktop.org/series/52559/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147_full -> Patchwork_10831_full = == Summary - WARNING == Minor unknown

[Intel-gfx] [PATCH v3 3/3] drm/i915/gen9+: Add support for pipe background color (v3)

2018-11-15 Thread Matt Roper
Gen9+ platforms allow CRTC's to be programmed with a background/canvas color below the programmable planes. Let's expose this for use by compositors. v2: - Split out bgcolor sanitization and programming of csc/gamma bits to a separate patch that we can land before the ABI changes are ready

[Intel-gfx] [PATCH v3 1/3] drm/i915: Force background color to black for gen9+ (v2)

2018-11-15 Thread Matt Roper
We don't yet allow userspace to control the CRTC background color, but we should manually program the color to black to ensure the BIOS didn't leave us with some other color. We should also set the pipe gamma and pipe CSC bits so that the background color goes through the same color management

[Intel-gfx] [PATCH v3 2/3] drm: Add CRTC background color property (v3)

2018-11-15 Thread Matt Roper
Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Compositors that want a UI with a solid color background can potentially save memory bandwidth by setting the CRTC background

[Intel-gfx] ✓ Fi.CI.BAT: success for CRTC background color (rev3)

2018-11-15 Thread Patchwork
== Series Details == Series: CRTC background color (rev3) URL : https://patchwork.freedesktop.org/series/50834/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147 -> Patchwork_10834 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/51412/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/dp_mst: Add some atomic state iterator macros Okay! Commit:

Re: [Intel-gfx] [PATCH v9 20/24] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable

2018-11-15 Thread Manasi Navare
On Tue, Nov 13, 2018 at 05:52:28PM -0800, Manasi Navare wrote: > DSC can be supported per DP connector. This patch adds a per connector > debugfs node to expose DSC support capability by the kernel. > The same node can be used from userspace to force DSC enable. > > force_dsc_en written through

[Intel-gfx] ✓ Fi.CI.IGT: success for CRTC background color (rev3)

2018-11-15 Thread Patchwork
== Series Details == Series: CRTC background color (rev3) URL : https://patchwork.freedesktop.org/series/50834/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5147_full -> Patchwork_10834_full = == Summary - SUCCESS == No regressions found. == Known issues ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/51412/ State : warning == Summary == $ dim checkpatch origin/drm-tip 446143844eea drm/dp_mst: Add some atomic state iterator macros -:7: WARNING:COMMIT_MESSAGE:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/51412/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5149_full -> Patchwork_10835_full = == Summary - FAILURE == Serious unknown changes

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)

2018-11-15 Thread Patchwork
== Series Details == Series: drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/51412/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5149 -> Patchwork_10835 = == Summary - SUCCESS == No regressions found. External

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Workaround an issue with unused lockdep subclass

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Workaround an issue with unused lockdep subclass URL : https://patchwork.freedesktop.org/series/52551/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5147 -> Patchwork_10830 = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy URL : https://patchwork.freedesktop.org/series/52559/ State : warning == Summary == $ dim checkpatch origin/drm-tip e9cbd5053fbd drm/i915/glk: Use cached RCOMP value when re-enabling DPIO Phy -:29:

Re: [Intel-gfx] [RFC 6/7] drm/i915: Introduce subplatform concept

2018-11-15 Thread Tvrtko Ursulin
On 13/11/2018 22:28, Jani Nikula wrote: On Tue, 13 Nov 2018, Tvrtko Ursulin wrote: On 13/11/2018 11:40, Jani Nikula wrote: On Mon, 12 Nov 2018, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Introduce subplatform mask to eliminate throughout the code devid checking sprinkle, mostly courtesy

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Pass the plane to icl_program_input_csc_coeff()

2018-11-15 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjala [mailto:ville.syrj...@linux.intel.com] >Sent: Thursday, November 15, 2018 2:37 AM >To: intel-gfx@lists.freedesktop.org >Cc: Shankar, Uma ; Maarten Lankhorst > >Subject: [PATCH v2 13/13] drm/i915: Pass the plane to >icl_program_input_csc_coeff() >

Re: [Intel-gfx] [PATCH i-g-t 1/4] kms_content_protection: Fix log bug on 32-bit platforms.

2018-11-15 Thread Ville Syrjälä
On Wed, Nov 14, 2018 at 02:28:29PM -0800, Eric Anholt wrote: > long is different between 32 and 64 and should basically never be > used. Fixes compiler warning about passing the wrong type. > > Signed-off-by: Eric Anholt > --- > tests/kms_content_protection.c | 3 ++- > 1 file changed, 2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: remove excess line continuation backslashes

2018-11-15 Thread Patchwork
== Series Details == Series: drm/i915: remove excess line continuation backslashes URL : https://patchwork.freedesktop.org/series/52477/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5139_full -> Patchwork_10825_full = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH 1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch()

2018-11-15 Thread Jani Nikula
Conform to function naming in intel_bios.c. Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_bios.c | 3 ++- drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c |

[Intel-gfx] [PATCH 2/3] drm/i915: remove unused DDC PIN macros

2018-11-15 Thread Jani Nikula
Their user has vanished in the course of history. Remove. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 8c6ca39feefc..d100c38697ff 100644 ---

[Intel-gfx] [PATCH 3/3] drm/i915/bios: make the aux channel macros private to the vbt parser

2018-11-15 Thread Jani Nikula
Hide the aux channel macros in intel_vbt_defs.h now that their use has been abstracted in intel_bios_port_aux_ch(). Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 7 --- drivers/gpu/drm/i915/intel_vbt_defs.h | 7 +++ 2 files changed, 7

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch()

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch() URL : https://patchwork.freedesktop.org/series/52525/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/bios: rename

Re: [Intel-gfx] [PATCH] drm/i915: Fix plane allocation/free functions

2018-11-15 Thread Maarten Lankhorst
Op 13-11-18 om 15:02 schreef Ville Syrjälä: > On Tue, Nov 13, 2018 at 10:28:04AM +0100, Maarten Lankhorst wrote: >> Use intel_plane_destroy_state in intel_plane_free to free the state. > Not entirely necessary since we have nothing in the state at that moment > that would required to be freed

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Return immediately if trylock fails for direct-reclaim

2018-11-15 Thread Tvrtko Ursulin
On 13/11/2018 17:10, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-13 10:24:43) On 09/11/2018 11:44, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-09 07:30:34) On 08/11/2018 16:48, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-08 16:23:08) On 08/11/2018 08:17, Chris

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch()

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch() URL : https://patchwork.freedesktop.org/series/52525/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5141 -> Patchwork_10828 = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH] drm/i915: remove excess line continuation backslashes

2018-11-15 Thread Jani Nikula
On Wed, 14 Nov 2018, Jani Nikula wrote: > On Wed, 14 Nov 2018, Ville Syrjälä wrote: >> On Wed, Nov 14, 2018 at 01:21:30PM +0200, Jani Nikula wrote: >>> While removing .palette_offsets, I removed the commas after >>> .trans_offsets in the macros, but failed to remove the line continuation >>>

[Intel-gfx] [PATCH 5/5] drm/i915/fixed: cosmetic cleanup

2018-11-15 Thread Jani Nikula
Clean up fixed point temp variable initialization, use the more conventional tmp name for temp variables, add empty lines before return. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_fixed.h | 77 +-- 1 file changed, 41

[Intel-gfx] [PATCH 2/5] drm/i915/fixed: prefer kernel types over stdint types

2018-11-15 Thread Jani Nikula
While at it, conform to kernel spacing (i.e. no space) after cast. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_fixed.h | 61 +++ 1 file changed, 29 insertions(+), 32 deletions(-) diff --git

[Intel-gfx] [PATCH 1/5] drm/i915: extract fixed point math to i915_fixed.h

2018-11-15 Thread Jani Nikula
Reduce bloat in one of the bigger header files. Fix some indentation while at it. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 139 + drivers/gpu/drm/i915/i915_fixed.h | 142 ++

[Intel-gfx] [PATCH 4/5] drm/i915/fixed: simplify is_fixed16_zero()

2018-11-15 Thread Jani Nikula
Simply return the condition. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_fixed.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_fixed.h b/drivers/gpu/drm/i915/i915_fixed.h index 927c59395569..524f1c95c4e1

[Intel-gfx] [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition

2018-11-15 Thread Jani Nikula
No need to use a compound statement enclosed in parenthesis where a C99 compound literal will do. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_fixed.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_fixed.h

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Pass the plane to icl_program_input_csc_coeff()

2018-11-15 Thread Maarten Lankhorst
Op 14-11-18 om 22:07 schreef Ville Syrjala: > From: Ville Syrjälä > > On icl+ the plane state that gets passed to update_slave() is not > the plane state of the plane we're programming. With NV12 the > plane state would be coming from the master (UV) plane whereas > the plane we're programming is

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch()

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/bios: rename intel_aux_ch() to intel_bios_port_aux_ch() URL : https://patchwork.freedesktop.org/series/52525/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5141_full -> Patchwork_10828_full = == Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h URL : https://patchwork.freedesktop.org/series/52528/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6a9582cd3a2e drm/i915: extract fixed point math to i915_fixed.h

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h URL : https://patchwork.freedesktop.org/series/52528/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: extract fixed point math to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h

2018-11-15 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h URL : https://patchwork.freedesktop.org/series/52528/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5142 -> Patchwork_10829 = == Summary - SUCCESS == No