Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-21 Thread Lyude Paul
For the nouveau and drm core changes Reviewed-by: Lyude Paul On Mon, 2018-11-12 at 16:01 +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook,

Re: [Intel-gfx] [PATCH v2 05/13] drm/i915: Fix latency==0 handling for level 0 watermark on skl+

2018-11-21 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 03:14:34PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:21PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > If the level 0 latency is 0 we can't do anything. Return an error > > rather than success. > > > > While this can't happen due to

Re: [Intel-gfx] [PATCH v2 1/7] Revert "drm/i915: Kill GEN_FOREVER"

2018-11-21 Thread Rodrigo Vivi
On Tue, Nov 06, 2018 at 01:51:17PM -0800, Lucas De Marchi wrote: > This reverts commit 5bc0e89ff1bee1566bd2fbd1142dce001c068aeb. > > The macro was added and then never used so it was removed. However > after removal it was noticed that it was actually something that should > indeed be useful to

Re: [Intel-gfx] [PATCH v2 10/13] drm/i915: Move ddb/wm programming into plane update/disable hooks on skl+

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 04:48:39PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:26PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On SKL+ the plane WM/BUF_CFG registers are a proper part of each > > plane's register set. That means accessing them will cancel any > >

[Intel-gfx] [PATCH v5 6/6] drm/i915/hsw: Drop the stereo 3D enabled check in psr_compute_config()

2018-11-21 Thread José Roberto de Souza
We should not access hardware while computing config also we don't support stereo 3D so this test was never true. Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 7 --- 1 file changed, 7

[Intel-gfx] [PATCH v5 2/6] drm/i915: Check PSR errors instead of retrain while PSR is enabled

2018-11-21 Thread José Roberto de Souza
When a PSR error happens sink sets the PSR error register and also set the link status to a error status. So in the short pulse handling it was returning earlier and doing a full detection and attempting to retrain but it fails as PSR HW is in change of the main-link. Just call

[Intel-gfx] [PATCH v5 3/6] drm/i915: Do not enable PSR in the next modeset after a error

2018-11-21 Thread José Roberto de Souza
When we detect a error and disable PSR, it is kept disabled until the next modeset but as the sink already show signs that it do not properly work with PSR lets disabled it for good to avoid any additional flickering. Cc: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto

[Intel-gfx] [PATCH v5 4/6] drm/i915: Disable PSR when a PSR aux error happen

2018-11-21 Thread José Roberto de Souza
While PSR is active hardware will do aux transactions by it self to wakeup sink to receive a new frame when necessary. If that transaction is not acked by sink, hardware will trigger this interruption. So let's disable PSR as it is a hint that there is problem with this sink. The removed FIXME

[Intel-gfx] [PATCH v5 5/6] drm/i915: Keep PSR disabled after a driver reload after a PSR error

2018-11-21 Thread José Roberto de Souza
If a PSR error happened and the driver is reloaded, the EDP_PSR_IIR will still keep the error set even after the reset done in the irq_preinstall and irq_uninstall hooks. And enabling in this situation cause the screen to freeze in the first time that PSR HW tries to activate so lets keep PSR

[Intel-gfx] [PATCH v5 1/6] drm/i915: Avoid a full port detection in the first eDP short pulse

2018-11-21 Thread José Roberto de Souza
Some eDP panels do not set a valid sink count value and even for the ones that sets is should always be one for eDP, that is why it is not cached in intel_edp_init_dpcd(). But intel_dp_short_pulse() compares the old count with the read one if there is a mistmatch a full port detection will be

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse

2018-11-21 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse URL : https://patchwork.freedesktop.org/series/52848/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Avoid a full

Re: [Intel-gfx] [PATCH v2 03/13] drm/i915: Introduce crtc_state->update_planes bitmask

2018-11-21 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 03:14:14PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Keep track which planes need updating during the commit. For now this > > is just (was_visible || is_visible) but I'll have need to update

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Clean up skl+ vs. icl+ watermark computation

2018-11-21 Thread Matt Roper
On Wed, Nov 21, 2018 at 09:05:33PM +0200, Ville Syrjälä wrote: > On Tue, Nov 20, 2018 at 02:44:34PM -0800, Matt Roper wrote: > > On Wed, Nov 14, 2018 at 11:07:24PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä ...snip... > > > +static int icl_build_plane_wm(struct skl_ddb_allocation *ddb,

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: merge gen checks to use range

2018-11-21 Thread Rodrigo Vivi
On Tue, Nov 06, 2018 at 01:51:22PM -0800, Lucas De Marchi wrote: > Instead of using several GT_GEN(), let's pass the range to > GT_GEN_RANGE(). By code inspection these were the ranges deemed > necessary for spatch: > > @@ > expression e; > @@ > ( > - GT_GEN(e, 3) || GT_GEN(e, 2) > +

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Program SKL+ watermarks/ddb more carefully (rev8)

2018-11-21 Thread Ville Syrjälä
On Wed, Nov 21, 2018 at 06:05:21AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Program SKL+ watermarks/ddb more carefully (rev8) > URL : https://patchwork.freedesktop.org/series/51878/ > State : failure > > == Summary == > > = CI Bug Log - changes from

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: rename IS_GEN9_* to GT_GEN9_*

2018-11-21 Thread Rodrigo Vivi
On Tue, Nov 06, 2018 at 01:51:20PM -0800, Lucas De Marchi wrote: > Like it was done for the generic IS_GEN -> GT_GEN rename, but since > the LP/BC variants only exist in gen 9, keep the single macro > definition. Also move the define to be together with GT_GEN(). > > Users were converted with: >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse

2018-11-21 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse URL : https://patchwork.freedesktop.org/series/52848/ State : warning == Summary == $ dim checkpatch origin/drm-tip 38e729ea9ec4 drm/i915: Avoid a full port detection

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Clean up skl+ vs. icl+ watermark computation

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 02:44:34PM -0800, Matt Roper wrote: > On Wed, Nov 14, 2018 at 11:07:24PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make a cleaner split between the skl+ and icl+ ways of computing > > watermarks. This way skl_build_pipe_wm() doesn't have to know any > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout URL : https://patchwork.freedesktop.org/series/52820/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5180_full -> Patchwork_10876_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Disable PSR when a PSR aux error happen

2018-11-21 Thread Rodrigo Vivi
On Tue, Nov 20, 2018 at 03:05:07PM -0800, Souza, Jose wrote: > On Tue, 2018-11-20 at 14:47 -0800, Rodrigo Vivi wrote: > > On Fri, Nov 09, 2018 at 12:20:13PM -0800, José Roberto de Souza > > wrote: > > > While PSR is active hardware will do aux transactions by it self to > > > wakeup sink to

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: replace IS_GEN with GT_GEN(..., N)

2018-11-21 Thread Rodrigo Vivi
On Tue, Nov 06, 2018 at 01:51:19PM -0800, Lucas De Marchi wrote: > Define GT_GEN() similarly to our GT_GEN_RANGE() and convert users of > IS_GEN to pss the gen as parameter. This prepares for the addition > of display gen checks by renaming the IS_GENx() and using common code > for all the n gens.

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-21 Thread Rodrigo Vivi
On Mon, Nov 19, 2018 at 02:20:55PM -0800, Lucas De Marchi wrote: > On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: > > > > On 08/11/2018 00:57, Lucas De Marchi wrote: > > > On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: > > > > > > > > On 06/11/2018 21:51, Lucas

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse

2018-11-21 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse URL : https://patchwork.freedesktop.org/series/52848/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5183 -> Patchwork_10883 = == Summary - SUCCESS

Re: [Intel-gfx] [PATCH] drm/atomic: Fix the early return in drm_atomic_set_mode_for_crtc()

2018-11-21 Thread Ville Syrjälä
On Wed, Nov 21, 2018 at 10:59:56AM +0100, Daniel Vetter wrote: > On Tue, Nov 20, 2018 at 07:55:42PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The early return in drm_atomic_set_mode_for_crtc() isn't quite > > right. It would mistakenly return and fail to update > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add rotation readout for plane initial config

2018-11-21 Thread Maarten Lankhorst
Op 20-11-18 om 23:20 schreef Rodrigo Vivi: > On Tue, Nov 20, 2018 at 03:54:50PM +0200, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> If we need to force a full plane update before userspace/fbdev >> have given us a proper plane state we should try to maintain the >> current plane state as

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

2018-11-21 Thread Ville Syrjälä
On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: > On Tue, 20 Nov 2018, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make life easier for drivers by simply passing the connector > > to drm_hdmi_avi_infoframe_from_display_mode() and > > drm_hdmi_avi_infoframe_quant_range().

Re: [Intel-gfx] [PATCH 4.20 regression fix] drm/i915: Revert "Fix assert_plane() warning on bootup with external display"

2018-11-21 Thread Ville Syrjälä
On Mon, Nov 19, 2018 at 11:35:00PM +0100, Hans de Goede wrote: > Starting with 4.20-rc1 I'm seeing the LCD screen briefly turn mostly purple > on devices with a DSI panel (seen on 2 different devices with a DSI panel). > > This happens both with and without fastboot=1. This is caused by > commit

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add rotation readout for plane initial config

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 02:20:14PM -0800, Rodrigo Vivi wrote: > On Tue, Nov 20, 2018 at 03:54:50PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > If we need to force a full plane update before userspace/fbdev > > have given us a proper plane state we should try to maintain the > >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Log test and subtest names for easier debugging

2018-11-21 Thread Tvrtko Ursulin
On 20/11/2018 18:18, Tvrtko Ursulin wrote: On 20/11/2018 18:10, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-20 17:58:33) On 20/11/2018 17:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-20 17:28:39) From: Tvrtko Ursulin Since pr_debug is not printed by default, change

Re: [Intel-gfx] [PATCH] drm/i915/ilk: Fix warning when reading emon_status with no output

2018-11-21 Thread Chris Wilson
Quoting Souza, Jose (2018-11-20 22:07:14) > On Mon, 2018-11-19 at 17:05 -0800, Rodrigo Vivi wrote: > > On Mon, Nov 19, 2018 at 03:01:01PM -0800, José Roberto de Souza > > wrote: > > > When there is no output no one will hold a runtime_pm reference > > > causing a warning when trying to read

Re: [Intel-gfx] [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

2018-11-21 Thread Christian König
Am 20.11.18 um 19:58 schrieb Kenny Ho: Account for the number of command submitted to amdgpu by type on a per cgroup basis, for the purpose of profiling/monitoring applications. x prefix in the control file name x.cmd_submitted.amd.stat signify experimental. Change-Id:

Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.

2018-11-21 Thread Petri Latvala
On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: > These are basic non-rendering tests of the UABI. > > Signed-off-by: Eric Anholt > --- > lib/igt_v3d.c | 4 -- > tests/Makefile.am | 2 + > tests/Makefile.sources| 6 +++ > tests/meson.build | 3 ++

Re: [Intel-gfx] [PATCH] drm/i915/backlight: Fix backlight takeover on LPT

2018-11-21 Thread Ville Syrjälä
On Wed, Nov 21, 2018 at 08:16:06AM +0100, Tolga Cakir wrote: > Am Di., 20. Nov. 2018 um 19:51 Uhr schrieb Ville Syrjälä > : > > > > On Tue, Nov 20, 2018 at 11:39:26AM +0100, Maarten Lankhorst wrote: > > > On lynxpoint the bios sometimes sets up the backlight using the CPU > > > display, but the

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do not touch PCH handshake registers if PCH is not present

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 02:32:41PM -0800, José Roberto de Souza wrote: > If no PCH was detected in intel_detect_pch() don't touch the > handshake registers. We are explicitly told to frob this on BXT/GLK. So this doesn't make sense. What is this supposed to fix? > > Cc: Lucas De Marchi > Cc:

Re: [Intel-gfx] v4.20-rc1: list_del corruption on thinkpad x220

2018-11-21 Thread Joonas Lahtinen
+ Chris Quoting Pavel Machek (2018-11-08 19:58:03) > Hi! > > My machine locked hard (thinkpad x220). After reboot, I found this in > syslog: > > Sounds like memory corruption..? Does not sound like easy to debug. Were you doing something GPU intense when you experienced the hard hang? And if

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Force a LUT update in intel_initial_commit()

2018-11-21 Thread Ville Syrjälä
On Tue, Nov 20, 2018 at 02:25:40PM -0800, Rodrigo Vivi wrote: > On Tue, Nov 20, 2018 at 03:54:49PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > If we force a plane update to fix up our half populated plane state > > we'll also force on the pipe gamma for the plane (since we always

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

2018-11-21 Thread Jani Nikula
On Tue, 20 Nov 2018, Ville Syrjala wrote: > From: Ville Syrjälä > > Make life easier for drivers by simply passing the connector > to drm_hdmi_avi_infoframe_from_display_mode() and > drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > need to worry about is_hdmi2_sink mess. Overall

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make CHICKEN_TRANS reg not depend on enum value (rev2)

2018-11-21 Thread Imre Deak
On Tue, Nov 20, 2018 at 01:00:17AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Make CHICKEN_TRANS reg not depend on enum value (rev2) > URL : https://patchwork.freedesktop.org/series/52700/ > State : success Pushed to -dinq, thanks for the review. > > == Summary == >

Re: [Intel-gfx] v4.20-rc1: list_del corruption on thinkpad x220

2018-11-21 Thread Pavel Machek
Hi! > > My machine locked hard (thinkpad x220). After reboot, I found this in > > syslog: > > > > Sounds like memory corruption..? Does not sound like easy to debug. > > Were you doing something GPU intense when you experienced the hard hang? > > And if so, have you been able to hit the issue

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Synchronize hpd work in i915_hpd_storm_ctl_show()

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Synchronize hpd work in i915_hpd_storm_ctl_show() URL : https://patchwork.freedesktop.org/series/52796/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5175_full -> Patchwork_10872_full = == Summary - FAILURE == Serious unknown

Re: [Intel-gfx] [PATCH] drm/i915: Release power well if load DMC failed

2018-11-21 Thread Lee, Shawn C
On Tue, 20 Nov 2018, "Jani Nikula" wrote: >On Wed, 21 Nov 2018, "Lee, Shawn C" wrote: >> On Tue, 20 Nov 2018, "Jani Nikula" wrote: Driver obtain power well at intel_csr_ucode_init(). And release it after load DMC firmware successful. >>> >>>Correct. >>> An issue happened when DMC

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Avoid use-after-free iterating the gtt list

2018-11-21 Thread Zhenyu Wang
On 2018.11.21 09:20:19 +, Chris Wilson wrote: > Quoting Zhenyu Wang (2018-11-21 02:29:21) > > On 2018.11.20 20:24:38 +, Chris Wilson wrote: > > > Found by smatch: > > > > > > drivers/gpu/drm/i915/gvt/gtt.c:2452 intel_vgpu_destroy_ggtt_mm() error: > > > dereferencing freed memory 'pos' >

Re: [Intel-gfx] [PATCH i-g-t 2/4] v3d: Import the V3D DRM UAPI header.

2018-11-21 Thread Petri Latvala
On Wed, Nov 14, 2018 at 02:28:30PM -0800, Eric Anholt wrote: > Copied from make headers_install at drm-misc-next 783195ec1cad > ("drm/syncobj: disable the timeline UAPI for now v2") > > Signed-off-by: Eric Anholt Acked-by: Petri Latvala > --- > include/drm-uapi/v3d_drm.h | 204

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Avoid use-after-free iterating the gtt list

2018-11-21 Thread Chris Wilson
Quoting Zhenyu Wang (2018-11-21 02:29:21) > On 2018.11.20 20:24:38 +, Chris Wilson wrote: > > Found by smatch: > > > > drivers/gpu/drm/i915/gvt/gtt.c:2452 intel_vgpu_destroy_ggtt_mm() error: > > dereferencing freed memory 'pos' > > > > Signed-off-by: Chris Wilson > > Cc: Zhenyu Wang > >

Re: [Intel-gfx] [PATCH] drm/i915: Release power well if load DMC failed

2018-11-21 Thread Jani Nikula
On Wed, 21 Nov 2018, "Lee, Shawn C" wrote: > On Tue, 20 Nov 2018, "Jani Nikula" wrote: >>On Wed, 21 Nov 2018, "Lee, Shawn C" wrote: >>> On Tue, 20 Nov 2018, "Jani Nikula" wrote: > Driver obtain power well at intel_csr_ucode_init(). > And release it after load DMC firmware successful.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings

2018-11-21 Thread Jani Nikula
On Fri, 16 Nov 2018, Lucas De Marchi wrote: > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If > we have released no firmware yet for a platform, stop scaring the > consumer and merely note its

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Joonas Lahtinen
Quoting Hans Holmberg (2018-11-21 11:54:23) > From: Hans Holmberg > > There is no need to rebuild i915_gpu_error.o when the version string > changes as the version is available in init_utsname()->release. > > Signed-off-by: Hans Holmberg Seems reasonable to me. Reviewed-by: Joonas Lahtinen

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Add HAS_DISPLAY() and use it

2018-11-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Add HAS_DISPLAY() and use it URL : https://patchwork.freedesktop.org/series/52790/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5175_full -> Patchwork_10871_full = == Summary - FAILURE == Serious unknown

Re: [Intel-gfx] [PATCH] drm/i915: fix spelling mistake "reserverd" -> "reserved"

2018-11-21 Thread Jani Nikula
On Tue, 20 Nov 2018, Alexandre Belloni wrote: > Fix a spelling mistake in a comment. > > Signed-off-by: Alexandre Belloni Thanks for the patch, pushed to drm-intel-next-queued. BR, Jani. > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Intel-gfx] [PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-21 Thread Ville Syrjälä
On Wed, Nov 21, 2018 at 10:27:27AM +0100, Daniel Vetter wrote: > On Mon, Nov 12, 2018 at 06:59:45PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On i965gm we need to adjust max_vblank_count dynamically > > depending on whether the TV encoder is used or not. To > > that end add a

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Make pipe/transcoder offsets not depend on enum values

2018-11-21 Thread Imre Deak
On Tue, Nov 20, 2018 at 01:53:06PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915: Make pipe/transcoder offsets not > depend on enum values > URL : https://patchwork.freedesktop.org/series/52742/ > State : success Pushed to -dinq, thanks for the

[Intel-gfx] [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout

2018-11-21 Thread Chris Wilson
Make the wait for the evict kthread use an explicit timeout rather than a handwaved jiffie value so it is consistent across all platforms. References: https://bugs.freedesktop.org/show_bug.cgi?id=108735 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 2 +- 1

Re: [Intel-gfx] [PATCH] drm/i915: Release power well if load DMC failed

2018-11-21 Thread Lee, Shawn C
On Tue, 20 Nov 2018, "Jani Nikula" wrote: >> Driver obtain power well at intel_csr_ucode_init(). >> And release it after load DMC firmware successful. > >Correct. > >> An issue happened when DMC was not found or failed to load. Power well >> would not be released and just output some error

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Log test and subtest names for easier debugging

2018-11-21 Thread Tvrtko Ursulin
On 21/11/2018 09:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-11-21 09:02:18) On 20/11/2018 18:18, Tvrtko Ursulin wrote: I can certainly send a patch for -DDEBUG, seems like that would be the correct thing to do for all selftests. I've changed my mind - I think it is more desirable

Re: [Intel-gfx] [PATCH RFC 5/5] drm/amdgpu: Add accounting of buffer object creation request via DRM cgroup

2018-11-21 Thread Christian König
Am 20.11.18 um 19:58 schrieb Kenny Ho: Account for the total size of buffer object requested to amdgpu by buffer type on a per cgroup basis. x prefix in the control file name x.bo_requested.amd.stat signify experimental. Change-Id: Ifb680c4bcf3652879a7a659510e25680c2465cf6 Signed-off-by: Kenny

Re: [Intel-gfx] [PATCH] drm/atomic: Fix the early return in drm_atomic_set_mode_for_crtc()

2018-11-21 Thread Daniel Vetter
On Tue, Nov 20, 2018 at 07:55:42PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The early return in drm_atomic_set_mode_for_crtc() isn't quite > right. It would mistakenly return and fail to update > crtc_state->enable if someone actually tried to set a zeroed > mode on a currently

Re: [Intel-gfx] [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

2018-11-21 Thread Christian König
Am 20.11.18 um 21:57 schrieb Eric Anholt: Kenny Ho writes: Account for the number of command submitted to amdgpu by type on a per cgroup basis, for the purpose of profiling/monitoring applications. For profiling other drivers, I've used perf tracepoints, which let you get useful timelines of

Re: [Intel-gfx] [PATCH RFC 2/5] cgroup: Add mechanism to register vendor specific DRM devices

2018-11-21 Thread Christian König
Am 20.11.18 um 19:58 schrieb Kenny Ho: Since many parts of the DRM subsystem has vendor-specific implementations, we introduce mechanisms for vendor to register their specific resources and control files to the DRM cgroup subsystem. A vendor will register itself with the DRM cgroup subsystem

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Jani Nikula
On Wed, 21 Nov 2018, Hans Holmberg wrote: > From: Hans Holmberg > > There is no need to rebuild i915_gpu_error.o when the version string > changes as the version is available in init_utsname()->release. > > Signed-off-by: Hans Holmberg Nice! Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH] drm/i915: Release power well if load DMC failed

2018-11-21 Thread Jani Nikula
On Wed, 21 Nov 2018, "Lee, Shawn C" wrote: > On Tue, 20 Nov 2018, "Jani Nikula" wrote: >>> Driver obtain power well at intel_csr_ucode_init(). >>> And release it after load DMC firmware successful. >> >>Correct. >> >>> An issue happened when DMC was not found or failed to load. Power well >>>

Re: [Intel-gfx] [PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-21 Thread Daniel Vetter
On Mon, Nov 12, 2018 at 06:59:45PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On i965gm we need to adjust max_vblank_count dynamically > depending on whether the TV encoder is used or not. To > that end add a per-crtc max_vblank_count that takes > precedence over its device wide

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Log test and subtest names for easier debugging

2018-11-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-21 09:02:18) > > On 20/11/2018 18:18, Tvrtko Ursulin wrote: > > I can certainly send a patch for -DDEBUG, seems like that would be the > > correct thing to do for all selftests. > > I've changed my mind - I think it is more desirable to actually just do > what

Re: [Intel-gfx] [PATCH RFC 3/5] drm/amdgpu: Add DRM cgroup support for AMD devices

2018-11-21 Thread Christian König
Am 20.11.18 um 19:58 schrieb Kenny Ho: Change-Id: Ib66c44ac1b1c367659e362a2fc05b6fbb3805876 Signed-off-by: Kenny Ho --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 drivers/gpu/drm/amd/amdgpu/amdgpu_drmcgrp.c | 37

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Release power well if load DMC failed

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Release power well if load DMC failed URL : https://patchwork.freedesktop.org/series/52805/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5175 -> Patchwork_10875 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize hpd work in i915_hpd_storm_ctl_show()

2018-11-21 Thread Daniel Vetter
On Tue, Nov 20, 2018 at 07:37:17PM -0500, Lyude Paul wrote: > While trying to add a chamelium test for short HPD IRQs, I ran into > issues where a hotplug storm would be triggered, but the point at which > it would be reported by the kernel would be after igt actually finished > checking

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Chris Wilson
Quoting Hans Holmberg (2018-11-21 09:54:23) > From: Hans Holmberg > > There is no need to rebuild i915_gpu_error.o when the version string > changes as the version is available in init_utsname()->release. > > Signed-off-by: Hans Holmberg > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++--

Re: [Intel-gfx] [PATCH i-g-t 3/4] Add v3d helper library

2018-11-21 Thread Petri Latvala
On Wed, Nov 14, 2018 at 02:28:31PM -0800, Eric Anholt wrote: > Just a few little ioctl wrappers that v3d tests will use. > > Signed-off-by: Eric Anholt Acked-by: Petri Latvala > --- > lib/Makefile.sources | 2 + > lib/drmtest.c| 3 + > lib/drmtest.h| 1 + >

[Intel-gfx] [PATCH] drm/i915/execlists: Poison the CSB after use

2018-11-21 Thread Chris Wilson
After reading the event status from the CSB, write back 0 (an invalid value) so we can detect if the HW should signal a new event without writing the event in the future. References: https://bugs.freedesktop.org/show_bug.cgi?id=108315 Signed-off-by: Chris Wilson Cc: Mika Kuoppala ---

Re: [Intel-gfx] [PATCH] drm/i915: Show waiter's status on engine dump

2018-11-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-11-21 15:08:27) > > On 21/11/2018 13:09, Chris Wilson wrote: > > When showing the list of waiters, include the task's status so that we > > can tell if they have been woken up and are waiting for the CPU, or if > > they are still waiting to be woken. > > > >

Re: [Intel-gfx] [PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-21 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 01:37:51PM +0200, Ville Syrjälä wrote: > On Wed, Nov 21, 2018 at 10:27:27AM +0100, Daniel Vetter wrote: > > On Mon, Nov 12, 2018 at 06:59:45PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > On i965gm we need to adjust max_vblank_count dynamically > > >

Re: [Intel-gfx] [PATCH] drm/i915: Show waiter's status on engine dump

2018-11-21 Thread Tvrtko Ursulin
On 21/11/2018 15:16, Chris Wilson wrote: When showing the list of waiters, include the task's status so that we can tell if they have been woken up and are waiting for the CPU, or if they are still waiting to be woken. v2: task_state_to_char() Signed-off-by: Chris Wilson Cc: Mika Kuoppala

[Intel-gfx] [PATCH] drm/i915: Show waiter's status on engine dump

2018-11-21 Thread Chris Wilson
When showing the list of waiters, include the task's status so that we can tell if they have been woken up and are waiting for the CPU, or if they are still waiting to be woken. v2: task_state_to_char() Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show waiter's status on engine dump

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Show waiter's status on engine dump URL : https://patchwork.freedesktop.org/series/52825/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5181 -> Patchwork_10879 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show waiter's status on engine dump (rev2)

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Show waiter's status on engine dump (rev2) URL : https://patchwork.freedesktop.org/series/52825/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5181 -> Patchwork_10880 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] [PULL] drm-misc-fixes

2018-11-21 Thread Sean Paul
Hi Dave, Another light -fixes pull, either we've really got our act together this release or the hammer is about to drop. I'll go with the optimistic take :-) Hope the time adjustment back to upside-down-time has been smooth for you! drm-misc-fixes-2018-11-21: - vc4: Fix NULL deref in async

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout

2018-11-21 Thread Mika Kuoppala
Chris Wilson writes: > Make the wait for the evict kthread use an explicit timeout rather than > a handwaved jiffie value so it is consistent across all platforms. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=108735 > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout URL : https://patchwork.freedesktop.org/series/52820/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5180 -> Patchwork_10876 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Release power well if load DMC failed

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Release power well if load DMC failed URL : https://patchwork.freedesktop.org/series/52805/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5175_full -> Patchwork_10875_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Poison the CSB after use (rev2)

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Poison the CSB after use (rev2) URL : https://patchwork.freedesktop.org/series/51703/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5181 -> Patchwork_10878 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH] drm/i915: Show waiter's status on engine dump

2018-11-21 Thread Tvrtko Ursulin
On 21/11/2018 13:09, Chris Wilson wrote: When showing the list of waiters, include the task's status so that we can tell if they have been woken up and are waiting for the CPU, or if they are still waiting to be woken. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin ---

[Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Hans Holmberg
From: Hans Holmberg There is no need to rebuild i915_gpu_error.o when the version string changes as the version is available in init_utsname()->release. Signed-off-by: Hans Holmberg --- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Hans Holmberg
On Wed, Nov 21, 2018 at 11:10 AM Joonas Lahtinen wrote: > > Quoting Hans Holmberg (2018-11-21 11:54:23) > > From: Hans Holmberg > > > > There is no need to rebuild i915_gpu_error.o when the version string > > changes as the version is available in init_utsname()->release. > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915/backlight: Fix backlight takeover on LPT

2018-11-21 Thread Tolga Cakir
Am Di., 20. Nov. 2018 um 19:51 Uhr schrieb Ville Syrjälä : > > On Tue, Nov 20, 2018 at 11:39:26AM +0100, Maarten Lankhorst wrote: > > On lynxpoint the bios sometimes sets up the backlight using the CPU > > display, but the driver expects using the PWM PCH override register. > > > > Read the value

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout

2018-11-21 Thread Chris Wilson
Quoting Mika Kuoppala (2018-11-21 12:26:23) > Chris Wilson writes: > > > Make the wait for the evict kthread use an explicit timeout rather than > > a handwaved jiffie value so it is consistent across all platforms. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=108735 > >

Re: [Intel-gfx] [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Joonas Lahtinen
Quoting Hans Holmberg (2018-11-21 13:35:19) > On Wed, Nov 21, 2018 at 11:10 AM Joonas Lahtinen > wrote: > > > > Quoting Hans Holmberg (2018-11-21 11:54:23) > > > From: Hans Holmberg > > > > > > There is no need to rebuild i915_gpu_error.o when the version string > > > changes as the version is

Re: [Intel-gfx] [PATCH] drm/i915/backlight: Fix backlight takeover on LPT

2018-11-21 Thread Tolga Cakir
Am Mi., 21. Nov. 2018 um 11:45 Uhr schrieb Ville Syrjälä : > > On Wed, Nov 21, 2018 at 08:16:06AM +0100, Tolga Cakir wrote: > > Am Di., 20. Nov. 2018 um 19:51 Uhr schrieb Ville Syrjälä > > : > > > > > > On Tue, Nov 20, 2018 at 11:39:26AM +0100, Maarten Lankhorst wrote: > > > > On lynxpoint the

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Poison the CSB after use

2018-11-21 Thread Chris Wilson
Quoting Chris Wilson (2018-11-21 13:08:23) > After reading the event status from the CSB, write back 0 (an invalid > value) so we can detect if the HW should signal a new event without > writing the event in the future. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=108315 >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: avoid rebuilding i915_gpu_error.o on version string updates URL : https://patchwork.freedesktop.org/series/52822/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5181 -> Patchwork_10877 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout

2018-11-21 Thread Chris Wilson
Quoting Patchwork (2018-11-21 12:33:00) > == Series Details == > > Series: drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout > URL : https://patchwork.freedesktop.org/series/52820/ > State : success > > == Summary == > > = CI Bug Log - changes from CI_DRM_5180 ->

[Intel-gfx] [PATCH] drm/i915: Show waiter's status on engine dump

2018-11-21 Thread Chris Wilson
When showing the list of waiters, include the task's status so that we can tell if they have been woken up and are waiting for the CPU, or if they are still waiting to be woken. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_engine_cs.c | 6

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings

2018-11-21 Thread Rodrigo Vivi
On Wed, Nov 21, 2018 at 11:29:02AM +0200, Jani Nikula wrote: > On Fri, 16 Nov 2018, Lucas De Marchi wrote: > > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown > > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If > > we have released no firmware yet

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Show waiter's status on engine dump (rev2)

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Show waiter's status on engine dump (rev2) URL : https://patchwork.freedesktop.org/series/52825/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5181_full -> Patchwork_10880_full = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] [PATCH] drm/i915: Release power well if load DMC failed

2018-11-21 Thread Lee, Shawn C
On Wed, 21 Nov 2018, "Jani Nikula" wrote: >On Wed, 21 Nov 2018, "Lee, Shawn C" wrote: >> On Tue, 20 Nov 2018, "Jani Nikula" wrote: >>>On Wed, 21 Nov 2018, "Lee, Shawn C" wrote: On Tue, 20 Nov 2018, "Jani Nikula" wrote: >> Driver obtain power well at intel_csr_ucode_init(). >> And

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add HAS_DISPLAY() and use it

2018-11-21 Thread Lucas De Marchi
On Tue, Nov 20, 2018 at 02:32:40PM -0800, José Roberto de Souza wrote: > Right now it is decided if GEN has display by checking the num_pipes, > so lets make it explicit and use a macro. > > Cc: Lucas De Marchi > Cc: Jani Nikula > Signed-off-by: José Roberto de Souza Reviewed-by: Lucas De

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse

2018-11-21 Thread Patchwork
== Series Details == Series: series starting with [v5,1/6] drm/i915: Avoid a full port detection in the first eDP short pulse URL : https://patchwork.freedesktop.org/series/52848/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5183_full -> Patchwork_10883_full = == Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: avoid rebuilding i915_gpu_error.o on version string updates

2018-11-21 Thread Patchwork
== Series Details == Series: drm/i915: avoid rebuilding i915_gpu_error.o on version string updates URL : https://patchwork.freedesktop.org/series/52822/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5181_full -> Patchwork_10877_full = == Summary - WARNING == Minor

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Downgrade unknown CSR firmware warnings

2018-11-21 Thread Lucas De Marchi
On Wed, Nov 21, 2018 at 11:29:02AM +0200, Jani Nikula wrote: > On Fri, 16 Nov 2018, Lucas De Marchi wrote: > > Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown > > firmware warnings") for huc and guc: downgrade CSR firmware warnings. If > > we have released no firmware yet

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

2018-11-21 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Tuesday, 20 November 2018 18:13:42 EET Ville Syrjala wrote: > From: Ville Syrjälä > > Make life easier for drivers by simply passing the connector > to drm_hdmi_avi_infoframe_from_display_mode() and > drm_hdmi_avi_infoframe_quant_range(). That way drivers

Re: [Intel-gfx] [PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-21 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 5:16 PM Ville Syrjälä wrote: > > On Wed, Nov 21, 2018 at 04:19:36PM +0100, Daniel Vetter wrote: > > On Wed, Nov 21, 2018 at 01:37:51PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 21, 2018 at 10:27:27AM +0100, Daniel Vetter wrote: > > > > On Mon, Nov 12, 2018 at

Re: [Intel-gfx] [PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-21 Thread Ville Syrjälä
On Wed, Nov 21, 2018 at 05:22:49PM +0100, Daniel Vetter wrote: > On Wed, Nov 21, 2018 at 5:16 PM Ville Syrjälä > wrote: > > > > On Wed, Nov 21, 2018 at 04:19:36PM +0100, Daniel Vetter wrote: > > > On Wed, Nov 21, 2018 at 01:37:51PM +0200, Ville Syrjälä wrote: > > > > On Wed, Nov 21, 2018 at

  1   2   >