On Thu, 20 Dec 2018 at 23:04, Ulf Hansson wrote:
>
> On Thu, 20 Dec 2018 at 15:17, Vincent Guittot
> wrote:
> >
> > Use the new pm runtime interface to get the accounted suspended time:
> > pm_runtime_accounted_time_get()
>
> pm_runtime_suspended_time()
>
> This change also makes quite some nice
== Series Details ==
Series: skl+ watermark stuff
URL : https://patchwork.freedesktop.org/series/54424/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5339_full -> Patchwork_11148_full
Summary
---
**SUCCESS**
No
From: Anusha Srivatsa
We have an update of GuC for BXT.
Load the latest version.
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
== Series Details ==
Series: Gen9 Guc and HuC Updates (rev2)
URL : https://patchwork.freedesktop.org/series/54431/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5341 -> Patchwork_11150
Summary
---
**WARNING**
== Series Details ==
Series: Gen9 Guc and HuC Updates (rev2)
URL : https://patchwork.freedesktop.org/series/54431/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5341_full -> Patchwork_11150_full
Summary
---
== Series Details ==
Series: Move pm_runtime accounted time to raw nsec
URL : https://patchwork.freedesktop.org/series/54404/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5337_full -> Patchwork_11144_full
Summary
---
From: Anusha Srivatsa
We have an update of GuC for SKL.
Load the latest version.
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
From: Anusha Srivatsa
Load Huc for GLK.
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_huc_fw.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c
b/drivers/gpu/drm/i915/intel_huc_fw.c
index
From: Michal Wajdeczko
This will let the driver decide where GuC can be used
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
drivers/gpu/drm/i915/intel_uc.c| 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git
From: Anusha Srivatsa
We have an update of HuC for SKL.
Load the latest version.
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_huc_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c
From: Anusha Srivatsa
We have an update of HuC for KBL.
Load the latest version.
cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_huc_fw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c
Adding pull request:
The following changes since commit 0f22c8527439eaaf5c3fcf87b31c89445b6fa84d:
Revert "amdgpu: update vega10 fw for 18.50 release" (2018-12-18 15:38:53
-0500)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware BXT_HUC
for you to
From: Anusha Srivatsa
We have an update of GuC for KBL.
Load the latest version.
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
From: Anusha Srivatsa
Load the v13.125 guC on Geminilake.
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_guc_fw.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
b/drivers/gpu/drm/i915/intel_guc_fw.c
index
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev5)
URL : https://patchwork.freedesktop.org/series/54127/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5339_full -> Patchwork_11149_full
On Thu, 20 Dec 2018 at 23:03, Ulf Hansson wrote:
>
> On Thu, 20 Dec 2018 at 15:17, Vincent Guittot
> wrote:
> >
> > From: Thara Gopinath
> >
> > This patch replaces jiffies based accounting for runtime_active_time
> > and runtime_suspended_time with ktime base accounting. This makes the
> >
Regards
Shashank
On 12/12/2018 2:08 AM, Uma Shankar wrote:
From: Ville Syrjälä
This patch enables infoframes on GLK+ to be
used to send HDR metadata to HDMI sink.
Signed-off-by: Ville Syrjälä
Signed-off-by: Uma Shankar
---
drivers/gpu/drm/i915/i915_reg.h | 4
Hi Rafael,
On Fri, 21 Dec 2018 at 09:58, Rafael J. Wysocki wrote:
>
> On Thu, Dec 20, 2018 at 11:03 PM Ulf Hansson wrote:
> >
> > On Thu, 20 Dec 2018 at 15:17, Vincent Guittot
> > wrote:
> > >
> > > From: Thara Gopinath
> > >
> > > This patch replaces jiffies based accounting for
== Series Details ==
Series: series starting with [v4,1/3] ACPI / PMIC: Add support for executing
PMIC MIPI sequence elements
URL : https://patchwork.freedesktop.org/series/54003/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5311_full -> Patchwork_11089_full
Regards
Shashank
On 12/12/2018 2:08 AM, Uma Shankar wrote:
Enable writing of HDR metadata infoframe to panel.
The data will be provid by usersapace compositors, based
on blending policies and passsed to driver through a blob
property.
v2: Rebase
Signed-off-by: Uma Shankar
---
Regards
Shashank
On 12/12/2018 2:08 AM, Uma Shankar wrote:
From: Ville Syrjälä
Function argument for hdmi_drm_infoframe_log is made constant.
Signed-off-by: Ville Syrjälä
Signed-off-by: Uma Shankar
---
drivers/video/hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Thu, Dec 20, 2018 at 11:03 PM Ulf Hansson wrote:
>
> On Thu, 20 Dec 2018 at 15:17, Vincent Guittot
> wrote:
> >
> > From: Thara Gopinath
> >
> > This patch replaces jiffies based accounting for runtime_active_time
> > and runtime_suspended_time with ktime base accounting. This makes the
> >
From: Thara Gopinath
This patch replaces jiffies based accounting for runtime_active_time
and runtime_suspended_time with ktime base accounting. This makes the
runtime debug counters inline with genpd and other pm subsytems which
uses ktime based accounting.
timekeeping is initialized before
Move pm_runtime accounted time to raw nsec. The subject of the patchset
has changed as the 1st patch of the previous version has been queued by
Rafael.
Patch 1 adds a new pm_runtime interface to get accounted suspended time
Patch 2 moves drm/i915 driver on the new interface and removes access to
Use the new pm runtime interface to get the accounted suspended time:
pm_runtime_suspended_time().
This new interface helps to simplify and cleanup the code that computes
__I915_SAMPLE_RC6_ESTIMATED and to remove direct access to internals of
PM runtime.
Reviewed-by: Ulf Hansson
Signed-off-by:
Some drivers (like i915/drm) needs to get the accounted suspended time.
pm_runtime_suspended_time() will return the suspended accounted time
in ns unit.
Reviewed-by: Ulf Hansson
Signed-off-by: Vincent Guittot
---
drivers/base/power/runtime.c | 16
include/linux/pm_runtime.h
== Series Details ==
Series: Move pm_runtime accounted time to raw nsec
URL : https://patchwork.freedesktop.org/series/54404/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c92f56748cd1 PM/runtime: Add a new interface to get accounted time
-:48: CHECK:AVOID_EXTERNS: extern
On Fri, 21 Dec 2018 at 11:34, Vincent Guittot
wrote:
>
> From: Thara Gopinath
>
> This patch replaces jiffies based accounting for runtime_active_time
> and runtime_suspended_time with ktime base accounting. This makes the
> runtime debug counters inline with genpd and other pm subsytems which
>
Hi,
On 21/12/2018 10:33, Vincent Guittot wrote:
Use the new pm runtime interface to get the accounted suspended time:
pm_runtime_suspended_time().
This new interface helps to simplify and cleanup the code that computes
__I915_SAMPLE_RC6_ESTIMATED and to remove direct access to internals of
PM
== Series Details ==
Series: Move pm_runtime accounted time to raw nsec
URL : https://patchwork.freedesktop.org/series/54404/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5337 -> Patchwork_11144
Summary
---
On 14/12/2018 18:20, Lucas De Marchi wrote:
Instead of checking the gen number every time we need to know the max
number of entries, just save it into the table struct so we don't need
extra branches throughout the code.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Lucas De Marchi
---
Regards
Shashank
On 12/12/2018 2:08 AM, Uma Shankar wrote:
Enable Dynamic Range and Mastering Infoframe for HDR
content, which is defined in CEA 861.3 spec.
The metadata will be computed based on blending
policy in userspace compositors and passed as a connector
property blob to driver. The
Regards
Shashank
On 12/12/2018 2:08 AM, Uma Shankar wrote:
From: Ville Syrjälä
ADD HLG EOTF to the list of EOTF transfer functions
supported.
Would it be possible to add some details about HLG ?
Signed-off-by: Ville Syrjälä
Signed-off-by: Uma Shankar
---
drivers/gpu/drm/drm_edid.c |
Hi Matt,
On Thu, Dec 13, 2018 at 01:55:25PM -0800, Matt Roper wrote:
> Some hardware may place additional restrictions on the gamma/degamma
> curves described by our LUT properties. E.g., that a gamma curve never
> decreases or that the red/green/blue channels of a LUT's entries must be
> equal.
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Add an update_pipe callback to
intel_encoder and call this on fastsets (v2)
URL : https://patchwork.freedesktop.org/series/54339/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full ->
Macros with this much magic in them deserve some explanatory text.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_params.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_params.h
b/drivers/gpu/drm/i915/i915_params.h
index
Prevent accidental use of i915_modparams throughout the driver by hiding
it in i915_params.c. Add accessors for the legitimate uses.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.c| 2 +-
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i915/i915_params.c | 20
Start using device specific parameters instead of module parameters for
most things. The module parameters become the immutable initial values
for i915 parameters. Any later changes are only reflected in the
debugfs.
The stragglers are:
* i915.alpha_support and i915.modeset. Needed before
Add a debugfs subdirectory i915_params with all the i915 module
parameters. This is a first step, with lots of boilerplate, and not much
benefit yet.
Add debugfs permissions to I915_PARAMS_FOR_EACH(). This duplicates the
mode with module parameter sysfs, but the goal is to make the module
Only support runtime changes through the debugfs.
i915.verbose_state_checks remains an exception, and is not exposed via
debugfs.
FIXME: Before this gets applied, IGT needs to be changed to use the
debugfs for modifying the parameters. IGT changes at least the following
through module parameter
Seems like selftests is a better home for everything related to load
failure injection, including the module parameter.
The failure injection code gets moved from under DRM_I915_DEBUG to
DRM_I915_SELFTEST config option. This should be of no consequence, as
the former selects the latter.
With the
Reveals the build fail fixed in the last hunk. Also prep work.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h| 6 +++---
drivers/gpu/drm/i915/intel_uc.c| 12 ++--
drivers/gpu/drm/i915/intel_uc.h| 6 +++---
drivers/gpu/drm/i915/intel_wopcm.c | 2 +-
4 files
Season's greetings!
This series migrates module parameters to per-device parameters in
drm_i915_private, accessible via debugfs.
Patches 1-6 are fairly straightforward prep work to make the rest
easier. After initial reviews I'll probably submit them separately.
Patches 7-8 add debugfs access
Abstract the one user in anticipation of more. Set the dangling pointers
to NULL while at it.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_gpu_error.c | 9 +
drivers/gpu/drm/i915/i915_params.c| 16
drivers/gpu/drm/i915/i915_params.h| 1 +
3 files
Abstract the one user in anticipation of more.
Reviewed-by: Chris Wilson
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_gpu_error.c | 11 +--
drivers/gpu/drm/i915/i915_params.c| 14 ++
drivers/gpu/drm/i915/i915_params.h| 1 +
3 files changed, 16
i915.enable_hangcheck has been an outlier since its introduction in
commit 3e0dc6b01f53 ("drm/i915: hangcheck disable parameter") with 0644
permissions, while all the rest are either 0400 or 0600. Follow suit
with 0600.
IGT never reads the value, so there should be no impact.
Signed-off-by: Jani
It's not uncommon for us to switch param types between bools and ints,
often having otherwise bool semantics but -1 value for platform
default. Allow bool values for ints.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 14 ++
1 file changed, 14 insertions(+)
It's not uncommon for us to switch param types between bools and ints,
often having otherwise bool semantics but -1 value for platform
default. Allow bool values for ints.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 14 ++
1 file changed, 14 insertions(+)
Hi Linus,
drm-fixes-2018-12-21:
final drm-fixes for 4.20
array_index_nospec patch, cc: stable
Very calm week, so either everything perfect or everyone on holidays
already. Same for -next btw, I merged a few things but nothing that should
block Dave's main merge window pull, so that one is still
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev3)
URL : https://patchwork.freedesktop.org/series/54127/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5338 -> Patchwork_11145
On 12/12/2018 13:41, Chris Wilson wrote:
The information presented here is not relevant to current development.
We can either use the context information, but more often we want to
inspect the active gpu state.
The ulterior motive is to eradicate dev->filelist.
Signed-off-by: Chris Wilson
On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin
wrote:
>
>
> Hi,
>
> On 21/12/2018 10:33, Vincent Guittot wrote:
> > Use the new pm runtime interface to get the accounted suspended time:
> > pm_runtime_suspended_time().
> > This new interface helps to simplify and cleanup the code that computes
> >
Argh, stray file accidentally sent, ignore.
On Fri, 21 Dec 2018, Jani Nikula wrote:
> It's not uncommon for us to switch param types between bools and ints,
> often having otherwise bool semantics but -1 value for platform
> default. Allow bool values for ints.
>
> Signed-off-by: Jani Nikula
>
Op 17-12-2018 om 12:16 schreef Maarten Lankhorst:
> Op 11-12-2018 om 19:16 schreef Souza, Jose:
>> On Tue, 2018-12-04 at 13:23 -0800, Dhinakaran Pandiyan wrote:
>>> On Tue, 2018-12-04 at 10:52 -0800, Souza, Jose wrote:
On Mon, 2018-12-03 at 18:58 -0800, Dhinakaran Pandiyan wrote:
> On
On Thu, 20 Dec 2018, Imre Deak wrote:
> Registering an output for a non-existent port (on a given SKU) can lead
> to problems when trying to use the port, for instance timeouts during
> power well enabling. Since there are no strap bits for port detection we
> have to rely on VBT for this, so do
== Series Details ==
Series: drm/i915: from module params to device params
URL : https://patchwork.freedesktop.org/series/54414/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
586195831aff drm/i915: add a helper to make a copy of i915_params
-:53: CHECK:MACRO_ARG_PRECEDENCE:
On 14/12/2018 18:20, Lucas De Marchi wrote:
From: Tomasz Lis
The table has been unified across OSes to minimize virtualization overhead.
The MOCS table is now published as part of bspec, and versioned. Entries
are supposed to never be modified, but new ones can be added. Adding
entries
== Series Details ==
Series: drm/i915: Fix ILK-IVB primary plane enable delays (rev2)
URL : https://patchwork.freedesktop.org/series/54336/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11135_full
Op 20-12-2018 om 19:55 schreef Hans de Goede:
> Hi,
>
> On 20-12-18 16:17, Maarten Lankhorst wrote:
>> Without this, we will get a dmesg-warn when enable_fbc is cleared on a
>> fastset:
>> WARN_ON(!crtc_state->enable_fbc)
>> WARNING: CPU: 0 PID: 1090 at drivers/gpu/drm/i915/intel_fbc.c:1091
>>
On Fri, Dec 21, 2018 at 10:52:38AM +0800, Zhenyu Wang wrote:
> On 2018.12.20 12:33:35 +0100, Gerd Hoffmann wrote:
> > On Thu, Dec 20, 2018 at 08:45:09AM +, Zhang, Tina wrote:
> > >
> > >
> > > > -Original Message-
> > > > From: intel-gvt-dev
> > > >
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev3)
URL : https://patchwork.freedesktop.org/series/54127/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7891fae7c511 drm/i915/backlight: Restore backlight on
== Series Details ==
Series: drm/i915: add a helper to make a copy of i915_params
URL : https://patchwork.freedesktop.org/series/54353/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11138_full
On Thu, 20 Dec 2018, Imre Deak wrote:
> We have already a function to detect DDI ports using VBT, so instead of
> opencoding the DDI specific version of this, move the opencoded part to
> the existing helper.
>
> Cc: Jani Nikula
> Cc: Mika Kahola
> Signed-off-by: Imre Deak
> ---
>
== Series Details ==
Series: drm/i915: Disable FBC on fastset if necessary, v2.
URL : https://patchwork.freedesktop.org/series/54363/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11139_full
Summary
== Series Details ==
Series: drm/i915: from module params to device params
URL : https://patchwork.freedesktop.org/series/54414/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: add a helper to make a copy of i915_params
Okay!
Commit:
== Series Details ==
Series: drm/i915: Unwind failure on pinning the gen7 ppgtt
URL : https://patchwork.freedesktop.org/series/54433/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5341_full -> Patchwork_11151_full
Summary
If we fail to pin the ggtt vma slot for the ppgtt page tables, we need
to unwind the locals before reporting the error. Or else on subsequent
attempts to bind the page tables into the ggtt, we will already believe
that the vma has been pinned and continue on blithely. If something else
should
== Series Details ==
Series: drm/i915: Unwind failure on pinning the gen7 ppgtt
URL : https://patchwork.freedesktop.org/series/54433/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5341 -> Patchwork_11151
Summary
---
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev5)
URL : https://patchwork.freedesktop.org/series/54127/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
16a369e8ed29 drm/i915/backlight: Restore backlight on
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev5)
URL : https://patchwork.freedesktop.org/series/54127/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5339 -> Patchwork_11149
On Fri, 21 Dec 2018 14:31:38 +0100, Jani Nikula
wrote:
/snip/
diff --git a/drivers/gpu/drm/i915/intel_uc.h
b/drivers/gpu/drm/i915/intel_uc.h
index 25d73ada74ae..24990ade4fb8 100644
--- a/drivers/gpu/drm/i915/intel_uc.h
+++ b/drivers/gpu/drm/i915/intel_uc.h
@@ -41,19 +41,19 @@ void
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev4)
URL : https://patchwork.freedesktop.org/series/54127/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5338 -> Patchwork_11147
== Series Details ==
Series: series starting with [RESEND,1/5] drm/i915/backlight: Restore backlight
on resume, v2. (rev4)
URL : https://patchwork.freedesktop.org/series/54127/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4e82ad638e91 drm/i915/backlight: Restore backlight on
== Series Details ==
Series: drm/debugfs_crc: Degrade ERROR when overflowing to INFO
URL : https://patchwork.freedesktop.org/series/54364/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11140_full
== Series Details ==
Series: drm/i915: from module params to device params
URL : https://patchwork.freedesktop.org/series/54414/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5338 -> Patchwork_11146
Summary
---
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the
corresponding helper (rev2)
URL : https://patchwork.freedesktop.org/series/54341/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11141_full
From: Ville Syrjälä
skl_needs_memory_bw_wa() doesn't look at the passed in state at all.
Possibly it should, but for now let's make life simpler by just
passing in dev_priv.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_pm.c | 21 +
1 file changed, 5
From: Ville Syrjälä
IS_GLK||IS_BXT == IS_GEN9_LP
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_pm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 3c351a21a0fa..b5e8ac51ef1c 100644
From: Ville Syrjälä
The spec doesn't use a definite article in front of SAGV. The
rules regarding articles and initialisms are super fuzzy, but
at least to my ears it sounds much more natural to not have
the article. Perhaps because I tend to pronounce it as
"sag-vee" instead of spelling out the
From: Ville Syrjälä
The spec used to say "8bpp" which someone took to mean 8 bytes per
pixel when in fact it was supposed to be 8 bits per pixel. The
spec has been updated to make it more clear now. Fix the code
to match.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
From: Ville Syrjälä
0*whatever==0 so this check is pointless. Remove it.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_pm.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 0843990ebf9f..3c351a21a0fa
From: Ville Syrjälä
Bspec says we have to reject the watermark if it's >= the ddb
allocation. Fix the code to reject the == case as it should.
For transition watermarks we can just use >=, for the rest
we'll do +1 when calculating the minimum ddb allocation size.
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
On icl+ bspec tells us to calculate a separate minimum ddb
allocation from the blocks watermark. Both have to be checked
against the actual ddb allocation, but since we do things the
other way around we'll just calculat the minimum acceptable
ddb allocation by taking the
From: Ville Syrjälä
On glk+ the level 0 lines watermark actually matters. Do not ignore it.
And while at it let's change things so that we always program a
consistnet 0 to the register when the lines watermarks is ignored
by the hardware.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
I thought we could remove all the early latency==0 checks
and rely on skl_wm_method{1,2}() checking for it. But
skl_compute_plane_wm() applies a bunch of workarounds to bump
up the latency before calling those guys so clearly it won't
end up doing the right thing. Also not
From: Ville Syrjälä
A few fixes to the watermark/ddb stuff. Noticed while trying to fix
icl. That one is still busted but at least we should more or less
match the spec now. Included a few cleanups etc. at the end as well.
Ville Syrjälä (9):
drm/i915: Don't ignore level 0 lines watermark for
On Fri, Dec 21, 2018 at 01:29:40AM +0530, Uma Shankar wrote:
> Enable ICL pipe csc hardware. CSC block is enabled
> in CSC_MODE register instead of PLANE_COLOR_CTL.
>
> ToDO: Extend the ABI to accept 32 bit coefficient values
> instead of 16bit for future platforms.
>
> v2: Addressed Maarten's
On Fri, Dec 21, 2018 at 01:29:39AM +0530, Uma Shankar wrote:
> Add support for icl pipe degamma and gamma.
>
> v2: Removed a POSTING_READ and corrected the Bit
> Definition as per Maarten's comments.
>
> v3: Addressed Matt's review comments. Removed rmw patterns
> as suggested by Matt.
>
> v4:
On Fri, Dec 21, 2018 at 07:14:36PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> IS_GLK||IS_BXT == IS_GEN9_LP
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
(I wont be able to review the entire series, just quickly
glancing the obvious ones before going out on vacation)
== Series Details ==
Series: Add support for Gen 11 pipe color features (rev4)
URL : https://patchwork.freedesktop.org/series/51408/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5337_full -> Patchwork_11143_full
Summary
On 2018-12-21 13:29, Tvrtko Ursulin wrote:
On 14/12/2018 18:20, Lucas De Marchi wrote:
From: Tomasz Lis
The table has been unified across OSes to minimize virtualization
overhead.
The MOCS table is now published as part of bspec, and versioned. Entries
are supposed to never be modified,
== Series Details ==
Series: skl+ watermark stuff
URL : https://patchwork.freedesktop.org/series/54424/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5339 -> Patchwork_11148
Summary
---
**SUCCESS**
No regressions
On Thu, Dec 20, 2018 at 03:55:27PM +0100, Daniel Vetter wrote:
> On Thu, Dec 20, 2018 at 02:28:55PM +, Winkler, Tomas wrote:
> >
> >
> > > On Wed, 19 Dec 2018, "Winkler, Tomas" wrote:
> > > >>
> > > >> On Wed, 19 Dec 2018, "C, Ramalingam" wrote:
> > > >> > On 12/19/2018 8:05 PM, Daniel
On Fri, Dec 21, 2018 at 01:29:38AM +0530, Uma Shankar wrote:
> Removed crtc state variable for gamma mode as it's redundant
> since currently we have fixed modes on respective hardware
> platforms. This was making this state variable irrelevant.
I'm going to add it back at some point.
>
>
On Fri, Dec 21, 2018 at 07:14:34PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The spec doesn't use a definite article in front of SAGV. The
> rules regarding articles and initialisms are super fuzzy, but
> at least to my ears it sounds much more natural to not have
> the article.
== Series Details ==
Series: skl+ watermark stuff
URL : https://patchwork.freedesktop.org/series/54424/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Don't ignore level 0 lines watermark for glk+
Okay!
Commit: drm/i915: Reinstate an early
On Fri, 2018-12-21 at 10:23 -0700, Ross Zwisler wrote:
> The following commit:
>
> commit 2bdd045e3a30 ("drm/i915/psr: Check if VBT says PSR can be
> enabled.")
>
> added some code with no usable functionality. Regardless of how the
> psr
> default is set up in the BDB_DRIVER_FEATURES section,
On Thu, 2018-12-20 at 15:13 -0800, Dhinakaran Pandiyan wrote:
> On Thu, 2018-12-20 at 09:10 -0800, Rodrigo Vivi wrote:
> > On Thu, Dec 20, 2018 at 02:21:20PM +0100, Hans de Goede wrote:
> > > Call intel_psr_enable() and intel_edp_drrs_enable() on pipe
> > > updates
> > > to make
> > > sure that we
98 matches
Mail list logo
