Re: [Intel-gfx] [PATCH] drm/i915/icl: Remove DDI IO power domain from PG3 power domains

2019-08-05 Thread Imre Deak
On Wed, Jul 31, 2019 at 09:03:24AM +0530, Anshuman Gupta wrote: > DDI IO power domain are in IO/PHY/AFE power domains. Which does not > require PG3 power well to be enable. Thanks for tracking this down. Imo the commit message would be clearer by saying: The DDI-IO power wells are backing the

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix wrong escape clock divisor init for GLK (rev3)

2019-08-05 Thread Jani Nikula
On Fri, 12 Jul 2019, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix wrong escape clock divisor init for GLK (rev3) > URL : https://patchwork.freedesktop.org/series/63505/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > bcd7871af13d drm/i915: Fix

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix include order in intel_tc.*

2019-08-05 Thread Jani Nikula
On Mon, 08 Jul 2019, Lucas De Marchi wrote: > On Thu, Jul 04, 2019 at 04:56:41PM +0300, Imre Deak wrote: >>On Wed, Jul 03, 2019 at 05:06:47PM -0700, Lucas De Marchi wrote: >>> Make intel_tc.h the first include so we guarantee it's self-contained. >>> Sort the rest. Same principle applies for

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix wrong escape clock divisor init for GLK (rev3)

2019-08-05 Thread Lisovskiy, Stanislav
On Mon, 2019-08-05 at 10:59 +0300, Jani Nikula wrote: > On Fri, 12 Jul 2019, Patchwork > wrote: > > == Series Details == > > > > Series: drm/i915: Fix wrong escape clock divisor init for GLK > > (rev3) > > URL : https://patchwork.freedesktop.org/series/63505/ > > State : warning > > > > ==

Re: [Intel-gfx] [PATCH 1/4] drm/i915: make new intel_tc.c use uncore accessors

2019-08-05 Thread Jani Nikula
On Wed, 03 Jul 2019, Lucas De Marchi wrote: > Let's make the just created intel_tc.c already follow the trend of using > i915 instead of dev_priv and calling the intel_uncore_*() functions. I'm not sure we all agreed on using intel_uncore_{read,write}() in display/ code yet though. There's

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-08-05 Thread Chris Wilson
As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105010

[Intel-gfx] [PATCH 1/2] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

[Intel-gfx] patc push failed

2019-08-05 Thread Yang, Dong
Hi, I have clone the drm-intel code-base, after I apply my patch locally and I want upstream the patch, but it report error: fatal: unable to access 'https://anongit.freedesktop.org/git/drm-intel.git/': The requested URL returned error: 403 I use git clone to clone the code-base: git clone

Re: [Intel-gfx] [PATCH v12 0/6] HDCP2.2 Phase II

2019-08-05 Thread Jani Nikula
On Thu, 01 Aug 2019, Ramalingam C wrote: > Series adds the content_type support for HDCP2.2. Along with that uevent > is sent for each HDCP state change triggered within kernel. Acked-by: Jani Nikula For merging the i915 specific parts via drm-misc along the rest of the patches. > > Pekka

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix wrong escape clock divisor init for GLK (rev3)

2019-08-05 Thread Jani Nikula
On Mon, 05 Aug 2019, "Lisovskiy, Stanislav" wrote: > On Mon, 2019-08-05 at 10:59 +0300, Jani Nikula wrote: >> On Fri, 12 Jul 2019, Patchwork >> wrote: >> > == Series Details == >> > >> > Series: drm/i915: Fix wrong escape clock divisor init for GLK >> > (rev3) >> > URL :

Re: [Intel-gfx] [PATCH 12/13] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-08-05 Thread Jyri Sarha
On 31/07/2019 19:58, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- > 1 file

Re: [Intel-gfx] patc push failed

2019-08-05 Thread Jani Nikula
On Mon, 05 Aug 2019, "Yang, Dong" wrote: > I have clone the drm-intel code-base, after I apply my patch locally > and I want upstream the patch, but it report error: fatal: unable to > access 'https://anongit.freedesktop.org/git/drm-intel.git/': The > requested URL returned error: 403 > > I use

[Intel-gfx] [PATCH v6 10/17] drm/ttm: switch ttm core from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_driver.h| 12 ++-- drivers/gpu/drm/ttm/ttm_bo.c | 98 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 16 ++--- drivers/gpu/drm/ttm/ttm_bo_vm.c| 6 +-

[Intel-gfx] [PATCH v6 11/17] drm/radeon: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++---

[Intel-gfx] [PATCH v6 03/17] drm/qxl: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from qxl_bo, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_drv.h | 6 +++--- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++--

[Intel-gfx] [PATCH v6 16/17] drm/virtio: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

[Intel-gfx] [PATCH v6 04/17] drm/radeon: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +-

[Intel-gfx] [PATCH v6 05/17] drm/amdgpu: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 -

[Intel-gfx] [PATCH v6 07/17] drm/ttm: use gem reservation object

2019-08-05 Thread Gerd Hoffmann
Drop ttm_resv from ttm_buffer_object, use the gem reservation object (base._resv) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 39 ++-

[Intel-gfx] [PATCH v6 12/17] drm/vmwgfx: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 8 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 6 +++--- 4 files changed, 11

[Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-05 Thread Gerd Hoffmann
Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2

[Intel-gfx] [PATCH v6 14/17] drm/nouveau: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c| 5 ++--- drivers/gpu/drm/nouveau/nouveau_fence.c | 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 4 files changed, 5 insertions(+), 6

[Intel-gfx] [PATCH v6 15/17] drm/qxl: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +- drivers/gpu/drm/qxl/qxl_release.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c b/drivers/gpu/drm/qxl/qxl_debugfs.c index

[Intel-gfx] [PATCH v6 17/17] drm/ttm: drop ttm_buffer_object->resv

2019-08-05 Thread Gerd Hoffmann
All users moved to ttm_buffer_object->base.resv Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index

[Intel-gfx] [PATCH v6 06/17] drm/nouveau: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from nouveau_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.h | 5 - drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +-

[Intel-gfx] [PATCH v6 13/17] drm/amdgpu: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-

[Intel-gfx] [PATCH v6 02/17] drm/vram: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from drm_gem_vram_object, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König Acked-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 3 +-- drivers/gpu/drm/ast/ast_main.c | 2 +-

[Intel-gfx] [PATCH v6 09/17] drm/ttm: set both resv and base.resv pointers

2019-08-05 Thread Gerd Hoffmann
Initialize both ttm_buffer_object->resv and ttm_buffer_object->base.resv pointers. This allows to move users from the former to the latter. When all users are moved we can drop ttm_buffer_object->resv. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/ttm: make ttm bo a gem bo subclass (rev2)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/ttm: make ttm bo a gem bo subclass (rev2) URL : https://patchwork.freedesktop.org/series/64701/ State : success == Summary == CI Bug Log - changes from CI_DRM_6628 -> Patchwork_13870 Summary ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915: stop pruning reservation object after wait

2019-08-05 Thread Chris Wilson
Quoting Christian König (2019-08-05 16:45:50) > The reservation object should be capable of handling its internal memory > management itself. And since we search for a free slot to add the fence > from the beginning this is actually a waste of time and only minimal helpful. "From the beginning?"

Re: [Intel-gfx] [PATCH 5/5] dma-buf: nuke reservation_object seq number

2019-08-05 Thread Daniel Vetter
On Mon, Aug 05, 2019 at 05:07:41PM +0100, Chris Wilson wrote: > Quoting Christian König (2019-08-05 16:45:54) > > @@ -214,16 +214,16 @@ static __poll_t dma_buf_poll(struct file *file, > > poll_table *poll) > > return 0; > > > > retry: > > - seq =

Re: [Intel-gfx] [PATCH 1/4] drm/i915/guc: Prefer intel_guc_is_submission_supported

2019-08-05 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-04 20:50:49) > No need to use intel_uc_supports_guc_submission(uc) as we > can directly use intel_guc_is_submission_supported(guc) > > Signed-off-by: Michal Wajdeczko > Cc: Daniele Ceraolo Spurio > Cc: Chris Wilson Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 2/4] drm/i915/huc: Prefer intel_huc_is_supported

2019-08-05 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-04 20:50:50) > No need to dance with intel_uc_supports_huc(uc) as we > can directly use intel_huc_is_supported(huc) > > Signed-off-by: Michal Wajdeczko > Cc: Daniele Ceraolo Spurio > Cc: Chris Wilson Reviewed-by: Chris Wilson -Chris

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for convert i915 to new mount API

2019-08-05 Thread Patchwork
== Series Details == Series: convert i915 to new mount API URL : https://patchwork.freedesktop.org/series/64720/ State : warning == Summary == $ dim checkpatch origin/drm-tip 475186841e5f fs: export put_filesystem() 50698577361e i915: convert to new mount API -:74:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Refactor oa object to better manage resources (rev4)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/i915/perf: Refactor oa object to better manage resources (rev4) URL : https://patchwork.freedesktop.org/series/60176/ State : warning == Summary == $ dim checkpatch origin/drm-tip f885af0cdd23 drm/i915/perf: Refactor oa object to better manage resources -:880:

[Intel-gfx] [PATCH v3] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

Re: [Intel-gfx] [RFC] drm/i915/gt: create a subfolder for GT debugfs

2019-08-05 Thread Daniele Ceraolo Spurio
On 8/3/19 1:27 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-08-03 02:09:44) The idea is to better organize our debugfs entries by moving the GT-related ones into their own subfolder, similarly to what we did for the kernel code. As an example, this patch moves the GuC/HuC and

[Intel-gfx] [PATCHv2 2/3] i915: convert to new mount API

2019-08-05 Thread Sergey Senozhatsky
tmpfs does not set ->remount_fs() anymore and its users need to be converted to new mount API. BUG: kernel NULL pointer dereference, address: PF: supervisor instruction fetch in kernel mode PF: error_code(0x0010) - not-present page RIP: 0010:0x0 Code: Bad RIP value. Call

[Intel-gfx] [PATCHv2 3/3] i915: do not leak module ref counter

2019-08-05 Thread Sergey Senozhatsky
put_filesystem() must follow get_fs_type(). Signed-off-by: Sergey Senozhatsky --- drivers/gpu/drm/i915/gem/i915_gemfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c index feedc9242072..93ac365ce9ce 100644 ---

[Intel-gfx] [PATCHv2 1/3] fs: export put_filesystem()

2019-08-05 Thread Sergey Senozhatsky
Modules can use get_fs_type(), which is exported, but are unable to put_filesystem(). Export it and let modules to also decrement corresponding file systems' reference counters. Signed-off-by: Sergey Senozhatsky --- fs/filesystems.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for convert i915 to new mount API

2019-08-05 Thread Patchwork
== Series Details == Series: convert i915 to new mount API URL : https://patchwork.freedesktop.org/series/64720/ State : success == Summary == CI Bug Log - changes from CI_DRM_6630 -> Patchwork_13871 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 05/17] drm/i915/gem: Make caps.scheduler static

2019-08-05 Thread Andi Shyti
Hi Chris, > /** > - * i915_gem_shrinker_register - Register the i915 shrinker > + * i915_gem_driver_register__shrinker - Register the i915 shrinker > * @i915: i915 device > * > * This function registers and sets up the i915 shrinker and OOM handler. > */ > -void

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove stale kerneldoc for internal MOCS functions

2019-08-05 Thread Daniele Ceraolo Spurio
On 8/3/19 3:22 AM, Chris Wilson wrote: The kerneldoc were stale, generating mismatching parameters warning, but furthermore they were for internal routines, not part of the MOCS interface so the instructions were superfluous. Signed-off-by: Chris Wilson Reviewed-by: Daniele Ceraolo Spurio

Re: [Intel-gfx] [PATCH 13/17] drm/i915: Isolate i915_getparam_ioctl()

2019-08-05 Thread Andi Shyti
Hi Chris, On Tue, Jul 30, 2019 at 02:30:31PM +0100, Chris Wilson wrote: > This giant switch has tendrils all other the struct and does not fit > into the rest of the driver bring up and control of i915_drv.c. Push it > to one side so that it can grow in peace. > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH 12/17] drm/i915: Use intel_engine_lookup_user for probing HAS_BSD etc

2019-08-05 Thread Andi Shyti
Hi Chris, On Tue, Jul 30, 2019 at 02:30:30PM +0100, Chris Wilson wrote: > Use the same mechanism to determine if a backend engine exists for a > uabi mapping as used internally. Looks OK, Reviewed-by: Andi Shyti Andi ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 3/4] drm/i915/uc: Remove redundant GuC support checks

2019-08-05 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-04 20:50:51) > Since commit db81bc6eb9c0 ("drm/i915/uc: Consider enable_guc > modparam during fw selection") we have started using firmware > status as main indicator of the GuC support. No need to use > same checks twice. > > Signed-off-by: Michal Wajdeczko >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/ttm: make ttm bo a gem bo subclass (rev2)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/ttm: make ttm bo a gem bo subclass (rev2) URL : https://patchwork.freedesktop.org/series/64701/ State : success == Summary == CI Bug Log - changes from CI_DRM_6628_full -> Patchwork_13870_full Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/perf: Refactor oa object to better manage resources (rev4)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/i915/perf: Refactor oa object to better manage resources (rev4) URL : https://patchwork.freedesktop.org/series/60176/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/perf: Refactor oa object to better manage

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Push the ring creation flags to the backend

2019-08-05 Thread Andi Shyti
Hi Chris, On Tue, Jul 30, 2019 at 02:30:27PM +0100, Chris Wilson wrote: > Push the ring creation flags from the outer GEM context to the inner > intel_cotnext to avoid an unsightly back-reference from inside the > backend. > > Signed-off-by: Chris Wilson looks nice! Reviewed-by: Andi Shyti

[Intel-gfx] [PATCHv2 0/3] convert i915 to new mount API

2019-08-05 Thread Sergey Senozhatsky
Hello, Convert i915 to a new mount API and fix i915_gemfs_init() kernel Oops. It also appears that we need to EXPORTs put_filesystem(), so i915 can properly put filesystem after it is done with kern_mount(). v2: - export put_filesystem() [Chris] - always put_filesystem() in

Re: [Intel-gfx] [PATCH 5/5] dma-buf: nuke reservation_object seq number

2019-08-05 Thread Chris Wilson
Quoting Christian König (2019-08-05 16:45:54) > @@ -214,16 +214,16 @@ static __poll_t dma_buf_poll(struct file *file, > poll_table *poll) > return 0; > > retry: > - seq = read_seqcount_begin(>seq); > rcu_read_lock(); > > + fence_excl =

[Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-08-05 Thread Umesh Nerlige Ramappa
The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user. Attributes in the oa object that are gen-specific

Re: [Intel-gfx] [PATCH v2 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-05 Thread Rodrigo Vivi
On Sun, Aug 04, 2019 at 03:48:47PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide

Re: [Intel-gfx] [PATCH 1/5] drm/i915: stop pruning reservation object after wait

2019-08-05 Thread Chris Wilson
Quoting Chris Wilson (2019-08-05 16:58:56) > Quoting Christian König (2019-08-05 16:45:50) > > The reservation object should be capable of handling its internal memory > > management itself. And since we search for a free slot to add the fence > > from the beginning this is actually a waste of

Re: [Intel-gfx] [PATCH 04/17] drm/i915: Use drm_i915_private directly from drv_get_drvdata()

2019-08-05 Thread Andi Shyti
Hi Chris, > static void i915_switcheroo_set_state(struct pci_dev *pdev, enum > vga_switcheroo_state state) > { > - struct drm_device *dev = pci_get_drvdata(pdev); > + struct drm_i915_private *i915 = pdev_to_i915(pdev); > pm_message_t pmm = { .event = PM_EVENT_SUSPEND }; > > +

Re: [Intel-gfx] [PATCH 4/4] drm/i915/uc: Don't fail on HuC early init errors

2019-08-05 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-04 20:50:52) > Since commit 301efe96f777 ("drm/i915/uc: Don't fail on HuC > firmware failure") we can continue driver load after error > during HuC firmware load or authentication, but we could > still fail on any error during early HuC initialization. > Change

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove stale kerneldoc for internal MOCS functions

2019-08-05 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-08-05 17:59:31) > > > On 8/3/19 3:22 AM, Chris Wilson wrote: > > The kerneldoc were stale, generating mismatching parameters warning, but > > furthermore they were for internal routines, not part of the MOCS > > interface so the instructions were superfluous.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with drm/i915: Defer final intel_wakeref_put to process context (rev2)

2019-08-05 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Defer final intel_wakeref_put to process context (rev2) URL : https://patchwork.freedesktop.org/series/64693/ State : success == Summary == CI Bug Log - changes from CI_DRM_6628 -> Patchwork_13868

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/ttm: make ttm bo a gem bo subclass (rev2)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/ttm: make ttm bo a gem bo subclass (rev2) URL : https://patchwork.freedesktop.org/series/64701/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7942960fb839 drm/ttm: add gem base object -:66: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be

[Intel-gfx] [PATCH v5 14/18] drm/amdgpu: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-

[Intel-gfx] [PATCH v5 08/18] drm/ttm: use gem vma_node

2019-08-05 Thread Gerd Hoffmann
Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2

[Intel-gfx] [PATCH v5 18/18] drm/ttm: drop ttm_buffer_object->resv

2019-08-05 Thread Gerd Hoffmann
All users moved to ttm_buffer_object->base.resv Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index

[Intel-gfx] [PATCH v5 16/18] drm/qxl: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +- drivers/gpu/drm/qxl/qxl_release.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c b/drivers/gpu/drm/qxl/qxl_debugfs.c index

[Intel-gfx] [PATCH v5 13/18] drm/vmwgfx: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 8 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 6 +++--- 4 files changed, 11

[Intel-gfx] [PATCH v5 04/18] drm/radeon: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +-

[Intel-gfx] [PATCH v5 07/18] drm/ttm: use gem reservation object

2019-08-05 Thread Gerd Hoffmann
Drop ttm_resv from ttm_buffer_object, use the gem reservation object (base._resv) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 39 ++-

[Intel-gfx] [PATCH v5 02/18] drm/vram: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from drm_gem_vram_object, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König Acked-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 3 +-- drivers/gpu/drm/ast/ast_main.c | 2 +-

[Intel-gfx] [PATCH v5 11/18] [fixup] ttm

2019-08-05 Thread Gerd Hoffmann
--- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index b3d628b3f038..73d407494586 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -961,7 +961,7 @@ static

[Intel-gfx] [PATCH v5 15/18] drm/nouveau: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c| 5 ++--- drivers/gpu/drm/nouveau/nouveau_fence.c | 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 4 files changed, 5 insertions(+), 6

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/ttm: make ttm bo a gem bo subclass

2019-08-05 Thread Patchwork
== Series Details == Series: drm/ttm: make ttm bo a gem bo subclass URL : https://patchwork.freedesktop.org/series/64701/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC [M]

[Intel-gfx] [PATCH] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64693/ State : success == Summary == CI Bug Log - changes from CI_DRM_6628 -> Patchwork_13867

[Intel-gfx] [PATCH v5 06/18] drm/nouveau: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from nouveau_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.h | 5 - drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +-

[Intel-gfx] [PATCH v5 12/18] drm/radeon: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++---

[Intel-gfx] [PATCH v5 05/18] drm/amdgpu: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 -

[Intel-gfx] [PATCH v5 01/18] drm/ttm: add gem base object

2019-08-05 Thread Gerd Hoffmann
Add drm_gem_object struct to ttm_buffer_object, so ttm objects are a gdm object superclass. Add a function to check whenever a given bo actually uses the embedded drm_gem_object. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 23

[Intel-gfx] [PATCH v5 17/18] drm/virtio: switch driver from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

[Intel-gfx] [PATCH v5 03/18] drm/qxl: use embedded gem object

2019-08-05 Thread Gerd Hoffmann
Drop drm_gem_object from qxl_bo, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_drv.h | 6 +++--- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++--

[Intel-gfx] [PATCH v5 09/18] drm/ttm: set both resv and base.resv pointers

2019-08-05 Thread Gerd Hoffmann
Initialize both ttm_buffer_object->resv and ttm_buffer_object->base.resv pointers. This allows to move users from the former to the latter. When all users are moved we can drop ttm_buffer_object->resv. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c

[Intel-gfx] [PATCH v5 10/18] drm/ttm: switch ttm core from bo->resv to bo->base.resv

2019-08-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_driver.h| 12 ++-- drivers/gpu/drm/ttm/ttm_bo.c | 94 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 16 ++--- drivers/gpu/drm/ttm/ttm_bo_vm.c| 6 +-

Re: [Intel-gfx] [PATCH v5 11/18] [fixup] ttm

2019-08-05 Thread Gerd Hoffmann
On Mon, Aug 05, 2019 at 02:43:03PM +0200, Gerd Hoffmann wrote: > --- > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index b3d628b3f038..73d407494586 100644 > ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with drm/i915: Defer final intel_wakeref_put to process context (rev2)

2019-08-05 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Defer final intel_wakeref_put to process context (rev2) URL : https://patchwork.freedesktop.org/series/64693/ State : success == Summary == CI Bug Log - changes from CI_DRM_6628_full -> Patchwork_13868_full

Re: [Intel-gfx] [PATCH] drm/i915/icl: Remove DDI IO power domain from PG3 power domains

2019-08-05 Thread Imre Deak
On Mon, Aug 05, 2019 at 12:49:13PM +0300, Imre Deak wrote: > On Wed, Jul 31, 2019 at 09:03:24AM +0530, Anshuman Gupta wrote: > > > DDI IO power domain are in IO/PHY/AFE power domains. Which does not > > require PG3 power well to be enable. > > Thanks for tracking this down. > > Imo the commit

[Intel-gfx] [PATCH v5 00/18] drm/ttm: make ttm bo a gem bo subclass

2019-08-05 Thread Gerd Hoffmann
v5: - rebase to latest drm-misc-next, adapt to reservation changes. - cc to intel-gfx for CI coverage. - all patches are acked now, so unless CI throws errors I'll go push this tomorrow. v4: - rebase to latest drm-misc-next, adapt to vram helper changes. v3: - comment updates - rebased on

[Intel-gfx] [PATCH v6 00/17] drm/ttm: make ttm bo a gem bo subclass

2019-08-05 Thread Gerd Hoffmann
v6: - fix CONFIG_PROVE_LOCKING=y build failure spotted by CI. v5: - rebase to latest drm-misc-next, adapt to reservation changes. - cc to intel-gfx for CI coverage. - all patches are acked now, so unless CI throws errors I'll go push this tomorrow. v4: - rebase to latest drm-misc-next,

[Intel-gfx] [PATCH v6 01/17] drm/ttm: add gem base object

2019-08-05 Thread Gerd Hoffmann
Add drm_gem_object struct to ttm_buffer_object, so ttm objects are a gdm object superclass. Add a function to check whenever a given bo actually uses the embedded drm_gem_object. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 23

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/ttm: make ttm bo a gem bo subclass (rev2)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/ttm: make ttm bo a gem bo subclass (rev2) URL : https://patchwork.freedesktop.org/series/64701/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/ttm: add gem base object Okay! Commit: drm/vram: use embedded gem

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_schedule: Avoid using borked engines

2019-08-05 Thread Andi Shyti
Hi Chris, On Tue, Jul 30, 2019 at 10:24:53PM +0100, Chris Wilson wrote: > Check for viability of store-dword before use. > > Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti Andi ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCHv2 2/3] i915: convert to new mount API

2019-08-05 Thread Al Viro
On Mon, Aug 05, 2019 at 07:12:55PM +0100, Al Viro wrote: > On Tue, Aug 06, 2019 at 01:03:06AM +0900, Sergey Senozhatsky wrote: > > tmpfs does not set ->remount_fs() anymore and its users need > > to be converted to new mount API. > > Could you explain why the devil do you bother with remount at

[Intel-gfx] [PATCH v3] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-08-05 Thread Chris Wilson
As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs that interfere with the new

Re: [Intel-gfx] [PATCH 1/4] drm/i915: make new intel_tc.c use uncore accessors

2019-08-05 Thread Lucas De Marchi
On Mon, Aug 05, 2019 at 12:48:16PM +0300, Jani Nikula wrote: On Wed, 03 Jul 2019, Lucas De Marchi wrote: Let's make the just created intel_tc.c already follow the trend of using i915 instead of dev_priv and calling the intel_uncore_*() functions. I'm not sure we all agreed on using

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Refactor oa object to better manage resources (rev4)

2019-08-05 Thread Patchwork
== Series Details == Series: drm/i915/perf: Refactor oa object to better manage resources (rev4) URL : https://patchwork.freedesktop.org/series/60176/ State : success == Summary == CI Bug Log - changes from CI_DRM_6630 -> Patchwork_13872

Re: [Intel-gfx] [PATCH 4/4] drm/i915/uc: Don't fail on HuC early init errors

2019-08-05 Thread Michal Wajdeczko
On Mon, 05 Aug 2019 19:24:57 +0200, Chris Wilson wrote: So we just leave the HuC uninitialised and HUC_STATUS should then report no authentication. (We do scrub that at some point just in case the million resets did not?) Bspec says that it's RO from the host and it will be 0 out of reset

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't fail on HuC early init errors

2019-08-05 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-04 21:27:38) > On Sun, 04 Aug 2019 22:18:51 +0200, Patchwork > wrote: > > * igt@runner@aborted: > > - fi-cml-u2: NOTRUN -> [FAIL][1] > >[1]: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-cml-u2/igt@run...@aborted.html > >

[Intel-gfx] [PATCH v3] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

[Intel-gfx] [PATCH v3] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Chris Wilson
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3] drm/i915: Defer final intel_wakeref_put to process context (rev5)

2019-08-05 Thread Patchwork
== Series Details == Series: series starting with [v3] drm/i915: Defer final intel_wakeref_put to process context (rev5) URL : https://patchwork.freedesktop.org/series/64693/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Defer final

Re: [Intel-gfx] [PATCH] drm/i915: Separate pinning of pages from i915_vma_insert()

2019-08-05 Thread Kumar Valsan, Prathap
On Fri, Aug 02, 2019 at 09:30:43PM +0100, Chris Wilson wrote: > Quoting Prathap Kumar Valsan (2019-08-02 21:41:11) > > Currently i915_vma_insert() is responsible for allocating drm mm node > > and also allocating or gathering physical pages. Move the latter to a > > separate function for better

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/2] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64730/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Defer final

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Defer final intel_wakeref_put to process context

2019-08-05 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Defer final intel_wakeref_put to process context URL : https://patchwork.freedesktop.org/series/64730/ State : warning == Summary == $ dim checkpatch origin/drm-tip 67f25b32ca94 drm/i915: Defer final intel_wakeref_put to

  1   2   >