[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Lower cdclk for sub 4k resolutions URL : https://patchwork.freedesktop.org/series/65475/ State : success == Summary == CI Bug Log - changes from CI_DRM_6748 -> Patchwork_14100 Summary ---

Re: [Intel-gfx] [PATCH v2 31/40] rm/i915/tgl: Move GTCR register to cope with GAM MMIO address remap

2019-08-20 Thread Lucas De Marchi
On Sat, Aug 17, 2019 at 02:38:53AM -0700, Lucas De Marchi wrote: From: Michel Thierry GAM registers located in the 0x4xxx range have been relocated to 0xCxxx; this is to make space for global MOCS registers. HSD: 399379 Cc: Daniele Ceraolo Spurio Signed-off-by: Michel Thierry Signed-off-by:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep annotations on its head URL : https://patchwork.freedesktop.org/series/65467/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743_full -> Patchwork_14096_full

Re: [Intel-gfx] [PATCH 3/4] kernel.h: Add non_block_start/end()

2019-08-20 Thread Daniel Vetter
On Tue, Aug 20, 2019 at 10:19:01AM +0200, Daniel Vetter wrote: > In some special cases we must not block, but there's not a > spinlock, preempt-off, irqs-off or similar critical section already > that arms the might_sleep() debug checks. Add a non_block_start/end() > pair to annotate these. > >

Re: [Intel-gfx] [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+

2019-08-20 Thread Daniele Ceraolo Spurio
On 8/20/19 12:54 PM, Daniel Vetter wrote: The cpu (de)tiler hw is gone, this stopped being useful. Plus it never supported any of the fancy new tiling formats, which means userspace also stopped using the magic side-channel this provides. This would totally break a lot of the igts, but

Re: [Intel-gfx] [PATCH] drm/i915: Do not create a new max_bpc prop for MST connectors

2019-08-20 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 5ca0ef8a56b8 drm/i915: Add max_bpc property for DP MST. The bot has tested the following trees: v5.2.9. v5.2.9: Failed to apply! Possible dependencies: Unable to calculate

[Intel-gfx] ✗ Fi.CI.BAT: failure for RFC/T: dma_resv vs. mmap_sem

2019-08-20 Thread Patchwork
== Series Details == Series: RFC/T: dma_resv vs. mmap_sem URL : https://patchwork.freedesktop.org/series/65488/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6749 -> Patchwork_14107 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+

2019-08-20 Thread Daniel Vetter
On Tue, Aug 20, 2019 at 8:55 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-08-20 18:06:31) > > The cpu (de)tiler hw is gone, this stopped being useful. Plus it never > > supported any of the fancy new tiling formats, which means userspace > > also stopped using the magic side-channel

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: disable set/get_tiling ioctl on gen12+

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: disable set/get_tiling ioctl on gen12+ URL : https://patchwork.freedesktop.org/series/65495/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6749 -> Patchwork_14109 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Serialize insertion into the file->mm.request_list

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: Serialize insertion into the file->mm.request_list URL : https://patchwork.freedesktop.org/series/65468/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743_full -> Patchwork_14097_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: disable set/get_tiling ioctl on gen12+ (rev2)

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: disable set/get_tiling ioctl on gen12+ (rev2) URL : https://patchwork.freedesktop.org/series/65495/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5281445913b8 drm/i915: disable set/get_tiling ioctl on gen12+ -:56:

Re: [Intel-gfx] [PATCH v2 21/40] drm/i915/tgl: Enable VD HCP/MFX sub-pipe power gating

2019-08-20 Thread Lucas De Marchi
On Sat, Aug 17, 2019 at 02:38:43AM -0700, Lucas De Marchi wrote: From: Michel Thierry HCP/MFX power gating is disabled by default, turn it on for the vd units available. User space will also issue a MI_FORCE_WAKEUP properly to wake up proper subwell. During driver load, init_clock_gating

[Intel-gfx] [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+

2019-08-20 Thread Daniel Vetter
The cpu (de)tiler hw is gone, this stopped being useful. Plus it never supported any of the fancy new tiling formats, which means userspace also stopped using the magic side-channel this provides. This would totally break a lot of the igts, but they're already broken for the same reasons as

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Serialise the fill BLT with the vma pinning (rev2)

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: Serialise the fill BLT with the vma pinning (rev2) URL : https://patchwork.freedesktop.org/series/65482/ State : failure == Summary == Applying: drm/i915: Serialise the fill BLT with the vma pinning Using index info to reconstruct a base tree... M

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gtt: Relax pd_used assertion

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Relax pd_used assertion URL : https://patchwork.freedesktop.org/series/65484/ State : failure == Summary == Applying: drm/i915/gtt: Relax pd_used assertion Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/i915_gem_gtt.c

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add function to determine if a slice has a subslice

2019-08-20 Thread Chris Wilson
Quoting Summers, Stuart (2019-08-20 20:01:05) > On Tue, 2019-08-20 at 11:53 +0100, Chris Wilson wrote: > > Quoting Stuart Summers (2019-08-19 22:50:00) > > > Add a new function to determine whether a particular slice > > > has a given subslice. > > > > > > Signed-off-by: Stuart Summers > > > ---

Re: [Intel-gfx] [PATCH v3 6/8] drm/i915/display/icl: Enable master-slaves in trans port sync mode in correct order

2019-08-20 Thread Manasi Navare
Hi Maarten, For this patch, you want me to modify it such that if (slave && needs_modeset) then dont do anything since the slave update crtc and pipe an dplane updates will happen with master. So if(master && needs_modeset) { obtain slaves from slave_mask obtain corresponding slave crtc state

[Intel-gfx] ✓ Fi.CI.IGT: success for Tiger Lake batch 3 (rev3)

2019-08-20 Thread Patchwork
== Series Details == Series: Tiger Lake batch 3 (rev3) URL : https://patchwork.freedesktop.org/series/65290/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743_full -> Patchwork_14094_full Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Introduce intel_reg_types.h

2019-08-20 Thread Daniele Ceraolo Spurio
On 8/20/19 8:42 AM, Michal Wajdeczko wrote: On Tue, 20 Aug 2019 04:01:47 +0200, Daniele Ceraolo Spurio wrote: diff --git a/drivers/gpu/drm/i915/intel_reg_types.h b/drivers/gpu/drm/i915/intel_reg_types.h new file mode 100644 index ..87bce80dd5ed --- /dev/null +++

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not create a new max_bpc prop for MST connectors

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: Do not create a new max_bpc prop for MST connectors URL : https://patchwork.freedesktop.org/series/65493/ State : success == Summary == CI Bug Log - changes from CI_DRM_6749 -> Patchwork_14108 Summary

Re: [Intel-gfx] [PATCH v2 06/40] drm/i915: Add transcoder restriction to PSR2

2019-08-20 Thread Lucas De Marchi
On Sat, Aug 17, 2019 at 02:38:28AM -0700, Lucas De Marchi wrote: From: José Roberto de Souza According to PSR2_CTL definition in BSpec there is only one instance of PSR2_CTL. Platforms gen < 12 with EDP transcoder only support PSR2 on TRANSCODER_EDP while on TGL PSR2 is only supported by

Re: [Intel-gfx] [PATCH v2 05/40] drm/i915/psr: Make PSR registers relative to transcoders

2019-08-20 Thread Souza, Jose
On Tue, 2019-08-20 at 13:16 -0700, Lucas De Marchi wrote: > On Sat, Aug 17, 2019 at 02:38:27AM -0700, Lucas De Marchi wrote: > > From: José Roberto de Souza > > > > PSR registers are a mess, some have the full address while others > > just > > have the additional offset from psr_mmio_base. > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable HDCP 1.4 and 2.2 on Gen12+ (rev4)

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: Enable HDCP 1.4 and 2.2 on Gen12+ (rev4) URL : https://patchwork.freedesktop.org/series/63432/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743_full -> Patchwork_14093_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFC/T: dma_resv vs. mmap_sem

2019-08-20 Thread Patchwork
== Series Details == Series: RFC/T: dma_resv vs. mmap_sem URL : https://patchwork.freedesktop.org/series/65488/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4823a79936e3 dma_resv: prime lockdep annotations -:65: WARNING:BAD_SIGN_OFF: email address '"VMware Graphics" ' might

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add function to determine if a slice has a subslice

2019-08-20 Thread Summers, Stuart
On Tue, 2019-08-20 at 11:53 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-08-19 22:50:00) > > Add a new function to determine whether a particular slice > > has a given subslice. > > > > Signed-off-by: Stuart Summers > > --- > > drivers/gpu/drm/i915/gt/intel_sseu.h | 10

[Intel-gfx] [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+

2019-08-20 Thread Daniel Vetter
The cpu (de)tiler hw is gone, this stopped being useful. Plus it never supported any of the fancy new tiling formats, which means userspace also stopped using the magic side-channel this provides. This would totally break a lot of the igts, but they're already broken for the same reasons as

Re: [Intel-gfx] [PATCH v2 07/40] drm/i915: Do not unmask PSR interruption in IRQ postinstall

2019-08-20 Thread Lucas De Marchi
On Sat, Aug 17, 2019 at 02:38:29AM -0700, Lucas De Marchi wrote: From: José Roberto de Souza No need to unmask PSR interrutpion if PSR is not enabled, better move the call to intel_psr_enable_source(). Cc: Rodrigo Vivi Cc: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza

[Intel-gfx] [PATCH] dmabuf: Mark up onstack timer for selftests

2019-08-20 Thread Chris Wilson
The dma-fence selftest uses an on-stack timer that requires explicit annotation for debugobjects. Signed-off-by: Chris Wilson Cc: Daniel Vetter --- drivers/dma-buf/st-dma-fence.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/st-dma-fence.c

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix HW readout for crtc_clock in HDMI mode (rev2)

2019-08-20 Thread Imre Deak
On Fri, Aug 09, 2019 at 11:47:12AM +0300, Imre Deak wrote: > On Fri, Aug 09, 2019 at 06:55:53AM +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Fix HW readout for crtc_clock in HDMI mode (rev2) > > URL : https://patchwork.freedesktop.org/series/64909/ > > State :

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Ville Syrjälä
On Tue, Aug 20, 2019 at 01:35:37PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Kahola, Mika > >Sent: Tuesday, August 20, 2019 4:37 PM > >To: intel-gfx@lists.freedesktop.org > >Cc: Shankar, Uma ; Kahola, Mika > > > >Subject: [PATCH] drm/i915/tgl: Lower cdclk for sub 4k

[Intel-gfx] [PATCH] drm/i915/gtt: Relax pd_used assertion

2019-08-20 Thread Chris Wilson
The current assertion tries to make sure that we do not over count the number of used PDE inside a page directory -- that is with an array of 512 pde, we do not expect more than 512 elements used! However, our assertion has to take into account that as we pin an element into the page directory,

Re: [Intel-gfx] [PATCH 5/5] drm/i915/hdmi: make hdcp2_msg_data const

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 16:40:19 +0300, Jani Nikula wrote: > It's static const data, make it so. > > Cc: Ramalingam C > Signed-off-by: Jani Nikula Reviewed-by: Ramalingam C -Ram > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Intel-gfx] [PATCH 1/5] drm/i915/dp: stylistic cleanup around hdcp2_msg_data

2019-08-20 Thread Jani Nikula
On Tue, 20 Aug 2019, Ville Syrjälä wrote: > On Tue, Aug 20, 2019 at 04:40:15PM +0300, Jani Nikula wrote: >> Split struct declaration and array definition. Fix indents and >> whitespace. No functional changes. >> >> Cc: Ramalingam C >> Signed-off-by: Jani Nikula >> --- >>

Re: [Intel-gfx] [PATCH 1/3] dma_resv: prime lockdep annotations

2019-08-20 Thread Koenig, Christian
Am 20.08.19 um 16:53 schrieb Daniel Vetter: > Full audit of everyone: > > - i915, radeon, amdgpu should be clean per their maintainers. > > - vram helpers should be fine, they don't do command submission, so >really no business holding struct_mutex while doing copy_*_user. But >I haven't

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-08-20 Thread Koenig, Christian
Am 20.08.19 um 17:41 schrieb Daniel Vetter: > On Tue, Aug 20, 2019 at 5:34 PM Koenig, Christian > wrote: >> Am 20.08.19 um 17:21 schrieb Daniel Vetter: >>> On Tue, Aug 20, 2019 at 5:16 PM Koenig, Christian >>> wrote: Am 20.08.19 um 16:53 schrieb Daniel Vetter: > With nouveau fixed all

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Jani Nikula
On Tue, 20 Aug 2019, Ramalingam C wrote: > On 2019-08-20 at 14:14:03 +0530, Winkler, Tomas wrote: >> >> >> > >> > For the reusability of the enum transcoder and enum pipe in other driver >> > modules (like mei_hdcp), enum port definition is moved from I915 local >> > header >> >

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: enum transcoder and pipe are moved into i915_drm.h

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 15:30:53 +0300, Jani Nikula wrote: > On Tue, 20 Aug 2019, Ramalingam C wrote: > > On 2019-08-20 at 14:14:03 +0530, Winkler, Tomas wrote: > >> > >> > >> > > >> > For the reusability of the enum transcoder and enum pipe in other driver > >> > modules (like mei_hdcp), enum port

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Kahola, Mika
On Tue, 2019-08-20 at 16:03 +0300, Ville Syrjälä wrote: > On Tue, Aug 20, 2019 at 02:06:31PM +0300, Mika Kahola wrote: > > In order to achieve improved power savings we can tune down CD > > clock frequency > > for sub 4k resolutions. The maximum CD clock frequency for sub 4k > > resolutions is set

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Sanitize PHY state during display core uninit

2019-08-20 Thread Imre Deak
On Sat, Aug 17, 2019 at 02:58:45AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Sanitize PHY state during display core uninit > URL : https://patchwork.freedesktop.org/series/65298/ > State : success Thanks for the review, pushed to -dinq. > > == Summary == > > CI

[Intel-gfx] [PATCH 4/5] drm/i915/hdmi: stylistic cleanup around hdcp2_msg_data

2019-08-20 Thread Jani Nikula
Split struct declaration and array definition. Fix indents and whitespace. No functional changes. Cc: Ramalingam C Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hdmi.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git

[Intel-gfx] [PATCH 1/5] drm/i915/dp: stylistic cleanup around hdcp2_msg_data

2019-08-20 Thread Jani Nikula
Split struct declaration and array definition. Fix indents and whitespace. No functional changes. Cc: Ramalingam C Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 70 + 1 file changed, 36 insertions(+), 34 deletions(-) diff --git

[Intel-gfx] [PATCH 2/5] drm/i915/dp: avoid shadowing variables

2019-08-20 Thread Jani Nikula
Everything seems to be all right, but shadowing is to be avoided. Cc: Ramalingam C Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c

[Intel-gfx] [PATCH 3/5] drm/i915/dp: make hdcp2_dp_msg_data const

2019-08-20 Thread Jani Nikula
It's static const data, make it so. Cc: Ramalingam C Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[Intel-gfx] [PATCH 5/5] drm/i915/hdmi: make hdcp2_msg_data const

2019-08-20 Thread Jani Nikula
It's static const data, make it so. Cc: Ramalingam C Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index

Re: [Intel-gfx] [PATCH 1/3] dma_resv: prime lockdep annotations

2019-08-20 Thread Chris Wilson
Quoting Daniel Vetter (2019-08-20 15:53:34) > Full audit of everyone: > > - i915, radeon, amdgpu should be clean per their maintainers. > > - vram helpers should be fine, they don't do command submission, so > really no business holding struct_mutex while doing copy_*_user. But > I haven't

[Intel-gfx] ✗ Fi.CI.BAT: failure for Tiger Lake batch 3 (rev3)

2019-08-20 Thread Patchwork
== Series Details == Series: Tiger Lake batch 3 (rev3) URL : https://patchwork.freedesktop.org/series/65290/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6743 -> Patchwork_14094 Summary --- **FAILURE** Serious

[Intel-gfx] [PATCHv2 2/2] i915: do not leak module ref counter

2019-08-20 Thread Sergey Senozhatsky
Always put_filesystem() in i915_gemfs_init(). Signed-off-by: Sergey Senozhatsky --- - v2: rebased (i915 does not remount gemfs anymore) drivers/gpu/drm/i915/gem/i915_gemfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c

[Intel-gfx] [PATCHv2 1/2] fs: export put_filesystem()

2019-08-20 Thread Sergey Senozhatsky
Modules, e.g. i915, can use exported get_fs_type(), but are unable to put_filesystem(). Export it and let modules to decrement file systems' reference counters. Signed-off-by: Sergey Senozhatsky --- fs/filesystems.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/filesystems.c

Re: [Intel-gfx] [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API

2019-08-20 Thread Hans Verkuil
On 8/19/19 4:48 PM, Neil Armstrong wrote: > Hi Dariusz, Hans, > > I can apply the dw-hdmi patches if necessary. I'd appreciate it if you can do that. Thanks, Hans > > Neil > > On 19/08/2019 11:38, Hans Verkuil wrote: >> Hi all, >> >> The patches in this series can be applied

[Intel-gfx] [PATCH] drm/i915: Serialise the fill BLT with the vma pinning

2019-08-20 Thread Chris Wilson
Make sure that we wait for the vma to be pinned prior to telling the GPU to fill the pages through that vma. However, since our async operations fight over obj->resv->excl_fence we must manually order them. This makes it much more fragile, and gives an outside observer the chance to see the

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-08-20 Thread Koenig, Christian
Am 20.08.19 um 16:53 schrieb Daniel Vetter: > With nouveau fixed all ttm-using drives have the correct nesting of > mmap_sem vs dma_resv, and we can just lock the buffer. > > Assuming I didn't screw up anything with my audit of course. > > Signed-off-by: Daniel Vetter > Cc: Christian Koenig >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: Gen12 csb support (rev3)

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Gen12 csb support (rev3) URL : https://patchwork.freedesktop.org/series/62890/ State : failure == Summary == Applying: drm/i915/tgl: Gen12 csb support Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/gt/intel_lrc.c Falling

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Ville Syrjälä
On Tue, Aug 20, 2019 at 02:06:31PM +0300, Mika Kahola wrote: > In order to achieve improved power savings we can tune down CD clock frequency > for sub 4k resolutions. The maximum CD clock frequency for sub 4k > resolutions is set to 172.8 MHz. > > Signed-off-by: Mika Kahola > --- >

Re: [Intel-gfx] [PATCH 4/5] drm/i915/hdmi: stylistic cleanup around hdcp2_msg_data

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 16:40:18 +0300, Jani Nikula wrote: > Split struct declaration and array definition. Fix indents and > whitespace. No functional changes. > > Cc: Ramalingam C > Signed-off-by: Jani Nikula Reviewed-by: Ramalingam C -Ram > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 39

Re: [Intel-gfx] [PATCH 3/5] drm/i915/dp: make hdcp2_dp_msg_data const

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 16:40:17 +0300, Jani Nikula wrote: > It's static const data, make it so. > > Cc: Ramalingam C > Signed-off-by: Jani Nikula Reviewed-by: Ramalingam C -Ram > --- > drivers/gpu/drm/i915/display/intel_dp.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > >

[Intel-gfx] [PATCH 1/6] drm/i915/gtt: Relax pd_used assertion

2019-08-20 Thread Chris Wilson
The current assertion tries to make sure that we do not over count the number of used PDE inside a page directory -- that is with an array of 512 pde, we do not expect more than 512 elements used! However, our assertion has to take into account that as we pin an element into the page directory,

[Intel-gfx] [PATCH 3/6] drm/i915: Track ggtt fence reservations under its own mutex

2019-08-20 Thread Chris Wilson
We can reduce the locking for fence registers from the dev->struct_mutex to a local mutex. We could introduce a mutex for the sole purpose of tracking the fence acquisition, except there is a little bit of overlap with the fault tracking, so use the i915_ggtt.mutex as it covers both.

[Intel-gfx] [PATCH 2/6] drm/i915: Replace PIN_NONFAULT with calls to PIN_NOEVICT

2019-08-20 Thread Chris Wilson
When under severe stress for GTT mappable space, the LRU eviction model falls off a cliff. We spend all our time scanning the much large non-mappable vma searching for something within the mappable zone we can evict. Turn this on its head by only using the full vma if it is already pinned in the

[Intel-gfx] [PATCH 6/6] drm/i915: Replace i915_vma_put_fence()

2019-08-20 Thread Chris Wilson
Avoid calling i915_vma_put_fence() by using our alternate paths that bind a secondary vma avoiding the original fenced vma. For the few instances where we need to release the fence (i.e. on binding when the GGTT range becomes invalid), replace the put_fence with a revoke_fence. Signed-off-by:

[Intel-gfx] [PATCH 5/6] drm/i915: Pull obj->userfault tracking under the ggtt->mutex

2019-08-20 Thread Chris Wilson
Since we want to revoke the ggtt vma from only under the ggtt->mutex, we need to move protection of the userfault tracking from the struct_mutex to the ggtt->mutex. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 10 +++--- drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 4/6] drm/i915: Only track bound elements of the GTT

2019-08-20 Thread Chris Wilson
The premise here is to simply avoiding having to acquire the vm->mutex inside vma create/destroy to update the vm->unbound_lists, to avoid some nasty lock recursions later. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c| 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-08-20 Thread Koenig, Christian
Am 20.08.19 um 17:21 schrieb Daniel Vetter: > On Tue, Aug 20, 2019 at 5:16 PM Koenig, Christian > wrote: >> Am 20.08.19 um 16:53 schrieb Daniel Vetter: >>> With nouveau fixed all ttm-using drives have the correct nesting of >>> mmap_sem vs dma_resv, and we can just lock the buffer. >>> >>>

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Lower cdclk for sub 4k resolutions URL : https://patchwork.freedesktop.org/series/65475/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0fb206f34d2d drm/i915/tgl: Lower cdclk for sub 4k resolutions -:6: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Lower cdclk for sub 4k resolutions URL : https://patchwork.freedesktop.org/series/65475/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/tgl: Lower cdclk for sub 4k resolutions

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Shankar, Uma
>-Original Message- >From: Kahola, Mika >Sent: Tuesday, August 20, 2019 4:37 PM >To: intel-gfx@lists.freedesktop.org >Cc: Shankar, Uma ; Kahola, Mika > >Subject: [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions > >In order to achieve improved power savings we can tune down CD

[Intel-gfx] [PATCH] drm/i915: Serialise the fill BLT with the vma pinning

2019-08-20 Thread Chris Wilson
Make sure that we wait for the vma to be pinned prior to telling the GPU to fill the pages through that vma. However, since our async operations fight over obj->resv->excl_fence we must manually order them. This makes it much more fragile, and gives an outside observer the chance to see the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uc: define GuC and HuC FWs for EHL

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915/uc: define GuC and HuC FWs for EHL URL : https://patchwork.freedesktop.org/series/65444/ State : success == Summary == CI Bug Log - changes from CI_DRM_6741_full -> Patchwork_14090_full Summary ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915/dp: stylistic cleanup around hdcp2_msg_data

2019-08-20 Thread Ville Syrjälä
On Tue, Aug 20, 2019 at 04:40:15PM +0300, Jani Nikula wrote: > Split struct declaration and array definition. Fix indents and > whitespace. No functional changes. > > Cc: Ramalingam C > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp.c | 70 + >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/dp: stylistic cleanup around hdcp2_msg_data

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 16:40:15 +0300, Jani Nikula wrote: > Split struct declaration and array definition. Fix indents and > whitespace. No functional changes. > Reviewed-by: Ramalingam C -Ram > Cc: Ramalingam C > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp.c | 70

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Switch obj->mm.lock lockdep annotations on its head URL : https://patchwork.freedesktop.org/series/65467/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743 -> Patchwork_14096

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Relax pd_used assertion

2019-08-20 Thread Chris Wilson
Quoting Mika Kuoppala (2019-08-20 15:25:50) > Chris Wilson writes: > > > The current assertion tries to make sure that we do not over count the > > number of used PDE inside a page directory -- that is with an array of > > 512 pde, we do not expect more than 512 elements used! However, our > >

Re: [Intel-gfx] [PATCH 02/15] drm/i915/dsb: DSB context creation.

2019-08-20 Thread Jani Nikula
On Wed, 14 Aug 2019, Animesh Manna wrote: > Yes, have missed and local build also could not catch as maybe object > files were present in that directory. > Fixed the issue and latest trybot link - > https://patchwork.freedesktop.org/series/65161/ I don't have the patches. I'm not subscribed to

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Shankar, Uma
>> >-Original Message- >> >From: Kahola, Mika >> >Sent: Tuesday, August 20, 2019 4:37 PM >> >To: intel-gfx@lists.freedesktop.org >> >Cc: Shankar, Uma ; Kahola, Mika >> > >> >Subject: [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions >> > >> >In order to achieve improved power

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Introduce intel_reg_types.h

2019-08-20 Thread Michal Wajdeczko
On Tue, 20 Aug 2019 04:01:47 +0200, Daniele Ceraolo Spurio wrote: diff --git a/drivers/gpu/drm/i915/intel_reg_types.h b/drivers/gpu/drm/i915/intel_reg_types.h new file mode 100644 index ..87bce80dd5ed --- /dev/null +++ b/drivers/gpu/drm/i915/intel_reg_types.h + +typedef

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-08-20 Thread Daniel Vetter
On Tue, Aug 20, 2019 at 5:34 PM Koenig, Christian wrote: > > Am 20.08.19 um 17:21 schrieb Daniel Vetter: > > On Tue, Aug 20, 2019 at 5:16 PM Koenig, Christian > > wrote: > >> Am 20.08.19 um 16:53 schrieb Daniel Vetter: > >>> With nouveau fixed all ttm-using drives have the correct nesting of >

[Intel-gfx] ✓ Fi.CI.BAT: success for mmu notifier debug annotations/checks

2019-08-20 Thread Patchwork
== Series Details == Series: mmu notifier debug annotations/checks URL : https://patchwork.freedesktop.org/series/65465/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743 -> Patchwork_14095 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Introduce intel_reg_types.h

2019-08-20 Thread Chris Wilson
Quoting Chris Wilson (2019-08-20 12:16:36) > Quoting Daniele Ceraolo Spurio (2019-08-20 03:01:47) > > With the introduction of display uncore, we want to categorize registers > > between display and non-display. To help us getting it right, it will > > be useful to move the display registers to a

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Relax pd_used assertion

2019-08-20 Thread Mika Kuoppala
Chris Wilson writes: > The current assertion tries to make sure that we do not over count the > number of used PDE inside a page directory -- that is with an array of > 512 pde, we do not expect more than 512 elements used! However, our > assertion has to take into account that as we pin an

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-08-20 Thread Daniel Vetter
On Tue, Aug 20, 2019 at 5:16 PM Koenig, Christian wrote: > > Am 20.08.19 um 16:53 schrieb Daniel Vetter: > > With nouveau fixed all ttm-using drives have the correct nesting of > > mmap_sem vs dma_resv, and we can just lock the buffer. > > > > Assuming I didn't screw up anything with my audit of

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Dynamically allocate s0ix struct for VLV URL : https://patchwork.freedesktop.org/series/65445/ State : success == Summary == CI Bug Log - changes from CI_DRM_6741_full -> Patchwork_14091_full

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Ville Syrjälä
On Tue, Aug 20, 2019 at 01:22:00PM +, Kahola, Mika wrote: > On Tue, 2019-08-20 at 16:03 +0300, Ville Syrjälä wrote: > > On Tue, Aug 20, 2019 at 02:06:31PM +0300, Mika Kahola wrote: > > > In order to achieve improved power savings we can tune down CD > > > clock frequency > > > for sub 4k

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Serialize insertion into the file->mm.request_list

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: Serialize insertion into the file->mm.request_list URL : https://patchwork.freedesktop.org/series/65468/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743 -> Patchwork_14097 Summary

Re: [Intel-gfx] [PATCH 4/4] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-20 Thread Daniel Vetter
On Tue, Aug 20, 2019 at 10:34:18AM -0300, Jason Gunthorpe wrote: > On Tue, Aug 20, 2019 at 10:19:02AM +0200, Daniel Vetter wrote: > > We need to make sure implementations don't cheat and don't have a > > possible schedule/blocking point deeply burried where review can't > > catch it. > > > > I'm

[Intel-gfx] ✓ Fi.CI.BAT: success for Tiger Lake batch 3 (rev3)

2019-08-20 Thread Patchwork
== Series Details == Series: Tiger Lake batch 3 (rev3) URL : https://patchwork.freedesktop.org/series/65290/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743 -> Patchwork_14094 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 2/5] drm/i915/dp: avoid shadowing variables

2019-08-20 Thread Ramalingam C
On 2019-08-20 at 16:40:16 +0300, Jani Nikula wrote: > Everything seems to be all right, but shadowing is to be avoided. > > Cc: Ramalingam C > Signed-off-by: Jani Nikula Reviewed-by: Ramalingam C -Ram > --- > drivers/gpu/drm/i915/display/intel_dp.c | 8 > 1 file changed, 4

[Intel-gfx] [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-08-20 Thread Daniel Vetter
With nouveau fixed all ttm-using drives have the correct nesting of mmap_sem vs dma_resv, and we can just lock the buffer. Assuming I didn't screw up anything with my audit of course. Signed-off-by: Daniel Vetter Cc: Christian Koenig Cc: Huang Rui Cc: Gerd Hoffmann Cc: "VMware Graphics" Cc:

[Intel-gfx] [PATCH 0/3] RFC/T: dma_resv vs. mmap_sem

2019-08-20 Thread Daniel Vetter
Hi all, As part of all the recent discussions around ttm and dma_resv I started looking into this. The goal (at least somewhen in the near future) is to have it all documented and the cross-driver semantics locked down as much as possible. One of the biggest issues there is how the dma_resv

[Intel-gfx] [PATCH 1/3] dma_resv: prime lockdep annotations

2019-08-20 Thread Daniel Vetter
Full audit of everyone: - i915, radeon, amdgpu should be clean per their maintainers. - vram helpers should be fine, they don't do command submission, so really no business holding struct_mutex while doing copy_*_user. But I haven't checked them all. - panfrost seems to dma_resv_lock only

[Intel-gfx] [PATCH 2/3] drm/nouveau: slowpath for pushbuf ioctl

2019-08-20 Thread Daniel Vetter
We can't copy_*_user while holding reservations, that will (soon even for nouveau) lead to deadlocks. And it breaks the cross-driver contract around dma_resv. Fix this by adding a slowpath for when we need relocations, and by pushing the writeback of the new presumed offsets to the very end.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Be defensive when starting vma activity

2019-08-20 Thread Patchwork
== Series Details == Series: drm/i915: Be defensive when starting vma activity URL : https://patchwork.freedesktop.org/series/65471/ State : success == Summary == CI Bug Log - changes from CI_DRM_6743 -> Patchwork_14098 Summary ---

[Intel-gfx] [PATCH] drm/i915: Do not create a new max_bpc prop for MST connectors

2019-08-20 Thread Ville Syrjala
From: Ville Syrjälä We're not allowed to create new properties after device registration so for MST connectors we need to either create the max_bpc property earlier, or we reuse one we already have. Let's do the latter apporach since the corresponding SST connector already has the prop and its

<    1   2