[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Make sure the gen6 ppgtt is bound before first use (rev2)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Make sure the gen6 ppgtt is bound before first use (rev2) URL : https://patchwork.freedesktop.org/series/66551/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2989952e76ad drm/i915/gtt: Make sure the gen6 ppgtt is bound before first

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gtt: Make sure the gen6 ppgtt is bound before first use (rev2)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Make sure the gen6 ppgtt is bound before first use (rev2) URL : https://patchwork.freedesktop.org/series/66551/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6874 -> Patchwork_14367

Re: [Intel-gfx] [PATCH 0/6] Remaining patches to enable Transcoder Port Sync for tiled displays

2019-09-12 Thread Jani Nikula
On Wed, 11 Sep 2019, Manasi Navare wrote: > On Wed, Sep 11, 2019 at 12:08:00PM +0300, Jani Nikula wrote: >> On Tue, 10 Sep 2019, Manasi Navare wrote: >> > On Tue, Sep 10, 2019 at 11:07:30AM -0700, Manasi Navare wrote: >> >> On Tue, Sep 10, 2019 at 12:29:19PM +0300, Jani Nikula wrote: >> >> > On

[Intel-gfx] ✓ Fi.CI.BAT: success for DSB enablement. (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: DSB enablement. (rev6) URL : https://patchwork.freedesktop.org/series/63013/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874 -> Patchwork_14369 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DSB enablement. (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: DSB enablement. (rev6) URL : https://patchwork.freedesktop.org/series/63013/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/dsb: feature flag added for display state buffer. Okay!

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DSB enablement. (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: DSB enablement. (rev6) URL : https://patchwork.freedesktop.org/series/63013/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9bb8863660ce drm/i915/dsb: feature flag added for display state buffer. 5d5acdf62c4f drm/i915/dsb: DSB context creation.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable FBC if BIOS reserved memory (stolen) is unavailable

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Disable FBC if BIOS reserved memory (stolen) is unavailable URL : https://patchwork.freedesktop.org/series/66549/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874 -> Patchwork_14366

Re: [Intel-gfx] [PATCH v6 3/7] drm: Add DisplayPort colorspace property

2019-09-12 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Gwan-gyeong Mun > Sent: torstai 12. syyskuuta 2019 6.25 > To: intel-gfx@lists.freedesktop.org > Cc: imir...@alum.mit.edu; dri-de...@lists.freedesktop.org > Subject: [Intel-gfx]

[Intel-gfx] [PATCH 2/2] drm/i915/execlists: Ensure the context is reloaded after a GPU reset

2019-09-12 Thread Chris Wilson
After we manipulate the context to allow replay after a GPU reset, force that context to be reloaded. This should be a layer of paranoia, for if the GPU was reset, the context will no longer be resident! Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 1

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Chris Wilson
After a GPU reset, we need to drain all the CS events so that we have an accurate picture of the execlists state at the time of the reset. Be paranoid and force a read of the CSB write pointer from memory. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c |

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence URL : https://patchwork.freedesktop.org/series/66556/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5fde471c1784 drm/i915/tgl: Add missing ddi clock

Re: [Intel-gfx] [PATCH v7 04/11] drm: revocation check at drm subsystem

2019-09-12 Thread Ramalingam C
On 2019-09-12 at 00:15:32 +, Harry Wentland wrote: > Adding a couple AMD guys. > > I know this is already merged but I have a few questions after some > internal discussions. > > On 2019-05-07 12:27 p.m., Ramalingam C wrote: > > On every hdcp revocation check request SRM is read from fw file

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Update ICL DMC version to v1.09

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Update ICL DMC version to v1.09 URL : https://patchwork.freedesktop.org/series/66560/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874 -> Patchwork_14368 Summary ---

[Intel-gfx] [PULL] drm-misc-fixes

2019-09-12 Thread Maarten Lankhorst
drm-misc-fixes-2019-09-12: drm-misc-fixes for v5.3 final: - Constify modes whitelist harder. - Fix lima driver gem_wait ioctl. The following changes since commit 424c38a4e32509ae82dc9d7300432295806cb911: drm/selftests: modes: Add more unit tests for the cmdline parser (2019-08-30 10:21:56

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Support for DP HDR outputs (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: Support for DP HDR outputs (rev6) URL : https://patchwork.freedesktop.org/series/65656/ State : warning == Summary == $ dim checkpatch origin/drm-tip eeb0d02345b0 drm/i915/dp: Extend program of VSC Header and DB for Colorimetry Format 24ada68e93e8

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-12 10:20:39) > > On 11/09/2019 17:38, Chris Wilson wrote: > > As we track when we put the GT device to sleep upon idling, we can use > > that callback to sample the current rc6 counters and record the > > timestamp for estimating samples after that point while

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Mika Kuoppala
Chris Wilson writes: > After a GPU reset, we need to drain all the CS events so that we have an > accurate picture of the execlists state at the time of the reset. Be > paranoid and force a read of the CSB write pointer from memory. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder URL : https://patchwork.freedesktop.org/series/66547/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14365_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Fix cdclk bypass freq readout for tgl/bxt/glk (rev2)

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Fix cdclk bypass freq readout for tgl/bxt/glk (rev2) URL : https://patchwork.freedesktop.org/series/66537/ State : success == Summary == CI Bug Log - changes from CI_DRM_6875 -> Patchwork_14374

[Intel-gfx] [PATCH v4] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs that interfere with the new

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset URL : https://patchwork.freedesktop.org/series/66586/ State : warning == Summary == $ dim checkpatch origin/drm-tip 08e4e869b22e drm/i915/execlists: Add a paranoid

Re: [Intel-gfx] [PATCH v6] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
Quoting Chris Wilson (2019-09-12 11:41:31) > + spin_lock_irqsave(>lock, flags); > + if (intel_gt_pm_get_if_awake(gt)) { > + val = __get_rc6(gt); > + intel_gt_pm_put(gt); As food for thought, what about val = 0; if (intel_gt_pm_get_if_awake(gt)) {

[Intel-gfx] [PATCH v7 1/7] drm/i915/dp: Extend program of VSC Header and DB for Colorimetry Format

2019-09-12 Thread Gwan-gyeong Mun
It refactors and renames a function which handled vsc sdp header and data block setup for supporting colorimetry format. Function intel_dp_setup_vsc_sdp handles vsc sdp header and data block setup for pixel encoding / colorimetry format. In order to use colorspace information of a connector, it

[Intel-gfx] [PATCH v7 0/7] drm/i915/dp: Support for DP HDR outputs

2019-09-12 Thread Gwan-gyeong Mun
Support for HDR10 video was introduced in DisplayPort 1.4. On GLK+ platform, in order to use DisplayPort HDR10, we need to support BT.2020 colorimetry and HDR Static metadata. It implements the CTA-861-G standard for transport of static HDR metadata. It enables writing of HDR metadata infoframe

[Intel-gfx] [PATCH v7 3/7] drm: Add DisplayPort colorspace property

2019-09-12 Thread Gwan-gyeong Mun
Because between HDMI and DP have different colorspaces, it renames drm_mode_create_colorspace_property() function to drm_mode_create_hdmi_colorspace_property() function for HDMI connector. And it adds drm_mode_create_dp_colorspace_property() function for creating of DP colorspace property. In

[Intel-gfx] [PATCH v7 2/7] drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA

2019-09-12 Thread Gwan-gyeong Mun
When BT.2020 Colorimetry output is used for DP, we should program BT.2020 Colorimetry to MSA and VSC SDP. It adds output_colorspace to intel_crtc_state struct as a place holder of pipe's output colorspace. In order to distinguish needed colorimetry for VSC SDP, it adds intel_dp_needs_vsc_sdp

[Intel-gfx] [PATCH v7 6/7] drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata

2019-09-12 Thread Gwan-gyeong Mun
Function intel_dp_setup_hdr_metadata_infoframe_sdp handles Infoframe SDP header and data block setup for HDR Static Metadata. It enables writing of HDR metadata infoframe SDP to panel. Support for HDR video was introduced in DisplayPort 1.4. It implements the CTA-861-G standard for transport of

[Intel-gfx] [PATCH v7 7/7] drm/i915/dp: Attach HDR metadata property to DP connector

2019-09-12 Thread Gwan-gyeong Mun
It attaches HDR metadata property to DP connector on GLK+. It enables HDR metadata infoframe sdp on GLK+ to be used to send HDR metadata to DP sink. v2: Minor style fix Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_dp.c | 5 + 1 file

[Intel-gfx] [PATCH v7 4/7] drm/i915/dp: Attach colorspace property

2019-09-12 Thread Gwan-gyeong Mun
It attaches the colorspace connector property to a DisplayPort connector. Based on colorspace change, modeset will be triggered to switch to a new colorspace. Based on colorspace property value create a VSC SDP packet with appropriate colorspace. This would help to enable wider color gamut like

[Intel-gfx] [PATCH v7 5/7] drm/i915: Add new GMP register size for GEN11

2019-09-12 Thread Gwan-gyeong Mun
According to Bspec, GEN11 and prior GEN11 have different register size for HDR Metadata Infoframe SDP packet. It adds new VIDEO_DIP_GMP_DATA_SIZE for GEN11. And it makes handle different register size for HDMI_PACKET_TYPE_GAMUT_METADATA on hsw_dip_data_size() for each GEN platforms. It addresses

[Intel-gfx] ✗ Fi.CI.IGT: failure for DSB enablement. (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: DSB enablement. (rev6) URL : https://patchwork.freedesktop.org/series/63013/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14369_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-09-12 08:51:38) >> Chris Wilson writes: >> >> > After a GPU reset, we need to drain all the CS events so that we have an >> > accurate picture of the execlists state at the time of the reset. Be >> > paranoid and force a read of the CSB write

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Fix cdclk bypass freq readout for tgl/bxt/glk (rev2)

2019-09-12 Thread Chris Wilson
Quoting Patchwork (2019-09-12 10:36:49) > == Series Details == > > Series: series starting with [1/4] drm/i915: Fix cdclk bypass freq readout > for tgl/bxt/glk (rev2) > URL : https://patchwork.freedesktop.org/series/66537/ > State : success > > == Summary == > > CI Bug Log - changes from

Re: [Intel-gfx] 5.3-rc3: Frozen graphics with kcompactd migrating i915 pages

2019-09-12 Thread Linus Torvalds
On Thu, Sep 12, 2019 at 12:51 PM Martin Wilck wrote: > > Is there an alternative to reverting aa56a292ce62 ("drm/i915/userptr: > Acquire the page lock around set_page_dirty()")? And if we do, what > would be the consequences? Would other patches need to be reverted, > too? Looking at that

[Intel-gfx] ✓ Fi.CI.BAT: success for Mdev: support mutiple kinds of devices

2019-09-12 Thread Patchwork
== Series Details == Series: Mdev: support mutiple kinds of devices URL : https://patchwork.freedesktop.org/series/66588/ State : success == Summary == CI Bug Log - changes from CI_DRM_6877 -> Patchwork_14376 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence URL : https://patchwork.freedesktop.org/series/66556/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874 -> Patchwork_14370

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset URL : https://patchwork.freedesktop.org/series/66579/ State : failure == Summary == Applying: drm/i915/execlists: Add a paranoid flush of the CSB pointers upon

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: convert device info num_pipes to pipe_mask (rev2)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915: convert device info num_pipes to pipe_mask (rev2) URL : https://patchwork.freedesktop.org/series/66567/ State : success == Summary == CI Bug Log - changes from CI_DRM_6875 -> Patchwork_14372 Summary

[Intel-gfx] [PATCH 2/2] drm/i915/execlists: Ensure the context is reloaded after a GPU reset

2019-09-12 Thread Chris Wilson
After we manipulate the context to allow replay after a GPU reset, force that context to be reloaded. This should be a layer of paranoia, for if the GPU was reset, the context will no longer be resident! Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 1

Re: [Intel-gfx] [RFC PATCH 2/2] mdev: introduce device specific ops

2019-09-12 Thread Michael S. Tsirkin
On Thu, Sep 12, 2019 at 05:40:12PM +0800, Jason Wang wrote: > Currently, except for the crate and remove. The rest fields of better: Currently, except for create and remove, the rest of the field in ... > mdev_parent_ops is just designed for vfio-mdev driver and may not help > for kernel mdev

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-12 10:55:00) > > On 12/09/2019 10:39, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-09-12 10:20:39) > >> Don't we end up doing the irqsave spinlock needlessly when !CONFIG_PM? > > > > No, the intent is to serialise with i915_pmu_gt_parked and > >

Re: [Intel-gfx] [PATCH v4] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
Quoting Chris Wilson (2019-09-12 11:13:39) > +#if IS_ENABLED(CONFIG_PM) > + > +static inline s64 ktime_since(const ktime_t kt) > +{ > + return ktime_to_ns(ktime_sub(ktime_get(), kt)); > +} > + > +void i915_pmu_gt_parked(struct drm_i915_private *i915) > +{ > + struct i915_pmu *pmu =

Re: [Intel-gfx] [PATCH] drm/i915: Disable FBC if BIOS reserved memory (stolen) is unavailable

2019-09-12 Thread Ville Syrjälä
On Wed, Sep 11, 2019 at 06:59:26PM +0100, Chris Wilson wrote: > The FBC requires a couple of contiguous buffers, which we allocate from > stolen memory. If stolen memory is unavailable, we cannot allocate those > buffers and so cannot support FBC. Mark it so. > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH] drm/i915: Disable FBC if BIOS reserved memory (stolen) is unavailable

2019-09-12 Thread Chris Wilson
Quoting Ville Syrjälä (2019-09-12 11:30:14) > On Wed, Sep 11, 2019 at 06:59:26PM +0100, Chris Wilson wrote: > > The FBC requires a couple of contiguous buffers, which we allocate from > > stolen memory. If stolen memory is unavailable, we cannot allocate those > > buffers and so cannot support

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Update ICL DMC version to v1.09

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Update ICL DMC version to v1.09 URL : https://patchwork.freedesktop.org/series/66560/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14368_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Mdev: support mutiple kinds of devices

2019-09-12 Thread Patchwork
== Series Details == Series: Mdev: support mutiple kinds of devices URL : https://patchwork.freedesktop.org/series/66588/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6368bc7c0c50 mdev: device id support 1029a6c22da1 mdev: introduce device specific ops -:303:

Re: 5.3-rc3: Frozen graphics with kcompactd migrating i915 pages

2019-09-12 Thread l...@kraav.com
On Thu, Sep 12, 2019 at 11:23:09AM +, Martin Wilck wrote: > > There's a considerable risk that many users will start seeing this > regression when 5.3 is released. I am not aware of a workaround. > > Is there an alternative to reverting aa56a292ce62 ("drm/i915/userptr: > Acquire the page

Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Ensure the context is reloaded after a GPU reset

2019-09-12 Thread Chris Wilson
Quoting Mika Kuoppala (2019-09-12 12:53:01) > Chris Wilson writes: > > > After we manipulate the context to allow replay after a GPU reset, force > > that context to be reloaded. This should be a layer of paranoia, for if > > the GPU was reset, the context will no longer be resident! > > > >

Re: [Intel-gfx] [PATCH v6 01/10] drm/i915/dsb: feature flag added for display state buffer.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 12:41 AM, Animesh Manna wrote: Display State Buffer(DSB) is a new hardware capability, introduced in GEN12 display. DSB allows a driver to batch-program display HW registers. Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Shashank Sharma Signed-off-by: Animesh Manna ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Support for DP HDR outputs (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: Support for DP HDR outputs (rev6) URL : https://patchwork.freedesktop.org/series/65656/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874 -> Patchwork_14371 Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Chris Wilson
Quoting Mika Kuoppala (2019-09-12 09:27:56) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2019-09-12 08:51:38) > >> Chris Wilson writes: > >> > >> > After a GPU reset, we need to drain all the CS events so that we have an > >> > accurate picture of the execlists state at the time of the

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Tvrtko Ursulin
On 11/09/2019 17:38, Chris Wilson wrote: As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs

[Intel-gfx] [PATCH i-g-t] benchmarks/gem_wsim: Cleanup register access on exit

2019-09-12 Thread Chris Wilson
Drop the forcewake before libigt tries to wait on it. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 47 +++ 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c index

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Tvrtko Ursulin
On 11/09/2019 17:38, Chris Wilson wrote: As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs

[Intel-gfx] [PATCH v5] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs that interfere with the new

[Intel-gfx] [PATCH v6] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs that interfere with the new

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Use GT parked for estimating RC6 while asleep (rev3)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use GT parked for estimating RC6 while asleep (rev3) URL : https://patchwork.freedesktop.org/series/56583/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14364_full

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Chris Wilson
After a GPU reset, we need to drain all the CS events so that we have an accurate picture of the execlists state at the time of the reset. Be paranoid and force a read of the CSB write pointer from memory. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala ---

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Tvrtko Ursulin
On 12/09/2019 10:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-12 10:20:39) On 11/09/2019 17:38, Chris Wilson wrote: As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating

Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Ensure the context is reloaded after a GPU reset

2019-09-12 Thread Mika Kuoppala
Chris Wilson writes: > After we manipulate the context to allow replay after a GPU reset, force > that context to be reloaded. This should be a layer of paranoia, for if > the GPU was reset, the context will no longer be resident! > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Chris Wilson
Quoting Mika Kuoppala (2019-09-12 08:51:38) > Chris Wilson writes: > > > After a GPU reset, we need to drain all the CS events so that we have an > > accurate picture of the execlists state at the time of the reset. Be > > paranoid and force a read of the CSB write pointer from memory. > > > >

[Intel-gfx] [RFC PATCH 2/2] mdev: introduce device specific ops

2019-09-12 Thread Jason Wang
Currently, except for the crate and remove. The rest fields of mdev_parent_ops is just designed for vfio-mdev driver and may not help for kernel mdev driver. So follow the device id support by previous patch, this patch introduces device specific ops which points to device specific ops (e.g vfio

[Intel-gfx] [RFC PATCH 1/2] mdev: device id support

2019-09-12 Thread Jason Wang
Mdev bus only support vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, one example is virtio-mdev[1] driver. This means we need to add device id support in bus match method to pair the mdev device and mdev driver correctly. So

[Intel-gfx] [RFC PATCH 0/2] Mdev: support mutiple kinds of devices

2019-09-12 Thread Jason Wang
Hi all: During the development of virtio-mdev[1]. I find that mdev needs to be extended to support devices other than vfio mdev device. So this series tries to extend the mdev to be able to differ from different devices by: - device id and matching for mdev bus - device speicfic callbacks and

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable FBC if BIOS reserved memory (stolen) is unavailable

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Disable FBC if BIOS reserved memory (stolen) is unavailable URL : https://patchwork.freedesktop.org/series/66549/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14366_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Add a paranoid flush of the CSB pointers upon reset URL : https://patchwork.freedesktop.org/series/66586/ State : success == Summary == CI Bug Log - changes from CI_DRM_6876 -> Patchwork_14375

[Intel-gfx] [PATCH v7] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
As we track when we put the GT device to sleep upon idling, we can use that callback to sample the current rc6 counters and record the timestamp for estimating samples after that point while asleep. v2: Stick to using ktime_t v3: Track user_wakerefs that interfere with the new

Re: [Intel-gfx] [PATCH v7] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

2019-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-12 13:38:47) > > On 12/09/2019 12:32, Chris Wilson wrote: > > + if (val) > > + /* > > + * If we are coming back from being runtime suspended we must > > + * be careful not to report a larger value than returned > > +

[PATCH] Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"

2019-09-12 Thread Chris Wilson
The userptr put_pages can be called from inside try_to_unmap, and so enters with the page lock held on one of the object's backing pages. We cannot take the page lock ourselves for fear of recursion. Reported-by: Lionel Landwerlin Reported-by: Martin Wilck Reported-by: Leo Kraav Fixes:

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Get the correct wakeref for reading HOTPLUG_EN et al.

2019-09-12 Thread Chris Wilson
Quoting Arkadiusz Hiler (2019-09-12 13:54:18) > Without it we get: > Unclaimed read from register 0x1e1110 > WARNING: CPU: 2 PID: 1029 at drivers/gpu/drm/i915/intel_uncore.c:1101 > __unclaimed_reg_debug+0x40/0x50 [i915] > Call Trace: > fwtable_read32+0x233/0x300 [i915] >

Re: [Intel-gfx] [PATCH v3 00/37] Introduce memory region concept (including device local memory)

2019-09-12 Thread Joonas Lahtinen
Quoting Dave Airlie (2019-08-13 22:20:52) > On Sat, 10 Aug 2019 at 08:26, Matthew Auld wrote: > > > > In preparation for upcoming devices with device local memory, introduce the > > concept of different memory regions, and a simple buddy allocator to manage > > them in i915. > > > > One of the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Support for DP HDR outputs (rev6)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: Support for DP HDR outputs (rev6) URL : https://patchwork.freedesktop.org/series/65656/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14371_full Summary

[Intel-gfx] [PATCH] drm/i915/selftests: Keep the engine awake while we keep for preemption

2019-09-12 Thread Chris Wilson
Keep the engine awake to ensure that we don't inject any pm-idle requests. References: https://bugs.freedesktop.org/show_bug.cgi?id=08 Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Skip busyness sampling when and where not needed

2019-09-12 Thread Tvrtko Ursulin
On 11/09/2019 17:50, Patchwork wrote: == Series Details == Series: drm/i915/pmu: Skip busyness sampling when and where not needed URL : https://patchwork.freedesktop.org/series/66541/ State : success == Summary == CI Bug Log - changes from CI_DRM_6872 -> Patchwork_14363

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence

2019-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence URL : https://patchwork.freedesktop.org/series/66556/ State : success == Summary == CI Bug Log - changes from CI_DRM_6874_full -> Patchwork_14370_full

Re: [Intel-gfx] [PATCH v6 02/10] drm/i915/dsb: DSB context creation.

2019-09-12 Thread Jani Nikula
On Thu, 12 Sep 2019, Animesh Manna wrote: > This patch adds a function, which will internally get the gem buffer > for DSB engine. The GEM buffer is from global GTT, and is mapped into > CPU domain, contains the data + opcode to be feed to DSB engine. > > v1: Initial version. > > v2: > - removed

Re: [Intel-gfx] [PATCH v7 04/11] drm: revocation check at drm subsystem

2019-09-12 Thread Harry Wentland
Adding a couple AMD guys. I know this is already merged but I have a few questions after some internal discussions. On 2019-05-07 12:27 p.m., Ramalingam C wrote: > On every hdcp revocation check request SRM is read from fw file > /lib/firmware/display_hdcp_srm.bin > According to section 5 of

Re: [Intel-gfx] [PATCH] Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"

2019-09-12 Thread Tvrtko Ursulin
On 12/09/2019 13:56, Chris Wilson wrote: The userptr put_pages can be called from inside try_to_unmap, and so enters with the page lock held on one of the object's backing pages. We cannot take the page lock ourselves for fear of recursion. Reported-by: Lionel Landwerlin Reported-by: Martin

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915/dsb: single register write function for DSB.

2019-09-12 Thread Jani Nikula
On Thu, 12 Sep 2019, "Sharma, Shashank" wrote: > On 9/12/2019 12:41 AM, Animesh Manna wrote: >> DSB support single register write through opcode 0x1. Generic >> api created which accumulate all single register write in a batch >> buffer and once DSB is triggered, it will program all the registers

Re: [Intel-gfx] [PATCH v6 05/10] drm/i915/dsb: Check DSB engine status.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 12:41 AM, Animesh Manna wrote: As per bspec check for DSB status before programming any of its register. Inline function added to check the dsb status. Cc: Michel Thierry Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Shashank Sharma Signed-off-by: Animesh Manna ---

[Intel-gfx] [PATCH v2] drm/i915/tgl: Disable preemption while being debugged

2019-09-12 Thread Chris Wilson
We see failures where the context continues executing past a preemption event, eventually leading to situations where a request has executed before we have event submitted it to HW! It seems like tgl is ignoring our RING_TAIL updates, but more likely is that there is a missing update required for

Re: [Intel-gfx] [PATCH v2] drm/i915/tgl: Disable preemption while being debugged

2019-09-12 Thread Mika Kuoppala
Chris Wilson writes: > We see failures where the context continues executing past a > preemption event, eventually leading to situations where a request has > executed before we have event submitted it to HW! It seems like tgl is > ignoring our RING_TAIL updates, but more likely is that there is

Re: [Intel-gfx] [PATCH v6 09/10] drm/i915/dsb: Enable DSB for gen12.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 12:41 AM, Animesh Manna wrote: Enabling DSB by setting 1 to has_dsb flag for gen12. Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Shashank Sharma Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Support for DP HDR outputs (rev7)

2019-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: Support for DP HDR outputs (rev7) URL : https://patchwork.freedesktop.org/series/65656/ State : success == Summary == CI Bug Log - changes from CI_DRM_6881 -> Patchwork_14378 Summary ---

Re: 5.3-rc3: Frozen graphics with kcompactd migrating i915 pages

2019-09-12 Thread Martin Wilck
Hi Chris, On Tue, 2019-09-10 at 17:20 +0300, Leho Kraav wrote: > On Fri, Aug 09, 2019 at 01:53:43PM +0100, Chris Wilson wrote: > > Quoting Martin Wilck (2019-08-09 13:41:42) > > > This happened to me today, running kernel 5.3.0-rc3-1.g571863b- > > > default > > > (5.3-rc3 with just a few patches

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915/dsb: single register write function for DSB.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 12:41 AM, Animesh Manna wrote: DSB support single register write through opcode 0x1. Generic api created which accumulate all single register write in a batch buffer and once DSB is triggered, it will program all the registers at the same time. v1: Initial version. v2: Unused

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915/dsb: single register write function for DSB.

2019-09-12 Thread Animesh Manna
On 9/12/2019 6:30 PM, Sharma, Shashank wrote: On 9/12/2019 6:21 PM, Jani Nikula wrote: On Thu, 12 Sep 2019, "Sharma, Shashank" wrote: On 9/12/2019 12:41 AM, Animesh Manna wrote: DSB support single register write through opcode 0x1. Generic api created which accumulate all single register

Re: [Intel-gfx] [PATCH v6 08/10] drm/i915/dsb: Enable gamma lut programming using DSB.

2019-09-12 Thread Jani Nikula
On Thu, 12 Sep 2019, Animesh Manna wrote: > Gamma lut programming can be programmed using DSB > where bulk register programming can be done using indexed > register write which takes number of data and the mmio offset > to be written. > > Currently enabled for 12-bit gamma LUT which is enabled by

Re: [Intel-gfx] [PATCH v6 04/10] drm/i915/dsb: Indexed register write function for DSB.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 12:41 AM, Animesh Manna wrote: DSB can program large set of data through indexed register write (opcode 0x9) in one shot. DSB feature can be used for bulk register programming e.g. gamma lut programming, HDR meta data programming. v1: initial version. v2: simplified code by using

[Intel-gfx] [PATCH] drm/i915/tgl: Disable preemption while being debugged

2019-09-12 Thread Chris Wilson
We see failures where the context continues executing past a preemption event, eventually leading to situations where a request has executed before we have event submitted it to HW! It seems like tgl is ignoring our RING_TAIL updates, but more likely is that there is a missing update required for

[Intel-gfx] [PATCH 2/4] drm/i915/tgl: s/ss/eu fuse reading support

2019-09-12 Thread Mika Kuoppala
From: Daniele Ceraolo Spurio Gen12 has dual-subslices (DSS), which compared to gen11 subslices have some duplicated resources/paths. Although DSS behave similarly to 2 subslices, instead of splitting this and presenting userspace with bits not directly representative of hardware resources,

[Intel-gfx] [PATCH 3/4] drm/i915/tgl: Re-enable rc6

2019-09-12 Thread Mika Kuoppala
We think that we got rc6 problems sorted out. Flip the switch and let CI expose our tendency to naive optimism. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH 1/4] drm/i915/tgl: Introduce gen12 forcewake ranges

2019-09-12 Thread Mika Kuoppala
From: Michel Thierry The media ranges extend beyond what gen11 gives so we can't piggypack on gen11 ranges, even on read side. Introduce a table for gen12 and accessors for it. v2: correctly implement gen12_fwtable_write/read (Daniele) v3: update with ranges from bspec. v4: avoid

[Intel-gfx] [PATCH 4/4] drm/i915/tgl: Disable preemption while being debugged

2019-09-12 Thread Mika Kuoppala
From: Chris Wilson We see failures where the context continues executing past a preemption event, eventually leading to situations where a request has executed before we have event submitted it to HW! It seems like tgl is ignoring our RING_TAIL updates, but more likely is that there is a missing

Re: [Intel-gfx] [PATCH 2/4] drm/i915/tgl: s/ss/eu fuse reading support

2019-09-12 Thread Lionel Landwerlin
On 12/09/2019 16:38, Mika Kuoppala wrote: From: Daniele Ceraolo Spurio Gen12 has dual-subslices (DSS), which compared to gen11 subslices have some duplicated resources/paths. Although DSS behave similarly to 2 subslices, instead of splitting this and presenting userspace with bits not directly

Re: [Intel-gfx] [CI RESEND] drm/i915: convert device info num_pipes to pipe_mask

2019-09-12 Thread Jani Nikula
On Wed, 11 Sep 2019, Jani Nikula wrote: > Replace device info number of pipes with a bit mask of available > pipes. This will prove handy in the future. There's still a bunch of > future work to do to actually allow a non-consecutive mask of pipes, but > it's a start. No functional changes. > >

[Intel-gfx] [PATCH 0/1] Fix i915_interrupt_info debugfs with display off on VLV

2019-09-12 Thread Arkadiusz Hiler
Cover letter to use https://intel-gfx-ci.01.org/test-with.html https://patchwork.freedesktop.org/patch/330337/?series=66602 Test-with: 20190912123320.13131-1-arkadiusz.hi...@intel.com Arkadiusz Hiler (1): drm/i915: Get the correct wakeref for reading HOTPLUG_EN et al.

[Intel-gfx] [PATCH 1/1] drm/i915: Get the correct wakeref for reading HOTPLUG_EN et al.

2019-09-12 Thread Arkadiusz Hiler
Without it we get: Unclaimed read from register 0x1e1110 WARNING: CPU: 2 PID: 1029 at drivers/gpu/drm/i915/intel_uncore.c:1101 __unclaimed_reg_debug+0x40/0x50 [i915] Call Trace: fwtable_read32+0x233/0x300 [i915] i915_interrupt_info+0xa73/0xd60 [i915] seq_read+0xdb/0x3c0

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915/dsb: single register write function for DSB.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 6:21 PM, Jani Nikula wrote: On Thu, 12 Sep 2019, "Sharma, Shashank" wrote: On 9/12/2019 12:41 AM, Animesh Manna wrote: DSB support single register write through opcode 0x1. Generic api created which accumulate all single register write in a batch buffer and once DSB is

Re: [Intel-gfx] [PATCH v6 03/10] drm/i915/dsb: single register write function for DSB.

2019-09-12 Thread Sharma, Shashank
On 9/12/2019 6:37 PM, Animesh Manna wrote: On 9/12/2019 6:30 PM, Sharma, Shashank wrote: On 9/12/2019 6:21 PM, Jani Nikula wrote: On Thu, 12 Sep 2019, "Sharma, Shashank" wrote: On 9/12/2019 12:41 AM, Animesh Manna wrote: DSB support single register write through opcode 0x1. Generic api

  1   2   >