[Intel-gfx] [CI 2/9] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-10-10 Thread Chris Wilson
From: Lionel Landwerlin Reporting this version will help application figure out what level of the support the running kernel provides. v2: Add i915_perf_ioctl_version() (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH] drm/i915/perf: implement active wait for noa configurations

2019-10-10 Thread Chris Wilson
From: Lionel Landwerlin NOA configuration take some amount of time to apply. That amount of time depends on the size of the GT. There is no documented time for this. For example, past experimentations with powergating configuration changes seem to indicate a 60~70us delay. We go with 500us as

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev3)

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev3) URL : https://patchwork.freedesktop.org/series/67874/ State : warning == Summary == $ dim checkpatch origin/drm-tip e3e8e6f3790d drm/i915/perf: Replace global

[Intel-gfx] [PATCH] drm/i915/ehl: Port C's hotplug interrupt is associated with TC1 bits

2019-10-10 Thread Vivek Kasireddy
On some platforms that have the MCC PCH, Port C's hotplug interrupt bits are mapped to TC1 bits. Suggested-by: Matt Roper Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 8 2 files changed, 7 insertions(+),

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp: Remove the unused drm_device to get rid of build warning

2019-10-10 Thread Patchwork
== Series Details == Series: drm/dp: Remove the unused drm_device to get rid of build warning URL : https://patchwork.freedesktop.org/series/67879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7058 -> Patchwork_14760

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev4)

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev4) URL : https://patchwork.freedesktop.org/series/67874/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8bb740107b70 drm/i915/perf: Replace global

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev4)

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev4) URL : https://patchwork.freedesktop.org/series/67874/ State : success == Summary == CI Bug Log - changes from CI_DRM_7058 -> Patchwork_14761

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp: Remove the unused drm_device to get rid of build warning

2019-10-10 Thread Patchwork
== Series Details == Series: drm/dp: Remove the unused drm_device to get rid of build warning URL : https://patchwork.freedesktop.org/series/67879/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/dp: Remove the unused drm_device to get rid of build

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2019-10-10 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_atomic_get_mst_topology_state': drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable 'dev'

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Don't disable interrupts independently of the lock (rev2)

2019-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't disable interrupts independently of the lock (rev2) URL : https://patchwork.freedesktop.org/series/59289/ State : failure == Summary == Applying: drm/i915: Don't disable interrupts independently of the lock error: sha1 information is lacking or

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v7,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync (rev2)

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [v7,1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync (rev2) URL : https://patchwork.freedesktop.org/series/67806/ State : failure == Summary == Applying: drm/i915/display/icl: Save Master

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/display: Handle fused off display correctly

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/display: Handle fused off display correctly URL : https://patchwork.freedesktop.org/series/67872/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7058 -> Patchwork_14757

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev3)

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm (rev3) URL : https://patchwork.freedesktop.org/series/67874/ State : success == Summary == CI Bug Log - changes from CI_DRM_7058 -> Patchwork_14759

[Intel-gfx] [PATCH v8 3/6] drm/i915/display/icl: HW state readout for transcoder port sync config

2019-10-10 Thread Manasi Navare
After the state is committed, we readout the HW registers and compare the HW state with the SW state that we just committed. For Transcdoer port sync, we add master_transcoder and the salves bitmask to the crtc_state, hence we need to read those during the HW state readout to avoid pipe state

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm URL : https://patchwork.freedesktop.org/series/67874/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4aa72c4ef98d drm/i915/perf: Replace global wakeref

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Chris Wilson
Quoting Sebastian Andrzej Siewior (2019-10-10 19:26:10) > On 2019-10-10 19:11:27 [+0100], Chris Wilson wrote: > > > --- a/drivers/gpu/drm/i915/i915_request.c > > > +++ b/drivers/gpu/drm/i915/i915_request.c > > > @@ -251,15 +251,13 @@ static bool i915_request_retire(struct i > > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: DFSM CDCLK LIMIT is only available in BXT

2019-10-10 Thread Souza, Jose
I messed up on this patch, please ignore this one. Will send the fixed version soon. On Thu, 2019-10-10 at 12:32 -0700, José Roberto de Souza wrote: > On GLK those registers are reserved and on another gens it have > another meaning, so renaming it to BXT only. > > BSpec: 7548 > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/perf: Replace global wakeref tracking with engine-pm URL : https://patchwork.freedesktop.org/series/67874/ State : success == Summary == CI Bug Log - changes from CI_DRM_7058 -> Patchwork_14758

[Intel-gfx] [PATCH] drm/i915/perf: Allow dynamic reconfiguration of the OA stream

2019-10-10 Thread Chris Wilson
Introduce a new perf_ioctl command to change the OA configuration of the active stream. This allows the OA stream to be reconfigured between batch buffers, giving greater flexibility in sampling. We inject a request into the OA context to reconfigure the stream asynchronously on the GPU in between

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Chris Wilson
Quoting Sebastian Andrzej Siewior (2019-10-10 17:06:40) > The locks (active.lock and rq->lock) need to be taken with disabled > interrupts. This is done in i915_request_retire() by disabling the > interrupts independently of the locks itself. > While local_irq_disable()+spin_lock() equals

[Intel-gfx] [PATCH 4/4] drm/i915/display: Check if FBC and DMC are fused off

2019-10-10 Thread José Roberto de Souza
Those features could be fused off on GEN9 non-low power and newer GENs. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 1/4] drm/i915/display: Handle fused off display correctly

2019-10-10 Thread José Roberto de Souza
If all pipes are fused off it means that display is disabled, similar like we handle for GEN 7 and 8 right above. On GEN 9 the bit 31 is "Internal Graphics Disable" and on newer GENs it has another function, probably on GEN 9 when bit 31 is set all the 3 pipes disable bit are set, so we can unify

[Intel-gfx] [PATCH 2/4] drm/i915/display: Handle fused off HDCP

2019-10-10 Thread José Roberto de Souza
HDCP could be fused off, so not all GEN9+ platforms will support it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/i915_reg.h | 1 +

[Intel-gfx] [PATCH 3/4] drm/i915/display: DFSM CDCLK LIMIT is only available in BXT

2019-10-10 Thread José Roberto de Souza
On GLK those registers are reserved and on another gens it have another meaning, so renaming it to BXT only. BSpec: 7548 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 +--- drivers/gpu/drm/i915/i915_reg.h| 10 +- 2 files

[Intel-gfx] [PATCH] drm/dp: Remove the unused drm_device to get rid of build warning

2019-10-10 Thread Manasi Navare
We no longer use the connection mutex and hence no need to define drm_device *dev, it causes a unused variable build warning Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check") Cc: Sean Paul Cc: Lyude Paul Cc: Daniel Vetter Signed-off-by: Manasi Navare ---

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Sebastian Andrzej Siewior
On 2019-10-10 19:11:27 [+0100], Chris Wilson wrote: > > --- a/drivers/gpu/drm/i915/i915_request.c > > +++ b/drivers/gpu/drm/i915/i915_request.c > > @@ -251,15 +251,13 @@ static bool i915_request_retire(struct i > > active->retire(active, rq); > > } > > > > -

[Intel-gfx] [CI 8/9] drm/i915/perf: allow holding preemption on filtered ctx

2019-10-10 Thread Chris Wilson
From: Lionel Landwerlin We would like to make use of perf in Vulkan. The Vulkan API is much lower level than OpenGL, with applications directly exposed to the concept of command buffers (pretty much equivalent to our batch buffers). In Vulkan, queries are always limited in scope to a command

Re: [Intel-gfx] [PATCH 7/9] drm/i915/perf: Allow dynamic reconfiguration of the OA stream

2019-10-10 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-10 17:07:11) > Yeah, that's a fine interface actually. One last thought for the interface, should we return the previous config-id? That limits the config-id space to long (min s32) so that we can report the negative error code (or exclude the top 4095 values).

[Intel-gfx] [PATCH] drm/i915/perf: Allow dynamic reconfiguration of the OA stream

2019-10-10 Thread Chris Wilson
Introduce a new perf_ioctl command to change the OA configuration of the active stream. This allows the OA stream to be reconfigured between batch buffers, giving greater flexibility in sampling. We inject a request into the OA context to reconfigure the stream asynchronously on the GPU in between

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Check that registers are preserved between virtual engines

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Check that registers are preserved between virtual engines URL : https://patchwork.freedesktop.org/series/67843/ State : success == Summary == CI Bug Log - changes from CI_DRM_7051_full -> Patchwork_14747_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Check known register values within the context

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Check known register values within the context URL : https://patchwork.freedesktop.org/series/67862/ State : success == Summary == CI Bug Log - changes from CI_DRM_7057 -> Patchwork_14754

Re: [Intel-gfx] [PATCH 7/9] drm/i915/perf: Allow dynamic reconfiguration of the OA stream

2019-10-10 Thread Lionel Landwerlin
On 10/10/2019 22:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-10 17:07:11) Yeah, that's a fine interface actually. One last thought for the interface, should we return the previous config-id? That limits the config-id space to long (min s32) so that we can report the negative

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Check known register values within the context

2019-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Check known register values within the context URL : https://patchwork.freedesktop.org/series/67849/ State : success == Summary == CI Bug Log - changes from CI_DRM_7055_full -> Patchwork_14748_full

[Intel-gfx] [PATCH 3/7] drm/i915: fix port checks for MST support on gen >= 11

2019-10-10 Thread Lucas De Marchi
Both Ice Lake and Elkhart Lake (gen 11) support MST on all external connections except DDI A. Tiger Lake (gen 12) supports on all external connections. Move the check to happen inside intel_dp_mst_encoder_init() and add specific platform checks. Signed-off-by: Lucas De Marchi ---

[Intel-gfx] [PATCH 7/7] drm/dp-mst: fix warning on unused var

2019-10-10 Thread Lucas De Marchi
Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check") Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index

[Intel-gfx] [PATCH 1/7] drm/i915: simplify setting of ddi_io_power_domain

2019-10-10 Thread Lucas De Marchi
Instead of the ever growing switch, just compute the ddi io power domain based on the port number. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_ddi.c | 43 ++-- 1 file changed, 3 insertions(+), 40 deletions(-) diff --git

[Intel-gfx] [PATCH 2/7] drm/i915: cleanup unused returns on DP-MST

2019-10-10 Thread Lucas De Marchi
Those init functions mark their success in the intel_dig_port struct, the return values are not really used. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 +-- drivers/gpu/drm/i915/display/intel_dp_mst.h | 2 +- 2 files changed, 6 insertions(+), 7

[Intel-gfx] [PATCH 0/7] Small fixes before fixing MST

2019-10-10 Thread Lucas De Marchi
I'm trying to understand why TGL is failing on link training when MST is enabled. I couldn't find it yet, but here some trivial patches trying to improve our code. Lucas De Marchi (7): drm/i915: simplify setting of ddi_io_power_domain drm/i915: cleanup unused returns on DP-MST drm/i915: fix

[Intel-gfx] [PATCH 4/7] drm/i915: remove extra new line on pipe_config mismatch

2019-10-10 Thread Lucas De Marchi
The new line is already added by pipe_config_mismatch(), so the callers shouldn't add it. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 22 ++-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[Intel-gfx] [PATCH 5/7] drm/i915: add pipe name to pipe mismatch logs

2019-10-10 Thread Lucas De Marchi
This way it's easier to figure out what didn't match when we have multiple pipes enabled. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 33 +++- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git

[Intel-gfx] [PATCH 6/7] drm/i915: prettify MST debug message

2019-10-10 Thread Lucas De Marchi
s/?/:/ so it's get correctly colored by dmesg. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Small fixes before fixing MST

2019-10-10 Thread Patchwork
== Series Details == Series: Small fixes before fixing MST URL : https://patchwork.freedesktop.org/series/67883/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: simplify setting of ddi_io_power_domain Okay! Commit: drm/i915: cleanup unused

[Intel-gfx] ✓ Fi.CI.BAT: success for Small fixes before fixing MST

2019-10-10 Thread Patchwork
== Series Details == Series: Small fixes before fixing MST URL : https://patchwork.freedesktop.org/series/67883/ State : success == Summary == CI Bug Log - changes from CI_DRM_7060 -> Patchwork_14763 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Honour O_NONBLOCK before throttling execbuf submissions

2019-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Honour O_NONBLOCK before throttling execbuf submissions URL : https://patchwork.freedesktop.org/series/67850/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7056_full -> Patchwork_14749_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Small fixes before fixing MST

2019-10-10 Thread Patchwork
== Series Details == Series: Small fixes before fixing MST URL : https://patchwork.freedesktop.org/series/67883/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0fdcd1fc0932 drm/i915: simplify setting of ddi_io_power_domain e302891b93c2 drm/i915: cleanup unused returns on DP-MST

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Port C's hotplug interrupt is associated with TC1 bits

2019-10-10 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Port C's hotplug interrupt is associated with TC1 bits URL : https://patchwork.freedesktop.org/series/67881/ State : success == Summary == CI Bug Log - changes from CI_DRM_7060 -> Patchwork_14762

<    1   2