[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Suspend MST topology manager before destroy fbdev (rev2)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Suspend MST topology manager before destroy fbdev (rev2) URL : https://patchwork.freedesktop.org/series/70081/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7429 -> Patchwork_15456

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/5] drm/i915/psr: Add bits per pixel limitation (rev2)

2019-11-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/psr: Add bits per pixel limitation (rev2) URL : https://patchwork.freedesktop.org/series/70002/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7426_full -> Patchwork_15445_full

[Intel-gfx] [PATCH] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-27 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Force the state compute phase once to enable PSR (rev2)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Force the state compute phase once to enable PSR (rev2) URL : https://patchwork.freedesktop.org/series/7/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7426_full -> Patchwork_15444_full

[Intel-gfx] [PATCH] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-27 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw URL : https://patchwork.freedesktop.org/series/70089/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7429 -> Patchwork_15457 Summary ---

[Intel-gfx] [PATCH v3 0/2] drm: mmap fixups

2019-11-27 Thread Gerd Hoffmann
Tested on qemu, with bochs (vram helpers) and cirrus (shmem helpers). Cc'ing intel-gfx for CI coverage. v3: better fake-offset handling in drm_gem_prime_mmap() (Rob) Gerd Hoffmann (2): drm: call drm_gem_object_funcs.mmap with fake offset drm: share address space for dma bufs

[Intel-gfx] [PATCH v3 2/2] drm: share address space for dma bufs

2019-11-27 Thread Gerd Hoffmann
Use the shared address space of the drm device (see drm_open() in drm_file.c) for dma-bufs too. That removes a difference betweem drm device mmap vmas and dma-buf mmap vmas and fixes corner cases like dropping ptes (using madvise(DONTNEED) for example) not working properly. Also remove amdgpu

[Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-11-27 Thread Gerd Hoffmann
The fake offset is going to stay, so change the calling convention for drm_gem_object_funcs.mmap to include the fake offset. Update all users accordingly. Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap") and on top then adds the fake

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2019-11-27 Thread Navik, Ankit P
Hi Chris, Thank you for your feedback. > On 26/11/2019 10:52, Charis Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-26 10:51:22) > > You mentioned you did some experiment where you did something on > > context pinning and that it did not work so well. I don't know what > > that was though.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/tgl: Do not program clockgating

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl: Do not program clockgating URL : https://patchwork.freedesktop.org/series/70076/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7426_full -> Patchwork_15450_full Summary

[Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Chris Wilson
We want the bonded request to have the same scheduler properties as its master so that it is placed at the same depth in the queue. For example, consider we have requests A, B and B', where B & B' are a bonded pair to run in parallel on two engines. A -> B \- B' B will run

[Intel-gfx] [PATCH v3 05/13] drm/i915/fbc: Precompute gen9 cfb stride w/a

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Precompute the override cfb stride value so that we can check it when determining if flip nuke can be used or not. The hardware has 13 bits for this, so we can shrink the storage to u16 while at it. v2: Don't explode when crtc_state->enable_fbc lies to us Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for bios: dot not discard address space (rev2)

2019-11-27 Thread Patchwork
== Series Details == Series: bios: dot not discard address space (rev2) URL : https://patchwork.freedesktop.org/series/70075/ State : success == Summary == CI Bug Log - changes from CI_DRM_7430 -> Patchwork_15459 Summary ---

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-27 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

Re: [Intel-gfx] [PATCH 4/8] drm/rockchip: Use drm_gem_fb_create_with_dirty

2019-11-27 Thread Andrzej Pietrasiewicz
Hi Daniel, W dniu 15.11.2019 o 10:21, Daniel Vetter pisze: If rockchip would switch over to the generic fbdev setup we could grabage collect even more of all this code (all of the remaining fb handling code really). Signed-off-by: Daniel Vetter Cc: Sandy Huang Cc: "Heiko Stübner" Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: enable DSC (rev4)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/dsi: enable DSC (rev4) URL : https://patchwork.freedesktop.org/series/69540/ State : success == Summary == CI Bug Log - changes from CI_DRM_7431 -> Patchwork_15462 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915: Copy across scheduler behaviour flags across submit fences URL : https://patchwork.freedesktop.org/series/70107/ State : success == Summary == CI Bug Log - changes from CI_DRM_7431 -> Patchwork_15463

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 11:17, Chris Wilson wrote: We want the bonded request to have the same scheduler properties as its master so that it is placed at the same depth in the queue. For example, consider we have requests A, B and B', where B & B' are a bonded pair to run in parallel on two engines.

[Intel-gfx] ✗ Fi.CI.IGT: failure for Clear Color Support for TGL Render Decompression (rev11)

2019-11-27 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev11) URL : https://patchwork.freedesktop.org/series/66814/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7428_full -> Patchwork_15453_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/fbc: Fix FBC for glk+ (rev3)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Fix FBC for glk+ (rev3) URL : https://patchwork.freedesktop.org/series/70062/ State : failure == Summary == Applying: drm/i915/fbc: Disable fbc by default on all glk+ Applying: drm/i915/fbc: Nuke bogus single pipe fbc1 restriction Applying: drm/i915:

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-27 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] [PATCH] drm/i915: Serialise i915_active_fence_set() with itself

2019-11-27 Thread Chris Wilson
The expected downside to commit 58b4c1a07ada ("drm/i915: Reduce nested prepare_remote_context() to a trylock") was that it would need to return -EAGAIN to userspace in order to resolve potential mutex inversion. Such an unsightly round trip is unnecessary if we could atomically insert a barrier

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-27 14:22:37) > > On 27/11/2019 14:04, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-27 13:46:14) > >> On 27/11/2019 11:17, Chris Wilson wrote: > >>> We want the bonded request to have the same scheduler properties as its > >>> master so that it is placed

Re: [Intel-gfx] [PATCH] drm/i915: Serialise i915_active_fence_set() with itself

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 13:45, Chris Wilson wrote: The expected downside to commit 58b4c1a07ada ("drm/i915: Reduce nested prepare_remote_context() to a trylock") was that it would need to return -EAGAIN to userspace in order to resolve potential mutex inversion. Such an unsightly round trip is

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balance: Check chain of submit dependencies

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 14:50, Chris Wilson wrote: Check that the submit fence couples into the dependency chain so that the bonded pair cannot over take any of the earlier requests. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_exec_balancer.c | 88

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Defer breadcrumb processing to after the irq handler

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Defer breadcrumb processing to after the irq handler URL : https://patchwork.freedesktop.org/series/70109/ State : success == Summary == CI Bug Log - changes from CI_DRM_7432 -> Patchwork_15465

[Intel-gfx] [PATCH v6 3/4] drm/i915: Manipulate DBuf slices properly

2019-11-27 Thread Stanislav Lisovskiy
Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v6 4/4] drm/i915: Correctly map DBUF slices to pipes

2019-11-27 Thread Stanislav Lisovskiy
Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v6 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-11-27 Thread Stanislav Lisovskiy
Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 10 +-

[Intel-gfx] [PATCH v6 0/4] Enable second DBuf slice for ICL and TGL

2019-11-27 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (4): drm/i915: Remove skl_ddl_allocation struct drm/i915:

[Intel-gfx] [PATCH v6 2/4] drm/i915: Move dbuf slice update to proper place

2019-11-27 Thread Stanislav Lisovskiy
Current DBuf slices update wasn't done in proper plane, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 36 +++- 1 file

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-27 15:21:30) > > On 27/11/2019 14:37, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-27 14:22:37) > >> > >> On 27/11/2019 14:04, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-11-27 13:46:14) > On 27/11/2019 11:17, Chris Wilson wrote: > >

[Intel-gfx] [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-27 Thread Jani Nikula
Deferred IO now preserves the fb_ops. Cc: Noralf Trønnes Cc: dri-de...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_fb_helper.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c

[Intel-gfx] [PATCH 04/13] video: udlfb: don't restore fb_mmap after deferred IO cleanup

2019-11-27 Thread Jani Nikula
Deferred IO now preserves the fb_ops. Cc: Bernie Thompson Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/udlfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index fe373b63ddd6..07905d385949

[Intel-gfx] [PATCH 06/13] video: fbmem: use const pointer for fb_ops

2019-11-27 Thread Jani Nikula
Use const for fb_ops to let us make the info->fbops pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/core/fbmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c

[Intel-gfx] [PATCH 05/13] video: fbdev: vesafb: modify the static fb_ops directly

2019-11-27 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/vesafb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/vesafb.c

[Intel-gfx] [PATCH 10/13] video: constify fb ops across all drivers

2019-11-27 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can star making the ops const as well. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +-

[Intel-gfx] [PATCH 00/13] video, drm: constify fbops in struct fb_info

2019-11-27 Thread Jani Nikula
So I wanted to quickly move our struct fb_ops to const data because we don't modify it... and this series is where the rabbit hole ends. Ugh. The main pain point is deferred IO, which is covered in patch 1. Everything gets easier after that. The last 5 could be merged at leisure. BR, Jani.

[Intel-gfx] [PATCH 03/13] video: smscufx: don't restore fb_mmap after deferred IO cleanup

2019-11-27 Thread Jani Nikula
Deferred IO now preserves the fb_ops. Cc: Steve Glendinning Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/smscufx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c index

[Intel-gfx] [PATCH 01/13] video: fb_defio: preserve user fb_ops

2019-11-27 Thread Jani Nikula
Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap and then resetting it to NULL afterwards causes problems all over the place. First, it prevents making the fbops member of struct fb_info a const pointer, which means we can't make struct fb_ops const anywhere. Second, a few

[Intel-gfx] [PATCH 07/13] video: omapfb: use const pointer for fb_ops

2019-11-27 Thread Jani Nikula
Use const for fb_ops to let us make the info->fbops pointer const in the future. Cc: linux-fb...@vger.kernel.org Cc: linux-o...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/omap/omapfb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 08/13] video: fbdev: make fbops member of struct fb_info a const pointer

2019-11-27 Thread Jani Nikula
Now that we no longer modify the fbops, or hold non-const pointers to it, we can make it const. With that, also deferred_io_private needs to be const. After this, we can start making the fbops const all over the place. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: enable DSC (rev4)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/dsi: enable DSC (rev4) URL : https://patchwork.freedesktop.org/series/69540/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5531079c698e drm/i915/bios: pass devdata to parse_ddi_port 94a64f506df8 drm/i915/bios: parse compression parameters

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Chris Wilson
Quoting Chris Wilson (2019-11-27 11:17:42) > We want the bonded request to have the same scheduler properties as its > master so that it is placed at the same depth in the queue. For example, > consider we have requests A, B and B', where B & B' are a bonded pair to > run in parallel on two

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balance: Check chain of submit dependencies

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 15:15, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-27 15:08:25) On 27/11/2019 14:50, Chris Wilson wrote: Check that the submit fence couples into the dependency chain so that the bonded pair cannot over take any of the earlier requests. Signed-off-by: Chris Wilson Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 14:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-27 14:22:37) On 27/11/2019 14:04, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-27 13:46:14) On 27/11/2019 11:17, Chris Wilson wrote: We want the bonded request to have the same scheduler properties as its

Re: [Intel-gfx] [PATCH] drm/i915/gt: Defer breadcrumb processing to after the irq handler

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 11:58, Chris Wilson wrote: The design of our interrupt handlers is that we ack the receipt of the interrupt first, inside the critical section where the master interrupt control is off and other cpus cannot start processing the next interrupt; and then process the interrupt events

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-27 13:46:14) > > On 27/11/2019 11:17, Chris Wilson wrote: > > We want the bonded request to have the same scheduler properties as its > > master so that it is placed at the same depth in the queue. For example, > > consider we have requests A, B and B', where B &

[Intel-gfx] [PATCH 0/2] adding gamma state checker for icl+ platforms

2019-11-27 Thread Swati Sharma
In this patch, enabled gamma state checker for ICL and TGL. Limiting state checker only for super fine segment, since getting incorrect readbacks for fine and coarse segments. Patch includes fix for multiple colored screen during boot. Swati Sharma (2): [v8] drm/i915/color: Extract

[Intel-gfx] [PATCH 1/2] [v8] drm/i915/color: Extract icl_read_luts()

2019-11-27 Thread Swati Sharma
For icl+, have hw read out to create hw blob of gamma lut values. icl+ platforms supports multi segmented gamma mode by default, add hw lut creation for this mode. This will be used to validate gamma programming using dsb (display state buffer) which is a tgl specific feature. Major change

[Intel-gfx] [PATCH 2/2] FOR_TESTING_ONLY: Print rgb values of hw and sw blobs

2019-11-27 Thread Swati Sharma
Only to print hw and sw lut values/channel. Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_color.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c index c7d0f37d8899..8f46c785f55a

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balance: Check chain of submit dependencies

2019-11-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-11-27 15:08:25) > > On 27/11/2019 14:50, Chris Wilson wrote: > > Check that the submit fence couples into the dependency chain so that > > the bonded pair cannot over take any of the earlier requests. > > > > Signed-off-by: Chris Wilson > > Cc: Tvrtko Ursulin > >

[Intel-gfx] [PATCH 12/13] media: constify fb ops across all drivers

2019-11-27 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can star making the ops const as well. Cc: Hans Verkuil Cc: Andy Walls Cc: linux-me...@vger.kernel.org Cc: ivtv-de...@ivtvdriver.org Signed-off-by: Jani Nikula --- drivers/media/pci/ivtv/ivtvfb.c | 3 +--

[Intel-gfx] [PATCH 09/13] drm: constify fb ops across all drivers

2019-11-27 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 +- drivers/gpu/drm/armada/armada_fbdev.c | 2 +-

[Intel-gfx] [PATCH 11/13] HID: picoLCD: constify fb ops

2019-11-27 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can star making the ops const as well. Cc: Bruno Prémont Cc: linux-in...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/hid/hid-picolcd_fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 13/13] samples: vfio-mdev: constify fb ops

2019-11-27 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can star making the ops const as well. Cc: Kirti Wankhede Cc: k...@vger.kernel.org Signed-off-by: Jani Nikula --- samples/vfio-mdev/mdpy-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/vfio-mdev/mdpy-fb.c

Re: [Intel-gfx] [PATCH 01/13] video: fb_defio: preserve user fb_ops

2019-11-27 Thread Ville Syrjälä
On Wed, Nov 27, 2019 at 06:31:57PM +0200, Jani Nikula wrote: > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > and then resetting it to NULL afterwards causes problems all over the > place. First, it prevents making the fbops member of struct fb_info a > const pointer,

Re: [Intel-gfx] [PATCH] drm/i915: Copy across scheduler behaviour flags across submit fences

2019-11-27 Thread Tvrtko Ursulin
On 27/11/2019 14:04, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-11-27 13:46:14) On 27/11/2019 11:17, Chris Wilson wrote: We want the bonded request to have the same scheduler properties as its master so that it is placed at the same depth in the queue. For example, consider we have

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_balance: Check chain of submit dependencies

2019-11-27 Thread Chris Wilson
Check that the submit fence couples into the dependency chain so that the bonded pair cannot over take any of the earlier requests. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_exec_balancer.c | 88 ++ 1 file changed, 88 insertions(+) diff

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Handle SDEISR according to PCH rather than platform (rev3)

2019-11-27 Thread Matt Roper
On Wed, Nov 27, 2019 at 07:19:08AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915: Handle SDEISR according to PCH > rather than platform (rev3) > URL : https://patchwork.freedesktop.org/series/70073/ > State : failure > > == Summary == > > CI

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Handle SDEISR according to PCH rather than platform

2019-11-27 Thread Lucas De Marchi
On Tue, Nov 26, 2019 at 01:07:30PM -0800, Matt Roper wrote: The South Display is part of the PCH so we should technically be basing our port detection logic off the PCH in use rather than the platform generation. Cc: Lucas De Marchi Signed-off-by: Matt Roper Reviewed-by: Lucas De Marchi

Re: [Intel-gfx] [PATCH 4/7] drm/i915/dp: Power down sink before disable pipe/transcoder clock

2019-11-27 Thread Ville Syrjälä
On Tue, Nov 26, 2019 at 10:12:52PM +, Souza, Jose wrote: > On Tue, 2019-11-26 at 22:15 +0200, Ville Syrjälä wrote: > > On Fri, Nov 22, 2019 at 04:54:56PM -0800, José Roberto de Souza > > wrote: > > > Disabling pipe/transcoder clock before power down sink could cause > > > sink lost signal,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw (rev5)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw (rev5) URL : https://patchwork.freedesktop.org/series/70089/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15472 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for adding gamma state checker for icl+ platforms (rev7)

2019-11-27 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev7) URL : https://patchwork.freedesktop.org/series/66811/ State : success == Summary == CI Bug Log - changes from CI_DRM_7432 -> Patchwork_15468 Summary ---

Re: [Intel-gfx] [PATCH 03/13] video: smscufx: don't restore fb_mmap after deferred IO cleanup

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:31:59PM +0200, Jani Nikula wrote: > Deferred IO now preserves the fb_ops. > > Cc: Steve Glendinning > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/smscufx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 01/13] video: fb_defio: preserve user fb_ops

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 07:17:41PM +0100, Daniel Vetter wrote: > On Wed, Nov 27, 2019 at 06:31:57PM +0200, Jani Nikula wrote: > > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > > and then resetting it to NULL afterwards causes problems all over the > > place. First, it

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/tgl: Do not program clockgating

2019-11-27 Thread Souza, Jose
On Wed, 2019-11-27 at 11:11 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/display/tgl: Do not program clockgating > URL : https://patchwork.freedesktop.org/series/70076/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7426_full ->

Re: [Intel-gfx] [PATCH 2/3] drm/i915/ehl: Make icp_digital_port_connected() use phy instead of port

2019-11-27 Thread Lucas De Marchi
On Tue, Nov 26, 2019 at 01:07:31PM -0800, Matt Roper wrote: When looking at SDEISR to determine the connection status of combo outputs, we should use the phy index rather than the port index. Although they're usually the same thing, EHL's DDI-D (port D) is attached to PHY-A and SDEISR doesn't

Re: [Intel-gfx] [PATCH 1/7] drm/i915/display: Refactor intel_commit_modeset_disables()

2019-11-27 Thread Ville Syrjälä
On Tue, Nov 26, 2019 at 10:03:08PM +, Souza, Jose wrote: > On Tue, 2019-11-26 at 21:40 +0200, Ville Syrjälä wrote: > > On Fri, Nov 22, 2019 at 04:54:53PM -0800, José Roberto de Souza > > wrote: > > > Commit 9c722e17c1b9 ("drm/i915: Disable pipes in reverse order") > > > reverted the order that

Re: [Intel-gfx] [RFC 03/13] drm/i915/svm: Runtime (RT) allocator support

2019-11-27 Thread Niranjan Vishwanathapura
On Tue, Nov 26, 2019 at 03:59:31PM +0200, Joonas Lahtinen wrote: Quoting Niranjan Vishwanathapura (2019-11-25 18:40:57) On Mon, Nov 25, 2019 at 09:59:37AM +, Chris Wilson wrote: >Quoting Niranjana Vishwanathapura (2019-11-22 20:57:24) >> Shared Virtual Memory (SVM) runtime allocator support

[Intel-gfx] ✓ Fi.CI.BAT: success for video, drm: constify fbops in struct fb_info

2019-11-27 Thread Patchwork
== Series Details == Series: video, drm: constify fbops in struct fb_info URL : https://patchwork.freedesktop.org/series/70119/ State : success == Summary == CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15470 Summary ---

Re: [Intel-gfx] [PATCH 4/8] drm/rockchip: Use drm_gem_fb_create_with_dirty

2019-11-27 Thread Andrzej Pietrasiewicz
Hi Daniel, After applying this patch there are some slight differences in the effective behavior of the code. I can't tell if they are important, please see below. Andrzej W dniu 15.11.2019 o 10:21, Daniel Vetter pisze: If rockchip would switch over to the generic fbdev setup we could

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for adding gamma state checker for icl+ platforms (rev7)

2019-11-27 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev7) URL : https://patchwork.freedesktop.org/series/66811/ State : warning == Summary == $ dim checkpatch origin/drm-tip bee2710f9f35 drm/i915/color: Extract icl_read_luts() -:33: WARNING:COMMIT_LOG_LONG_LINE:

Re: [Intel-gfx] [PATCH 01/13] video: fb_defio: preserve user fb_ops

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 07:01:16PM +0200, Ville Syrjälä wrote: > On Wed, Nov 27, 2019 at 06:31:57PM +0200, Jani Nikula wrote: > > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > > and then resetting it to NULL afterwards causes problems all over the > > place. First, it

Re: [Intel-gfx] [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:31:58PM +0200, Jani Nikula wrote: > Deferred IO now preserves the fb_ops. > > Cc: Noralf Trønnes > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_helper.c | 18 ++ > 1 file

Re: [Intel-gfx] [PATCH 1/7] drm/i915/display: Refactor intel_commit_modeset_disables()

2019-11-27 Thread Lucas De Marchi
On Tue, Nov 26, 2019 at 02:49:47PM -0800, Matt Roper wrote: On Tue, Nov 26, 2019 at 02:03:08PM -0800, Souza, Jose wrote: On Tue, 2019-11-26 at 21:40 +0200, Ville Syrjälä wrote: > On Fri, Nov 22, 2019 at 04:54:53PM -0800, José Roberto de Souza > wrote: > > Commit 9c722e17c1b9 ("drm/i915: Disable

[Intel-gfx] [PATCH 2/7] drm/i915: Pass dev_priv to ilk_disable_lp_wm()

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Get rid of another 'dev' usage by passing dev_priv instead. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 +--- drivers/gpu/drm/i915/intel_pm.h | 2 +- 3 files changed, 3

[Intel-gfx] [PATCH 4/7] drm/i915: Clean up intel_{pre, post}_plane_update()

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Change the calling convention to just pass the state+crtc and switch to intel_ types throughout. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 88 +--- drivers/gpu/drm/i915/display/intel_fbc.c | 14 ++--

[Intel-gfx] [PATCH 5/7] drm/i915: Clean up the gen2 "no planes -> underrun" workaround

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä We have the active_planes bitmask now so use it to properly determine when some planes are visible for the gen2 underrun workaround. This let's us almost eliminate intel_post_enable_primary(). The manual underrun checks we can simply move into intel_atomic_commit_tail()

[Intel-gfx] [PATCH 7/7] drm/i915: Make intel_crtc_arm_fifo_underrun() functional on gen2

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Assuming intel_crtc_arm_fifo_underrun() only gets called when there's no pending plane updates we can utilize it on gen2 by checking the active_planes bitmask so that we only re-enable underrun reporting if some planes are active. i915_fifo_underrun_reset_write() seems to

[Intel-gfx] [PATCH 3/7] drm/i915: s/pipe_config/new_crtc_state/ intel_{pre, post}_plane_update()

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Replace the old world 'pipe_config' variable name with the new thing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 40 ++-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git

[Intel-gfx] [PATCH 0/7] drm/i915: Cleanups around pre/post plane update

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä I was poking around the fbc stuff and again stumbled on the mess in intel_{pre,post}_plane_update(), so I proceeded to clean it up a bit. Ville Syrjälä (7): drm/i915: Clean up arguments to nv12/scaler w/a funcs drm/i915: Pass dev_priv to ilk_disable_lp_wm() drm/i915:

[Intel-gfx] [PATCH 1/7] drm/i915: Clean up arguments to nv12/scaler w/a funcs

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Don't pass the redundant dev_priv to needs_nv12_wa() and needs_scalerclk_wa(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 26 +++- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for video, drm: constify fbops in struct fb_info

2019-11-27 Thread Patchwork
== Series Details == Series: video, drm: constify fbops in struct fb_info URL : https://patchwork.freedesktop.org/series/70119/ State : warning == Summary == $ dim checkpatch origin/drm-tip a9312755bd82 video: fb_defio: preserve user fb_ops -:93: CHECK:AVOID_EXTERNS: extern prototypes should

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw (rev4)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw (rev4) URL : https://patchwork.freedesktop.org/series/70089/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7432 -> Patchwork_15466 Summary

Re: [Intel-gfx] [PATCH 01/13] video: fb_defio: preserve user fb_ops

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:31:57PM +0200, Jani Nikula wrote: > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > and then resetting it to NULL afterwards causes problems all over the > place. First, it prevents making the fbops member of struct fb_info a > const pointer,

Re: [Intel-gfx] [PATCH 13/13] samples: vfio-mdev: constify fb ops

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:32:09PM +0200, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can star making > the ops const as well. > > Cc: Kirti Wankhede > Cc: k...@vger.kernel.org > Signed-off-by: Jani Nikula You've missed at least drivers/staging/fbtft in your

Re: [Intel-gfx] [PATCH] drm/i915/display: Suspend MST topology manager before destroy fbdev

2019-11-27 Thread Lucas De Marchi
On Tue, Nov 26, 2019 at 06:16:09PM -0800, Jose Souza wrote: MST do topology probe in threads, so this running threads needs to be flushed before fbdev is destroyed as when a new MST node is found it calls drm_kms_helper_hotplug_event() that calls fbdev functions Bugzilla:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable second DBuf slice for ICL and TGL (rev2)

2019-11-27 Thread Patchwork
== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev2) URL : https://patchwork.freedesktop.org/series/70059/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Remove skl_ddl_allocation struct Okay!

Re: [Intel-gfx] [PATCH 3/7] drm/i915/tgl: Select master trasconder for MST stream

2019-11-27 Thread Ville Syrjälä
On Tue, Nov 26, 2019 at 08:30:31PM +, Souza, Jose wrote: > On Tue, 2019-11-26 at 22:05 +0200, Ville Syrjälä wrote: > > On Fri, Nov 22, 2019 at 04:54:55PM -0800, José Roberto de Souza > > wrote: > > > On TGL the blending of all the streams have moved from DDI to > > > transcoder, so now every

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable second DBuf slice for ICL and TGL (rev2)

2019-11-27 Thread Patchwork
== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev2) URL : https://patchwork.freedesktop.org/series/70059/ State : success == Summary == CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15469 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Handle SDEISR according to PCH rather than platform (rev4)

2019-11-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Handle SDEISR according to PCH rather than platform (rev4) URL : https://patchwork.freedesktop.org/series/70073/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7434 -> Patchwork_15471

Re: [Intel-gfx] [PATCH 4/8] drm/rockchip: Use drm_gem_fb_create_with_dirty

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 6:33 PM Andrzej Pietrasiewicz wrote: > > Hi Daniel, > > After applying this patch there are some slight differences > in the effective behavior of the code. > > I can't tell if they are important, please see below. > > Andrzej > > W dniu 15.11.2019 o 10:21, Daniel Vetter

Re: [Intel-gfx] [PATCH 5/5] drm/i915/vbt: Parse power conservation features block

2019-11-27 Thread Matt Roper
On Mon, Nov 25, 2019 at 04:47:39PM -0800, Souza, Jose wrote: > On Tue, 2019-11-12 at 23:56 +, Souza, Jose wrote: > > On Tue, 2019-11-12 at 13:21 -0800, Matt Roper wrote: > > > On Tue, Nov 05, 2019 at 05:45:04PM -0800, José Roberto de Souza > > > wrote: > > > > Since VBT 228 is from this block

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Serialise i915_active_fence_set() with itself (rev3)

2019-11-27 Thread Patchwork
== Series Details == Series: drm/i915: Serialise i915_active_fence_set() with itself (rev3) URL : https://patchwork.freedesktop.org/series/70068/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7432 -> Patchwork_15467

Re: [Intel-gfx] [PATCH 05/13] video: fbdev: vesafb: modify the static fb_ops directly

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:32:01PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/vesafb.c | 6 +++--- > 1 file changed, 3

Re: [Intel-gfx] [PATCH 04/13] video: udlfb: don't restore fb_mmap after deferred IO cleanup

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:32:00PM +0200, Jani Nikula wrote: > Deferred IO now preserves the fb_ops. > > Cc: Bernie Thompson > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter Aside: I wonder whether we should start retiring all the fbdev drivers which

[Intel-gfx] [CI] drm/i915/gen7: Re-enable full-ppgtt for ivb, byt, hsw

2019-11-27 Thread Chris Wilson
After much hair pulling, resort to preallocating the ppGTT entries on init to circumvent the apparent lack of PD invalidate following the write to PP_DCLV upon switching mm between contexts (and here the same context after binding new objects). However, the details of that PP_DCLV invalidate are

[Intel-gfx] [PATCH 6/7] drm/i915: Nuke intel_pre_disable_primary_noatomic()

2019-11-27 Thread Ville Syrjala
From: Ville Syrjälä Let's just inline intel_pre_disable_primary_noatomic() into intel_plane_disable_noatomic(). The CxSR disable we can do regardless of which plane we're disabling, and while at it we can make the gen2 underrun w/a accurate by consulting the active_planes bitmask.

  1   2   >