[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix includes and local vars order (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix includes and local vars order (rev2) URL : https://patchwork.freedesktop.org/series/77555/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8525_full -> Patchwork_17759_full Summary

[Intel-gfx] [CI] agp/intel: Fix a memory leak on module initialisation failure

2020-05-22 Thread Chris Wilson
From: Qiushi Wu In intel_gtt_setup_scratch_page(), pointer "page" is not released if pci_dma_mapping_error() return an error, leading to a memory leak on module intialisation failure. Simply fix this issue by freeing "page" before return. Fixes: 0e87d2b06cb46 ("intel-gtt: initialize our own

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915: Disable semaphore inter-engine sync without timeslicing

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Disable semaphore inter-engine sync without timeslicing URL : https://patchwork.freedesktop.org/series/77512/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8518_full -> Patchwork_17751_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Immediately check for ACK after submission

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: Immediately check for ACK after submission URL : https://patchwork.freedesktop.org/series/77509/ State : success == Summary == CI Bug Log - changes from CI_DRM_8517_full -> Patchwork_17749_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Flush the submission, not cancel it!

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush the submission, not cancel it! URL : https://patchwork.freedesktop.org/series/77510/ State : success == Summary == CI Bug Log - changes from CI_DRM_8517_full -> Patchwork_17750_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for agp/intel: Fix a memory leak on module initialisation failure

2020-05-22 Thread Patchwork
== Series Details == Series: agp/intel: Fix a memory leak on module initialisation failure URL : https://patchwork.freedesktop.org/series/77550/ State : warning == Summary == $ dim checkpatch origin/drm-tip 118686605b3f agp/intel: Fix a memory leak on module initialisation failure -:8:

[Intel-gfx] ✓ Fi.CI.BAT: success for agp/intel: Fix a memory leak on module initialisation failure

2020-05-22 Thread Patchwork
== Series Details == Series: agp/intel: Fix a memory leak on module initialisation failure URL : https://patchwork.freedesktop.org/series/77550/ State : success == Summary == CI Bug Log - changes from CI_DRM_8524 -> Patchwork_17756 Summary

Re: [Intel-gfx] [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-22 Thread Souptick Joarder
Hi John, On Tue, May 19, 2020 at 5:51 AM John Hubbard wrote: > > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. > >

Re: [Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Chris Wilson
Quoting Chris Wilson (2020-05-22 11:42:07) > Our __sgt_iter assumes that the scattergather list has at least one > element. But during construction we may fail in allocating the first > page, and so mark the first element as the terminator. This is > unexpected! > > [22555.524752] RIP:

[Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order

2020-05-22 Thread Stanislav Lisovskiy
Removed duplicate include and fixed comment > 80 chars. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_bw.c| 43 -- drivers/gpu/drm/i915/display/intel_bw.h| 2 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove PIN_UPDATE for i915_vma_pin

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915: Remove PIN_UPDATE for i915_vma_pin URL : https://patchwork.freedesktop.org/series/77515/ State : success == Summary == CI Bug Log - changes from CI_DRM_8518_full -> Patchwork_17752_full Summary

[Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Chris Wilson
Our __sgt_iter assumes that the scattergather list has at least one element. But during construction we may fail in allocating the first page, and so mark the first element as the terminator. This is unexpected! [22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915] [22555.524759] Code: 49

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/gem: Avoid iterating an empty list URL : https://patchwork.freedesktop.org/series/77553/ State : success == Summary == CI Bug Log - changes from CI_DRM_8524 -> Patchwork_17757 Summary ---

Re: [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order

2020-05-22 Thread Chris Wilson
Quoting Stanislav Lisovskiy (2020-05-22 13:55:34) > Removed duplicate include and fixed comment > 80 chars. > > Signed-off-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_bw.c| 43 -- > drivers/gpu/drm/i915/display/intel_bw.h| 2 +- >

Re: [Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Matthew Auld
On Fri, 22 May 2020 at 13:02, Chris Wilson wrote: > > Quoting Chris Wilson (2020-05-22 11:42:07) > > Our __sgt_iter assumes that the scattergather list has at least one > > element. But during construction we may fail in allocating the first > > page, and so mark the first element as the

Re: [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order

2020-05-22 Thread Lisovskiy, Stanislav
On Fri, May 22, 2020 at 02:05:26PM +0100, Chris Wilson wrote: > Quoting Stanislav Lisovskiy (2020-05-22 13:55:34) > > Removed duplicate include and fixed comment > 80 chars. > > > > Signed-off-by: Stanislav Lisovskiy > > --- > > drivers/gpu/drm/i915/display/intel_bw.c| 43

[Intel-gfx] [PATCH v2] drm/i915: Fix includes and local vars order

2020-05-22 Thread Stanislav Lisovskiy
Removed duplicate include and fixed comment > 80 chars. v2: Added newline after system include and between functions Reviewed-by: Chris Wilson Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_bw.c| 44 -- drivers/gpu/drm/i915/display/intel_bw.h

[Intel-gfx] [CI] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Chris Wilson
Our __sgt_iter assumes that the scattergather list has at least one element. But during construction we may fail in allocating the first page, and so mark the first element as the terminator. This is unexpected! [22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915] [22555.524759] Code: 49

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix includes and local vars order URL : https://patchwork.freedesktop.org/series/77555/ State : success == Summary == CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17758 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Stop cross-poluting PIN_GLOBAL with PIN_USER with no-ppgtt

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: Stop cross-poluting PIN_GLOBAL with PIN_USER with no-ppgtt URL : https://patchwork.freedesktop.org/series/77517/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8520_full -> Patchwork_17753_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Avoid iterating an empty list (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/gem: Avoid iterating an empty list (rev2) URL : https://patchwork.freedesktop.org/series/77553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17760 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels URL : https://patchwork.freedesktop.org/series/77518/ State : success == Summary == CI Bug Log - changes from CI_DRM_8520_full -> Patchwork_17754_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix includes and local vars order (rev2) URL : https://patchwork.freedesktop.org/series/77555/ State : success == Summary == CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17759 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for agp/intel: Fix a memory leak on module initialisation failure

2020-05-22 Thread Patchwork
== Series Details == Series: agp/intel: Fix a memory leak on module initialisation failure URL : https://patchwork.freedesktop.org/series/77550/ State : success == Summary == CI Bug Log - changes from CI_DRM_8524_full -> Patchwork_17756_full

[Intel-gfx] [CI 4/4] drm/i915: convert get_user_pages() --> pin_user_pages()

2020-05-22 Thread Chris Wilson
From: John Hubbard This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]:

[Intel-gfx] [CI 1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-22 Thread Chris Wilson
From: John Hubbard This is in order to avoid a forward declaration of internal_get_user_pages_fast(), in the next patch. This is code movement only--all generated code should be identical. Signed-off-by: John Hubbard --- mm/gup.c | 112 +++

[Intel-gfx] [CI 2/4] mm/gup: refactor and de-duplicate gup_fast() code

2020-05-22 Thread Chris Wilson
From: John Hubbard There were two nearly identical sets of code for gup_fast() style of walking the page tables with interrupts disabled. This has lead to the usual maintenance problems that arise from having duplicated code. There is already a core internal routine in gup.c for gup_fast(), so

[Intel-gfx] [CI 3/4] mm/gup: introduce pin_user_pages_fast_only()

2020-05-22 Thread Chris Wilson
From: John Hubbard This is the FOLL_PIN equivalent of __get_user_pages_fast(), except with a more descriptive name, and gup_flags instead of a boolean "write" in the argument list. Signed-off-by: John Hubbard --- include/linux/mm.h | 2 ++ mm/gup.c | 36

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim checkpatch origin/drm-tip 48c15b755cba mm/gup: move __get_user_pages_fast() down

Re: [Intel-gfx] [PATCH v3] drm/i915/mst: filter out the display mode exceed sink's capability

2020-05-22 Thread Lyude Paul
On Fri, 2020-05-22 at 14:35 -0400, Lyude Paul wrote: > > On Tue, 2020-05-19 at 11:56 +0800, Lee Shawn C wrote: > > So far, max dot clock rate for MST mode rely on physcial > > bandwidth limitation. It would caused compatibility issue > > if source display resolution exceed MST hub output ability.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : success == Summary == CI Bug Log - changes from CI_DRM_8527 -> Patchwork_17762

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c URL : https://patchwork.freedesktop.org/series/77566/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8526 -> Patchwork_17761

Re: [Intel-gfx] [PATCH v3] drm/i915/mst: filter out the display mode exceed sink's capability

2020-05-22 Thread Lyude Paul
On Tue, 2020-05-19 at 11:56 +0800, Lee Shawn C wrote: > So far, max dot clock rate for MST mode rely on physcial > bandwidth limitation. It would caused compatibility issue > if source display resolution exceed MST hub output ability. > > For example, source DUT had DP 1.2 output capability. >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim checkpatch origin/drm-tip eeb23485305d mm/gup: move

[Intel-gfx] [PATCH] drm/i915/dsi: Dont forget to clean up the connector on error (v2)

2020-05-22 Thread Vivek Kasireddy
If an error is encountered during the DSI initialization setup, the drm connector object also needs to be cleaned up along with the encoder. The error can happen due to a missing mode in the VBT or for other reasons. v2: Rephrase the commit message to make it more clear. Cc: Jani Nikula Cc:

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev18)

2020-05-22 Thread Chris Wilson
Quoting Chris Wilson (2020-05-22 23:00:10) > Quoting Lisovskiy, Stanislav (2020-05-21 10:35:42) > > Seems to be unrelated issue. There seems to be some list corruption > > happening in drm fb manipulation code. > > if those patches would be causing that (like some severe mem corruption)- > > it

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Dont forget to clean up the connector on error (rev2)

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Dont forget to clean up the connector on error (rev2) URL : https://patchwork.freedesktop.org/series/77011/ State : success == Summary == CI Bug Log - changes from CI_DRM_8527 -> Patchwork_17763

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev18)

2020-05-22 Thread Chris Wilson
Quoting Lisovskiy, Stanislav (2020-05-21 10:35:42) > Seems to be unrelated issue. There seems to be some list corruption happening > in drm fb manipulation code. > if those patches would be causing that (like some severe mem corruption)- it > would happen much more broadly than single test and

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Avoid waiting inside mmu_notifier_invalidate_range

2020-05-22 Thread Patchwork
== Series Details == Series: drm/i915/gem: Avoid waiting inside mmu_notifier_invalidate_range URL : https://patchwork.freedesktop.org/series/77529/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8523_full -> Patchwork_17755_full