Re: [Intel-gfx] [PATCH 00/14] drm/i915: PCI ID cleanup

2020-07-16 Thread Alexei Podtelezhnikov
> I started by splitting Alexei's SKL PCI ID fix into > logical chunks, and then ocd kicked in a bit... Thank you for picking it up. Please do not forget https://lists.freedesktop.org/archives/intel-gfx/2020-April/237944.html Alexei > > Cc: Alexei Podtelezhnikov > > Alexei Podtelezhnikov

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Add compiler paranoia for checking HWSP values

2020-07-16 Thread Chris Wilson
Since we want to read the values from the HWSP as written to by the GPU, warn the compiler that the values are volatile. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/selftest_timeline.c | 22 ++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Wait for aux invalidation on Tigerlake

2020-07-16 Thread Chris Wilson
Add a SRM read back of the aux invalidation register after poking hsdes: 1809175790, as failing to do so leads to writes going astray. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2169 Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 31

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Race breadcrumb signaling against timeslicing

2020-07-16 Thread Chris Wilson
This is an attempt to chase down some preempt-to-busy races with breadcrumb signaling on the virtual engines. By using more semaphore spinners than available engines, we encourage very short timeslices, and we make each batch of random duration to try and coincide the end of a batch with the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2) URL : https://patchwork.freedesktop.org/series/79534/ State : success == Summary == CI Bug Log - changes from CI_DRM_8758 -> Patchwork_18196

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Remaining RKL patches (rev7)

2020-07-16 Thread Patchwork
== Series Details == Series: Remaining RKL patches (rev7) URL : https://patchwork.freedesktop.org/series/77971/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: PCI ID cleanup

2020-07-16 Thread Patchwork
== Series Details == Series: drm/i915: PCI ID cleanup URL : https://patchwork.freedesktop.org/series/79561/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8757_full -> Patchwork_18192_full Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL URL : https://patchwork.freedesktop.org/series/79569/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7e44cd55cc41 drm/i915/dp: HAX Try the bspec value for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL URL : https://patchwork.freedesktop.org/series/79569/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL URL : https://patchwork.freedesktop.org/series/79569/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8759 -> Patchwork_18198

[Intel-gfx] [PATCH v8 5/5] drm/i915/rkl: Add Wa_14011224835 for PHY B initialization

2020-07-16 Thread Matt Roper
After doing normal PHY-B initialization on Rocket Lake, we need to manually copy some additional PHY-A register values into PHY-B registers. Note that the bspec's combo phy page doesn't specify that this workaround is restricted to specific platform steppings (and doesn't even do a very good job

[Intel-gfx] [PATCH v8 1/5] drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout

2020-07-16 Thread Matt Roper
RKL uses a slightly different bit layout for the DPCLKA_CFGCR0 register. v2: - Fix inverted mask application when updating ICL_DPCLKA_CFGCR0 - Checkpatch style fixes Bspec: 50287 Cc: Aditya Swarup Signed-off-by: Matt Roper Reviewed-by: José Roberto de Souza ---

[Intel-gfx] [PATCH v8 0/5] Remaining RKL patches

2020-07-16 Thread Matt Roper
The first couple patches here already have r-b's from Jose, but since it's been a while since they were last sent to the list we should get another CI pass before merging them. Changes since v7: - Undo the renumbering of PLL IDs in the DPLL4 patch; the shared DPLL code has deep-rooted

[Intel-gfx] [PATCH v8 4/5] drm/i915/rkl: Handle HTI

2020-07-16 Thread Matt Roper
If HTI (also sometimes called HDPORT) is enabled at startup, it may be using some of the PHYs and DPLLs making them unavailable for general usage. Let's read out the HDPORT_STATE register and avoid making use of resources that HTI is already using. v2: - Fix minor checkpatch warnings v3: -

[Intel-gfx] [PATCH v8 3/5] drm/i915/rkl: Add DPLL4 support

2020-07-16 Thread Matt Roper
Rocket Lake has a third DPLL (called 'DPLL4') that must be used to enable a third display. Unlike EHL's variant of DPLL4, the RKL variant behaves the same as DPLL0/1. And despite its name, the DPLL4 registers are offset as if it were DPLL2. v2: - Add new .update_ref_clks() hook. v3: -

[Intel-gfx] [PATCH v8 2/5] drm/i915/rkl: Add initial workarounds

2020-07-16 Thread Matt Roper
RKL and TGL share some general gen12 workarounds, but each platform also has its own platform-specific workarounds. v2: - Add Wa_1604555607 for RKL. This makes RKL's ctx WA list identical to TGL's, so we'll have both functions call the tgl_ function for now; this workaround isn't listed

[Intel-gfx] ✓ Fi.CI.BAT: success for Remaining RKL patches (rev7)

2020-07-16 Thread Patchwork
== Series Details == Series: Remaining RKL patches (rev7) URL : https://patchwork.freedesktop.org/series/77971/ State : success == Summary == CI Bug Log - changes from CI_DRM_8758 -> Patchwork_18197 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Be wary of data races when reading the active execlists (rev2) URL : https://patchwork.freedesktop.org/series/79551/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8757_full -> Patchwork_18193_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Move WaDisableDopClockGating:skl to skl_init_clock_gating()

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move WaDisableDopClockGating:skl to skl_init_clock_gating() URL : https://patchwork.freedesktop.org/series/79563/ State : success == Summary == CI Bug Log - changes from CI_DRM_8757_full -> Patchwork_18194_full

[Intel-gfx] [PATCH 1/2] drm/i915/dp: HAX Try the bspec value for CLKTOP2_CORECLKCTL

2020-07-16 Thread Manasi Navare
Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 4 drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index

[Intel-gfx] [PATCH 2/2] drm/i915/display/dp: Hacks for testing link training fail errors

2020-07-16 Thread Manasi Navare
Keep the link rate const at 2.7 Gpbs, lane count =4 and do not fallback on link training. See if kms_atomic_transition test passes in constant configuration Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_dp.c | 7 +--

Re: [Intel-gfx] [PATCH v8 4/5] drm/i915/rkl: Handle HTI

2020-07-16 Thread Souza, Jose
On Thu, 2020-07-16 at 15:05 -0700, Matt Roper wrote: > If HTI (also sometimes called HDPORT) is enabled at startup, it may be > using some of the PHYs and DPLLs making them unavailable for general > usage. Let's read out the HDPORT_STATE register and avoid making use of > resources that HTI is

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move WaDisableDopClockGating:skl to skl_init_clock_gating()

2020-07-16 Thread Souza, Jose
On Thu, 2020-07-16 at 22:04 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > It's silly to have if(SKL) checks in gen9_init_clock_gating() when > we can just move those bits into skl_init_clock_gating(). > > I'm not entirely convinced we even need this w/a, or if we do > then maybe we want

Re: [Intel-gfx] [PATCH v8 5/5] drm/i915/rkl: Add Wa_14011224835 for PHY B initialization

2020-07-16 Thread Souza, Jose
On Thu, 2020-07-16 at 15:05 -0700, Matt Roper wrote: > After doing normal PHY-B initialization on Rocket Lake, we need to > manually copy some additional PHY-A register values into PHY-B > registers. > > Note that the bspec's combo phy page doesn't specify that this > workaround is restricted to

Re: [Intel-gfx] sw_sync deadlock avoidance, take 3

2020-07-16 Thread Daniel Stone
Hi all, On Wed, 15 Jul 2020 at 12:57, Daniel Vetter wrote: > On Wed, Jul 15, 2020 at 1:47 PM Daniel Stone wrote: > > On Wed, 15 Jul 2020 at 12:05, Bas Nieuwenhuizen > > wrote: > > > Yes, this is used as part of the Android stack on Chrome OS (need to > > > see if ChromeOS specific, but > > >

Re: [Intel-gfx] [PATCH 1/1] drm/i915/perf: Map OA buffer to user space

2020-07-16 Thread Umesh Nerlige Ramappa
On Thu, Jul 16, 2020 at 12:28:47PM -0700, Umesh Nerlige Ramappa wrote: On Thu, Jul 16, 2020 at 09:44:46PM +0300, Lionel Landwerlin wrote: On 16/07/2020 21:06, Umesh Nerlige Ramappa wrote: On Thu, Jul 16, 2020 at 06:32:10PM +0300, Lionel Landwerlin wrote: On 14/07/2020 10:22, Umesh Nerlige

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2)

2020-07-16 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system (rev2) URL : https://patchwork.freedesktop.org/series/79534/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8758_full -> Patchwork_18196_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Remaining RKL patches (rev7)

2020-07-16 Thread Patchwork
== Series Details == Series: Remaining RKL patches (rev7) URL : https://patchwork.freedesktop.org/series/77971/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8758_full -> Patchwork_18197_full Summary --- **FAILURE**

[Intel-gfx] [PATCH 2/3] drm/i915/perf: Whitelist OA counter and buffer registers

2020-07-16 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski It is useful to have markers in the OA reports to identify triggered reports. Whitelist some OA counters that can be used as markers. A triggered report can be found faster if we can sample the HW tail and head registers when the report was triggered. Whitelist OA buffer

[Intel-gfx] [PATCH 3/3] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-16 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach

[Intel-gfx] [PATCH 1/3] drm/i915/perf: Whitelist OA report trigger registers

2020-07-16 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski OA reports can be triggered into the OA buffer by writing into the OAREPORTTRIG registers. Whitelist the registers to allow user to trigger reports. Signed-off-by: Piotr Maciejewski Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_workarounds.c |

<    1   2