Re: [Intel-gfx] [PATCH v4 61/61] drm/i915: Keep userpointer bindings if seqcount is unchanged, v2.

2020-10-19 Thread Intel
On 10/16/20 12:44 PM, Maarten Lankhorst wrote: Instead of force unbinding and rebinding every time, we try to check if our notifier seqcount is still correct when pages are bound. This way we only rebind userptr when we need to, and prevent stalls. Changes since v1: - Missing mutex_unlock,

[Intel-gfx] [PATCH] drm/i915/gt: Onion unwind for scratch page allocation failure

2020-10-19 Thread Chris Wilson
In switching to using objects for our ppGTT scratch pages, care was not taken to avoid trying to unref NULL objects on failure. And for gen6 ppGTT, it appears we forgot entirely to unwind after a partial allocation failure. Fixes: 89351925a477 ("drm/i915/gt: Switch to object allocations for page

Re: [Intel-gfx] [PATCH] drm/i915: Rate limit 'Fault errors' message

2020-10-19 Thread Joonas Lahtinen
+ Zhenyu & Zhi, Should not we instead fix the reason why the errors happen instead of rate-limiting them? Regards, Joonas Quoting Stefan Fritsch (2020-10-16 18:23:40) > If linux is running as a guest and the host is doing igd pass-through > with VT-d enabled, this message is logged dozens of

Re: [Intel-gfx] [PATCH v4 15/61] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v4.

2020-10-19 Thread Intel
On 10/16/20 12:43 PM, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acquire the pages for pinning. When the locks are taken, we

Re: [Intel-gfx] [PATCH v4 15/61] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v4.

2020-10-19 Thread Maarten Lankhorst
Op 19-10-2020 om 09:30 schreef Thomas Hellström (Intel): > > On 10/16/20 12:43 PM, Maarten Lankhorst wrote: >> Instead of doing what we do currently, which will never work with >> PROVE_LOCKING, do the same as AMD does, and something similar to >> relocation slowpath. When all locks are dropped,

[Intel-gfx] [RFC] drm/hdcp: Max MST content streams

2020-10-19 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v4 15/61] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v4.

2020-10-19 Thread Intel
On 10/19/20 9:30 AM, Thomas Hellström (Intel) wrote: On 10/16/20 12:43 PM, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acquire

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/hdcp: Max MST content streams

2020-10-19 Thread Patchwork
== Series Details == Series: drm/hdcp: Max MST content streams URL : https://patchwork.freedesktop.org/series/82806/ State : success == Summary == CI Bug Log - changes from CI_DRM_9161 -> Patchwork_18724 Summary --- **SUCCESS**

Re: [Intel-gfx] drm/i915: Detecting Vt-d when running as guest os

2020-10-19 Thread Zhenyu Wang
On 2020.10.16 17:19:19 +0200, Stefan Fritsch wrote: > Hi, > > if Linux is running as a guest and the host is doing igd-pass-thorugh with > VT-d enabled, the i915 driver does not work all that great. The most > obvious problem is that there are dozens of 'Fault errors on pipe A' > errrors

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP MST Support (rev3)

2020-10-19 Thread Patchwork
== Series Details == Series: HDCP 2.2 DP MST Support (rev3) URL : https://patchwork.freedesktop.org/series/81538/ State : warning == Summary == $ dim checkpatch origin/drm-tip d159760a4a56 drm/i915/hdcp: Update CP property in update_pipe e2cb41b29aef drm/i915/hotplug: Handle CP_IRQ for DP-MST

[Intel-gfx] ✗ Fi.CI.BAT: failure for HDCP 2.2 DP MST Support (rev3)

2020-10-19 Thread Patchwork
== Series Details == Series: HDCP 2.2 DP MST Support (rev3) URL : https://patchwork.freedesktop.org/series/81538/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9162 -> Patchwork_18727 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Flush the old heartbeat more gently

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush the old heartbeat more gently URL : https://patchwork.freedesktop.org/series/82815/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9162 -> Patchwork_18728 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/hdcp: Max MST content streams

2020-10-19 Thread Patchwork
== Series Details == Series: drm/hdcp: Max MST content streams URL : https://patchwork.freedesktop.org/series/82806/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9161_full -> Patchwork_18724_full Summary ---

[Intel-gfx] [PATCH 09/13] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-19 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. v2: Init the hdcp port data k for HDMI/DP SST strem. Cc: Ramalingam C Signed-off-by: Anshuman Gupta ---

[Intel-gfx] [PATCH] drm/i915: Force VT'd workarounds when running as a guest OS

2020-10-19 Thread Chris Wilson
If i915.ko is being used as a passthrough device, it does not know if the host is using intel_iommu. Mixing the iommu and gfx causing a few issues (such as scanout overfetch) which we need to workaround inside the driver, so if we detect we are running under a hypervisor, also assume the device

Re: [Intel-gfx] drm/i915: Detecting Vt-d when running as guest os

2020-10-19 Thread Zhenyu Wang
On 2020.10.19 10:57:38 +0100, Chris Wilson wrote: > Quoting Zhenyu Wang (2020-10-19 10:19:09) > > On 2020.10.16 17:19:19 +0200, Stefan Fritsch wrote: > > > Hi, > > > > > > if Linux is running as a guest and the host is doing igd-pass-thorugh > > > with > > > VT-d enabled, the i915 driver does

Re: [Intel-gfx] drm/i915: Detecting Vt-d when running as guest os

2020-10-19 Thread Zhenyu Wang
On 2020.10.19 11:20:40 +0100, Chris Wilson wrote: > Quoting Zhenyu Wang (2020-10-19 10:51:44) > > On 2020.10.19 10:57:38 +0100, Chris Wilson wrote: > > > Quoting Zhenyu Wang (2020-10-19 10:19:09) > > > > On 2020.10.16 17:19:19 +0200, Stefan Fritsch wrote: > > > > > Hi, > > > > > > > > > > if

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force VT'd workarounds when running as a guest OS (rev2)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Force VT'd workarounds when running as a guest OS (rev2) URL : https://patchwork.freedesktop.org/series/82814/ State : success == Summary == CI Bug Log - changes from CI_DRM_9162 -> Patchwork_18726

Re: [Intel-gfx] [PATCH v10 06/11] drm/i915: Enable big joiner support in enable and disable sequences.

2020-10-19 Thread Jani Nikula
On Fri, 16 Oct 2020, "Navare, Manasi" wrote: > I really want to push back on any design changes at this point since we have > a working solution > and we currently dont have any special cases. Like I discussed with you all > the commit modeset enables > code is now generic and similar to 2p2p.

Re: [Intel-gfx] drm/i915: Detecting Vt-d when running as guest os

2020-10-19 Thread Chris Wilson
Quoting Zhenyu Wang (2020-10-19 10:51:44) > On 2020.10.19 10:57:38 +0100, Chris Wilson wrote: > > Quoting Zhenyu Wang (2020-10-19 10:19:09) > > > On 2020.10.16 17:19:19 +0200, Stefan Fritsch wrote: > > > > Hi, > > > > > > > > if Linux is running as a guest and the host is doing igd-pass-thorugh

Re: [Intel-gfx] drm/i915: Detecting Vt-d when running as guest os

2020-10-19 Thread Chris Wilson
Quoting Zhenyu Wang (2020-10-19 10:19:09) > On 2020.10.16 17:19:19 +0200, Stefan Fritsch wrote: > > Hi, > > > > if Linux is running as a guest and the host is doing igd-pass-thorugh with > > VT-d enabled, the i915 driver does not work all that great. The most > > obvious problem is that there

Re: [Intel-gfx] [PATCH] drm/i915: Drop runtime-pm assert from vgpu io accessors

2020-10-19 Thread Zhenyu Wang
Hi, Chris Looks this one is still missed to push? Could you help? Thanks On 2020.08.19 16:32:59 +0800, Zhenyu Wang wrote: > > ping for committing? > > On 2020.08.12 10:06:31 +0800, Zhenyu Wang wrote: > > On 2020.08.11 10:25:32 +0100, Chris Wilson wrote: > > > The "mmio" writes into vgpu

Re: [Intel-gfx] [PATCH] drm/i915/gt: Onion unwind for scratch page allocation failure

2020-10-19 Thread Matthew Auld
On 19/10/2020 09:34, Chris Wilson wrote: In switching to using objects for our ppGTT scratch pages, care was not taken to avoid trying to unref NULL objects on failure. And for gen6 ppGTT, it appears we forgot entirely to unwind after a partial allocation failure. Fixes: 89351925a477

Re: [Intel-gfx] [PATCH] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-19 Thread Surendrakumar Upadhyay, TejaskumarX
Hi Jose, I use scripts/checkpatch.pl. And it has reported me following : drm-tip# ./scripts/checkpatch.pl 0001-drm-i915-edp-jsl-Update-vswing-table-for-HBR-and-HBR.patch WARNING: else is not generally useful after a break or return #88: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1222: +

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Remove obj->mm.lock! (rev9)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev9) URL : https://patchwork.freedesktop.org/series/82337/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC [M]

[Intel-gfx] [PATCH] drm/i915/selftests: Flush the old heartbeat more gently

2020-10-19 Thread Chris Wilson
In order to test how fast the heartbeat can respond, we measure with the interval set to its minimum. Before we measure though, we want to be sure we start with a fresh pulse, and so wait until any old one is complete. During that wait though, we were continually flushing the work, and so

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Onion unwind for scratch page allocation failure

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/gt: Onion unwind for scratch page allocation failure URL : https://patchwork.freedesktop.org/series/82811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9161_full -> Patchwork_18725_full

[Intel-gfx] [PATCH] drm/i915: Do not share hwsp across contexts any more, v5.

2020-10-19 Thread Maarten Lankhorst
Instead of sharing pages with breadcrumbs, give each timeline a single page. This allows unrelated timelines not to share locks any more during command submission. As an additional benefit, seqno wraparound no longer requires i915_vma_pin, which means we no longer need to worry about a potential

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Onion unwind for scratch page allocation failure

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/gt: Onion unwind for scratch page allocation failure URL : https://patchwork.freedesktop.org/series/82811/ State : success == Summary == CI Bug Log - changes from CI_DRM_9161 -> Patchwork_18725 Summary

[Intel-gfx] [PATCH] drm/i915: Force VT'd workarounds when running as a guest OS

2020-10-19 Thread Chris Wilson
If i915.ko is being used as a passthrough device, it does not know if the host is using intel_iommu. Mixing the iommu and gfx causing a few issues (such as scanout overfetch) which we need to workaround inside the driver, so if we detect we are running under a hypervisor, also assume the device

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP 2.2 DP MST Support (rev3)

2020-10-19 Thread Patchwork
== Series Details == Series: HDCP 2.2 DP MST Support (rev3) URL : https://patchwork.freedesktop.org/series/81538/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] [PATCH v5.1] drm/i915: Do not share hwsp across contexts any more, v5.

2020-10-19 Thread Maarten Lankhorst
Instead of sharing pages with breadcrumbs, give each timeline a single page. This allows unrelated timelines not to share locks any more during command submission. As an additional benefit, seqno wraparound no longer requires i915_vma_pin, which means we no longer need to worry about a potential

Re: [Intel-gfx] [PATCH 2/2] drm/i915: s/intel_dp_sink_dpms/intel_dp_set_power/

2020-10-19 Thread Imre Deak
On Fri, Oct 16, 2020 at 10:48:00PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename intel_dp_sink_dpms() to intel_dp_set_power() > so one doesn't always have to convert from the DPMS > enum values to the actual DP D-states. > > Also when dealing with a branch device this has nothing

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Flush the old heartbeat more gently (rev2)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush the old heartbeat more gently (rev2) URL : https://patchwork.freedesktop.org/series/82815/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9162_full -> Patchwork_18731_full

Re: [Intel-gfx] [PATCH v10 07/11] drm/i915: Make hardware readout work on i915.

2020-10-19 Thread Ville Syrjälä
On Thu, Oct 08, 2020 at 02:45:31PM -0700, Manasi Navare wrote: > From: Maarten Lankhorst > > Unfortunately I have no way to test this, but it should be correct > if the bios sets up bigjoiner in a sane way. > > Skip iterating over bigjoiner slaves, only the master has the state we > care about.

Re: [Intel-gfx] [PATCH] drm/i915: Rate limit 'Fault errors' message

2020-10-19 Thread Stefan Fritsch
I think we should do both. Any log message that can be triggered 50 times per second in practice should be rate limited. Also, the rate limiting is probably a candidate for backporting to stable kernels while the real fix may be not. PS: See also my other mail about "drm/i915: Detecting Vt-d

Re: [Intel-gfx] [PATCH] arch: um: convert tasklets to use new tasklet_setup() API

2020-10-19 Thread Anton Ivanov
On 17/08/2020 10:15, Allen Pais wrote: From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier

Re: [Intel-gfx] [PATCH] drm/i915: Force VT'd workarounds when running as a guest OS

2020-10-19 Thread Stefan Fritsch
Works for me and makes the fault messages disappear. Thanks. Tested-by: Stefan Fritsch On Mon, 19 Oct 2020, Chris Wilson wrote: > If i915.ko is being used as a passthrough device, it does not know if > the host is using intel_iommu. Mixing the iommu and gfx causing a few > issues (such as

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do drm_mode_config_reset() after HPD init

2020-10-19 Thread Imre Deak
On Tue, Oct 06, 2020 at 09:58:08PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > LSPCON requires HPD detection logic to be enabled when we call > its .reset() hook during resume, to check the live state of the > pin. To that end let's reorder the resume sequence such that > we do HPD

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: s/pipe/transcoder/ when dealing with PIPECONF/TRANSCONF

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: s/pipe/transcoder/ when dealing with PIPECONF/TRANSCONF URL : https://patchwork.freedesktop.org/series/82831/ State : success == Summary == CI Bug Log - changes from CI_DRM_9162 -> Patchwork_18732

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move the lspcon resume from .reset() to intel_dp_sink_dpms()

2020-10-19 Thread Imre Deak
On Mon, Oct 19, 2020 at 06:34:34PM +0300, Ville Syrjälä wrote: > On Mon, Oct 19, 2020 at 06:27:01PM +0300, Imre Deak wrote: > > On Fri, Oct 16, 2020 at 10:47:59PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Rather that try to trick LSPCON back into PCON mode from the

Re: [Intel-gfx] USB-C DP mode problem on linux

2020-10-19 Thread Heikki Krogerus
Hi Andrzej, On Sat, Oct 17, 2020 at 01:34:54PM +0200, Andrzej Kre wrote: > Hi, > > I know that You were involved in working on USB-C DP drivers. > You are my last chance to resolve my issue. > > On my HP laptop I have Intel UHD Graphics 620. > When I'm connecting my 4K monitor to Display Port.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move the lspcon resume from .reset() to intel_dp_sink_dpms()

2020-10-19 Thread Imre Deak
On Fri, Oct 16, 2020 at 10:47:59PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Rather that try to trick LSPCON back into PCON mode from the .reset() > hook let's just do that as a regular part of the normal modeset > sequence, which is going to take care of the system resume case.

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-19 Thread Imre Deak
On Tue, Oct 13, 2020 at 09:11:37PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we call .hpd_irq_setup() directly just before display > resume, and follow it with another call via intel_hpd_init() > just afterwards. Assuming the hpd pins are marked as enabled > during the

Re: [Intel-gfx] [PATCH v10 09/11] drm/i915: Add bigjoiner aware plane clipping checks

2020-10-19 Thread Ville Syrjälä
On Thu, Oct 08, 2020 at 02:45:33PM -0700, Manasi Navare wrote: > From: Maarten Lankhorst > > We need to look at hw.fb for the framebuffer, and add the translation > for the slave_plane_state. With these changes we set the correct > rectangle on the bigjoiner slave, and don't set incorrect >

Re: [Intel-gfx] [PATCH v10 04/11] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-10-19 Thread Ville Syrjälä
On Thu, Oct 15, 2020 at 09:26:45AM -0700, Navare, Manasi wrote: > On Thu, Oct 15, 2020 at 02:52:47PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 14, 2020 at 12:04:10PM -0700, Navare, Manasi wrote: > > > On Wed, Oct 14, 2020 at 02:26:34PM +0300, Ville Syrjälä wrote: > > > > On Thu, Oct 08, 2020 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove obj->mm.lock! (rev10)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev10) URL : https://patchwork.freedesktop.org/series/82337/ State : success == Summary == CI Bug Log - changes from CI_DRM_9162 -> Patchwork_18730 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915: s/pipe/transcoder/ when dealing with PIPECONF/TRANSCONF

2020-10-19 Thread Ville Syrjala
From: Ville Syrjälä PIPECONF becamse TRANSCONF when HSW introduced the EDP transcoder. Bigjoiner is making life even more confusing by introducing a N:1 relationship between pipes and transcoders. In that case we only enable/configure the transcoder corresponding to the master pipe. Let's do

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do drm_mode_config_reset() after HPD init

2020-10-19 Thread Ville Syrjälä
On Mon, Oct 19, 2020 at 06:39:59PM +0300, Imre Deak wrote: > On Tue, Oct 06, 2020 at 09:58:08PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > LSPCON requires HPD detection logic to be enabled when we call > > its .reset() hook during resume, to check the live state of the > > pin.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev10)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev10) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim checkpatch origin/drm-tip f559c8e6c1e1 drm/i915: Move cmd parser pinning to execbuffer fd1c6790339e drm/i915: Add missing -EDEADLK

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Remove obj->mm.lock! (rev10)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev10) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww'

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove obj->mm.lock! (rev10)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev10) URL : https://patchwork.freedesktop.org/series/82337/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Force VT'd workarounds when running as a guest OS (rev2)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Force VT'd workarounds when running as a guest OS (rev2) URL : https://patchwork.freedesktop.org/series/82814/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9162_full -> Patchwork_18726_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Flush the old heartbeat more gently (rev2)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush the old heartbeat more gently (rev2) URL : https://patchwork.freedesktop.org/series/82815/ State : success == Summary == CI Bug Log - changes from CI_DRM_9162 -> Patchwork_18731

Re: [Intel-gfx] [PATCH] drm/i915/display: Program DBUF_CTL tracker state service

2020-10-19 Thread Matt Roper
On Fri, Oct 16, 2020 at 01:18:37PM -0700, José Roberto de Souza wrote: > This sequence is not part of "Sequences to Initialize Display" but > as noted in the MBus page the DBUF_CTL.Tracker_state_service needs > to be set to 8. > > BSpec: 49213 > Signed-off-by: José Roberto de Souza > --- >

[Intel-gfx] [PATCH v2] drm/i915/selftests: Flush the old heartbeat more gently

2020-10-19 Thread Chris Wilson
In order to test how fast the heartbeat can respond, we measure with the interval set to its minimum. Before we measure though, we want to be sure we start with a fresh pulse, and so wait until any old one is complete. During that wait though, we were continually flushing the work, and so

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove obj->mm.lock! (rev10)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove obj->mm.lock! (rev10) URL : https://patchwork.freedesktop.org/series/82337/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9162_full -> Patchwork_18730_full Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move the lspcon resume from .reset() to intel_dp_sink_dpms()

2020-10-19 Thread Ville Syrjälä
On Mon, Oct 19, 2020 at 06:27:01PM +0300, Imre Deak wrote: > On Fri, Oct 16, 2020 at 10:47:59PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Rather that try to trick LSPCON back into PCON mode from the .reset() > > hook let's just do that as a regular part of the normal modeset >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Onion unwind for scratch page allocation failure

2020-10-19 Thread Tang, CQ
I fixed this problem partially (not gen6 code) with patch: http://intel-gfx-pw.fi.intel.com/series/5911/ Should I continue to fix on internal? --CQ > -Original Message- > From: Intel-gfx On Behalf Of > Chris Wilson > Sent: Monday, October 19, 2020 1:35 AM > To:

Re: [Intel-gfx] [PATCH v10 10/11] drm/i915: Ensure correct master/slave enable/disable sequence

2020-10-19 Thread Ville Syrjälä
On Thu, Oct 08, 2020 at 02:45:34PM -0700, Manasi Navare wrote: > From: Maarten Lankhorst > > Enabling is done in a special sequence and so should plane updates > be. Ideally the end user never notices the second pipe is used. > > This way ideally everything will be tear free, and updates are >

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: Reorder hpd init vs. display resume

2020-10-19 Thread Lyude Paul
Reviewed-by: Lyude Paul On Tue, 2020-10-13 at 21:11 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we call .hpd_irq_setup() directly just before display > resume, and follow it with another call via intel_hpd_init() > just afterwards. Assuming the hpd pins are marked as

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gem: Poison stolen pages before use

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Poison stolen pages before use URL : https://patchwork.freedesktop.org/series/82834/ State : success == Summary == CI Bug Log - changes from CI_DRM_9163 -> Patchwork_18733

Re: [Intel-gfx] [PATCH] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-19 Thread Souza, Jose
Yes On Mon, 2020-10-19 at 18:13 +, Surendrakumar Upadhyay, TejaskumarX wrote: > Hi Jose, > > root@tejas-System-Product-Name:/home/tejas/all-external/drm-tip# ./dim > checkpatch > a11736f058e7 (HEAD -> latest) drm/i915/edp/jsl: Update vswing table for HBR > and HBR2 > -:58:

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-10-19 Thread Chris Wilson
Quoting Rodrigo Vivi (2020-10-19 19:29:36) > > I just checked the CI picture and it looks much better indeed. > > Only bad case being the gt_pm, which is also failing on other platforms. Not nearly in the same manner. CI is indicating that there is no RC6 entry and no power saving at all;

Re: [Intel-gfx] [PATCH] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-19 Thread Souza, Jose
I don't think that checkpatch.pl has all the style rules that we follow in drm. Check the output of "✗ Fi.CI.CHECKPATCH: warning for drm/i915/edp/jsl: Update vswing table for HBR and HBR2 (rev2)" there more style errors than that. On Mon, 2020-10-19 at 11:08 +, Surendrakumar Upadhyay,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gem: Poison stolen pages before use

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Poison stolen pages before use URL : https://patchwork.freedesktop.org/series/82834/ State : warning == Summary == $ dim checkpatch origin/drm-tip 650f2e2f5bdd drm/i915/gem: Poison stolen pages before use -:38:

[Intel-gfx] Fixes that failed cherry-pick to 5.10

2020-10-19 Thread Rodrigo Vivi
Hi Chris and Ville, Failed to cherry-pick: 233c1ae3c83f ("drm/i915/gt: Wait for CSB entries on Tigerlake") 2c1e63bab430 ("drm/i915: Mark initial fb obj as WT on eLLC machines to avoid rcu lockup during fbdev init") These patches look important to 5.10. If this is the case, please consider

Re: [Intel-gfx] [PATCH] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-19 Thread Surendrakumar Upadhyay, TejaskumarX
Hi Jose, root@tejas-System-Product-Name:/home/tejas/all-external/drm-tip# ./dim checkpatch a11736f058e7 (HEAD -> latest) drm/i915/edp/jsl: Update vswing table for HBR and HBR2 -:58: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #58: FILE:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Program DBUF_CTL tracker state service (rev2)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/display: Program DBUF_CTL tracker state service (rev2) URL : https://patchwork.freedesktop.org/series/82785/ State : success == Summary == CI Bug Log - changes from CI_DRM_9163 -> Patchwork_18734

Re: [Intel-gfx] Fixes that failed cherry-pick to 5.10

2020-10-19 Thread Chris Wilson
Quoting Rodrigo Vivi (2020-10-19 18:53:10) > Hi Chris and Ville, > > Failed to cherry-pick: > 233c1ae3c83f ("drm/i915/gt: Wait for CSB entries on Tigerlake") See https://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=dif for the dependencies. -Chris ___

Re: [Intel-gfx] Fixes that failed cherry-pick to 5.10

2020-10-19 Thread Rodrigo Vivi
On Mon, Oct 19, 2020 at 07:18:32PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2020-10-19 18:53:10) > > Hi Chris and Ville, > > > > Failed to cherry-pick: > > 233c1ae3c83f ("drm/i915/gt: Wait for CSB entries on Tigerlake") > > See https://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=dif

[Intel-gfx] [PATCH] drm/i915/display/fbc: Implement WA 22010751166

2020-10-19 Thread José Roberto de Souza
Underruns happens when plane height + y offset is not a module of 4 when FBC is enabled. Specification says that it only affects TGL display C stepping and newer but to simply the check and as TGL is already in final costumers hands, pre-production display stepping A and B was also included.

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-10-19 Thread Rodrigo Vivi
I just checked the CI picture and it looks much better indeed. Only bad case being the gt_pm, which is also failing on other platforms. So, Acked-by: Rodrigo Vivi On Thu, Oct 15, 2020 at 08:41:32AM +, K, SrinivasX wrote: > Hi Hariom, > > With Sunil's help was able to see EHL

Re: [Intel-gfx] [PATCH] drm/i915/jsl: Remove require_force_probe protection

2020-10-19 Thread Rodrigo Vivi
On Thu, Oct 15, 2020 at 08:53:08AM +, Kamati Srinivas wrote: > Removing force probe protection from JSL platform. Did > not observe warnings, errors, flickering or any visual > defects while doing ordinary tasks like browsing and > editing documents in a two monitor setup. I'm afraid we first

[Intel-gfx] [PATCH 1/2] drm/i915/gem: Poison stolen pages before use

2020-10-19 Thread Chris Wilson
When allocating objects from stolen, memset() the backing store to POISON_INUSE (0x5a) to help identify any uninitialised use of a stolen object. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 45 ++ 1 file changed,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/gem: Poison stolen pages before use

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Poison stolen pages before use URL : https://patchwork.freedesktop.org/series/82834/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [PATCH 10/61] drm/i915: Disable userptr pread/pwrite support.

2020-10-19 Thread Ruhl, Michael J
>-Original Message- >From: Maarten Lankhorst >Sent: Monday, October 12, 2020 10:14 AM >To: Ruhl, Michael J ; intel- >g...@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH 10/61] drm/i915: Disable userptr pread/pwrite >support. > >Op 02-10-2020 om 22:14 schreef Ruhl, Michael J: >>>

[Intel-gfx] [PATCH 2/2] drm/i915: Exclude low pages (128KiB) of stolen from use

2020-10-19 Thread Chris Wilson
The GPU is trashing the low pages of its reserved memory upon reset. If we are using this memory for ringbuffers, then we will dutiful resubmit the trashed rings after the reset causing further resets, and worse. We must exclude this range from our own use. The value of 128KiB was found by

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: s/pipe/transcoder/ when dealing with PIPECONF/TRANSCONF

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915: s/pipe/transcoder/ when dealing with PIPECONF/TRANSCONF URL : https://patchwork.freedesktop.org/series/82831/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9162_full -> Patchwork_18732_full

Re: [Intel-gfx] [PATCH] drm/i915/display: Program DBUF_CTL tracker state service

2020-10-19 Thread Souza, Jose
On Mon, 2020-10-19 at 08:31 -0700, Matt Roper wrote: > On Fri, Oct 16, 2020 at 01:18:37PM -0700, José Roberto de Souza wrote: > > This sequence is not part of "Sequences to Initialize Display" but > > as noted in the MBus page the DBUF_CTL.Tracker_state_service needs > > to be set to 8. > > > >

[Intel-gfx] [PATCH CI] drm/i915/display: Program DBUF_CTL tracker state service

2020-10-19 Thread José Roberto de Souza
This sequence is not part of "Sequences to Initialize Display" but as noted in the MBus page the DBUF_CTL.Tracker_state_service needs to be set to 8. BSpec: 49213 Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 14

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/fbc: Implement WA 22010751166

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/display/fbc: Implement WA 22010751166 URL : https://patchwork.freedesktop.org/series/82836/ State : success == Summary == CI Bug Log - changes from CI_DRM_9163 -> Patchwork_18735 Summary ---

[Intel-gfx] [PATCH 4/7] drm/i915: Extract hsw_panel_transcoders()

2020-10-19 Thread Ville Syrjala
From: Ville Syrjälä Extract the "panel transcoder" bitmask into a helper. We'll have a couple of uses for this later. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment URL : https://patchwork.freedesktop.org/series/82848/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Drop one more usless master_transcoder assignment

2020-10-19 Thread Navare, Manasi
On Tue, Oct 20, 2020 at 12:43:31AM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > We dropped the other redundant master_transcoder assignments > earlier, but this one slipped through. Get rid of it as well. > The crtc state gets fully reset before readout so there is > no point in doing

Re: [Intel-gfx] [PATCH v10 07/11] drm/i915: Make hardware readout work on i915.

2020-10-19 Thread Navare, Manasi
On Mon, Oct 19, 2020 at 07:36:59PM +0300, Ville Syrjälä wrote: > On Thu, Oct 08, 2020 at 02:45:31PM -0700, Manasi Navare wrote: > > From: Maarten Lankhorst > > > > Unfortunately I have no way to test this, but it should be correct > > if the bios sets up bigjoiner in a sane way. > > > > Skip

Re: [Intel-gfx] [PATCH v10 04/11] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-10-19 Thread Navare, Manasi
On Mon, Oct 19, 2020 at 07:30:07PM +0300, Ville Syrjälä wrote: > On Thu, Oct 15, 2020 at 09:26:45AM -0700, Navare, Manasi wrote: > > On Thu, Oct 15, 2020 at 02:52:47PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 14, 2020 at 12:04:10PM -0700, Navare, Manasi wrote: > > > > On Wed, Oct 14, 2020 at

Re: [Intel-gfx] [PATCH v10 09/11] drm/i915: Add bigjoiner aware plane clipping checks

2020-10-19 Thread Navare, Manasi
On Mon, Oct 19, 2020 at 07:20:31PM +0300, Ville Syrjälä wrote: > On Thu, Oct 08, 2020 at 02:45:33PM -0700, Manasi Navare wrote: > > From: Maarten Lankhorst > > > > We need to look at hw.fb for the framebuffer, and add the translation > > for the slave_plane_state. With these changes we set the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment URL : https://patchwork.freedesktop.org/series/82848/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5e9c0a3f80bf drm/i915: Drop one more usless

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment URL : https://patchwork.freedesktop.org/series/82848/ State : success == Summary == CI Bug Log - changes from CI_DRM_9165 -> Patchwork_18737

Re: [Intel-gfx] [PATCH v10 06/11] drm/i915: Enable big joiner support in enable and disable sequences.

2020-10-19 Thread Navare, Manasi
On Mon, Oct 19, 2020 at 02:34:07PM +0300, Jani Nikula wrote: > On Fri, 16 Oct 2020, "Navare, Manasi" wrote: > > I really want to push back on any design changes at this point since we > > have a working solution > > and we currently dont have any special cases. Like I discussed with you all > >

Re: [Intel-gfx] [PATCH v10 10/11] drm/i915: Ensure correct master/slave enable/disable sequence

2020-10-19 Thread Navare, Manasi
On Mon, Oct 19, 2020 at 07:26:19PM +0300, Ville Syrjälä wrote: > On Thu, Oct 08, 2020 at 02:45:34PM -0700, Manasi Navare wrote: > > From: Maarten Lankhorst > > > > Enabling is done in a special sequence and so should plane updates > > be. Ideally the end user never notices the second pipe is

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Drop one more usless master_transcoder assignment URL : https://patchwork.freedesktop.org/series/82848/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9165_full -> Patchwork_18737_full

Re: [Intel-gfx] [PATCH] drm/i915: Force VT'd workarounds when running as a guest OS

2020-10-19 Thread Zhenyu Wang
On 2020.10.19 11:15:23 +0100, Chris Wilson wrote: > If i915.ko is being used as a passthrough device, it does not know if > the host is using intel_iommu. Mixing the iommu and gfx causing a few > issues (such as scanout overfetch) which we need to workaround inside > the driver, so if we detect we

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/gem: Poison stolen pages before use

2020-10-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Poison stolen pages before use URL : https://patchwork.freedesktop.org/series/82834/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9163_full -> Patchwork_18733_full

Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Implement WA 22010751166

2020-10-19 Thread Matt Roper
On Mon, Oct 19, 2020 at 10:56:09AM -0700, José Roberto de Souza wrote: > Underruns happens when plane height + y offset is not a module of 4 I think you meant 'modulo' rather than 'module' here. > when FBC is enabled. Technically the workaround calls for us to just do our FBC disables for

[Intel-gfx] [PATCH] drm/i915/gem: Flush coherency domains on first set-domain-ioctl

2020-10-19 Thread Chris Wilson
Avoid skipping what appears to be a no-op set-domain-ioctl if the cache coherency state is inconsistent with our target domain. This also has the utility of using the population of the pages to validate the backing store. The danger in skipping the first set-domain is leaving the cache

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Program DBUF_CTL tracker state service (rev2)

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/display: Program DBUF_CTL tracker state service (rev2) URL : https://patchwork.freedesktop.org/series/82785/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9163_full -> Patchwork_18734_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Flush coherency domains on first set-domain-ioctl

2020-10-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Flush coherency domains on first set-domain-ioctl URL : https://patchwork.freedesktop.org/series/82843/ State : success == Summary == CI Bug Log - changes from CI_DRM_9165 -> Patchwork_18736

[Intel-gfx] [PATCH 1/7] drm/i915: Drop one more usless master_transcoder assignment

2020-10-19 Thread Ville Syrjala
From: Ville Syrjälä We dropped the other redundant master_transcoder assignments earlier, but this one slipped through. Get rid of it as well. The crtc state gets fully reset before readout so there is no point in doing this. Signed-off-by: Ville Syrjälä ---

  1   2   >