Re: [Intel-gfx] [PATCH 01/15] dmr: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > Could you please fix the subject, changing dmr to drm? > Ups! Sure, I'll fix that. Thanks for noticing. > > I think you can just reuse 'ret' instead of creating a new variable. That > ensures if the lock fails we return the error from the macros. > I didn't reuse "ret" because otherwise

Re: [Intel-gfx] [PATCH 12/15] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > int i; > > + int ret; > > Please move up with i Done! > > + DRM_MODESET_LOCK_ALL_END((_priv->drm), ctx, ret); > > > > return 0; > > Return ret here Done! > > + struct drm_modeset_acquire_ctx ctx; > > int i; > > + int ret; > > Please move up with i Done! > > -

[Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-17 Thread Matthew Brost
From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (with init_netconsole() hacked to call i915_init() when logging

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller URL : https://patchwork.freedesktop.org/series/94826/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21093 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make wa list per-gt (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Make wa list per-gt (rev2) URL : https://patchwork.freedesktop.org/series/94811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21091_full Summary ---

[Intel-gfx] [CI 2/4] drm/i915: rename debugfs_engines files

2021-09-17 Thread Lucas De Marchi
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_engines.[ch] to intel_gt_engines_debugfs.[ch] and then make functions, defines and structs follow suit. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula Reviewed-by: Matt Roper ---

[Intel-gfx] [CI 4/4] drm/i915: deduplicate frequency dump on debugfs

2021-09-17 Thread Lucas De Marchi
Although commit 9dd4b065446a ("drm/i915/gt: Move pm debug files into a gt aware debugfs") says it was moving debug files to gt/, the i915_frequency_info file was left behind and its implementation copied into drivers/gpu/drm/i915/gt/debugfs_gt_pm.c. Over time we had several patches having to

[Intel-gfx] [CI 1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Lucas De Marchi
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, defines and structs follow suit. While at it and since we are renaming the header, sort the includes alphabetically. Signed-off-by: Lucas De Marchi Acked-by:

[Intel-gfx] [CI 3/4] drm/i915: rename debugfs_gt_pm files

2021-09-17 Thread Lucas De Marchi
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt_pm.[ch] to intel_gt_pm_debugfs.[ch] and then make functions, defines and structs follow suit. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: rename debugfs_gt files URL : https://patchwork.freedesktop.org/series/94827/ State : warning == Summary == $ dim checkpatch origin/drm-tip b981772f1a36 drm/i915: rename debugfs_gt files -:170: WARNING:FILE_PATH_CHANGES:

[Intel-gfx] [PATCH v10 10/17] drm/i915/pxp: interfaces for using protected objects

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio This api allow user mode to create protected buffers and to mark contexts as making use of such objects. Only when using contexts marked in such a way is the execution guaranteed to work as expected. Contexts can only be marked as using protected content at creation

[Intel-gfx] [PATCH v10 07/17] drm/i915/pxp: Create the arbitrary session after boot

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation.

[Intel-gfx] [PATCH v10 17/17] drm/i915/pxp: enable PXP for integrated Gen12

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Note that discrete cards can support PXP as well, but we haven't tested on those yet so keeping it disabled for now. Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff

[Intel-gfx] [PATCH v10 02/17] mei: pxp: export pavp client to me client bus

2021-09-17 Thread Alan Previn
From: Vitaly Lubart Export PAVP client to work with i915 driver, for binding it uses kernel component framework. v2:drop debug prints, refactor match code to match mei_hdcp (Tomas) Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Reviewed-by:

[Intel-gfx] [PATCH v10 14/17] drm/i915/pxp: black pixels on pxp disabled

2021-09-17 Thread Alan Previn
From: Anshuman Gupta When protected sufaces has flipped and pxp session is disabled, display black pixels by using plane color CTM correction. v2: - Display black pixels in async flip too. v3: - Removed the black pixels logic for async flip. [Ville] - Used plane state to force black pixels.

[Intel-gfx] [PATCH v10 13/17] drm/i915/pxp: Add plane decryption support

2021-09-17 Thread Alan Previn
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PXP session is enabled. 2. Buffer object is protected. v2: - Used gen fb obj user_flags instead gem_object_metadata.

[Intel-gfx] [PATCH v10 11/17] drm/i915/pxp: start the arb session on demand

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Now that we can handle destruction and re-creation of the arb session, we can postpone the start of the session to the first submission that requires it, to avoid keeping it running with no user. Signed-off-by: Alan Previn Signed-off-by: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v10 12/17] drm/i915/pxp: Enable PXP power management

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the session state might still be marked as alive after resume. Therefore, we should consider the session as dead on suspend and invalidate all the

[Intel-gfx] [PATCH v10 16/17] drm/i915/pxp: add PXP documentation

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Now that all the pieces are in place we can add a description of how the feature works. Also modify the comments in struct intel_pxp into kerneldoc. v2: improve doc (Rodrigo) Signed-off-by: Daniele Ceraolo Spurio Cc: Daniel Vetter Cc: Rodrigo Vivi Reviewed-by:

[Intel-gfx] [PATCH v10 15/17] drm/i915/pxp: add pxp debugfs

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio 2 debugfs files, one to query the current status of the pxp session and one to trigger an invalidation for testing. v2: rename debugfs, fix date (Alan) Signed-off-by: Daniele Ceraolo Spurio Reviewed-by : Alan Previn Reviewed-by: Alan Previn ---

[Intel-gfx] [PATCH v10 08/17] drm/i915/pxp: Implement arb session teardown

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. Additionally, we want to emit a teardown operation to make sure we're clean on boot and resume v2: emit in

[Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" The HW will generate a teardown interrupt when session termination is required, which requires i915 to submit a terminating batch. Once the HW is done with the termination it will generate another interrupt, at which point it is safe to re-create the session. Since the

Re: [Intel-gfx] [PATCH 06/15] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > int err = 0; > > + int ret; > > You can use err here instead. Done!

Re: [Intel-gfx] [PATCH 13/19] drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Lucas De Marchi
On Mon, Apr 12, 2021 at 10:05:20AM +0100, Matthew Auld wrote: From: Clint Taylor Read OPROM SPI through MMIO and find VBT entry since we can't use OpRegion and PCI mapping may not work on some systems due to the BIOS not leaving the Option ROM mapped. I was surprised to see we still don't

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev3) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21094 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization

2021-09-17 Thread Lucas De Marchi
On Mon, May 17, 2021 at 02:57:33PM +0300, Jani Nikula wrote: On Mon, 12 Apr 2021, Matthew Auld wrote: From: Anshuman Gupta Sanitize OPROM header, CPD signature and OPROM PCI version. OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB structures and PCI struct offsets are provided by GSC

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load URL : https://patchwork.freedesktop.org/series/94819/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21087

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Patchwork
== Series Details == Series: 5.15-rc1 i915 blank screen booting on ThinkPads URL : https://patchwork.freedesktop.org/series/94820/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a23b1f1e8f8 5.15-rc1 i915 blank screen booting on ThinkPads -:7: WARNING:COMMIT_LOG_LONG_LINE:

Re: [Intel-gfx] [PATCH 15/15] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup

2021-09-17 Thread Fernando Ramos
> Can we remove drm_modeset_lock_all[_ctx] now? If so, let's queue that up as > part > of the set. > drm_modeset_lock_all() and drm_modeset_unlock_all() can be removed (I'll do that on v2 of this patch series). drm_modset_lock_all_ctx() is a different story and there are still two places (one

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix blank screen booting crashes (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: fix blank screen booting crashes (rev2) URL : https://patchwork.freedesktop.org/series/94822/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21092 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Check SFC fusing on Xe_HP (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev3) URL : https://patchwork.freedesktop.org/series/94808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./include/uapi/drm/i915_drm.h:1904: warning: This comment starts with '/**', but isn't a

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-17 Thread Souza, Jose
On Fri, 2021-09-17 at 20:49 +0300, Ville Syrjälä wrote: > On Fri, Sep 17, 2021 at 05:02:21PM +, Souza, Jose wrote: > > On Fri, 2021-09-17 at 16:04 +0300, Ville Syrjälä wrote: > > > On Thu, Sep 16, 2021 at 05:09:08PM +, Souza, Jose wrote: > > > > On Thu, 2021-09-16 at 16:17 +0300, Ville

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Check SFC fusing on Xe_HP (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev2) URL : https://patchwork.freedesktop.org/series/94808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev2) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21090 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix blank screen booting crashes (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: fix blank screen booting crashes (rev2) URL : https://patchwork.freedesktop.org/series/94822/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21092_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load URL : https://patchwork.freedesktop.org/series/94819/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21087_full

[Intel-gfx] [PATCH] drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Lucas De Marchi
From: Clint Taylor Read OPROM SPI through MMIO and find VBT entry since we can't use OpRegion and PCI mapping may not work on some systems due to most BIOSes not leaving the Option ROM mapped. Cc: Ville Syrjälä Cc: Tomas Winkler Signed-off-by: Clint Taylor Signed-off-by: Lucas De Marchi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: rename debugfs_gt files URL : https://patchwork.freedesktop.org/series/94827/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21095

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3) URL : https://patchwork.freedesktop.org/series/94721/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21088

[Intel-gfx] ✓ Fi.CI.BAT: success for 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Patchwork
== Series Details == Series: 5.15-rc1 i915 blank screen booting on ThinkPads URL : https://patchwork.freedesktop.org/series/94820/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21089 Summary ---

Re: [Intel-gfx] [PATCH 09/15] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > - drm_modeset_unlock_all(fb->dev); > > + DRM_MODESET_LOCK_ALL_END(fb->dev, ctx, ret); > > > > return 0; > > Return ret here. Done!

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make wa list per-gt (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Make wa list per-gt (rev2) URL : https://patchwork.freedesktop.org/series/94811/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21091 Summary --- **WARNING**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH 08/15] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > + struct drm_modeset_acquire_ctx ctx; > > int i, r; > > + int ret; > > Could you please tuck this up with i & r? Done! > > - drm_modeset_unlock_all(dev); > > + DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); > > You should check ret here Would it be save to return at this point if

[Intel-gfx] ✗ Fi.CI.IGT: failure for 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Patchwork
== Series Details == Series: 5.15-rc1 i915 blank screen booting on ThinkPads URL : https://patchwork.freedesktop.org/series/94820/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21089_full Summary

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Hugh Dickins
On Thu, 16 Sep 2021, Jani Nikula wrote: > On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: > > On 16/09/2021 05:37, Hugh Dickins wrote: > >> Two Lenovo ThinkPads, old T420s (2011), newer X1 Carbon 5th gen (2017): > >> i915 working fine on both up to 5.14, but blank screens booting 5.15-rc1, > >> kernel

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : warning == Summary == $ dim checkpatch origin/drm-tip e27175183684 drm/i915/pxp: Define PXP component interface -:31: WARNING:FILE_PATH_CHANGES: added, moved or

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Matthew Brost
On Fri, Sep 17, 2021 at 02:26:48PM -0700, Hugh Dickins wrote: > On Thu, 16 Sep 2021, Jani Nikula wrote: > > On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: > > > On 16/09/2021 05:37, Hugh Dickins wrote: > > >> Two Lenovo ThinkPads, old T420s (2011), newer X1 Carbon 5th gen (2017): > > >> i915 working

Re: [Intel-gfx] [PATCH 00/15] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-09-17 Thread Fernando Ramos
On 21/09/17 05:24PM, Daniel Vetter wrote: > > Can we at least replace those with drm_modeset_lock_all_ctx and delete > drm_modeset_lock_all? That would be really nice goal to make sure these > don't spread further. I just checked and turns out no one else is using "drm_modeset_lock_all()"

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3) URL : https://patchwork.freedesktop.org/series/94721/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21088_full

[Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-17 Thread Matthew Brost
From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (with init_netconsole() hacked to call i915_init() when logging

[Intel-gfx] [PATCH v10 03/17] drm/i915/pxp: define PXP device flag and kconfig

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Ahead of the PXP implementation, define the relevant define flag and kconfig option. v2: flip kconfig default to N. Some machines have IFWIs that do not support PXP, so we need it to be an opt-in until we add support to query the caps from the mei device.

[Intel-gfx] [PATCH v10 06/17] drm/i915/pxp: set KCR reg init

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio The setting is required by hardware to allow us doing further protection operation such as sending commands to GPU or TEE. The register needs to be re-programmed on resume, so for simplicitly we bundle the programming with the component binding, which is

[Intel-gfx] [PATCH v10 05/17] drm/i915/pxp: Implement funcs to create the TEE channel

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (default) session. v2: fix locking, don't pollute dev_priv (Chris) v3: wait for mei PXP component to be bound. v4: drop the wait, as the

[Intel-gfx] [PATCH v10 01/17] drm/i915/pxp: Define PXP component interface

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio This will be used for communication between the i915 driver and the mei one. Defining it in a stand-alone patch to avoid circualr dependedencies between the patches modifying the 2 drivers. Split out from an original patch from Huang, Sean Z v2: rename the

[Intel-gfx] [PATCH v10 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio The context is required to send the session termination commands to the VCS, which will be implemented in a follow-up patch. We can also use the presence of the context as a check of pxp initialization completion. v2: use perma-pinned context (Chris) v3: rename

[Intel-gfx] [PATCH v10 00/17] drm/i915: Introduce Intel PXP

2021-09-17 Thread Alan Previn
PXP (Protected Xe Path) is an i915 component, available on GEN12 and newer platforms, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. changes from v9: - Patch #3 - change comments from "Gen12+" to "Gen12 and

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: rename debugfs_gt files URL : https://patchwork.freedesktop.org/series/94827/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21095_full

Re: [Intel-gfx] [PATCH 11/15] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > int i, out_width; > > + int ret; > > Please put ret with i & out_width Done! > > - drm_modeset_unlock_all(crtc->dev); > > + DRM_MODESET_LOCK_ALL_END(crtc->dev, ctx, ret); > > > > return 0; > > Return ret here Done!

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Jani Nikula
On Fri, 17 Sep 2021, Matthew Brost wrote: > On Fri, Sep 17, 2021 at 02:26:48PM -0700, Hugh Dickins wrote: >> On Thu, 16 Sep 2021, Jani Nikula wrote: >> > On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: >> > > On 16/09/2021 05:37, Hugh Dickins wrote: >> > >> Two Lenovo ThinkPads, old T420s (2011),

Re: [Intel-gfx] [PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > + struct drm_modeset_acquire_ctx ctx; > > int r; > > + int ret; > > Relocate ret with r please Done! > > - drm_modeset_unlock_all(dev); > > + DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); > > You should check ret here Done! > > int r; > > + int ret; > > Relocate ret with r

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Matthew Brost
On Sat, Sep 18, 2021 at 01:52:48AM +0300, Jani Nikula wrote: > On Fri, 17 Sep 2021, Matthew Brost wrote: > > On Fri, Sep 17, 2021 at 02:26:48PM -0700, Hugh Dickins wrote: > >> On Thu, 16 Sep 2021, Jani Nikula wrote: > >> > On Thu, 16 Sep 2021, Tvrtko Ursulin > >> > wrote: > >> > > On 16/09/2021

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller URL : https://patchwork.freedesktop.org/series/94826/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4fda5dd183cb drm/i915/dg1: Read OPROM via SPI controller -:63: WARNING:OOM_MESSAGE: Possible unnecessary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21096 Summary --- **SUCCESS**

[Intel-gfx] [kbuild] Re: [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-09-17 Thread Dan Carpenter
Hi Sean, url: https://github.com/0day-ci/linux/commits/Sean-Paul/drm-hdcp-Pull-HDCP-auth-exchange-check-into-helpers/20210916-044145 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-m001-20210916 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22)

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Update to DMC v2.12 for ADLP

2021-09-17 Thread Imre Deak
On Wed, Sep 15, 2021 at 12:14:04AM +, Patchwork wrote: > == Series Details == > > Series: Update to DMC v2.12 for ADLP > URL : https://patchwork.freedesktop.org/series/94675/ > State : failure Thanks for the patch, pushed to drm-intel-next. The failure is on SKL, an unrelated platform. >

Re: [Intel-gfx] [PATCH] drm/i915/dsi: do not register gmbus if it was reserved for MIPI display

2021-09-17 Thread Jani Nikula
On Fri, 17 Sep 2021, Lee Shawn C wrote: > Gmbus driver would setup all Intel i2c GMBuses. But DDC bus > may configured as gpio and reserved for MIPI driver to control > panel power on/off sequence. > > Using i2c tool to communicate to peripherals via i2c interface > reversed for gmbus(DDC). There

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: unregister gmbus if LFP display was MIPI panel (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/dsi: unregister gmbus if LFP display was MIPI panel (rev3) URL : https://patchwork.freedesktop.org/series/94733/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10600_full -> Patchwork_21083_full

Re: [Intel-gfx] [PATCH v2] drm/i915: use strscpy() to avoid buffer overrun

2021-09-17 Thread Tvrtko Ursulin
On 16/09/2021 13:26, Tim Gardner wrote: In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length could save some future grief. CID 93300 (#1 of 1): Copy into fixed size buffer

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

2021-09-17 Thread Petri Latvala
On Thu, Sep 16, 2021 at 10:27:41AM -0700, John Harrison wrote: > On 9/16/2021 01:59, Petri Latvala wrote: > > On Wed, Sep 15, 2021 at 02:55:58PM -0700, john.c.harri...@intel.com wrote: > > > From: Rodrigo Vivi > > > > > > Newer platforms have an embedded table giving details about that > > >

Re: [Intel-gfx] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-17 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:32) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index c8921e2d6480..3ae6fc7a2c01 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3088,7 +3088,9 @@ mdss_dp:

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-09-17 Thread Fernando Ramos
On 21/09/16 11:53PM, Patchwork wrote: > Patch failed at 0012 drm/i915: cleanup: drm_modeset_lock_all() --> > DRM_MODESET_LOCK_ALL_BEGIN() Hi, I created the patch against drm-next (which currently points to ). Am I doing something wrong? Should I be targeting a different commit? Thanks.

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2021-09-17 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 modules_install) failed like this: depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper depmod: ERROR: Cycle detected: cec depmod: ERROR: Found 2 modules in dependency cycles! Caused by commit

Re: [Intel-gfx] [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-17 Thread Cornelia Huck
On Tue, Sep 14 2021, Jason Gunthorpe wrote: > On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: >> > I rebased it and fixed it up here: >> > >> > https://github.com/jgunthorpe/linux/tree/vfio_ccw >> > >> > Can you try again? >> >> That does address the crash, but then why is it

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-17 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 02:10:22PM -0700, Matthew Brost wrote: > On Tue, Sep 14, 2021 at 10:05:03PM +0200, Daniel Vetter wrote: > > On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > > > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > > > On Tue, 14 Sept 2021 at

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Fix g4x cxsr enable condition

2021-09-17 Thread Ville Syrjälä
On Thu, Sep 16, 2021 at 07:24:21PM +0300, Lisovskiy, Stanislav wrote: > On Fri, May 14, 2021 at 03:57:39PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The intention was to check whether the primary plane is enabled > > without any sprites planes being enabled. Instead we ended up

Re: [Intel-gfx] [PATCH v3 10/13] drm/i915/dp: add HAS_DP20 macro

2021-09-17 Thread Ville Syrjälä
On Thu, Sep 09, 2021 at 03:52:02PM +0300, Jani Nikula wrote: > Let's abstract the DP 2.0 feature. Initially just DG2. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Intel-gfx] [PATCH v3 12/13] drm/i915/dg2: configure TRANS_DP2_VFREQ{HIGH, LOW} for 128b/132b

2021-09-17 Thread Ville Syrjälä
On Thu, Sep 09, 2021 at 03:52:04PM +0300, Jani Nikula wrote: > There's a new register pair for 128b/132b mode where you need to set the > pixel clock in Hz. > > v2: Fix UHBR rate check, use intel_dp_is_uhbr() helper > > Bspec: 54128 > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä >

Re: [Intel-gfx] [PATCH 02/26] dma-buf: add dma_resv_for_each_fence

2021-09-17 Thread Daniel Vetter
On Fri, Sep 17, 2021 at 03:27:55PM +0200, Daniel Vetter wrote: > On Fri, Sep 17, 2021 at 02:34:49PM +0200, Christian König wrote: > > A simpler version of the iterator to be used when the dma_resv object is > > locked. > > > > Signed-off-by: Christian König > > --- > >

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-17 Thread Matthew Auld
On 14/09/2021 20:31, Thomas Hellström wrote: Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. Backup is performed in three steps, 1: Opportunistically evict evictable objects using the gpu blitter. 2: After gt idle, evict

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

2021-09-17 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 04:23:26PM -0700, John Harrison wrote: > On 9/14/2021 07:29, Daniel Vetter wrote: > > On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: > > > From: John Harrison > > > > > > When i915 receives a context reset notification from GuC, it triggers > > > an error

Re: [Intel-gfx] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2021-09-17 Thread Jani Nikula
On Wed, 15 Sep 2021, Sean Paul wrote: > From: Sean Paul > > Hello again, > This is the second version of the HDCP helper patchset. See version 1 > here: https://patchwork.freedesktop.org/series/94623/ > > In this second version, I've fixed up the oopsies exposed by 0-day and > yamllint and

Re: [Intel-gfx] [PATCH v3 11/13] drm/i915/dg2: use 128b/132b transcoder DDI mode

2021-09-17 Thread Ville Syrjälä
On Thu, Sep 09, 2021 at 03:52:03PM +0300, Jani Nikula wrote: > 128b/132b has a separate transcoder DDI mode, which also requires the > MST transport select to be set. Note that we'll use DP MST also for > single-stream 128b/132b. > > Having the FDI and 128b/132b modes share the register mode

Re: [Intel-gfx] [PATCH v3 05/13] drm/i915/dg2: add DG2+ TRANS_DDI_FUNC_CTL DP 2.0 128b/132b mode

2021-09-17 Thread Ville Syrjälä
On Thu, Sep 09, 2021 at 03:51:57PM +0300, Jani Nikula wrote: > Unfortunately, the DP 2.0 128b/132b DDI mode selection in the register > conflicts with FDI. Since we have to deal with both meanings in the same > code, for different platforms, clarify the macro name so we don't > forget. > > Bspec:

Re: [Intel-gfx] [PATCH v3 00/13] drm/i915/dp: dp 2.0 enabling prep work

2021-09-17 Thread Jani Nikula
On Thu, 09 Sep 2021, Jani Nikula wrote: > v3 of https://patchwork.freedesktop.org/series/93800/ with minor tweaks > and the already merged patches obviously dropped. > > Jani Nikula (13): > drm/dp: add DP 2.0 UHBR link rate and bw code conversions > drm/dp: use more of the extended receiver

[Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine v2

2021-09-17 Thread Christian König
This is maybe even a fix since the RCU usage here looks incorrect. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-09-17 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c

[Intel-gfx] [PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2

2021-09-17 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 112 + 1 file changed, 40 insertions(+), 72 deletions(-) diff --git

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for lib, stackdepot: check stackdepot handle before accessing slabs (rev3)

2021-09-17 Thread imran . f . khan
Hi, This change is just adding a wrapper function, so it can't cause regression. Could you please let me know if I need to do something in this regard or can it be ignored as false positive. Thanks, Imran On 17/9/21 9:01 am, Patchwork wrote: == Series Details == Series: lib, stackdepot:

[Intel-gfx] [PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-09-17 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 57 1 file

[Intel-gfx] [PATCH 10/26] drm/msm: use new iterator in msm_gem_describe

2021-09-17 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[Intel-gfx] [PATCH 09/26] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-09-17 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index

[Intel-gfx] [PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v2

2021-09-17 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index

[Intel-gfx] [PATCH 24/26] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-09-17 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 29 ++- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index

[Intel-gfx] [PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-09-17 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index

[Intel-gfx] Deploying new iterator interface for dma-buf

2021-09-17 Thread Christian König
Hopefully the last round for this. Added dma_resv_iter_begin/end as requested by Daniel. Fixed a bunch of problems pointed out by the CI systems and found a few more myselve. Please review and/or comment, Christian.

[Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-17 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 32 1 file changed, 11 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH 11/26] drm/radeon: use new iterator in radeon_sync_resv

2021-09-17 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index

[Intel-gfx] [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-09-17 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c

  1   2   >