== Series Details ==
Series: drm/i915/bios: fix slab-out-of-bounds access (rev3)
URL : https://patchwork.freedesktop.org/series/98263/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21893_full
acpi_dev_get_resources() does perform the NULL pointer check against
ACPI companion device which is given as function parameter. Thus,
there is no need to duplicate this check in the caller.
Signed-off-by: Andy Shevchenko
---
v2: used LIST_HEAD() (Ville), initialized lookup directly on stack
On 21/12/2021 22:14, John Harrison wrote:
On 12/21/2021 05:37, Tvrtko Ursulin wrote:
On 20/12/2021 18:34, John Harrison wrote:
On 12/20/2021 07:00, Tvrtko Ursulin wrote:
On 17/12/2021 16:22, Matthew Brost wrote:
On Fri, Dec 17, 2021 at 12:15:53PM +, Tvrtko Ursulin wrote:
On
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects.
URL : https://patchwork.freedesktop.org/series/98306/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dfcddd530d5e drm/i915: Use trylock instead of blocking lock for
On 12/22/21 16:56, Maarten Lankhorst wrote:
Convert free_work into delayed_work, similar to ttm to allow converting the
blocking lock in __i915_gem_free_objects to a trylock.
Unlike ttm, the object should already be idle, as it's kept alive
by a reference through struct i915_vma->active,
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects.
URL : https://patchwork.freedesktop.org/series/98306/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21896
Hi,
On Wed, 22 Dec 2021, Ville Syrjala wrote:
> The silent stream stuff recurses back into i915 audio
> component .get_power() from the .pin_eld_notify() hook.
> On GLK this will deadlock as i915 may already be holding
> the relevant modeset locks during .pin_eld_notify() and
> the GLK audio vs.
== Series Details ==
Series: series starting with [v2,1/1] drm/i915/dsi: Drop double check ACPI
companion device for NULL
URL : https://patchwork.freedesktop.org/series/98304/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21895_full
Ho ho ho!
I don't know if you've been naughty or nice when you get guc submission
locking fixes for christmas, but that's what we have here.
BR,
Jani.
The following changes since commit a7904a538933c525096ca2ccde1e60d0ee62c08e:
Linux 5.16-rc6 (2021-12-19 14:14:33 -0800)
are available in
From: Ville Syrjälä
The silent stream stuff recurses back into i915 audio
component .get_power() from the .pin_eld_notify() hook.
On GLK this will deadlock as i915 may already be holding
the relevant modeset locks during .pin_eld_notify() and
the GLK audio vs. CDCLK workaround will try to grab
== Series Details ==
Series: drm/i915: Extend parse_ddi_port() to all g4x+ platforms (rev2)
URL : https://patchwork.freedesktop.org/series/98183/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21897
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects.
URL : https://patchwork.freedesktop.org/series/98306/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21896_full
On Fri, Dec 17, 2021 at 05:54:03PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Lots of machines these days seem to have a crappy type1 DP dual
> mode adaptor chip slapped onto the motherboard. Based on the
> DP dual mode spec we currently limit those to 165MHz max TMDS
> clock.
>
>
Ping?
Main two points being:
1) Commit message seems in contradiction with the change in
guc_flush_destroyed_contexts. And the lock drop to immediately
re-acquire it looks questionable to start with.
2) And in deregister_destroyed_contexts and in 1) I was therefore asking
if you can
== Series Details ==
Series: ALSA: hda/hdmi: Disable silent stream on GLK
URL : https://patchwork.freedesktop.org/series/98302/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21894
Summary
---
== Series Details ==
Series: ALSA: hda/hdmi: Disable silent stream on GLK
URL : https://patchwork.freedesktop.org/series/98302/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21894_full
Summary
== Series Details ==
Series: series starting with [v2,1/1] drm/i915/dsi: Drop double check ACPI
companion device for NULL
URL : https://patchwork.freedesktop.org/series/98304/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21895
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects.
URL : https://patchwork.freedesktop.org/series/98306/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
On 12/22/2021 08:21, Tvrtko Ursulin wrote:
On 21/12/2021 22:14, John Harrison wrote:
On 12/21/2021 05:37, Tvrtko Ursulin wrote:
On 20/12/2021 18:34, John Harrison wrote:
On 12/20/2021 07:00, Tvrtko Ursulin wrote:
On 17/12/2021 16:22, Matthew Brost wrote:
On Fri, Dec 17, 2021 at 12:15:53PM
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects. (rev2)
URL : https://patchwork.freedesktop.org/series/98306/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11028_full -> Patchwork_21898_full
== Series Details ==
Series: drm/i915/guc: Use lockless list for destroyed contexts
URL : https://patchwork.freedesktop.org/series/98316/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Mon, Dec 06, 2021 at 12:01:04PM -0800, John Harrison wrote:
> On 11/11/2021 13:20, Matthew Brost wrote:
> > A weak implementation of parallel submission (multi-bb execbuf IOCTL) for
> > execlists. Doing as little as possible to support this interface for
> > execlists - basically just passing
== Series Details ==
Series: drm/i915/guc: Use lockless list for destroyed contexts
URL : https://patchwork.freedesktop.org/series/98316/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dc0006ee6d95 drm/i915/guc: Use lockless list for destroyed contexts
-:84:
Convert free_work into delayed_work, similar to ttm to allow converting the
blocking lock in __i915_gem_free_objects to a trylock.
Unlike ttm, the object should already be idle, as it's kept alive
by a reference through struct i915_vma->active, which is dropped
after all vma's are idle.
Because
From: Ville Syrjälä
Lots of machines these days seem to have a crappy type1 DP dual
mode adaptor chip slapped onto the motherboard. Based on the
DP dual mode spec we currently limit those to 165MHz max TMDS
clock.
Windows OTOH ignores DP dual mode adaptors when the VBT
indicates that the port
On Wed, Dec 22, 2021 at 06:34:54PM -, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [v2,1/1] drm/i915/dsi: Drop double check ACPI
> companion device for NULL
> URL : https://patchwork.freedesktop.org/series/98304/
> State : failure
I couldn't see how even
== Series Details ==
Series: drm/i915: Extend parse_ddi_port() to all g4x+ platforms (rev2)
URL : https://patchwork.freedesktop.org/series/98183/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21897_full
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects. (rev2)
URL : https://patchwork.freedesktop.org/series/98306/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects. (rev2)
URL : https://patchwork.freedesktop.org/series/98306/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ecd390fa7a1b drm/i915: Use trylock instead of blocking lock for
== Series Details ==
Series: drm/i915/guc: Use lockless list for destroyed contexts
URL : https://patchwork.freedesktop.org/series/98316/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11029 -> Patchwork_21900
Summary
On Wed, Dec 22, 2021 at 04:25:13PM +, Tvrtko Ursulin wrote:
>
> Ping?
>
Missed this.
This was merged before your comments landed on the list.
> Main two points being:
>
> 1) Commit message seems in contradiction with the change in
> guc_flush_destroyed_contexts. And the lock drop to
Michal, WRT below, feedback from other developers is match spec names.
(i.e. means other struct names introduced in the series needs minor touch-ups).
>
> /* Capture-types of GuC capture register lists */ -enum
> +enum guc_capture_owner
> {
> GUC_CAPTURE_LIST_INDEX_PF = 0,
>
== Series Details ==
Series: drm/i915/execlists: Weak parallel submission support for execlists
(rev3)
URL : https://patchwork.freedesktop.org/series/96088/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11029 -> Patchwork_21899
== Series Details ==
Series: drm/i915: Use trylock instead of blocking lock for
__i915_gem_free_objects. (rev2)
URL : https://patchwork.freedesktop.org/series/98306/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11028 -> Patchwork_21898
On 12/22/2021 15:29, Matthew Brost wrote:
Use a lockless list structure for destroyed contexts to avoid hammering
on global submission spin lock.
I thought the guidance was that lockless anything without an explanation
longer than War And Peace comes with an automatic termination penalty?
On 12/22/2021 14:35, Matthew Brost wrote:
A weak implementation of parallel submission (multi-bb execbuf IOCTL) for
execlists. Doing as little as possible to support this interface for
execlists - basically just passing submit fences between each request
generated and virtual engines are not
From: John Harrison
Don't silently drop reset notifications from the GuC. It might not be
safe to do an error capture but we still want some kind of report that
the reset happened.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +
1 file changed, 5
On Wed, Dec 22, 2021 at 04:48:36PM -0800, John Harrison wrote:
> On 12/22/2021 15:29, Matthew Brost wrote:
> > Use a lockless list structure for destroyed contexts to avoid hammering
> > on global submission spin lock.
> I thought the guidance was that lockless anything without an explanation
>
== Series Details ==
Series: drm/i915/execlists: Weak parallel submission support for execlists
(rev3)
URL : https://patchwork.freedesktop.org/series/96088/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11029_full -> Patchwork_21899_full
== Series Details ==
Series: drm/i915/guc: Report error on invalid reset notification
URL : https://patchwork.freedesktop.org/series/98324/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11031 -> Patchwork_21901
Summary
== Series Details ==
Series: drm/i915/guc: Use lockless list for destroyed contexts
URL : https://patchwork.freedesktop.org/series/98316/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11029_full -> Patchwork_21900_full
On Fri, 2021-12-17 at 21:37 +, Yokoyama, Caz wrote:
> On Thu, 2021-12-16 at 19:41 -0800, Madhumitha Tolakanahalli Pradeep
> wrote:
> > Replace GEN with DISPLAY_VER, in line with the naming
> > convention
> > followed in the i915 driver code.
> >
> > Signed-off-by: Madhumitha Tolakanahalli
== Series Details ==
Series: drm/i915/guc: Report error on invalid reset notification
URL : https://patchwork.freedesktop.org/series/98324/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11031_full -> Patchwork_21901_full
On 12/22/21 19:02, a...@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2021-12-22-19-02 has been uploaded to
>
>https://www.ozlabs.org/~akpm/mmotm/
>
> mmotm-readme.txt says
>
> README for mm-of-the-moment:
>
> https://www.ozlabs.org/~akpm/mmotm/
>
> This is a snapshot of
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Thursday, December 16, 2021 1:08 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915/fbc: Remember to update FBC state even
> when not reallocating CFB
>
> From: Ville Syrjälä
>
>
A weak implementation of parallel submission (multi-bb execbuf IOCTL) for
execlists. Doing as little as possible to support this interface for
execlists - basically just passing submit fences between each request
generated and virtual engines are not allowed. This is on par with what
is there for
Use a lockless list structure for destroyed contexts to avoid hammering
on global submission spin lock.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/intel_context.c | 2 -
drivers/gpu/drm/i915/gt/intel_context_types.h | 3 +-
On Tue, 21 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Remove the counterproductive CONFIG_DEBUG_FS ifdef and just include
> the debugfs dentry in drm_crtc always. This way we don't need
> annoying ifdefs in the actual code with DEBUGFS=n. Also we don't
> have these ifdefs around
On Sat, 18 Dec 2021, Thomas Gleixner wrote:
> On Fri, Dec 17 2021 at 15:27, Jani Nikula wrote:
>> On Fri, 10 Dec 2021, Tejas Upadhyay
>> wrote:
>>> Adding PCI device ids and enabling ADL-N platform.
>>> ADL-N from i915 point of view is subplatform of ADL-P.
>>>
>>> BSpec: 68397
>>>
>>> Changes
On Mon, 20 Dec 2021, Borislav Petkov wrote:
> On Sun, Dec 19, 2021 at 12:49:21AM -0800, Lucas De Marchi wrote:
>> > I note not all such changes in git log have your acks recorded, though
>> > most do. Do you want us to be more careful about Cc'ing you for acks on
>> > PCI ID changes every time
On Fri, 17 Dec 2021, Ville Syrjälä wrote:
> On Fri, Dec 17, 2021 at 08:02:55AM -0800, Harish Chegondi wrote:
>> Check return pointer from intel_crtc_for_plane() before dereferencing
>> it, as it can be NULL.
>
> Can't actually bu NULL. But I guess no real harm in having the
> check if it shuts up
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pull the "do we want to use i915->vbt.ports[]?" check into
> a central place.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 11 ---
> 1 file changed, 8
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Extend the vbt.ports[] stuff for all g4x+ platforms. We do need
> to drop the version check as some elk/ctg machines may have VBTs
> older than that. The oldest I know is an elk with version 142.
> But the child device stuff has
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> CHV is currently straddling the divide by using parse_ddi_ports() stuff
> for aux_ch/ddc_pin but going through all old codepaths for the rest
> (intel_bios_is_port_present(), intel_bios_is_port_edp(),
>
If VBT size is not a multiple of 4, the last 4-byte store will be out of
bounds of the allocated buffer. Spotted with KASAN. Round up the
allocation size.
v2: Use round_up() intead of roundup() as it's a power of 2 (Thomas)
Reported-by: Thomas Hellström
Fixes: a36e7dc0af1c ("drm/i915/dg1: Read
On Tue, 21 Dec 2021, Thomas Hellström wrote:
> On 12/21/21 14:08, Jani Nikula wrote:
>> If VBT size is not a multiple of 4, the last 4-byte store will be out of
>> bounds of the allocated buffer. Spotted with KASAN. Round up the
>> allocation size.
>>
>> Reported-by: Thomas Hellström
>> Fixes:
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> CHV is currently straddling the divide by using parse_ddi_ports() stuff
> for aux_ch/ddc_pin but going through all old codepaths for the rest
> (intel_bios_is_port_present(), intel_bios_is_port_edp(),
>
== Series Details ==
Series: drm/i915/bios: fix slab-out-of-bounds access (rev3)
URL : https://patchwork.freedesktop.org/series/98263/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21893
Summary
---
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Replace the DEVICE_TYPE_DP_DUAL_MODE_BITS stuff with just
> a DP+HDMI check. The rest of the bits shouldn't really
> matter anyway.
>
> The slight change in behaviour here is that now we do look at
> the
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Lots of machines these days seem to have a crappy type1 DP dual
> mode adaptor chip slapped onto the motherboard. Based on the
> DP dual mode spec we currently limit those to 165MHz max TMDS
> clock.
>
> Windows OTOH ignores DP
== Series Details ==
Series: drm/i915/bios: fix slab-out-of-bounds access (rev2)
URL : https://patchwork.freedesktop.org/series/98263/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21891
Summary
---
== Series Details ==
Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm()
(rev3)
URL : https://patchwork.freedesktop.org/series/98154/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11027 -> Patchwork_21892
On Fri, 17 Dec 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Now that we parse the DDI port info from the VBT on all g4x+ platforms
> we can throw out all the old codepaths in intel_bios_is_port_present(),
> intel_bios_is_port_edp() and intel_bios_is_port_dp_dual_mode(). None
> of these
== Series Details ==
Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm()
(rev3)
URL : https://patchwork.freedesktop.org/series/98154/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21892_full
On Wed, Dec 22, 2021 at 11:47:03AM +0200, Jani Nikula wrote:
> On Fri, 17 Dec 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Lots of machines these days seem to have a crappy type1 DP dual
> > mode adaptor chip slapped onto the motherboard. Based on the
> > DP dual mode spec we
On Wed, Dec 22, 2021 at 11:05:50AM +0200, Jani Nikula wrote:
> On Fri, 17 Dec 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > CHV is currently straddling the divide by using parse_ddi_ports() stuff
> > for aux_ch/ddc_pin but going through all old codepaths for the rest
> >
On Wed, Dec 22, 2021 at 11:34:47AM +0200, Jani Nikula wrote:
> On Fri, 17 Dec 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Replace the DEVICE_TYPE_DP_DUAL_MODE_BITS stuff with just
> > a DP+HDMI check. The rest of the bits shouldn't really
> > matter anyway.
> >
> > The slight
67 matches
Mail list logo
