Re: [Intel-gfx] [PATCH v2 08/12] drm/i915/dp: Rework HDMI DFP TMDS clock handling

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 08/12] drm/i915/dp: Rework HDMI DFP TMDS clock > handling > > From: Ville Syrjälä > > Rework the HDMI

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/dp: Duplicate native HDMI TMDS clock limit handling for DP HDMI DFPs

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 10/12] drm/i915/dp: Duplicate native HDMI TMDS > clock limit handling for DP HDMI DFPs > > From: Ville

Re: [Intel-gfx] [PATCH v2 12/12] drm/i915/dp: Disable DFP RGB->YCbCr conversion for now

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > > Subject: [PATCH v2 12/12] drm/i915/dp: Disable DFP RGB->YCbCr conversion for > now > > From: Ville Syrjälä > > We lack

[Intel-gfx] [PATCH v2] drm/i915/debugfs: Dump i915 children runtime status

2022-04-01 Thread Anshuman Gupta
i915 doesn't use pm_suspend_ignore_children(), which warrants that any runtime active child of i915 will block the runtime suspend of i915. i915_runtime_pm_status only exposes i915 runtime pm usage_count, which is not sufficient to debug in the scenarios when i915 has zero usage_count but there

Re: [Intel-gfx] [PATCH 15/15] drm/i915/xehp: Eliminate shared/implicit steering

2022-04-01 Thread Tvrtko Ursulin
On 31/03/2022 00:28, Matt Roper wrote: Historically we've selected and programmed a single MCR group/instance ID at driver startup that will steer register accesses for GSLICE/DSS ranges to a non-terminated instance. Any reads of these register ranges that don't need a specific unicast access

Re: [Intel-gfx] [PATCH 14/15] drm/i915: Define multicast registers as a new type

2022-04-01 Thread Tvrtko Ursulin
On 31/03/2022 00:28, Matt Roper wrote: Rather than treating multicast registers as 'i915_reg_t' let's define them as a completely new type. This will allow the compiler to help us make sure we're using multicast-aware functions to operate on multicast registers. This plan does break down a

Re: [Intel-gfx] [PATCH v2 02/12] drm/i915/dp: Respect the sink's max TMDS clock when dealing with DP->HDMI DFPs

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 02/12] drm/i915/dp: Respect the sink's max TMDS > clock when dealing with DP->HDMI DFPs > > From: Ville

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/dp: Extract intel_dp_has_audio()

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 03/12] drm/i915/dp: Extract > intel_dp_has_audio() > > From: Ville Syrjälä > > Declutter

Re: [Intel-gfx] [PATCH v2 07/12] drm/i915/dp: Make intel_dp_output_format() usable for "4:2:0 also" modes

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 07/12] drm/i915/dp: Make > intel_dp_output_format() > usable for "4:2:0 also" modes > > From: Ville

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915/dp: Add support for "4:2:0 also" modes for DP

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 09/12] drm/i915/dp: Add support for "4:2:0 > also" > modes for DP > > From: Ville Syrjälä > > Currently

Re: [Intel-gfx] [PATCH v2 11/12] drm/i915/dp: Fix DFP rgb->ycbcr conversion matrix

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > > Subject: [PATCH v2 11/12] drm/i915/dp: Fix DFP rgb->ycbcr conversion matrix > > From: Ville Syrjälä > > Our YCbCr

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dmc: abstract GPU error state dump

2022-04-01 Thread Jani Nikula
On Wed, 30 Mar 2022, Jani Nikula wrote: > Only intel_dmc.c should be accessing dmc details directly. > > Need to add an i915_error_printf() stub for > CONFIG_DRM_I915_CAPTURE_ERROR=n. > > v2: Add the stub (kernel test robot ) > > Signed-off-by: Jani Nikula > Reviewed-by: Lucas De Marchi # v1

Re: [Intel-gfx] [PATCH v2 01/12] drm/i915/dp: Extract intel_dp_tmds_clock_valid()

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 01/12] drm/i915/dp: Extract > intel_dp_tmds_clock_valid() > > From: Ville Syrjälä > > We're currently

Re: [Intel-gfx] [PATCH v2 04/12] drm/i915/dp: s/intel_dp_hdmi_ycbcr420/intel_dp_is_ycbcr420/

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 04/12] drm/i915/dp: > s/intel_dp_hdmi_ycbcr420/intel_dp_is_ycbcr420/ > > From: Ville Syrjälä > >

Re: [Intel-gfx] [PATCH v2 06/12] drm/i915/dp: Pass around intel_connector rather than drm_connector

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 06/12] drm/i915/dp: Pass around intel_connector > rather than drm_connector > > From: Ville Syrjälä > >

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915/dp: Reorder intel_dp_compute_config() a bit

2022-04-01 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 22, 2022 5:30 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 05/12] drm/i915/dp: Reorder > intel_dp_compute_config() a bit > > From: Ville Syrjälä > > Consolidate

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-01 Thread Maxime Ripard
On Thu, Mar 31, 2022 at 05:20:21PM +0200, Daniel Vetter wrote: > The stuff never really worked, and leads to lots of fun because it > out-of-order frees atomic states. Which upsets KASAN, among other > things. > > For async updates we now have a more solid solution with the > ->atomic_async_check

Re: [Intel-gfx] [PATCH v2 00/12] drm/edid: cleanup and refactoring around validity checks

2022-04-01 Thread Jani Nikula
On Thu, 31 Mar 2022, Jani Nikula wrote: > v2 of https://patchwork.freedesktop.org/series/101931/ > > Rebased, review comments addressed. Ville, care to double check patches 1 & 7 please? Thanks, Jani. > > BR, > Jani. > > > > Jani Nikula (12): > drm/edid: use struct edid * in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: Dump i915 children runtime status (rev2)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Dump i915 children runtime status (rev2) URL : https://patchwork.freedesktop.org/series/101866/ State : success == Summary == CI Bug Log - changes from CI_DRM_11437 -> Patchwork_22757 Summary

[Intel-gfx] [PATCH v7 6/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-04-01 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250

[Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-01 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Christian Konig

[Intel-gfx] [PATCH v7 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-04-01 Thread Ramalingam C
On Xe-HP and later devices, dedicated compression control state (CCS) stored in local memory is used for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the

[Intel-gfx] [PATCH v7 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-04-01 Thread Ramalingam C
When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the

[Intel-gfx] [PATCH v7 4/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-04-01 Thread Ramalingam C
Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. XY_CTRL_SURF_COPY_BLT is a BLT cmd used for reading and writing the ccs

[Intel-gfx] [PATCH v7 5/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-04-01 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH v7 1/9] drm/i915/gt: use engine instance directly for offset

2022-04-01 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7

[Intel-gfx] [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-01 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 40 - 1 file changed, 19 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH v7 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-04-01 Thread Ramalingam C
Use faster XY_FAST_COLOR_BLT cmd on graphics version of 12 and more, for clearing (Zero out) the pages of the newly allocated object. XY_FAST_COLOR_BLT is faster than the older XY_COLOR_BLT. v2: Typo fix at title [Thomas] v3: XY_FAST_COLOR_BLT is used only for FLAT_CCS capable gen12+

[Intel-gfx] [PATCH v7 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-04-01 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime status

2022-04-01 Thread Gupta, Anshuman
> -Original Message- > From: Jani Nikula > Sent: Friday, April 1, 2022 5:31 PM > To: Dixit, Ashutosh ; Gupta, Anshuman > > Cc: intel-gfx@lists.freedesktop.org; Wilson, Chris P > ; > Vivi, Rodrigo > Subject: Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime >

Re: [Intel-gfx] [PATCH] drm/i915/display/debugfs: Add connector debugfs for "output_bpc"

2022-04-01 Thread Jani Nikula
On Tue, 29 Mar 2022, Bhanuprakash Modem wrote: > This new debugfs will expose the connector's max supported bpc > and the bpc currently using. It is very useful for verifying > whether we enter the correct output color depth from IGT. > > Example: > cat /sys/kernel/debug/dri/0/DP-1/output_bpc >

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add DMC_EVT_HTP and DMC_EVT_CTL programming

2022-04-01 Thread Jani Nikula
On Mon, 28 Mar 2022, Anusha Srivatsa wrote: > We need add some checks around DMC reloading to > prevents the rare possibility of some adversary > writing to a random mmio register I've recently merged cleanup to localize all DMC register definitions to a new file display/intel_dmc_regs.h, and

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime status

2022-04-01 Thread Jani Nikula
On Fri, 01 Apr 2022, "Gupta, Anshuman" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Friday, April 1, 2022 5:31 PM >> To: Dixit, Ashutosh ; Gupta, Anshuman >> >> Cc: intel-gfx@lists.freedesktop.org; Wilson, Chris P >> ; >> Vivi, Rodrigo >> Subject: Re: [Intel-gfx] [PATCH]

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Random cleanups

2022-04-01 Thread Jani Nikula
On Mon, 21 Mar 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Clean up a few random things that caught my eye. Dunno if this got reviewed and merged already, but anyway, on the series, Reviewed-by: Jani Nikula > > Ville Syrjälä (3): > drm/i915: Program i830 DPLL FP register later >

[Intel-gfx] [PATCH v8 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-04-01 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang ---

[Intel-gfx] [PATCH v8 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-01 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g MMIO tracking table needs to be separated from GVT-g. --- v8: - Use SPDX header in the intel_gvt_mmio_table.c - Reference the gvt.h with

[Intel-gfx] [PATCH v8 0/3] Refactor GVT-g MMIO tracking table and handlers

2022-04-01 Thread Zhi Wang
To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when loading i915.

[Intel-gfx] [PATCH v8 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-04-01 Thread Zhi Wang
Save the initial HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime status

2022-04-01 Thread Gupta, Anshuman
> -Original Message- > From: Jani Nikula > Sent: Friday, April 1, 2022 6:26 PM > To: Gupta, Anshuman ; Dixit, Ashutosh > > Cc: intel-gfx@lists.freedesktop.org; Wilson, Chris P > ; > Vivi, Rodrigo > Subject: RE: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime >

Re: [Intel-gfx] [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-01 Thread Wang, Zhi A
Hi Jani: Thanks so much for the guidance. :) I included it in the v8 patch. :) Thanks, Zhi. On 3/31/22 8:25 AM, Jani Nikula wrote: > On Thu, 31 Mar 2022, "Wang, Zhi A" wrote: >> Hi Jani and Joonas: >> >> Are you OK with these patches? I noticed I need to change the license >> of the new file.

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Allow static DRRS on LVDS

2022-04-01 Thread Ville Syrjälä
On Thu, Mar 31, 2022 at 05:05:31PM +0300, Ville Syrjälä wrote: > On Thu, Mar 31, 2022 at 04:59:11PM +0300, Jani Nikula wrote: > > On Thu, 31 Mar 2022, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Nothing special about static DRRS on LVDS, it's just your > > > bog standard modeset.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Evict and restore of compressed object (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Evict and restore of compressed object (rev7) URL : https://patchwork.freedesktop.org/series/101106/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11438_full -> Patchwork_22758_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per client GPU utilisation (rev4)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev4) URL : https://patchwork.freedesktop.org/series/100573/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v8 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-04-01 Thread zhi.wang.linux
Hi Chirs: Thanks for the testing. I will find a kabelake and try it. :) -Original Message- From: Christoph Hellwig Sent: Friday, April 1, 2022 8:22 PM To: Zhi Wang Cc: dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; intel-gfx@lists.freedesktop.org;

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Per client GPU utilisation (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev5) URL : https://patchwork.freedesktop.org/series/100573/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or member

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display/psr: Lock and unlock PSR around pipe updates

2022-04-01 Thread kernel test robot
Hi "José, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on v5.17 next-20220401] [cannot apply to drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submi

[Intel-gfx] ✓ Fi.CI.BAT: success for Per client GPU utilisation (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev5) URL : https://patchwork.freedesktop.org/series/100573/ State : success == Summary == CI Bug Log - changes from CI_DRM_11440 -> Patchwork_22761 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v4 RFC] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-04-01 Thread Francisco Jerez
Daniel Vetter writes: > On Wed, Mar 30, 2022 at 02:53:11PM -0700, Matt Atwood wrote: >> Newer platforms have DSS that aren't necessarily available for both >> geometry and compute, two queries will need to exist. This introduces >> the first, when passing a valid engine class and engine instance

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display/psr: Lock and unlock PSR around pipe updates

2022-04-01 Thread kernel test robot
Hi "José, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on v5.17 next-20220401] [cannot apply to drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client GPU utilisation (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev5) URL : https://patchwork.freedesktop.org/series/100573/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7e9efd72439e drm/i915: Explicitly track DRM clients -:130: WARNING:FILE_PATH_CHANGES: added, moved or deleted

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3) URL : https://patchwork.freedesktop.org/series/101723/ State : success == Summary == CI Bug Log - changes from CI_DRM_11407_full -> Patchwork_22688_full

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

2022-04-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch URL : https://patchwork.freedesktop.org/series/102095/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

2022-04-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch URL : https://patchwork.freedesktop.org/series/102095/ State : success == Summary == CI Bug Log - changes from CI_DRM_11440 -> Patchwork_22762

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

2022-04-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch URL : https://patchwork.freedesktop.org/series/102095/ State : success == Summary == CI Bug Log - changes from CI_DRM_11440_full -> Patchwork_22762_full

[Intel-gfx] [PATCH 2/3] drm/i915/display/psr: Lock and unlock PSR around pipe updates

2022-04-01 Thread José Roberto de Souza
Frontbuffer rendering and page flips can race with each other and this can potentialy cause issues with PSR2 selective fetch. And because pipe/crtc updates are time sentive we can't grab the PSR lock after intel_pipe_update_start() and before intel_pipe_update_end(). So here adding the lock and

[Intel-gfx] [PATCH 1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

2022-04-01 Thread José Roberto de Souza
Following up what was done in commit 804f46885317 ("drm/i915/psr: Set "SF Partial Frame Enable" also on full update") and also setting partial frame enable when psr_force_hw_tracking_exit() is called. Also as PSR2_MAN_TRK_CTL is a double buffered registers do a RMW is not a good idea so here also

[Intel-gfx] [PATCH 3/3] drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations

2022-04-01 Thread José Roberto de Souza
Instead of exit PSR when a frontbuffer invalidation happens, we can enable the PSR2 selective fetch continuous full frame, that will keep the panel updated like PSR was disabled but without keeping PSR active. So as soon as the frontbuffer flush happens we can disable the continuous full frame

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per client GPU utilisation (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev5) URL : https://patchwork.freedesktop.org/series/100573/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3) URL : https://patchwork.freedesktop.org/series/101723/ State : success == Summary == CI Bug Log - changes from CI_DRM_11407_full -> Patchwork_22688_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Per client GPU utilisation (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev5) URL : https://patchwork.freedesktop.org/series/100573/ State : success == Summary == CI Bug Log - changes from CI_DRM_11440_full -> Patchwork_22761_full Summary ---

[Intel-gfx] [CI 6/8] drm: Document fdinfo format specification

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Proposal to standardise the fdinfo text format as optionally output by DRM drivers. Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.

[Intel-gfx] [CI 3/8] drm/i915: Track runtime spent in closed and unreachable GEM contexts

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter

[Intel-gfx] [CI 4/8] drm/i915: Track all user contexts per client

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using. To enable this we start tracking all context belonging to a client on a separate list. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind

[Intel-gfx] [CI 5/8] drm/i915: Track context current active time

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track context active (on hardware) status together with the start timestamp. This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime. The latter is only updated on context save so does not

[Intel-gfx] [CI 7/8] drm/i915: Count engine instances per uabi class

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will be useful to have at hand in a following patch. Signed-off-by: Tvrtko Ursulin Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 11 ++- drivers/gpu/drm/i915/i915_drv.h | 1 + 2 files changed, 7

[Intel-gfx] [CI 8/8] drm/i915: Expose client engine utilisation via fdinfo

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915. Example of the output: pos:0 flags: 012 mnt_id: 21 drm-driver:

[Intel-gfx] [CI 0/8] Per client GPU utilisation

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Test-with: 20220401141155.3122817-1-tvrtko.ursu...@linux.intel.com Tvrtko Ursulin (8): drm/i915: Explicitly track DRM clients drm/i915: Make GEM contexts track DRM clients drm/i915: Track runtime spent in closed and unreachable GEM contexts drm/i915: Track all user

[Intel-gfx] [CI 1/8] drm/i915: Explicitly track DRM clients

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning task pid/name. Unique client id is also assigned for the purpose of distinguishing/ consolidating between

[Intel-gfx] [CI 2/8] drm/i915: Make GEM contexts track DRM clients

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches. v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client GPU utilisation (rev4)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev4) URL : https://patchwork.freedesktop.org/series/100573/ State : warning == Summary == $ dim checkpatch origin/drm-tip 037908479101 drm/i915: Explicitly track DRM clients -:130: WARNING:FILE_PATH_CHANGES: added, moved or deleted

Re: [Intel-gfx] [PATCH v2 00/12] drm/edid: cleanup and refactoring around validity checks

2022-04-01 Thread Jani Nikula
On Fri, 01 Apr 2022, Ville Syrjälä wrote: > On Fri, Apr 01, 2022 at 11:55:21AM +0300, Jani Nikula wrote: >> On Thu, 31 Mar 2022, Jani Nikula wrote: >> > v2 of https://patchwork.freedesktop.org/series/101931/ >> > >> > Rebased, review comments addressed. >> >> Ville, care to double check patches

[Intel-gfx] ✗ Fi.CI.BAT: failure for Per client GPU utilisation (rev4)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev4) URL : https://patchwork.freedesktop.org/series/100573/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11439 -> Patchwork_22760 Summary --- **FAILURE**

[Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c:200:33: error: no member named 'tbo' in 'struct ttm_range_mgr_node'

2022-04-01 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: e797b8d09704b91463456234efdf04dc8f8c385d commit: edc1a46d62b7a03d53067f598db831092f9e1b05 [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: arm-randconfig-r033-20220401 (https://download.01.org/0day

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Evict and restore of compressed object (rev7)

2022-04-01 Thread Ramalingam C
On 2022-04-01 at 15:59:01 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/ttm: Evict and restore of compressed object (rev7) > URL : https://patchwork.freedesktop.org/series/101106/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11438_full ->

[Intel-gfx] [PATCH i-g-t 0/3] Per client GPU utilisation

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Only first three patches for review purposes (first stage) - adding the test and intel_gpu_top support. Tvrtko Ursulin (3): lib: Helper library for parsing i915 fdinfo output tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo

[Intel-gfx] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tests and intel_gpu_top will share common code for parsing this file. v2: * Fix key-value parsing if valid key line ends with ':'. * Return number of drm keys found. * Add DRM_CLIENT_FDINFO_MAX_ENGINES. (Umesh) * Always zero terminate read buffer. (Umesh)

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Refactor GVT-g MMIO tracking table and handlers

2022-04-01 Thread Patchwork
== Series Details == Series: Refactor GVT-g MMIO tracking table and handlers URL : https://patchwork.freedesktop.org/series/102073/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3) URL : https://patchwork.freedesktop.org/series/101723/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11407_full -> Patchwork_22688_full

[Intel-gfx] [PATCH i-g-t 2/3] tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Mostly inherited from the perf_pmu, some basic tests, and some tests to verify exported GPU busyness is as expected. v2: * Skip when kernel does not export drm keys in fdinfo. Signed-off-by: Tvrtko Ursulin Reviewed-by: Umesh Nerlige Ramappa --- tests/i915/drm_fdinfo.c

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dmc: abstract GPU error state dump

2022-04-01 Thread Lucas De Marchi
On Fri, Apr 01, 2022 at 10:43:19AM +0300, Jani Nikula wrote: On Wed, 30 Mar 2022, Jani Nikula wrote: Only intel_dmc.c should be accessing dmc details directly. Need to add an i915_error_printf() stub for CONFIG_DRM_I915_CAPTURE_ERROR=n. v2: Add the stub (kernel test robot ) Signed-off-by:

[Intel-gfx] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats

2022-04-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the i915 exported data in /proc//fdinfo to show GPU utilization per DRM client. Example of the output: intel-gpu-top: Intel Tigerlake (Gen12) @ /dev/dri/card0 - 220/ 221 MHz 70% RC6; 0.62/ 7.08 W; 760 irqs/s ENGINES BUSY

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: Evict and restore of compressed object (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Evict and restore of compressed object (rev7) URL : https://patchwork.freedesktop.org/series/101106/ State : success == Summary == CI Bug Log - changes from CI_DRM_11438 -> Patchwork_22758 Summary

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/11] intel-gpu-top: Add support for per client stats

2022-04-01 Thread Tvrtko Ursulin
On 31/03/2022 23:08, Umesh Nerlige Ramappa wrote: lgtm, I just have a few nits and questions below: Regardless, this is Reviewed-by: Umesh Nerlige Ramappa Thanks! I've sent the updated series with only first three patches for first stage. Only first patch misses the r-b now. Rest of

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime status

2022-04-01 Thread Gupta, Anshuman
> -Original Message- > From: Jani Nikula > Sent: Friday, April 1, 2022 7:40 PM > To: Gupta, Anshuman ; Dixit, Ashutosh > > Cc: intel-gfx@lists.freedesktop.org; Wilson, Chris P > ; > Vivi, Rodrigo > Subject: RE: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime >

Re: [Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-01 Thread Ramalingam C
Christian, Joonas and vivi Once the premerge results are greeen, if this patch can be merged into drm-intel-gt-next along with other patches could you please ack the request to merge into drm-intel-gt-next? Thanks Ram On 2022-04-01 at 18:07:49 +0530, Ramalingam C wrote: > Add a parameter called

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output

2022-04-01 Thread Umesh Nerlige Ramappa
lgtm, thanks for clarifications on the other patch. Reviewed-by: Umesh Nerlige Ramappa Umesh On Fri, Apr 01, 2022 at 03:11:53PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Tests and intel_gpu_top will share common code for parsing this file. v2: * Fix key-value parsing if valid key

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Per client GPU utilisation (rev4)

2022-04-01 Thread Patchwork
== Series Details == Series: Per client GPU utilisation (rev4) URL : https://patchwork.freedesktop.org/series/100573/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or member

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/dsb: modified to drm_info in dsb_prepare() (rev3) URL : https://patchwork.freedesktop.org/series/101723/ State : success == Summary == CI Bug Log - changes from CI_DRM_11407 -> Patchwork_22688 Summary

Re: [Intel-gfx] [PATCH v8 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-04-01 Thread Christoph Hellwig
This version still seems unhappy (same hardware as the last report): [ 38.650768] vfio_mdev 6814f392-50ac-4236-ae3d-26d472fd8aae: Adding to iommu group 0 [ 38.880317] L1TF CPU bug present and SMT on, data leak possible. See CVE-2018-3646 and

[Intel-gfx] ✗ Fi.CI.BAT: failure for Splitting intel-gtt calls for non-x86 platforms (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev7) URL : https://patchwork.freedesktop.org/series/101552/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11440 -> Patchwork_22763 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Splitting intel-gtt calls for non-x86 platforms (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev7) URL : https://patchwork.freedesktop.org/series/101552/ State : warning == Summary == $ dim checkpatch origin/drm-tip 270de0551c0b drm/i915/gt: Split intel-gtt functions by arch -:368:

Re: [Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-01 Thread Ramalingam C
On 2022-04-01 at 16:31:19 +0200, Christian König wrote: > I would be nicer to push this through drm-misc-next, but the intel branch > works for me as well. Hi Christian I have pushed this patch into drm-misc-next. Regards, Ram. > > Regards, > Christian. > > Am 01.04.22 um 16:28 schrieb

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rps: Centralize computation of freq caps (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/rps: Centralize computation of freq caps (rev5) URL : https://patchwork.freedesktop.org/series/101606/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert ct buffer to iosys_map

2022-04-01 Thread Lucas De Marchi
On Tue, Mar 22, 2022 at 02:14:37PM +0530, Mullati Siva wrote: From: Siva Mullati Convert CT commands and descriptors to use iosys_map rather than plain pointer and save it in the intel_guc_ct_buffer struct. This will help with ct_write and ct_read for cmd send and receive after the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rps: Centralize computation of freq caps (rev5)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/rps: Centralize computation of freq caps (rev5) URL : https://patchwork.freedesktop.org/series/101606/ State : success == Summary == CI Bug Log - changes from CI_DRM_11441 -> Patchwork_22764 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Splitting intel-gtt calls for non-x86 platforms (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev7) URL : https://patchwork.freedesktop.org/series/101552/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915/opregion: Abstract opregion function

2022-04-01 Thread Anshuman Gupta
On 2022-03-16 at 11:25:33 +0200, Jani Nikula wrote: > On Sun, 20 Feb 2022, Anshuman Gupta wrote: > > Abstract opregion operations like get opregion base, get rvda and > > opregion cleanup in form of i915_opregion_ops. > > This will be required to converge igfx and dgfx opregion. > > > > v2: > > -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: Evict and restore of compressed object (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Evict and restore of compressed object (rev7) URL : https://patchwork.freedesktop.org/series/101106/ State : warning == Summary == $ dim checkpatch origin/drm-tip c7781263ce21 drm/i915/gt: use engine instance directly for offset 4b35aa78c844

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: Evict and restore of compressed object (rev7)

2022-04-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Evict and restore of compressed object (rev7) URL : https://patchwork.freedesktop.org/series/101106/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime status

2022-04-01 Thread Jani Nikula
On Fri, 01 Apr 2022, "Gupta, Anshuman" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Friday, April 1, 2022 6:26 PM >> To: Gupta, Anshuman ; Dixit, Ashutosh >> >> Cc: intel-gfx@lists.freedesktop.org; Wilson, Chris P >> ; >> Vivi, Rodrigo >> Subject: RE: [Intel-gfx] [PATCH]

  1   2   >