This looks good execept the extern nitpick:
Reviewed-by: Christoph Hellwig
However I'd move this before the previous patch. More of the explanation
there.
Looks good:
Reviewed-by: Christoph Hellwig
On Tue, Apr 12, 2022 at 12:53:31PM -0300, Jason Gunthorpe wrote:
> Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no
> reason to use a group interface here, kvmgt has easy access to a
> vfio_device.
Once this is moved after the vfio_dma_rw, this is the last user of
the
On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote:
> + if (WARN_ON(!READ_ONCE(vdev->open_count)))
> + return -EINVAL;
I think all the WARN_ON()s in this patch need to be WARN_ON_ONCE,
otherwise there will be too many backtraces to be useful if a driver
ever gets the
Hello Jose,
See my comment below.
On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza wrote:
> After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full
> frame to handle frontbuffer invalidations") was merged we started to
> get some drm_WARN_ON(_priv->drm, !(tmp &
>
I messed up the delayed takover path in the locking conversion in
6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister").
Fix it by re-extracting the lockless function and using it in the
delayed takeover path, where we need to hold the lock already to
iterate over the list of
It looks like we still need to call dma_fence_put() on the man->move,
otherwise we just end up leaking it, leading to fireworks later.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689
Fixes: 8bb31587820a ("drm/ttm: remove bo->moving")
Cc: Christian König
Cc: Daniel Vetter
On Wed, Apr 13, 2022 at 11:16:08AM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> On 4/13/22 10:21, Daniel Vetter wrote:
> > I messed up the delayed takover path in the locking conversion in
> > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister").
> >
>
> Maybe a
On Mon, Apr 11, 2022 at 03:27:47PM -0700, Nathan Chancellor wrote:
> Hi Daniel,
>
> On Tue, Apr 05, 2022 at 11:03:32PM +0200, Daniel Vetter wrote:
> > Ideally console_lock becomes an implementation detail of fbcon.c and
> > doesn't show up anywhere in fbmem.c. We're still pretty far from that,
>
On Wed, Apr 13, 2022 at 09:21:33AM +0100, Matthew Auld wrote:
> It looks like we still need to call dma_fence_put() on the man->move,
> otherwise we just end up leaking it, leading to fireworks later.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689
> Fixes: 8bb31587820a
On Wed, Apr 13, 2022 at 10:43:02AM +0200, Christian König wrote:
> Am 13.04.22 um 10:21 schrieb Matthew Auld:
> > It looks like we still need to call dma_fence_put() on the man->move,
> > otherwise we just end up leaking it, leading to fireworks later.
> >
> > Closes:
> >
It looks like we still need to call dma_fence_put() on the man->move,
otherwise we just end up leaking it, leading to fireworks later.
v2(Daniel):
- Simplify the function tail
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689
Fixes: 8bb31587820a ("drm/ttm: remove bo->moving")
Cc:
Hello Daniel,
On 4/13/22 10:21, Daniel Vetter wrote:
> I messed up the delayed takover path in the locking conversion in
> 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister").
>
Maybe a few more words of what the issue is ? Something like the following:
If
On Fri, 08 Apr 2022, "Wang, Zhi A" wrote:
> Hi Jani:
>
> Thanks so much for the help. Can you generate a new tag on
> drm-intel-next? I noticed that there was one patch moving the DMC
> related registers into display/intel_dmc_regs.h, which is not included
> in the latest tag on drm-intel-next.
On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza wrote:
> If any of the PSR2 checks after intel_psr2_sel_fetch_config_valid()
> fails, enable_psr2_sel_fetch will be kept enabled causing problems
> in the functions that only checks for it and not for has_psr2.
>
> So here moving the check
(+ Tvrtko and Jani)
Quoting Ramalingam C (2022-04-02 06:02:38)
> On 2022-04-01 at 16:31:19 +0200, Christian König wrote:
> > I would be nicer to push this through drm-misc-next, but the intel branch
> > works for me as well.
> Hi Christian
>
> I have pushed this patch into drm-misc-next.
I've
We have now seen panel (XMG Core 15 e21 laptop) advertizing support
for Intel proprietary eDP backlight control via DPCD registers, but
actually working only with legacy pwm control.
This patch adds panel EDID check for possible HDR static metadata and
Intel proprietary eDP backlight control is
Hello Lyude,
See my respose below.
On Tue, 2022-04-12 at 13:50 -0400, Lyude Paul wrote:
> On Tue, 2022-04-12 at 08:25 +0300, Jouni Högander wrote:
> > We have now seen panel (XMG Core 15 e21 laptop) avertizing support
> > for Intel proprietary eDP backlight control via DPCD registers, but
> >
On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote:
> I messed up the delayed takover path in the locking conversion in
> 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister").
>
> Fix it by re-extracting the lockless function and using it in the
> delayed takeover
On Wed, Apr 13, 2022 at 10:04:48AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 6 Apr 2022 15:50:30 +1000 Stephen Rothwell
> wrote:
> >
> > After merging the drm-misc tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > include/drm/ttm/ttm_resource.h:226:
this function has been deleted since commit 9bdb073464d6 ("drm/i915/gvt:
Change KVMGT as self load module"), remove the deprecated function
declaration.
Signed-off-by: Cong Liu
---
drivers/gpu/drm/i915/intel_gvt.h | 1 -
1 file changed, 1 deletion(-)
diff --git
On 4/13/22 11:21, Daniel Vetter wrote:
> On Wed, Apr 13, 2022 at 11:16:08AM +0200, Javier Martinez Canillas wrote:
>> Hello Daniel,
>>
>> On 4/13/22 10:21, Daniel Vetter wrote:
>>> I messed up the delayed takover path in the locking conversion in
>>> 6e7da3af008b ("fbcon: Move console_lock for
Hi Jani:
Previously when I sent a pull request, it will be top of a tag in
drm-intel-next. The following patches move the DMC related registers, which is
used by GVT-g into intel_dmc_regs.h and it is not included in the latest tag.
commit 9c67d9e84c7d4a3a2371a54ee2dddc4699002000
Author: Jani
On Wed, 13 Apr 2022, "Wang, Zhi A" wrote:
> Hi Jani:
>
> Previously when I sent a pull request, it will be top of a tag in
> drm-intel-next. The following patches move the DMC related registers, which
> is used by GVT-g into intel_dmc_regs.h and it is not included in the latest
> tag.
>
>
Tolakanahalli Pradeep, Madhumitha kirjoitti 23.3.2022 klo 20.23:
The following changes since commit
681281e49fb6778831370e5d94e6e1d97f0752d6:
amdgpu: update PSP 13.0.8 firmware (2022-03-18 07:35:54 -0400)
are available in the Git repository at:
This is [1] rebased on gvt-next. (Which means it won't build on CI.)
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/102003/
Cc: Zhi Wang
Cc: Christoph Hellwig
Jani Nikula (2):
drm/i915/gvt: fix trace TRACE_INCLUDE_PATH
drm/i915/gvt: better align the Makefile with i915 Makefile
TRACE_INCLUDE_PATH should be a path relative to define_trace.h, not the
file including it. (See the comment in include/trace/define_trace.h.)
Cc: Zhi Wang
Cc: Christoph Hellwig
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gvt/trace.h | 2 +-
1 file changed, 1 insertion(+), 1
Drop extra ccflags, drop extra intermediate variables, list object files
one per line alphabetically.
Cc: Zhi Wang
Cc: Christoph Hellwig
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 6 +++---
drivers/gpu/drm/i915/gvt/Makefile | 30 +++---
2 files
On 2022-04-13 at 11:28:28 +0300, Joonas Lahtinen wrote:
> (+ Tvrtko and Jani)
>
> Quoting Ramalingam C (2022-04-02 06:02:38)
> > On 2022-04-01 at 16:31:19 +0200, Christian König wrote:
> > > I would be nicer to push this through drm-misc-next, but the intel branch
> > > works for me as well.
> >
On Wed, 13 Apr 2022 at 01:36, Abhinav Kumar wrote:
>
> Hi Daniel
>
> On 4/8/2022 9:04 PM, Abhinav Kumar wrote:
> >
> >
> > On 4/7/2022 4:12 PM, Rob Clark wrote:
> >> On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar
> >> wrote:
> >>>
> >>> Hi Rob and Daniel
> >>>
> >>> On 4/7/2022 3:51 PM, Rob Clark
== Series Details ==
Series: GSC support (rev5)
URL : https://patchwork.freedesktop.org/series/102160/
State : warning
== Summary ==
Error: dim checkpatch failed
c9eb3de40bf4 drm/i915/gsc: add gsc as a mei auxiliary device
Traceback (most recent call last):
File "scripts/spdxcheck.py", line
== Series Details ==
Series: GSC support (rev5)
URL : https://patchwork.freedesktop.org/series/102160/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
ADL-N and ADL-P stepping are different, thus we
need to add check for ADL-N in IS_ADLP_DISPLAY_STEP().
Signed-off-by: Tejas Upadhyay
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h
On Mon, 11 Apr 2022, Christoph Hellwig wrote:
> On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote:
>> > Up to you but I usually sort these lists
>>
>> Yeah, please do. Otherwise matches what I sent, so ack.
>
> Let's just merge your 2 patch series ASAP and I'll rebase on top of
> that.
== Series Details ==
Series: Make the rest of the VFIO driver interface use vfio_device
URL : https://patchwork.freedesktop.org/series/102606/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: Make the rest of the VFIO driver interface use vfio_device
URL : https://patchwork.freedesktop.org/series/102606/
State : warning
== Summary ==
Error: dim checkpatch failed
1a0dcd52cf62 vfio: Make vfio_(un)register_notifier accept a vfio_device
-:33:
== Series Details ==
Series: Make the rest of the VFIO driver interface use vfio_device
URL : https://patchwork.freedesktop.org/series/102606/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11493 -> Patchwork_102606v1
== Series Details ==
Series: GSC support (rev5)
URL : https://patchwork.freedesktop.org/series/102160/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11493 -> Patchwork_102160v5
Summary
---
**SUCCESS**
No
On 4/13/22 12:33 PM, Jani Nikula wrote:
> On Mon, 11 Apr 2022, Christoph Hellwig wrote:
>> On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote:
Up to you but I usually sort these lists
>>>
>>> Yeah, please do. Otherwise matches what I sent, so ack.
>>
>> Let's just merge your 2 patch
== Series Details ==
Series: drm/i915: ttm for stolen region (rev3)
URL : https://patchwork.freedesktop.org/series/102540/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11493 -> Patchwork_102540v3
Summary
---
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Tuesday, March 15, 2022 4:00 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 0/7] drm/i915/fbc: FBC frontbuffer stuff
>
> From: Ville Syrjälä
>
> Avoid all the FBC frontbuffer vs. atomic
On 4/13/22 1:43 PM, Jason Gunthorpe wrote:
> On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote:
>
>> It seems Jani's makefile clean patch has already included this one, I can
>> just simply drop this one so that Christoph won't need to re-send everything.
>>
>> For the branch to move
== Series Details ==
Series: drm/i915: ttm for stolen region (rev3)
URL : https://patchwork.freedesktop.org/series/102540/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 4/13/22 12:25 PM, Jani Nikula wrote:
> This is [1] rebased on gvt-next. (Which means it won't build on CI.)
>
> BR,
> Jani.
>
>
> [1] https://patchwork.freedesktop.org/series/102003/
>
>
> Cc: Zhi Wang
> Cc: Christoph Hellwig
>
>
> Jani Nikula (2):
> drm/i915/gvt: fix trace
On 4/11/22 2:13 PM, Christoph Hellwig wrote:
> Hi all,
>
> the GVT code in the i915 is a bit of a mess right now due to strange
> abstractions and lots of indirect calls. This series refactors various
> bits to clean that up. The main user visible change is that almost all
> of the GVT code
== Series Details ==
Series: series starting with [1/2] drm/i915/display/psr: Unset
enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails
URL : https://patchwork.freedesktop.org/series/102615/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11494 ->
On Wed, Apr 13, 2022 at 06:58:47PM +0300, Jani Nikula wrote:
> Acked-by: Jani Nikula
I've only added this to the i915 patches for now, let me know if you
also want me to add it to the vfio/mdev ones.
On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote:
> Yeah, I was thinking about that too, but on the other hand I think it
> is completely wrong that gvt requires kvm at all. A vfio_device is not
> supposed to be tightly linked to KVM - the only exception possibly
> being s390..
So
If any of the PSR2 checks after intel_psr2_sel_fetch_config_valid()
fails, enable_psr2_sel_fetch will be kept enabled causing problems
in the functions that only checks for it and not for has_psr2.
So here moving the check that do not depend on enable_psr2_sel_fetch
and for the remaning ones
Alderlake-P don't have PSR2_MAN_TRK_CTL_ENABLE bit, instead it have
ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE in the same bit but this
bit is clearead after each vblank so we can't count on having it
set after planes are programmed.
Cc: Jouni Högander
Fixes: 73262db68c27 ("drm/i915/display:
== Series Details ==
Series: Make the rest of the VFIO driver interface use vfio_device
URL : https://patchwork.freedesktop.org/series/102606/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11493_full -> Patchwork_102606v1_full
From: Ville Syrjälä
plane_state->uapi.crtc is not what we want to be looking at.
If bigjoiner is used hw.crtc is what tells us what crtc the plane
is supposedly using.
Not an actual problem on current hardware as the only FBC capable
pipe (A) can't be a bigjoiner slave and thus
From: Ville Syrjälä
intel_fbc_check_plane() is supposed to an int, not a boolean.
So replace the bogus 'return false's with the correct 'return 0's.
These were accidental copy-paste mistakes when the code got moved
into intel_fbc_check_plane() from somewhere else tht did return
a boolean.
No
Looks good:
Reviewed-by: Christoph Hellwig
On Wed, Apr 13, 2022 at 03:25:38PM +0300, Jani Nikula wrote:
> TRACE_INCLUDE_PATH should be a path relative to define_trace.h, not the
> file including it. (See the comment in include/trace/define_trace.h.)
Looks good:
Reviewed-by: Christoph Hellwig
Hi Dave & Daniel -
The first drm/i915 pull for v5.19.
BR,
Jani.
drm-intel-next-2022-04-13-1:
drm/i915 feature pull for v5.19:
Features and functionality:
- Add support for new Tile 4 format on DG2 (Stan)
- Add support for new CCS clear color compression on DG2 (Mika, Juha-Pekka)
- Add
On Wed, 13 Apr 2022, Christoph Hellwig wrote:
> On Wed, Apr 13, 2022 at 01:47:05PM +, Wang, Zhi A wrote:
>> > the GVT code in the i915 is a bit of a mess right now due to strange
>> > abstractions and lots of indirect calls. This series refactors various
>> > bits to clean that up. The main
On Wed, 2022-04-13 at 07:27 +, Hogander, Jouni wrote:
> Hello Jose,
>
> See my comment below.
>
> On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza wrote:
> > After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full
> > frame to handle frontbuffer invalidations") was
On Wed, Apr 13, 2022 at 11:03:05AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 13, 2022 at 08:11:05AM +0200, Christoph Hellwig wrote:
> > On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote:
> > > + if (WARN_ON(!READ_ONCE(vdev->open_count)))
> > > + return -EINVAL;
> >
> > I
On Wed, Apr 13, 2022 at 07:04:54PM +0300, Jani Nikula wrote:
> > v6:
> > - Remove the reference of intel_gvt_device_info.(Christoph)
> > - Refine the save_mmio() function. (Christoph)
> >
> > which don't belong in the commit log. It might be worth to fix that
> > before sending a pull request.
On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote:
> This is [1] rebased on gvt-next. (Which means it won't build on CI.)
Btw, now that I found that gvt-next branch:
Zhi, your commits still have per-commit changelog like:
v6:
- Remove the reference of
On Wed, Apr 13, 2022 at 01:47:05PM +, Wang, Zhi A wrote:
> > the GVT code in the i915 is a bit of a mess right now due to strange
> > abstractions and lots of indirect calls. This series refactors various
> > bits to clean that up. The main user visible change is that almost all
> > of the
On Wed, Apr 13, 2022 at 08:39:52AM -0300, Jason Gunthorpe wrote:
> I already looked into that for a while, it is a real mess too because
> of how the notifiers are used by the current drivers, eg gvt assumes
> the notifier is called during its open_device callback to setup its
> kvm.
gvt very
On Wed, 13 Apr 2022, Christoph Hellwig wrote:
> On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote:
>> This is [1] rebased on gvt-next. (Which means it won't build on CI.)
>
> Btw, now that I found that gvt-next branch:
>
> Zhi, your commits still have per-commit changelog like:
>
> v6:
On Wed, 13 Apr 2022, François Valenduc wrote:
> Commit 15512021eb3975a8c2366e3883337e252bb0eee5
> (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots
> to appears on the right upper corner of all console screens (see
>
On Mon, 11 Apr 2022, François Valenduc wrote:
> Commit 15512021eb3975a8c2366e3883337e252bb0eee5
> (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots
> to appears on the right upper corner of all console screens see the
> attached photo). git-bisect shows that this is the
On Wed, 13 Apr 2022 11:11:07 -0700, Ashutosh Dixit wrote:
>
> All kmalloc'd kobjects need a kobject_put() to free memory. For example in
> previous code, kobj_gt_release() never gets called.
Even if kobj_gt_release() were to get called, the code allocates 'struct
kobj_gt' and frees 'struct
On Wed, Apr 13, 2022 at 11:25:02AM +0200, Daniel Vetter wrote:
> On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote:
> > I messed up the delayed takover path in the locking conversion in
> > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister").
> >
> > Fix it by
On 4/13/22 8:04 PM, Jason Gunthorpe wrote:
> On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote:
>> On 4/13/22 5:37 PM, Jason Gunthorpe wrote:
>>> On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote:
On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote:
>
Looks good to me, series is:
Reviewed-by: Francisco Jerez
Matt Roper writes:
> This structure has a great comment describing the fields, but it's not
> currently in kerneldoc form and does not show up in the generated
> documentation. Let's fix that and also clarify the description of what
>
Some recent Intel dGfx platforms allow media IP to work at a different
frequency from the base GT. This patch series exposes sysfs controls for
this functionality in the new per-gt sysfs. Some enhancements and fixes to
previous per-gt functionality are also included to complete the new
== Series Details ==
Series: drm/i915: Check EDID for HDR static metadata when choosing blc
URL : https://patchwork.freedesktop.org/series/102645/
State : warning
== Summary ==
Error: dim checkpatch failed
0cc97e8784e7 drm/i915: Check EDID for HDR static metadata when choosing blc
-:71:
== Series Details ==
Series: Expose max and current bpc via debugfs (rev2)
URL : https://patchwork.freedesktop.org/series/102502/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11496_full -> Patchwork_102502v2_full
Summary
== Series Details ==
Series: drm/i915: Check EDID for HDR static metadata when choosing blc
URL : https://patchwork.freedesktop.org/series/102645/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102645v1
Client busyness is not available when GuC submission is used. Don't show it
in fdinfo till this is supported by GuC.
Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/5564
Fixes: 055634e4b62f ("drm/i915: Expose client engine utilisation via fdinfo")
Cc: Umesh Nerlige Ramappa
Cc: John
== Series Details ==
Series: fbcon: Fix delayed takeover locking
URL : https://patchwork.freedesktop.org/series/102641/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11496_full -> Patchwork_102641v1_full
Summary
---
== Series Details ==
Series: Update to GuC v70
URL : https://patchwork.freedesktop.org/series/102626/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/guc/slpc: Use i915_probe_error instead of drm_err
URL : https://patchwork.freedesktop.org/series/102625/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102625v1
On Wed, 2022-04-13 at 08:31 +, Hogander, Jouni wrote:
> Hello Lyude,
>
> See my respose below.
>
> On Tue, 2022-04-12 at 13:50 -0400, Lyude Paul wrote:
> > On Tue, 2022-04-12 at 08:25 +0300, Jouni Högander wrote:
> > > We have now seen panel (XMG Core 15 e21 laptop) avertizing support
> > >
== Series Details ==
Series: drm/i915: Remove intel_gvt_init_host declaration
URL : https://patchwork.freedesktop.org/series/102646/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102646v1
Summary
---
== Series Details ==
Series: drm/i915/adl-n: Differentiate ADLP and ADLN steppings
URL : https://patchwork.freedesktop.org/series/102652/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Wed, 13 Apr 2022, Cong Liu wrote:
> this function has been deleted since commit 9bdb073464d6 ("drm/i915/gvt:
> Change KVMGT as self load module"), remove the deprecated function
> declaration.
I don't want to push this right now avoid conflicts in other pending
work. Cc'd Zhi & Zhenyu to pick
On 4/7/2022 5:58 AM, Alexander Usyskin wrote:
From: Tomas Winkler
DG2 uses different GSC offsets on memory bar
and uses PXP head (HECI1).
Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
Reviewed-by: Daniele Ceraolo Spurio
Daniele
---
From: John Harrison
The latest GuC firmware drops the context descriptor pool in favour of
passing all creation data in the create H2G. It also greatly simplifies
the work queue and removes the process descriptor used for multi-LRC
submission. So, remove all mention of LRC and process
From: John Harrison
There are some workarounds for DG2 that are implemented in the GuC
firmware. However, the KMD is required to enable these by setting the
appropriate flag as GuC does not know what platform it is running on.
Wa_16011759253
Wa_14012630569
Wa_14013746162
v2: Add a couple
From: Matt Roper
We're now ready to start exposing compute engines to userspace.
While we're at it, let's extend the kerneldoc description for the other
engine types as well.
Cc: Daniele Ceraolo Spurio
Cc: Tvrtko Ursulin
Cc: Vinay Belgaumkar
Cc: Jordan Justen
Cc: Szymon Morek
UMD (mesa):
From: Vinay Belgaumkar
Enable GuC Wa to reset RCS/CCS before it goes into RC6.
v2: Comments from Matt R.
Signed-off-by: Vinay Belgaumkar
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 1 +
2 files changed, 6 insertions(+)
diff --git
From: Daniele Ceraolo Spurio
Cc: Vinay Belgaumkar
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/i915_pci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
Enable compute, work arounds and relevant GuC FW for DG2.
Signed-off-by: Matt Roper
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: John Harrison
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Vinay Belgaumkar
Signed-off-by: Tilak Tangudu
Daniele Ceraolo Spurio (1):
drm/i915:
From: John Harrison
Update to the latest GuC firmware release.
Signed-off-by: John Harrison
Reviewed-by: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
From: John Harrison
The latest GuC firmware drops the individual scheduling policy update
H2G commands in favour of a single KLV based H2G. So, change the
update wrappers accordingly.
Unfortunately, the API changes also mean losing the ability to set any
scheduling policy values during context
From: Tilak Tangudu
Prior to doing a reset, SW must ensure command streamer is stopped,
as a workaround, to eliminate a race condition in GPM flow.
Setting both the ring stop and prefetch disable bits, will cause the
command streamer to halt.
v2: 1. Removed duplicate code and added only
From: John Harrison
The above two workaronuds regarding context isolation are implemented
by GuC. The KMD just needs to enable them.
v2: Use dg2 stepping for ctx isolation WA (Umesh)
v3: Rebase (Umesh)
v4: Fix WA comments (Daniele)
v5: Drop Wa_22012727685 for G10 as it is n/a
v6: Undo v5 change
From: Matthew Brost
There is bug in DG2 where if the CCS contexts switches out while the RCS
is running it can cause memory corruption. To workaround this add an
atomic to a memory address with a value 1 and semaphore wait to the same
address for a value of 0. The GuC firmware is responsible for
== Series Details ==
Series: Expose max and current bpc via debugfs (rev2)
URL : https://patchwork.freedesktop.org/series/102502/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102502v2
Summary
---
== Series Details ==
Series: fbcon: Fix delayed takeover locking
URL : https://patchwork.freedesktop.org/series/102641/
State : warning
== Summary ==
Error: dim checkpatch failed
8854f9cee658 fbcon: Fix delayed takeover locking
-:7: ERROR:GIT_COMMIT_ID: Please use git commit description style
Expose new sysfs to program and retrieve media freq factor. Factor values
of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point
representation (corresponding to integer values of 0, 128 and 256
respectively).
Media freq factor is converted to media_ratio_mode for GuC. It is
programmed
Create a gt/gtN/.defaults directory (similar to
engine//.defaults) to expose default parameter values for each
gt in sysfs. Populate the .defaults directory with RPS parameter default
values in order to allow userspace to revert to default values when needed.
This patch adds the following sysfs
Each gt contains an independent instance of pcode. Extend pcode functions
to interface with pcode on different gt's. Previous (GT0) pcode read/write
interfaces are preserved.
Cc: Rodrigo Vivi
Cc: Mike Ruhl
Signed-off-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/intel_pcode.c | 108
All kmalloc'd kobjects need a kobject_put() to free memory. For example in
previous code, kobj_gt_release() never gets called. The requirement of
kobject_put() now results in a slightly different code organization.
Cc: Andi Shyti
Cc: Andrzej Hajda
Cc: Rodrigo Vivi
Fixes: b770bcfae9ad
1 - 100 of 138 matches
Mail list logo
